Subject: Re: bug#65359: [PATCH] eglot: add "lexical" LSP server

From: Eli Zaretskii <[email-masked]>
Date: Fri, 18 Aug 2023 09:00:02 +0300

> From: Mou Tong <[email-masked]>
> Date: Fri, 18 Aug 2023 01:38:39 +0000
> 
> There is a new LSP server for elixir: [lexical].
> 
> Although it said there had problems to use it with eglot, but I didn't
> meet the [problem] it said in the instruction.
> 
> And I had used it for serveral projects and it worked fine, I put this
> in my config and I don't know if there is a better way:
> 
> ```emacs-lisp
> (with-eval-after-load 'eglot
>  (setf (alist-get '(elixir-mode elixir-ts-mode heex-ts-mode)
>                   eglot-server-programs
>                   nil nil #'equal)
>        (eglot-alternatives
>         `(("start_lexical.sh")
>           ,(if (and (fboundp 'w32-shell-dos-semantics)
>                     (w32-shell-dos-semantics))
>                '("language_server.bat")
>              '("language_server.sh"))))))
> ```
> 
> So I send a patch like this. 
> 
> [lexical]: https://github.com/lexical-lsp/lexical
> 
> [problem]:
> https://github.com/lexical-lsp/lexical/blob/main/pages/installation.md#vanilla-emacs-with-eglot
> 
> 
> From f4789e6215291ca2be95f443e0d2a1b122a44b0d Mon Sep 17 00:00:00 2001
> From: dalu <[email-masked]>
> Date: Thu, 17 Aug 2023 18:34:42 +0800
> Subject: [PATCH] Add "lexical" LSP server to Eglot
> 
> ---
>  lisp/progmodes/eglot.el | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 113ff08e94e..be7ed54c71d 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -219,10 +219,12 @@ eglot-server-programs
>                                   . ("dart" "language-server"
>                                      "--client-id" "emacs.eglot-dart"))
>                                  ((elixir-mode elixir-ts-mode heex-ts-mode)
> -                                 . ,(if (and (fboundp 'w32-shell-dos-semantics)
> -                                             (w32-shell-dos-semantics))
> -                                        '("language_server.bat")
> -                                      '("language_server.sh")))
> +                                 . ,(eglot-alternatives
> +                                     `(("start_lexical.sh")
> +                                       ,(if (and (fboundp 'w32-shell-dos-semantics)
> +                                                 (w32-shell-dos-semantics))
> +                                            '("language_server.bat")
> +                                          '("language_server.sh")))))
>                                  (ada-mode . ("ada_language_server"))
>                                  (scala-mode . ,(eglot-alternatives
>                                                  '("metals" "metals-emacs")))

Thanks, but the fact the command is a shell script again needs the
w32-shell-dos-semantics dance, like language_server.sh did.