GNU bug report logs - #65358
30.0.50 [PATCH]; Add support for splicing Eshell globs in-place

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65358 in the body.
You can then email your comments to 65358 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50 [PATCH]; Add support for splicing Eshell globs in-place
Date: Thu, 17 Aug 2023 12:36:05 -0700

[Message part 1 (text/plain, inline)]

One odd thing about Eshell is that when you expand a glob, it expands as 
a sublist within your argument list. In practice, that usually works out 
ok, since external commands (and some Eshell built-ins) will flatten the 
list of arguments before processing them.

However, this can cause issues when calling Lisp commands. For example, 
if I have a single patch file in my current directory, I might try to 
refer to it via "*.patch". This works fine for a command like "cat", but 
not for "find-file":

  ~ $ find-file *.patch
  Wrong type argument: stringp, 
("0001-Allow-splicing-Eshell-globs-in-place.patch")

With the attached patch, you can set 'eshell-glob-splice-results' to t 
and then the above command will work as expected.

I'm tempted to make this new behavior the default, since it smooths over 
the differences between Emacs Lisp functions and external commands in 
Eshell (when using the command form, that is). However, at least for 
now, I think it would be best to leave this off by default. Once any 
bugs have been worked out and people have had the chance to try it out, 
when we could consider changing the default one day.

[0001-Allow-splicing-Eshell-globs-in-place.patch (text/plain, attachment)]

Message #10 received at 65358-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 65358-done <at> debbugs.gnu.org
Subject: Re: bug#65358: 30.0.50 [PATCH]; Add support for splicing Eshell globs
 in-place
Date: Mon, 21 Aug 2023 11:47:00 -0700

On 8/17/2023 12:36 PM, Jim Porter wrote:
> With the attached patch, you can set 'eshell-glob-splice-results' to t 
> and then the above command will work as expected.

Merged to master as cf52cdb121b, and marking this done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.