Subject: bug#65355: closed (Re: [bug#65355] [PATCH v2] gnu: opencv: Update to 4.8.0)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 29 Aug 2023 13:08:02 +0000

Your bug report

#65355: [PATCH] gnu: opencv: Update to 4.8.0

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
65355: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65355
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#65355] [PATCH v2] gnu: opencv: Update to 4.8.0
From: Christopher Baines <[email-masked]>
To: Andy Tai <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Tue, 29 Aug 2023 14:06:21 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Andy Tai <[email-masked]> writes:

> * gnu/packages/image-processing.scm (opencv): Update to 4.8.0
>   [arguments](configure-flags): Turn off flagbuffer support
>   as build fails with that
>   [#:phases](disable-broken-tests): Increase tolerance for
>   one test failure on x86-64
>   [inputs]: Add eigen, opencl-headers and openmpi
> ---
>  gnu/packages/image-processing.scm | 27 ++++++++++++++++++++++-----
>  1 file changed, 22 insertions(+), 5 deletions(-)

I've made a few tweaks and pushed this to master as
43b3500620cfbfc00fc66e57ab9752a8dcad6da1.

Please take a look at guix lint when making changes, it flagged up a few
new long lines and tabulations here. I also tweaked the formatting of
the commit message.

Thanks,

Chris

Subject: [PATCH] gnu: opencv: Update to 4.8.0
From: Andy Tai <[email-masked]>
To: [email-masked]
Date: Thu, 17 Aug 2023 16:12:35 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

From ccc44e4f892c76aebe057c3a71913e30d21a32bd Mon Sep 17 00:00:00 2001
Message-Id: <[email-masked]>
From: Andy Tai <[email-masked]>
Date: Thu, 17 Aug 2023 16:08:55 +0000
Subject: [PATCH] gnu: opencv: Update to 4.8.0
To: [email-masked]

* gnu/packages/image-processing.scm (opencv): Update to 4.8.0
---
 gnu/packages/image-processing.scm | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index afeda4bc20..79b1dd4121 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -81,6 +81,7 @@ (define-module (gnu packages image-processing)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages maths)
   #:use-module (gnu packages mpi)
+  #:use-module (gnu packages opencl)
   #:use-module (gnu packages pdf)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages photo)
@@ -492,7 +493,7 @@ (define-public vtk-7
 (define-public opencv
   (package
     (name "opencv")
-    (version "4.7.0")
+    (version "4.8.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -508,6 +509,7 @@ (define-public opencv
                     (for-each delete-file-recursively
                               '("carotene"
                                 "cpufeatures"
+                                "flatbuffers"
                                 "ffmpeg"
                                 "include"
                                 "ippicv"
@@ -531,7 +533,7 @@ (define-public opencv
                   (for-each delete-file (find-files "." "\\.jar$"))))
               (sha256
                (base32
-                "0l45v41nns2jmn9nr9fb0yvhqzfjpxjxn75i1c02rsfy3r3lv22v"))))
+                "14bjpb0ahhaqnim8g6vs0gyd6jgnmly1amx25a0rk1a6ii2aiywn"))))
     (build-system cmake-build-system)
     (arguments
      `(#:configure-flags
@@ -577,6 +579,11 @@ (define-public opencv
              ;; Is ON by default and would try to rebuild 3rd-party protobuf,
              ;; which we had removed, which would lead to an error:
              "-DBUILD_PROTOBUF=OFF"
+             
+             ;; OpenCV tries to use flatbuffers in 3rdparty which we removed
+             ;; so for now we don't buildfor  flatbuffer support
+             ;; TODO: make OpenCV use system flatbuffers which involves modifying CMake files
+             "-DWITH_FLATBUFFERS=OFF"
 
              ;; Rebuild protobuf files, because we have a slightly different
              ;; version than the included one. If we would not update, we
@@ -611,6 +618,11 @@ (define-public opencv
                (("\\b(Accum|DataAugmentation|Resample|Correlation|Interp)\\b" all)
                 (string-append "DISABLED_" all)))
 
+             ;; This test fails on x86-64, loosen the bounds.
+             ;; Expected: (max) < (0.131), actual: 0.207148 vs 0.131
+             (substitute* "modules/photo/test/test_hdr.cpp"
+                (("0\\.1\\)") "0.222)"))
+             
              ,@(if (target-aarch64?)
                  `(;; This test fails on aarch64, loosen the bounds.
                    ;; Expected: (max) < (0.131), actual: 0.207148 vs 0.131
@@ -668,7 +680,7 @@ (define-public opencv
            (file-name (git-file-name "opencv_extra" version))
            (sha256
             (base32
-             "0bdg5kwwdimnl2zp4ry5cmfxr9xb7zk2ml59853d90llsqjis47a"))))
+             "11y9b35j74gg4gqll4v366qmhvjkcqml45khiajd8zsk1fraf70l"))))
        ("opencv-contrib"
         ,(origin
            (method git-fetch)
@@ -677,9 +689,12 @@ (define-public opencv
            (file-name (git-file-name "opencv_contrib" version))
            (sha256
             (base32
-             "0hbfn835kxh3hwmwvzgdglm2np1ri3z7nfnf60gf4x6ikp89mv4r"))))))
+             "16crcca9r4y4rby0dqdhc06qi84hjk6qxy2sql2dhh35hfs856rr"))))))
     (inputs
-     (list ffmpeg-4
+     (list eigen
+     	   ffmpeg-4
+     	   ;flatbuffers  ;; build error on flatbufer generated code; TODO: enable when builds 
+     	   ;gstreamer  ;; TODO: proper gstreamer linkage
            gtk+
            gtkglext
            hdf5
@@ -691,8 +706,11 @@ (define-public opencv
            libpng
            libtiff
            libwebp
+           mesa-opencl
            openblas
+           opencl-headers
            openexr
+           openmpi
            openjpeg
            protobuf
            python

base-commit: 79ec651a286c71a3d4c72be33a1f80e76a560031
-- 
2.34.1