GNU bug report logs - #65346
30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65346: closed (30.0.50; *lisp/net/eww.el: new function
 'eww-open-in-new-buffer-background')
Date: Sun, 20 Aug 2023 08:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 20 Aug 2023 11:50:04 +0300
with message-id <83v8daw11f.fsf <at> gnu.org>
and subject line Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background'
has caused the debbugs.gnu.org bug report #65346,
regarding 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65346: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65346
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Sun <sunlin7 <at> yahoo.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.50;
 *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background'
Date: Wed, 16 Aug 2023 19:39:30 +0000

[Message part 3 (text/plain, inline)]

Hi,

In a EWW buffer, the user can use the 'eww-open-in-new-buffer' or "M-RET" to
open a URL in a new buffer and focus on the new buffer.

Sometimes people want to open the URLs in the background first and read them
later, so here is the 'eww-open-in-new-buffer-background' function,
binding to "C-<return>".

Example: using the eww to open the hack news and browse the topics,
open some topics in background with "C-<return>", and read them later.

Please help review the patch. Thanks.

Best Regards
Lin

[0001-lisp-net-eww.el-new-function-eww-open-in-new-buffer-.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> yahoo.com>
Cc: 65346-done <at> debbugs.gnu.org
Subject: Re: bug#65346: 30.0.50;
 *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background'
Date: Sun, 20 Aug 2023 11:50:04 +0300

> From: Lin Sun <sunlin7 <at> yahoo.com>
> Date: Fri, 18 Aug 2023 19:03:08 +0000
> Cc: 65346 <at> debbugs.gnu.org
> 
> On Fri, Aug 18, 2023 at 5:52 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> > This changes the API of a public function in incompatible ways, which
> > we try very hard not to do.  Instead, the signature or
> > eww-open-in-new-buffer should be like this:
> >
> >   (defun eww-open-in-new-buffer (&optional no-select)
> >
> > and the new NO-SELECT argument should be set non-nil by C-u.
> >
> > > +    (user-error "No avaliable link")))
> >
> > This also changes the text of the error message in this case.  Was
> > that really necessary?  The original text was more accurate, I think.
> >
> > Also, this new feature needs a NEWS entry and a suitable addition to
> > the EWW manual.
> 
> The attached patch included changes for the function, error message,
> NEWS and EWW manual.
> Please help review it.

Thanks, installed on master, and closing the bug.

Please in the future include a more detailed log of the changes in the
commit log message, and please follow our conventions for that as
described in CONTRIBUTE.  I did it for you this time, but it required
quite a lot of manual work.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.