GNU bug report logs - #65346
30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background'

Previous Next

Full log

Message #11 received at 65346 <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7 <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 65346 <at> debbugs.gnu.org
Subject: Re: bug#65346: 30.0.50;
 *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background'
Date: Thu, 17 Aug 2023 22:51:04 +0000

[Message part 1 (text/plain, inline)]

Hi Eli,
> "Background" is a problematic word for this, since that's not what you
> mean: you mean not to select the window displaying the URL.
>
> And I don't think we need a separate command for that: how about doing
> this in eww-open-in-new-buffer instead, if the user invokes it with a
> prefix argument C-u?
>
> And finally, what happens if the following condition, tested by
> eww-open-in-new-buffer, is fulfilled:
>
>       (when (or (eq eww-browse-url-new-window-is-tab t)
>                 (and (eq eww-browse-url-new-window-is-tab 'tab-bar)
>                      tab-bar-mode))
>
> In this case, AFAIU the URL is opened in a new tab.

Thank you for the comment, and agree with you, so I rewrote the
function `eww-open-in-new-buffer' with "C-u" support (also with an
optional argument "url"), then there is no "background" description.

I also tested the new patch with tab-bar-mode on and off, it works for
both scenarios.

Please help review again. Thanks.

Best regards
Lin

[0001-lisp-net-eww.el-eww-open-in-new-buffer-able-to-stay-.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.