From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 15:40:24 2023 Received: (at submit) by debbugs.gnu.org; 16 Aug 2023 19:40:24 +0000 Received: from localhost ([127.0.0.1]:42125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWMNU-0000Nw-0x for submit@debbugs.gnu.org; Wed, 16 Aug 2023 15:40:24 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWMNR-0000Nd-Dp for submit@debbugs.gnu.org; Wed, 16 Aug 2023 15:40:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWMN1-0004vw-Nv for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2023 15:39:56 -0400 Received: from sonic302-22.consmr.mail.ne1.yahoo.com ([66.163.186.148]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWMMz-0004ZR-8O for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2023 15:39:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692214789; bh=TkXjvVGnPdQbBZr/GETOp3git0rEuJI4MEFzUAMJobA=; h=References:In-Reply-To:From:Date:Subject:To:From:Subject:Reply-To; b=QiqwojMMISYURV2z6FXzzFWMWBY4qldL4cWS7v1owd/dTkDeBzLLbi4UXXQUE5olQa/wxkctS74pKP4uzVRFcld/WPp/DwykXcEzCR/82i2yRRLP7sLOFQFdbc+Y1ZQK4964R3ZMm+TY+i1oN5FvNk83AwEri+GuREy/vzwhEyq/ogbyT4+Z3ygRXDOoPp5Tq1n03FTNJXqlw9KupsD793w7Aw8UQqbjQvpMd8kvAQTSnTHsP2FrB3wlAKnfZzRqiN4eDWoFf26SAy0T+Ev3CMKIR7i4bjdZ/kn9bKzg5gsCv1lW5VaMm2jlF81s9J8H5Qjm81wno5ovhvLZJZ7RZw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692214789; bh=LOywsHTIGerzZbzv2jpORJ3ry3ZMwoT4y6M3ypHE5KB=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=hfBkYxQHLOEiV9jW+mVDCducg9nnSyCuDHVVR13LWYsvss4oDOefh1c9Ag715pjp/uOuBvN891GU//xi3W1u0F0noPnsUQGQxe61Eg8IsL3h7ZvN9MJQ6ko+OkY7BrkXa9WoQZD7ZlMuTtPCCQhXXnx8AowF8bHdxakoRNv5+XvoCiYzMsi5NqWf5WU0kg55KEj68VN1FZnrsJzqgVqH29R2T0hXefe5E2v395JXJY6TL8ur6xzYQLJGMf48/Iiyh7sLqX7rVDiLX3UOstSUpozI2eBR4AmbMfXrwfkR2Apww680hiwvJYN6rej/Qp7qe8/hXiabepZKcu5FEOlj2A== X-YMail-OSG: v8.WH6sVM1nF_7FQvNeYgay8urW9Ol5OD17lP5Jrl.PceJs4CHagvruU1H32hpH FAPeDvfel_YYGFZq.PcQWqamqZ2MUfW1B_SAJk8WhGd4ZIeZqmBXxnI0HSzAZbadLFy8YGjMWfVm w9ZwkgurHg9lFzshxHzwdNuUHkpkuJTRkhuih5IuZDONsCwl_9Did_wy7Nq.X.lg5KB4Npf9y82T h8l7yylTiSH5tImACp4MFeQ3sV1vfXSTI2wqsCLHyWhamjVh5whrr2IKV9wwxyhRS0RQj0Sq5eJ5 Q36xRNIcsxw1HAcGvonEFmq5XHlnTXYLJ4pKBO8ZOH6R2abgl4gQgoOuW4tt5qnIWwDncoCokKzm hvqw1SKAHv0PPk_9R.M6OZw_bPzlxhjcvzCXIY3wkzxl5ChtpqTWXDQ9dgI71AzTL1ETygdvuhmx o7RhczglWBZ0rgDDjFqA_shOJQO_5O8gC7aZxdZqshqJ2eUcSGfnQp5h33ncTchDx_jvvEoX1cvT rWNQThvgfNcJhROM.Wo4o.IUAHIq.EFXq42FGPxbQz.ODBmMg64ww0szKy.DQu7.MNW7gNrpnNHT 4T2ax27E9KpbRyYSANnWSYviSGCFeweIRtaQB5z0V.dBqF2QHnSUMSPzik2SNvkZtSVGFR_8zrC4 lHqPOzXAd1mFkpDlBdQ5HPuKyP.DJuIY5aiMDiq0QiluJRj2c6AaQAeL7IJktdveQmqCVFh_coVN 27ynVFrj8fgsFYm_AWurBKMcu0WalVSRDvEmk3jWmnujYLM0ZxtLIpSswTe.EEKreFJiDI1PmtCy jvsBH7ZTb.5auyMxljR4_4moi5naz2OaIW.eFAze2cQrv_EHlf9MWPSUlp.tsUQ8.PR818cpgzfe 6uS6oBQY2s9nJ3yR.OzGylBbFm8XEsAQCNlgmKWteG9NTVptzWarj2N2.OsRWElwE7uaw3S6oU9N YK1VaFLPuBwCAUCp._uQCDcx_6lTseri0Kpg0Ewcykfy4R3.Ic2VAd4cxwNXqOnXPrTmQAjKE32B AzCnv1kjtm4SaelBhOkbuVk14cMyFioRc3rIiWKyaAsPanHsKKOwKI0h1nAlHpjIDvN7zR7Z5DpF R.444FJZ0YqeHBXd_7RBmK2nWpH2Cm8fF2oZdMtDA.6kV7CCQUoSWRXgL.UULtxz56fUgQfgW5yQ GO.4JInli53foEnlq2jlRZgxZopYMDfw2t.IfcmTIKdywwCMjxgPQEmaGv1T3kl5Nyhj.sjjAwoE Yhp2IcyoUXxvECci7DF5NH10hiXy2pj9N7qK8mbvvKrineLWw2MfACIformMkYg408_9fK1nAC.u ozTN3hdFR0.Ah1uU_LuOulscqmsCTjS9I5ZJhvM4PyJ32GoXF4JWCXGeUqq6fgEOmkY9n7A1YKr4 hBbAZ0ac_Ve9VMR3ngcZ5sTqsuSfE22g9ZCuUV35lS4alHqQHRQczkjsd1PuZkAZnDXi6YoBrP43 AROyBUP1iWzmkDl4wcGOwyhfeafTsJC1sUu2Z5mrs9E9G6vjHIIvFaEsGnFsMsmguiHbVhSqRLE4 2iH2KOKaw7gWDa_F.rx7yHNSe5m4sYRftfkbCgRO2uj4cRNAHnL8zVkY0G3PEz7mrmOXMLSPjIE7 uC75aIMBMzIhB7ghH.THGRW8vOq7MoUTDItn7ByrEyMspsrWCEtFUSviMmhim42xm8AgOrR20FFG h4FI9rtbARCy3GjO0ERIhwHd8lshJMy9jMFkulVdYq97AecR3F9phFjrUf7.G.EVWTa6CjzAuK0x uuDwVWiSYlT1WVXM.4dmy1yK6o.OCRMOpOzcsYP9ccRqg17nS2akA7NhOcLtl58rEtbqTB7asxBh Ntt16dZvvk.teWpUpcLoll7LA9efY933mzBDLfMaG5rekNPDABKYFg7FTinI8KJe2x5_tHFGrgRy DlpPDj7aTDHuECD282y4CInw8WZ0W9M0.lCn4z8JLQpLCgN3AkBm4QswFKRsf6MPVXaB.hPAzjnr 3YAtsBRqJACaH0V2JKSHHPS92xWJq1R7bADkyC3Nll5fKZx.4vSiwaQFk.ce0jrOdFBv84YgrQfu 7A7NiuFf1EWG2Hx6PsoPqivHKp0Dx09B_W88qWjDvY6ITKqrje8BGCmJZyIH59DTzKR.5K7EJY5n Nkql7jpISMo9xokEoyx09Vtc57tCUw62v8pSTOk4H5.Ls7IrBYPFqTq58cl4L9n5bDiPvFX6URnE ALv4tYlkkDeLHqArygg9XY4zRWByD01aBB441ZJ.sxGHgw93aAs4U0NCi X-Sonic-MF: X-Sonic-ID: 17527769-504a-4942-931c-59aa7fb4668b Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Wed, 16 Aug 2023 19:39:49 +0000 Received: by hermes--production-ir2-5cc57b9c45-6h5c4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b00924a0a3c4f5ec8215f210c778878d; Wed, 16 Aug 2023 19:39:43 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-523476e868dso8975714a12.3 for ; Wed, 16 Aug 2023 12:39:43 -0700 (PDT) X-Gm-Message-State: AOJu0Yw8gijX4CIoyK1wXpsAK6Z5RX2syO89Eeow92cihsJ3N74e4jD/ b8pmJyjUY7EgEKJAawvAW41Hrc74tf1zAy2Bx1c= X-Google-Smtp-Source: AGHT+IF4Xmt35XqC7qivwGWVMfe57LiUEIuOdGqfaqnuM9+DIVKsZMPNYZTGXhZYgK4rUBpU0dnYrY6mWSucJSEP8sM= X-Received: by 2002:a50:fb18:0:b0:525:6d74:7122 with SMTP id d24-20020a50fb18000000b005256d747122mr2384906edq.30.1692214781872; Wed, 16 Aug 2023 12:39:41 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> In-Reply-To: From: Lin Sun Date: Wed, 16 Aug 2023 19:39:30 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' To: "bug-gnu-emacs@gnu.org" Content-Type: multipart/mixed; boundary="000000000000f52f5b06030f7414" X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3171 Received-SPF: pass client-ip=66.163.186.148; envelope-from=sunlin7@yahoo.com; helo=sonic302-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, In a EWW buffer, the user can use the 'eww-open-in-new-buffer' or "M-RET" to open a URL in a new buffer and focus on the new buffer. Sometimes people want to open the URLs in the background first and read them later, so here is the 'eww-open-in-new-buffer-background' function, binding to "C-". Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 FORGED_YAHOO_RCVD 'From' yahoo.com does not match 'Received' headers -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sunlin7[at]yahoo.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (sunlin7[at]yahoo.com) 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) --000000000000f52f5b06030f7414 Content-Type: text/plain; charset="UTF-8" Hi, In a EWW buffer, the user can use the 'eww-open-in-new-buffer' or "M-RET" to open a URL in a new buffer and focus on the new buffer. Sometimes people want to open the URLs in the background first and read them later, so here is the 'eww-open-in-new-buffer-background' function, binding to "C-". Example: using the eww to open the hack news and browse the topics, open some topics in background with "C-", and read them later. Please help review the patch. Thanks. Best Regards Lin --000000000000f52f5b06030f7414 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-net-eww.el-new-function-eww-open-in-new-buffer-.patch" Content-Disposition: attachment; filename="0001-lisp-net-eww.el-new-function-eww-open-in-new-buffer-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lle4tqk20 RnJvbSAyM2U4NTgwNzI2Y2ZmYzY4ODNhZDdmNTUzNDE0ZjI1N2MyNjNlMmJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBX ZWQsIDE2IEF1ZyAyMDIzIDAxOjAwOjA3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKmxpc3AvbmV0 L2V3dy5lbDogbmV3IGZ1bmN0aW9uCiBgZXd3LW9wZW4taW4tbmV3LWJ1ZmZlci1iYWNrZ3JvdWQn CgotLS0KIGxpc3AvbmV0L2V3dy5lbCB8IDggKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA4IGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL25ldC9ld3cuZWwgYi9saXNwL25ldC9ld3cu ZWwKaW5kZXggY2I3MzkyNmY0Ni4uM2U5YWQ1MWYxMCAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZXd3 LmVsCisrKyBiL2xpc3AvbmV0L2V3dy5lbApAQCAtNTYxLDYgKzU2MSwxMiBAQCBld3ctb3Blbi1p bi1uZXctYnVmZmVyCiAgICAgICAgICAgKGV3dy1tb2RlKQogICAgICAgICAgIChld3cgKGlmIChj b25zcCB1cmwpIChjYXIgdXJsKSB1cmwpKSkpKSkpCiAKKyhkZWZ1biBld3ctb3Blbi1pbi1uZXct YnVmZmVyLWJhY2tncm91bmQgKCkKKyAgIkZldGNoIGxpbmsgYXQgcG9pbnQgaW4gYSBuZXcgYmFj a2dyb3VuZCBFV1cgYnVmZmVyLiIKKyAgKGludGVyYWN0aXZlKQorICAoc2F2ZS13aW5kb3ctZXhj dXJzaW9uCisgICAgKGNhbGwtaW50ZXJhY3RpdmVseSAjJ2V3dy1vcGVuLWluLW5ldy1idWZmZXIp KSkKKwogKGRlZnVuIGV3dy1odG1sLXAgKGNvbnRlbnQtdHlwZSkKICAgIlJldHVybiBub24tbmls IGlmIENPTlRFTlQtVFlQRSBkZXNpZ25hdGVzIGFuIEhUTUwgY29udGVudCB0eXBlLgogQ3VycmVu dGx5IHRoaXMgbWVhbnMgZWl0aGVyIHRleHQvaHRtbCBvciBhcHBsaWNhdGlvbi94aHRtbCt4bWwu IgpAQCAtMTA3Myw2ICsxMDc5LDcgQEAgZXd3LW1vZGUtbWFwCiAgICJnIiAjJ2V3dy1yZWxvYWQg ICAgICAgICAgICAgO0ZJWE1FOiByZXZlcnQtYnVmZmVyLWZ1bmN0aW9uIGluc3RlYWQhCiAgICJH IiAjJ2V3dwogICAiTS1SRVQiICMnZXd3LW9wZW4taW4tbmV3LWJ1ZmZlcgorICAiQy08cmV0dXJu PiIgIydld3ctb3Blbi1pbi1uZXctYnVmZmVyLWJhY2tncm91bmQKICAgIlRBQiIgIydzaHItbmV4 dC1saW5rCiAgICJDLU0taSIgIydzaHItcHJldmlvdXMtbGluawogICAiPGJhY2t0YWI+IiAjJ3No ci1wcmV2aW91cy1saW5rCkBAIC0xMTEyLDYgKzExMTksNyBAQCBld3ctbW9kZS1tYXAKICAgICAg ICAgICBbIkNsb3NlIGJyb3dzZXIiIHF1aXQtd2luZG93IHRdCiAgICAgICAgICAgWyJSZWxvYWQi IGV3dy1yZWxvYWQgdF0KICAgICAgICAgICBbIkZvbGxvdyBVUkwgaW4gbmV3IGJ1ZmZlciIgZXd3 LW9wZW4taW4tbmV3LWJ1ZmZlcl0KKyAgICAgICAgICBbIkZvbGxvdyBVUkwgaW4gYmFja2dyb3Vu ZCIgZXd3LW9wZW4taW4tbmV3LWJ1ZmZlci1iYWNrZ3JvdW5kXQogICAgICAgICAgIFsiQmFjayB0 byBwcmV2aW91cyBwYWdlIiBld3ctYmFjay11cmwKICAgICAgICAgICAgOmFjdGl2ZSAobm90ICh6 ZXJvcCAobGVuZ3RoIGV3dy1oaXN0b3J5KSkpXQogICAgICAgICAgIFsiRm9yd2FyZCB0byBuZXh0 IHBhZ2UiIGV3dy1mb3J3YXJkLXVybAotLSAKMi4yMC41Cgo= --000000000000f52f5b06030f7414-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 03:49:24 2023 Received: (at 65346) by debbugs.gnu.org; 17 Aug 2023 07:49:24 +0000 Received: from localhost ([127.0.0.1]:42707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWXkx-0005vu-S7 for submit@debbugs.gnu.org; Thu, 17 Aug 2023 03:49:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWXkw-0005vi-KZ for 65346@debbugs.gnu.org; Thu, 17 Aug 2023 03:49:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWXkr-0001v4-6P; Thu, 17 Aug 2023 03:49:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LGnt1lHtywO8NgNCpj7EvegjwVm/FP4CwaIjZT26pDw=; b=sP9mVa8n0hkG 6K7HyxZn+ZPnMqDxFaKG5/qB8btD+rQT4JgZBSq+cxwSAmd8QolF0U932fWTqDEh/xRNjAz5MVtE0 bmkPwCCZ+bw6u8vLURpKgHE4GCBJ3EnxEd+Fr4RsYd2zvOZVjQopl95506xKyan8jlyBLac3IbdLh Z0BcEqGOMJ1j+fhhjjEWaKxjY/owi5+Dg/L5E4Gef97IhHr892c6d/fxH6yA7g9Rv1NP00VC57bTr 2qcxFjZ5iDr3Ee7ot9Ue9+bZYM8ZFySGjU7Bp83sql/Tz6MOFpMsEnRAGopssksOMOpOJ1bSJxVbO Xni5lTLPwysdrcaK42lxNQ==; Date: Thu, 17 Aug 2023 10:49:17 +0300 Message-Id: <83350i6rcy.fsf@gnu.org> From: Eli Zaretskii To: Lin Sun In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65346 Cc: 65346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 16 Aug 2023 19:39:30 +0000 > From: Lin Sun via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > In a EWW buffer, the user can use the 'eww-open-in-new-buffer' or "M-RET" to > open a URL in a new buffer and focus on the new buffer. > > Sometimes people want to open the URLs in the background first and read them > later, so here is the 'eww-open-in-new-buffer-background' function, > binding to "C-". > > Example: using the eww to open the hack news and browse the topics, > open some topics in background with "C-", and read them later. "Background" is a problematic word for this, since that's not what you mean: you mean not to select the window displaying the URL. And I don't think we need a separate command for that: how about doing this in eww-open-in-new-buffer instead, if the user invokes it with a prefix argument C-u? And finally, what happens if the following condition, tested by eww-open-in-new-buffer, is fulfilled: (when (or (eq eww-browse-url-new-window-is-tab t) (and (eq eww-browse-url-new-window-is-tab 'tab-bar) tab-bar-mode)) In this case, AFAIU the URL is opened in a new tab. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 18:51:32 2023 Received: (at 65346) by debbugs.gnu.org; 17 Aug 2023 22:51:32 +0000 Received: from localhost ([127.0.0.1]:45719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWlpz-00026t-T7 for submit@debbugs.gnu.org; Thu, 17 Aug 2023 18:51:32 -0400 Received: from sonic305-22.consmr.mail.ne1.yahoo.com ([66.163.185.148]:41277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWlpt-00026Z-Ni for 65346@debbugs.gnu.org; Thu, 17 Aug 2023 18:51:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692312678; bh=NVln2Z8xlA7rBZhdrzEM60dcC6jycxDqXAVlIxAe5G4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From:Subject:Reply-To; b=YaY87QdnHowwTxYkr2ML7wmXQJp+JRGGc9ffVCe42Qx13qk135vwqYfLqRc9oS0vKMghYybIZhoKwyOiB3JJymsrOayUg4kgliUXQsDS8crvheFOrlyOdrAARUH2NkMxw48gMYah103UDh65mE/0ndp+uMfLXnBi8b8S56DKL6ZYceVYg9TlZi1t5QJxbF7V5GkKxJ+6gPqul3jph6RNJ/XyAFrZwRlKZQQPRC7XKYcuK0/8YHMWUHewkbkZ4Hf1zTAjYYtUHi2BDz3qrIk7gi9REMmupHiuMLOrvbMM4g71Vm85fPqUCjQRA58SK0C3XXwz3C1izgxcVia8I536Pg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692312678; bh=2BMnjGsncACAI8LMTDo0exnZw8ibT8lMJRsrihHwnrF=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=GnTYVuqgbMTTCo23eJQGncz93vZiQlzBrSJ0EBWjTxiXCAYosKJoEcEj/Whcx0p4XEJMs/TxPWUN2fNq7UZ8l1hOfHEZgSNewho8fsSjHf1YNtSxu0ulC0/QN45hvcCwwT0BsiNuaAAD4QcWytfNmEYsPfzwJRmKlVyM+4+M7/u3E0FHK+qMmNfYD7x9ziYtIaQ4YqXgcNXmPfoQuK9LgnVHsLFGxFvHoNVlcO5R/aAa3i4AZBqiQ6TzX1HV36KLyOhWmCXMBjEr9ii7EET5O3PfgreX2T6NUHhpODB0OyEHITGHeFAOw4jVZZNN1UywLOUMiW27Aw+WRXfCB+u1oQ== X-YMail-OSG: 57XYEnkVM1nMQA9eaP.lf0z256kT22T6iuVk3yUgls2L7eu6q3PqDNZo_WPZ9_o xW9.a6O9DXkmsnZsJ9FHlf.xdlxeg9.je1A2oS_J8liaqQUZcrIc4cw9jtBXOV8UgZ2M3b5jQbm. 77X0.NTLpk8JRA4vRIfcXm6kgjLfQerEXY_COPGfstW4vQWMFwevz8dIcdUQck5226yIXW6JEbU9 dypFuOmMbvt6P_agxKVI.sU3aoNE42HG3LMPQ.f01wYSA3c10m5UOoyXwTOMU8LJz.Ex7lPiY0dI z_IWVUHh5RSWnc65fQN0SGMJvA3V9mLRu64ZwMarB4TkSaCrF5nQzOI7s4uNhxFvGlWgCYF2VeV9 DnBDloyVGZ4qUnhKIp4NO1Aa.sCkeWMow0b5qwosXThp0OItA4mMjphMwc5i4OGpBcp9XECbPlWc 91gzq.yfzXYcF2ARIawPsLAHVVK59wxsPmn7_OCTPaf2UWWae8hMJx4mbnxSJ1eAMhvfqDWeMqJH Jruh6tlpyvGjr24AMPhn.Eefl43yaTjAZwE4b5glQvNKyGh4uFW_6mdwzo9cfoaaHOzuNUSDgcAh G0OxMmKie4wuPtIi5jdxW7uLkwWVlI9cvM5U9FTecTBldAt5CQiO.srjmdh6VrwjFBO_M0dTPk7t zY_j5.OQHBlQOgHi.yO6dRvJskGTaNQ4Lh640yJK074_nVbS4PDND7Asn.YJkLo.fGKEiAMBUHDL WZb0eJNWiof5XVs7FMtXfJqij1bAIxGU.DFdjslDSM1l6WazTTdpNMEuD8r.eemYo7R_Ns3_q5rF yKzWr_J3.ffdMOKNz_qNst8Oc8ysXL64wYyst1s7TsfPk6Qwljf_2V3pzKTNzqgRkAU02ntgpvdz lurzn2NBNJzxOhm.sOm8Vs4hL32KzrCgloG6yFDXL3NmIVXd2lDM.0wnM_y0eR7npJdGHseRYLkM EO8gppEQKpEpI85UbqiiuMiifTPGuCcH.QARYXhpBNU7UA41Gmrm8DvtZFkAlGHOybk01JPAHyUp hxmeRfjZLx_woTZBr2YznWluPOmzsq5mZwCJ4_NrTGB1Eiq22VeDElJ5GMmsbPaISZmIL2shOwIN ZmYnjBDVW.Ti3G4veFbdwWmg8JKw9KnH4ml28ALN8kLIEueMBup3XsQiOZhi9y5XNGgfXEMXHUwK CBG9ZQunL6ilPFzdWKkzlWnTLTDxtD3vVXUr4L.fUVr0JFiI2YDR4zbs8_QJ5UUKR50zV0eOS5py yedLVl1LB1cwPMvTi16kOaHDlQXLszl6G590XXnbkowy8h_L3DcZEq5Pj5GR5FYO.h_44VjvSZ35 NyCfbo1LfWux66RzQGG.h3Xw8Ssz3yrO0yaacSXhkGZGdxap..2DmuYoZDlquYDDoNuejB8BJerp vFX3PeYX_e3HbdadOoAv7zTFxtr98ePExVDYnUgV1.MfUOPFwqUclErI1QAl8dl11z10UQDFdglI FkZ9LXTA6V8V6F861YMNNsajYKpG4bp4L95DutVjZxZb_4OtNSixpsML59lsCEu8AOWPBefZfC4Q AlSFJgc554Mf.lp0R6w5YgY.lnv8rhbbdycZMVaKtMDQT1CqzoyhzUeK3oTJ_Zms.nH16TgwlZcp .QjC_DM78IJ9O9RUR_g1VAyWJuWKlATq20PBwPg3GnGzCaUkuTSx4ETbLSqUehiBUsqC1y01Iriu TAlvHRTGTKGp3i_Weu1IsmbmcAnMeVItkH0QC2Ru4xa.s2PNZUPbYibRuOdcy6pIPTR8kzL7QIMH Mws1zStJQBCCU1dug7MfGxORAjhsvD3M2sC4Mf_v4zNQUAYx7oybSKHgrwF7615XB.vrnntetSiM 4VcKpVrqeNV8lyWbVtlNbRuSzIJSXtz5YI4SVa9nMRIbqvlkeeWM6SU2h6bhhC4_USIaIO_W28aO xFxZKXzIYAbZV1MDEyQ3clElEPZLkBIvmXvt0Kq3ItiCYOfL7ewy5UG.wgvvhyHp0cSHBL2cquSu __NRztte3DSN6xyYlZ.HWIxF9gqyPRJn017rOfBNfc_7DkYdcea7q12Cc.q5EfVg5Mfc3EuQOQnw 8FCQDOFvJwkAfqW8A5wUUm11yTqaBEPC8bPM537D68uWwbi5pknpui_pZeUVr7GrdiMU1P2Pcn53 ltc2jERwTDdm6.xqnfUZTNWH08GKo1oKIxwNWVAdpiuf2p4it.UMhWNtQ.VNPds3a5OIcWqq0oiD xAfFNFY8kTnj1HgWzG2nd7rkBD7BVzhgl6j6kA151tRVnHXyLLCCd8KfIhlllHfwj X-Sonic-MF: X-Sonic-ID: d372471b-babd-4546-a5e2-391e87b19283 Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Thu, 17 Aug 2023 22:51:18 +0000 Received: by hermes--production-ir2-5cc57b9c45-xh7tc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ffd50233cf2550ab3d1b8e0d70a8f4de; Thu, 17 Aug 2023 22:51:17 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5257e2b5d12so331255a12.2 for <65346@debbugs.gnu.org>; Thu, 17 Aug 2023 15:51:17 -0700 (PDT) X-Gm-Message-State: AOJu0Yy5c4E4BEH5CN4X+dEO6f9qb7RQpmTBQi4qQIpqClnKceC8DJgt ugj6veMlLS9jOWEXj9GTJJVjyWoAkydF24UP+d4= X-Google-Smtp-Source: AGHT+IGPbkRPmVxItTmHllJcIpPG3RUpHAJTZXUVigxHwW6/feJkPoMjgwSIWqjkPyAyzoAOPHjztVNYJxhuN1HGmxk= X-Received: by 2002:a17:906:5a50:b0:99c:7301:4d69 with SMTP id my16-20020a1709065a5000b0099c73014d69mr579770ejc.20.1692312675899; Thu, 17 Aug 2023 15:51:15 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> In-Reply-To: <83350i6rcy.fsf@gnu.org> From: Lin Sun Date: Thu, 17 Aug 2023 22:51:04 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000e5a32e0603263faa" X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 5091 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 65346 Cc: 65346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000e5a32e0603263faa Content-Type: text/plain; charset="UTF-8" Hi Eli, > "Background" is a problematic word for this, since that's not what you > mean: you mean not to select the window displaying the URL. > > And I don't think we need a separate command for that: how about doing > this in eww-open-in-new-buffer instead, if the user invokes it with a > prefix argument C-u? > > And finally, what happens if the following condition, tested by > eww-open-in-new-buffer, is fulfilled: > > (when (or (eq eww-browse-url-new-window-is-tab t) > (and (eq eww-browse-url-new-window-is-tab 'tab-bar) > tab-bar-mode)) > > In this case, AFAIU the URL is opened in a new tab. Thank you for the comment, and agree with you, so I rewrote the function `eww-open-in-new-buffer' with "C-u" support (also with an optional argument "url"), then there is no "background" description. I also tested the new patch with tab-bar-mode on and off, it works for both scenarios. Please help review again. Thanks. Best regards Lin --000000000000e5a32e0603263faa Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-net-eww.el-eww-open-in-new-buffer-able-to-stay-.patch" Content-Disposition: attachment; filename="0001-lisp-net-eww.el-eww-open-in-new-buffer-able-to-stay-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_llfr8je50 RnJvbSAzMTcwMTliY2MxZjY1OWJmNzFkYzIwYzE5OThkYzhiNDYyM2IwZmUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBX ZWQsIDE2IEF1ZyAyMDIzIDAxOjAwOjA3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKmxpc3AvbmV0 L2V3dy5lbDogYGV3dy1vcGVuLWluLW5ldy1idWZmZXInIGFibGUgdG8gc3RheSBvbgogY3VycmVu dCBidWZmZXIKCi0tLQogbGlzcC9uZXQvZXd3LmVsIHwgNTAgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlv bnMoKyksIDE4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xp c3AvbmV0L2V3dy5lbAppbmRleCBjYjczOTI2ZjQ2Li4yM2I0ZmUzMTE3IDEwMDY0NAotLS0gYS9s aXNwL25ldC9ld3cuZWwKKysrIGIvbGlzcC9uZXQvZXd3LmVsCkBAIC01NDIsMjQgKzU0MiwzOCBA QCBld3ctc2VhcmNoLXdvcmRzCiAgICAgICAgICAgKGNhbGwtaW50ZXJhY3RpdmVseSAjJ2V3dykp KQogICAgIChjYWxsLWludGVyYWN0aXZlbHkgIydld3cpKSkKIAotKGRlZnVuIGV3dy1vcGVuLWlu LW5ldy1idWZmZXIgKCkKLSAgIkZldGNoIGxpbmsgYXQgcG9pbnQgaW4gYSBuZXcgRVdXIGJ1ZmZl ci4iCi0gIChpbnRlcmFjdGl2ZSkKLSAgKGxldCAoKHVybCAoZXd3LXN1Z2dlc3RlZC11cmlzKSkp Ci0gICAgKGlmIChudWxsIHVybCkgKHVzZXItZXJyb3IgIk5vIGxpbmsgYXQgcG9pbnQiKQotICAg ICAgKHdoZW4gKG9yIChlcSBld3ctYnJvd3NlLXVybC1uZXctd2luZG93LWlzLXRhYiB0KQotICAg ICAgICAgICAgICAgIChhbmQgKGVxIGV3dy1icm93c2UtdXJsLW5ldy13aW5kb3ctaXMtdGFiICd0 YWItYmFyKQotICAgICAgICAgICAgICAgICAgICAgdGFiLWJhci1tb2RlKSkKLSAgICAgICAgKGxl dCAoKHRhYi1iYXItbmV3LXRhYi1jaG9pY2UgdCkpCi0gICAgICAgICAgKHRhYi1uZXcpKSkKLSAg ICAgIDs7IGNsb25lIHVzZWZ1bCB0byBrZWVwIGhpc3RvcnksIGJ1dAotICAgICAgOzsgc2hvdWxk IG5vdCBjbG9uZSBmcm9tIG5vbi1ld3cgYnVmZmVyCi0gICAgICAod2l0aC1jdXJyZW50LWJ1ZmZl cgotICAgICAgICAgIChpZiAoZXEgbWFqb3ItbW9kZSAnZXd3LW1vZGUpIChjbG9uZS1idWZmZXIp Ci0gICAgICAgICAgICAoZ2VuZXJhdGUtbmV3LWJ1ZmZlciAiKmV3dyoiKSkKLSAgICAgICAgKHVu bGVzcyAoZXF1YWwgdXJsIChld3ctY3VycmVudC11cmwpKQotICAgICAgICAgIChld3ctbW9kZSkK LSAgICAgICAgICAoZXd3IChpZiAoY29uc3AgdXJsKSAoY2FyIHVybCkgdXJsKSkpKSkpKQorKGRl ZnVuIGV3dy0tb3Blbi11cmwtaW4tbmV3LWJ1ZmZlciAodXJsKQorICAiT3BlbiB0aGUgVVJMIGlu IGEgbmV3IEVXVyBidWZmZXIuIgorICA7OyBjbG9uZSB1c2VmdWwgdG8ga2VlcCBoaXN0b3J5LCBi dXQKKyAgOzsgc2hvdWxkIG5vdCBjbG9uZSBmcm9tIG5vbi1ld3cgYnVmZmVyCisgICh3aXRoLWN1 cnJlbnQtYnVmZmVyCisgICAgICAoaWYgKGVxIG1ham9yLW1vZGUgJ2V3dy1tb2RlKSAoY2xvbmUt YnVmZmVyKQorICAgICAgICAoZ2VuZXJhdGUtbmV3LWJ1ZmZlciAiKmV3dyoiKSkKKyAgICAodW5s ZXNzIChlcXVhbCB1cmwgKGV3dy1jdXJyZW50LXVybCkpCisgICAgICAoZXd3LW1vZGUpCisgICAg ICAoZXd3IChpZiAoY29uc3AgdXJsKSAoY2FyIHVybCkgdXJsKSkpKSkKKworKGRlZnVuIGV3dy1v cGVuLWluLW5ldy1idWZmZXIgKHN0YXkgJm9wdGlvbmFsIHVybCkKKyAgIkZldGNoIFVSTCBpbiBh IG5ldyBFV1cgYnVmZmVyLgorCitJZiB0aGUgU1RBWSBpcyBub3QgYG5pbCcsIHRoZSBmb3JjdXMg d2lsbCBzdGF5IG9uIGN1cnJlbnQgYnVmZmVyLgorCitJZiB0aGUgVVJMIGlzIGBuaWwnLCBpdCB3 aWxsIHRyeSBgZXd3LXN1Z2dlc3RlZC11cmlzJyB1bmRlciBjdXJyZW50IGN1cnNvci4iCisgIChp bnRlcmFjdGl2ZSAiUCIpCisgIChpZi1sZXQgKCh1cmwgKG9yIHVybCAoZXd3LXN1Z2dlc3RlZC11 cmlzKSkpKQorICAgICAgKGlmIChvciAoZXEgZXd3LWJyb3dzZS11cmwtbmV3LXdpbmRvdy1pcy10 YWIgdCkKKyAgICAgICAgICAgICAgKGFuZCAoZXEgZXd3LWJyb3dzZS11cmwtbmV3LXdpbmRvdy1p cy10YWIgJ3RhYi1iYXIpCisgICAgICAgICAgICAgICAgICAgdGFiLWJhci1tb2RlKSkKKyAgICAg ICAgICAobGV0ICgodGFiLWJhci1uZXctdGFiLWNob2ljZSB0KSkKKyAgICAgICAgICAgICh0YWIt bmV3KQorICAgICAgICAgICAgKGV3dy0tb3Blbi11cmwtaW4tbmV3LWJ1ZmZlciB1cmwpCisgICAg ICAgICAgICAod2hlbiBzdGF5CisgICAgICAgICAgICAgICh0YWItYmFyLXN3aXRjaC10by1wcmV2 LXRhYikpKQorCisgICAgICAgIChpZiBzdGF5CisgICAgICAgICAgICAoc2F2ZS13aW5kb3ctZXhj dXJzaW9uIChld3ctLW9wZW4tdXJsLWluLW5ldy1idWZmZXIgdXJsKSkKKyAgICAgICAgICAoZXd3 LS1vcGVuLXVybC1pbi1uZXctYnVmZmVyIHVybCkpKQorICAgICh1c2VyLWVycm9yICJObyBhdmFs aWFibGUgbGluayIpKSkKIAogKGRlZnVuIGV3dy1odG1sLXAgKGNvbnRlbnQtdHlwZSkKICAgIlJl dHVybiBub24tbmlsIGlmIENPTlRFTlQtVFlQRSBkZXNpZ25hdGVzIGFuIEhUTUwgY29udGVudCB0 eXBlLgotLSAKMi4yMC41Cgo= --000000000000e5a32e0603263faa-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 22:16:11 2023 Received: (at 65346) by debbugs.gnu.org; 18 Aug 2023 02:16:11 +0000 Received: from localhost ([127.0.0.1]:45807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWp23-0007bm-7S for submit@debbugs.gnu.org; Thu, 17 Aug 2023 22:16:11 -0400 Received: from mout.web.de ([212.227.17.11]:48887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWp1y-0007b6-V4 for 65346@debbugs.gnu.org; Thu, 17 Aug 2023 22:16:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1692324958; x=1692929758; i=michael_heerdegen@web.de; bh=qBBtmFdEKdQptfy49mJWACHAkEs87x/6nsBVyi7Lrbs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=MmPgxF2kzfAHvnqjwY3Lpf5TPPluvOU1hwCHAXO+ULvXkoozm2K+k5kAqsmsRsZuz+xzcS8 /5+A9TGA8pYvtxhBejGHtpHufhB3Ho5MI6Z30BrcZW/A5mZdXFNVEDmciQo8K3c+p2vDtk+NM pI2wndWiv9PMsUMDkYOoi4Fu07bTjtbfRZMfJ2mFPoQxnBXalbqVdpp2anviLFs54NHjWFNch 16D3W7+7lh4S3BorOrUlbndUYrWMvdEwrOzzY0WAutmCECOLykYbvrskjf7O8Bz1tUll1lWV7 9XylT4ZbxvwLsXvW0YzvEtZQtU3zNKgV9kuGtYwWE414hTeyeZuQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.75.138.214]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MlsOP-1q638H2AEd-00ifdO; Fri, 18 Aug 2023 04:15:58 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' In-Reply-To: <83350i6rcy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Aug 2023 10:49:17 +0300") References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> Date: Fri, 18 Aug 2023 04:15:57 +0200 Message-ID: <87a5up9jtu.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:xRF4ipizlLbXchT0JfbZYlCMPcG+8K7I9HF0spZOTxuwUelaBhh VJgx1KpqAo3+wwIUORTGxdPXc22A8W6E1F1etsZYsQJbeORZQWMCyCeyhqJ84eGDAZo/6ha W40/SVruzpc5URlDe7HjXFJ/bNdiY7UtpohnxvA+eDATnG/Luvc2fjdplMBahcuCNozw031 Ko8X7u1Wke1EtHB1o195g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:1hpkokzSpnE=;XUlbY3lJo7npBzjOaTK0TcWqekq Q6I6GP0pyuLadqzqOzohh1cyXBOMnew3Mz/ypCCucfaBib7uuhVSdHIE7JA8QaKaMwbKHMX0q RFUxnXPsSbeTopxxK6yBUTDgFFrvCTY9E3eSJjP9TVm/poO2h/X7OAWV/zqr6jBgQnvdw9QfR wFJe5PjFnS02W3AwQyldi7gvdrLCu3PxUQaik6vxSuwPeNp/7BbkA4TGG8QoiGa4PGTaeaQIY wkJP8xkzcqikuQXrTx+5qzPiqHNw7pmnW0Z84biUjiy2gRLxHzW5rIswkb4KBidEdXQuaEiSb i0eltW6w1+Lg4XI2CCX+IZZFEIXQhvKv7mVspM9U6kBHGzswcnlP4C+Ca12KJ3yWxOaFncI0i PY/0xjtR0qbUhKU8kVOA55Vg4lnW3mmhoqR6U1nwONVFtSuBbqjlaAwChkXoxPR5JuqfPTfIn cSc06hoOO71rPrIFE8Qf+UP4p0SopycXGs40/hDPDoiHboXbUq8YbhEYzOKYKJs+oJ6+vjmFl jBO98+tHicOTqia7fuu1oAPKVSu8fYuz0bLjieI/2fgmFwgAGnEGVOM/znC8kDa1Hs0EiBWKh ZMCx6WASmDTkUuA3KHIkcbxMze90WMgG3WIibbLqkKNeZUGBhUcIZmCbMaSK+1+EvUIR1mJGq O0JOGkA+Fcrb2gabw/TXg0akrBy0TEvLKALwzA1dkT2g/FPVPtRlsc1U9bE0k9lqPLuJex2IT O8Ux3Bvlixt9CG/q7cFJWHjh7CyLwa398UAmy6urQ2/ZJj51ezd2L4fLu3Why3feLn3kxnCBZ bCfXXAUgPad4GgLEecXeI/JANr160rL7GUDXyhqvJt7UfLDp6uP7YXdS4vXD4VPNiGojZYSFk +40vM29wLqPHg/8rRvvANdDsTUJQ2sX4ky6C80GEaGp6q8Oc0GquAiXVlwtHNA4yedKSogLSD FMuUl0E1MqkTS2VsEeCc0a0gVb0= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65346 Cc: Lin Sun , 65346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > "Background" is a problematic word for this, since that's not what you > mean: you mean not to select the window displaying the URL. Right - but isn't that the wording known from other browsers? > And I don't think we need a separate command for that: how about doing > this in eww-open-in-new-buffer instead, if the user invokes it with a > prefix argument C-u? That's not very convenient, though. How about adding an option that toggles the meaning of the prefix arg? Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 18 01:52:33 2023 Received: (at 65346) by debbugs.gnu.org; 18 Aug 2023 05:52:33 +0000 Received: from localhost ([127.0.0.1]:45910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWsPR-0007qM-4J for submit@debbugs.gnu.org; Fri, 18 Aug 2023 01:52:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWsPP-0007q6-Mt for 65346@debbugs.gnu.org; Fri, 18 Aug 2023 01:52:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWsPJ-00070i-I4; Fri, 18 Aug 2023 01:52:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vpk0fTIkITg+eOav7XtM5KFohjOtWFTpGoEVZ9zHhkE=; b=AUB4QoCrMG1O CVgXA8WvmOuKriU70M3vAUTFyVpVGbkX5zrv7mAtj3EeZJxSVQnTOA2+FtmR6aDK8OHxa6TLV3JG0 afoyBR9WK8YW7c96/4j//YSYhd//vvMl+kcPTg8jDAnS0AG4Sd9/iiBjw2RcaijaV3w+l0yyzGU8W 4+bRgYq229LHgFEfJ5XLbFJ0erktXt4Abo9AaqnoRWdtTzabJ479np1WMLUsRzzga7HgSlcoeQ0u7 TZJrOawDiW6XLkfy1X0eOjK8+aP6g0lOCM5CALoSv2d1CJrTFXsU7Xamtdps7uG9vWxxnzF6iprot K4qpr0yXq9wE9At/IoH8Uw==; Date: Fri, 18 Aug 2023 08:52:32 +0300 Message-Id: <83sf8g523j.fsf@gnu.org> From: Eli Zaretskii To: Lin Sun In-Reply-To: (message from Lin Sun on Thu, 17 Aug 2023 22:51:04 +0000) Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65346 Cc: 65346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lin Sun > Date: Thu, 17 Aug 2023 22:51:04 +0000 > Cc: 65346@debbugs.gnu.org > > Thank you for the comment, and agree with you, so I rewrote the > function `eww-open-in-new-buffer' with "C-u" support (also with an > optional argument "url"), then there is no "background" description. > > I also tested the new patch with tab-bar-mode on and off, it works for > both scenarios. > > Please help review again. Thanks. Thanks. However, the way you implemented my suggestion is not what I had in mind. > -(defun eww-open-in-new-buffer () > - "Fetch link at point in a new EWW buffer." > - (interactive) > - (let ((url (eww-suggested-uris))) > - (if (null url) (user-error "No link at point") > - (when (or (eq eww-browse-url-new-window-is-tab t) > - (and (eq eww-browse-url-new-window-is-tab 'tab-bar) > - tab-bar-mode)) > - (let ((tab-bar-new-tab-choice t)) > - (tab-new))) > - ;; clone useful to keep history, but > - ;; should not clone from non-eww buffer > - (with-current-buffer > - (if (eq major-mode 'eww-mode) (clone-buffer) > - (generate-new-buffer "*eww*")) > - (unless (equal url (eww-current-url)) > - (eww-mode) > - (eww (if (consp url) (car url) url))))))) > +(defun eww--open-url-in-new-buffer (url) > + "Open the URL in a new EWW buffer." > + ;; clone useful to keep history, but > + ;; should not clone from non-eww buffer > + (with-current-buffer > + (if (eq major-mode 'eww-mode) (clone-buffer) > + (generate-new-buffer "*eww*")) > + (unless (equal url (eww-current-url)) > + (eww-mode) > + (eww (if (consp url) (car url) url))))) > + > +(defun eww-open-in-new-buffer (stay &optional url) > + "Fetch URL in a new EWW buffer. This changes the API of a public function in incompatible ways, which we try very hard not to do. Instead, the signature or eww-open-in-new-buffer should be like this: (defun eww-open-in-new-buffer (&optional no-select) and the new NO-SELECT argument should be set non-nil by C-u. > + (user-error "No avaliable link"))) This also changes the text of the error message in this case. Was that really necessary? The original text was more accurate, I think. Also, this new feature needs a NEWS entry and a suitable addition to the EWW manual. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 18 02:07:58 2023 Received: (at 65346) by debbugs.gnu.org; 18 Aug 2023 06:07:58 +0000 Received: from localhost ([127.0.0.1]:45946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWseL-0008Iv-PV for submit@debbugs.gnu.org; Fri, 18 Aug 2023 02:07:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWseJ-0008Ia-OU for 65346@debbugs.gnu.org; Fri, 18 Aug 2023 02:07:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWse0-0003VP-6t; Fri, 18 Aug 2023 02:07:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EezOIVb8N2StysWud5YRScrOnbLbYimX45Q66t94E+k=; b=QYgkHufiYjiM gj6/b6a6jMFYVQlv6gX565qn5kZns1rxfhKfJnG76BGcUSMcXYPcZcA0jDPCe3O7Wu3RkSR7cz5+I 0DU5h1VLZJEvgnT/2ATX241glLaa7hWwYMM6jGDpX14Bb6L3wqbDAl2wRLz6/Ly+2aZJOMe5bgAnv 6YnGE0HgC7Anv+6YO46z07udjP22owGdu1exV0drgfiwrnEMCCLKb5/7P+icLvWJVFkP/VQBkpUug +Q0nsllxXt26/32cbNwVpbSoWIQd9f1fCL/sTwuRPEYj3cIV+6qUk+MUC4cdN2xUvsefOK7pAjrKv t8DI7oPQ+ieBHJfc0+Zacg==; Date: Fri, 18 Aug 2023 09:07:28 +0300 Message-Id: <83lee851en.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87a5up9jtu.fsf@web.de> (message from Michael Heerdegen on Fri, 18 Aug 2023 04:15:57 +0200) Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> <87a5up9jtu.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65346 Cc: sunlin7@yahoo.com, 65346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: Lin Sun , 65346@debbugs.gnu.org > Date: Fri, 18 Aug 2023 04:15:57 +0200 > > Eli Zaretskii writes: > > > "Background" is a problematic word for this, since that's not what you > > mean: you mean not to select the window displaying the URL. > > Right - but isn't that the wording known from other browsers? Not AFAIK, no. And in Emacs, "background" has several other meanings, which could confuse. > > And I don't think we need a separate command for that: how about doing > > this in eww-open-in-new-buffer instead, if the user invokes it with a > > prefix argument C-u? > > That's not very convenient, though. How about adding an option that > toggles the meaning of the prefix arg? Fine by me. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 18 15:03:36 2023 Received: (at 65346) by debbugs.gnu.org; 18 Aug 2023 19:03:36 +0000 Received: from localhost ([127.0.0.1]:48796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qX4kx-0004Pa-GD for submit@debbugs.gnu.org; Fri, 18 Aug 2023 15:03:35 -0400 Received: from sonic314-21.consmr.mail.ne1.yahoo.com ([66.163.189.147]:45962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qX4kv-0004PL-2n for 65346@debbugs.gnu.org; Fri, 18 Aug 2023 15:03:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692385406; bh=5EJykD2BKTtQINygQpV0a5kusbzbuyTG5YBcZxAZ2Mc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From:Subject:Reply-To; b=t1mVkxSZ0T5Q07inOG5KQ0TxVmdJzHtDZ0iiMjKuEPlT8HRDGFJPcEFNTbsyeF2xMM6fb49CCbMXHPHs2NXdsfxWMVsUr4m+8K5JSinMCBJXQAZAfpoXgm5oJcCRJtA7ki8t7BD4f3mYsftt4gIxGxvHD9zediKz/9lACdZqOxd8aKZm6pUC6sQeJqVNSWUOvcf1wZCYOAsBCSLGAfTP4I8+RfW2sEGqJOJbQNcCUHIHGXJfJWl2OdKFWWVulSdTsBYD0cOGnqc2Q1BjWuAY+fLe1r04XCdlszcmAY/B/U/puRpKZ52tR+ScRiwZwojVlqmHheGn/VXlG/wU1mQIug== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692385406; bh=zxkF7w5B6CEe0AB1fH1lWy/nf6ehUrRS2/RIi8VIYIB=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=UjD5mu5cxjiIH5vas0fp2H8XhRvdC0bH1H9aOuvmYoCotlzaajQA5I6ljgMethD2q5xtxB4cq5dl7agTFgrXUlzGYfxjFR8OuR7feWv3a/vZaKXKM0ES4ppiBRgnB6jSZEcDl63MArLtcrxjMafL14ZZpH9D4T42BN/uBh/gGHegv/lXn8oh1jbqTN3fTQ8J+8KzT9Rq0I6hKoEd38njxE0B7V9UqwOcRWSCRu+LO0PbkDYS7YxNIhWWDMjY56Q10Z6Wr8Hrb4QPP4MLZm+gIQAC6PWG58LMLoNK4j9KrBelF1fY17ApdJMM7ckNga2fTFhlwNrlymV5Cahgt2V4XQ== X-YMail-OSG: 2sQDSCkVM1l0zJldzOXrrS65U.KVh1FRqMGJdQFT9ey2dmxvbXwIUaHg3ZhSZc8 ol90At8z9YEA0mzt398TMz3NN2xeSjUlQHqmiBmSYrDLBKbYkOc8vF166sO8RKVU5K8pUkAHSNqw d1Zp3GVtbJQaNQCYO2Ma_wPg5LS9BT1zH1xvo66CcEyislCv0xMyK.myzuWQRYNHh_FpBG6gziOA ClmGFpFTHRnOQjX38oGHQ0pgGDb_v_M_M9n.x9gPL0HIgIKdv_ReQGSqmmHDuGYGiiGwevFc80G_ ESVN7bmU6U5adfjqyGnHIY.PEVqvnxH6GHxVNyqUExIkg9b7hVdWvuKmpTBdvDTh_dUvOIy6BDmq pxOerb1VLkdJTxwgV37ZF9hTDwxQrG5w_ZfZlGyD6TMQswv.L0jRVezF8.vMMWsXYDuJisX9v7ER pHmAnYkLKnS6NbWbj1kWxjukT.uHeZ7WXpNI9nByzfkIpxvbUE85mo_odhvPocBl8kIdUX25EL9u JqqPppR8ThiinhdpkpCJgiroNQsvCBvj8BoLaDCEMD.dcucJyLSvmopNKZrds41dE5.vv_8nCtCP kWDZLP0qEkbMqH1maoj.DpLLd8B_QtFx5sgiSPP7vJbZbZLObUB7ulvDfd6pAEuJzVdx8_e8lQa7 oNL_EBP2ilzVr._7UZYrLVT23_l5jANnMELYvbZLseGk1BYwcWf7TzDl3dEeNQKVu1xs8ZPjmmBQ YoIcpBcfW7rYCK4CWcxprdqFfQrRfnrXR757TezkN8i4w51Dc65eW5f9.nIZjUcG91sD0T_z00y7 iANx7pNSzvzz6pcNZQhNBp.5ccjJVh17qhZP.wj41c_3K6_9yRsn5JFFWc7WxZbol2eJ81MrXtKN w1EukxQo.y42t_FUiGoxNt8wzeihNLyUfxlM3aJ9FIkltfDoE2GKT03qng.BGY3P0pt3auUbo7HJ wfIuzPV__H21hjEa2yYCFBVc5uQ_uyNvuLag0q2khgmDGwz5mFkZA7lGIVq.f5NeT65caMVTZGsb 14n891Uu5aQLu97WCS1JJlu8Kt44Lz_U2HT9QEITQuJQVLWgsXEN73HzafvMgvm4lNYSUqG5WxmD v0bbYoDkPqUsvNxY8lzwzXqSYMPK_C5qTFCGkIZSMbXgUBIIGCu4UzFc5qmhrODiYjDx0Svx0woO JHOv425M.0SidUzYT_nMQYgiOhRXhWH_vrQqvIJIx_8hR5alvfgFFIalpajbxcZO4Qyl__XgMdlA .A7TfSLRP9aziCAvL0ML2769PYaJM6tWbELu2bBTRkRGEQAIZCNzhnkM76RCzkQZ_Jb0R5O3F5tc Qnp1tpp7uDs0UXYVgf5Zyypd5mdHNr6h2HuoPGa0iCFNIb_ulqFoQF3bMI3Kz7MRm6dBN9r.eUUi LE812l5VYyL3ZXwlslNuTOsh7Feh2ZjptsUtCzPJWB0tsqurQ.O.8ynoYL0Oa_oA7oI.wjM0s8Cc N_5xBsr0RZZJ7_iApW9X7K9xTUBS7DS9rvChHP2yA2bGVWH4Ap7d6ylKXmBN1FbQxOdsma3JUNS. JLlYy_gFeOT66PNY7g0gEhbDAWstoe6Ieu7bBCAwPBRKHr8cNOfr4yY9YoVEOHAv5j7RGC88mcKe 7rvZKe0kCxD8Udh.v8eXeSD0.EigBg12G2Pwdec6fIpUUDDUdEuzmqL0L7KD.PUPLKITQXPwzeex 0ti5_wAb3bK1t_jhi1fc_JaohNzi6eJM.B98vXf.usaLckRH15D2123mnGi_oQaIlVfb2vm5jYrS fS.KkY8BVGqdoXARB9gEsWvTlQYFkrAP1D.0YKg5k2otAGar5sEEyNwrTeE_E5L5mKoETESDKFEr 4lvgfJM4BubDDlb4dPjIWw3g8RtBaUVk4.4Tr2nclTLBVPHx6op5OExmVJMHsrgpuyy1oRrNCi6B MtFmkJn3_eHDLHn7PCaY1Ux_vnniMKpfOavKSHZvycwJWOjkiwWbcu2keTcmgjY3obepNv05I9Ys zLl4l0RXJkIKpGAYBjMMlZI3iAOz5ZsWzrBH_EpQLDSUF3gPMLUpCQJo3URrqQk00vr6geyAzAvY vyobgutmqUJrZk4BOXg71fF40xHqV7M3tINI2IlA5Tc6YCtW.P7E713KR1QHgIbzL9QZLk1NK3MM vtGxqi76X0RVh7skY7U._vQAYQT5wa2moaELk0Axazz3HiJ5uGaKAcH5No42Lt56KUcrLPbhi3Is 01FrzcXpJ97XcGWdzgUoWLxKDpTOIZUZFuE26.HsMzWBivYPnfxXCJ08b9.qzqZskvI8ZirLQ X-Sonic-MF: X-Sonic-ID: bb65e3f4-86a4-48bd-841d-495891f359f9 Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Fri, 18 Aug 2023 19:03:26 +0000 Received: by hermes--production-ir2-5cc57b9c45-mk5d2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ed63814f0cb061f29242cf4152504dd8; Fri, 18 Aug 2023 19:03:21 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-522bd411679so1534455a12.0 for <65346@debbugs.gnu.org>; Fri, 18 Aug 2023 12:03:21 -0700 (PDT) X-Gm-Message-State: AOJu0YwiesDg3ix+ZHXLC10J8ZE+KFW3suVXYnHtJtZTk+pgV91GCbXz aWvNwn72u/HwQhZAXOQiUodhsZXRmZWmp+L3M18= X-Google-Smtp-Source: AGHT+IHEE8Qm0EW5cXM/KukX1KcMwZ5xQU7278FG+qIO+lQorxu4TIES25JC25UWpMAXhd4orUJNg8Auj66DHa9q+yI= X-Received: by 2002:a17:907:a075:b0:993:e752:1a6f with SMTP id ia21-20020a170907a07500b00993e7521a6fmr76541ejc.6.1692385400103; Fri, 18 Aug 2023 12:03:20 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> <83sf8g523j.fsf@gnu.org> In-Reply-To: <83sf8g523j.fsf@gnu.org> From: Lin Sun Date: Fri, 18 Aug 2023 19:03:08 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' To: Eli Zaretskii Content-Type: multipart/mixed; boundary="00000000000098c4ed0603372eeb" X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 6440 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 65346 Cc: 65346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --00000000000098c4ed0603372eeb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 18, 2023 at 5:52=E2=80=AFAM Eli Zaretskii wrote: > This changes the API of a public function in incompatible ways, which > we try very hard not to do. Instead, the signature or > eww-open-in-new-buffer should be like this: > > (defun eww-open-in-new-buffer (&optional no-select) > > and the new NO-SELECT argument should be set non-nil by C-u. > > > + (user-error "No avaliable link"))) > > This also changes the text of the error message in this case. Was > that really necessary? The original text was more accurate, I think. > > Also, this new feature needs a NEWS entry and a suitable addition to > the EWW manual. The attached patch included changes for the function, error message, NEWS and EWW manual. Please help review it. Thanks. Regards --00000000000098c4ed0603372eeb Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-net-eww.el-eww-open-in-new-buffer-able-to-stay-.patch" Content-Disposition: attachment; filename="0001-lisp-net-eww.el-eww-open-in-new-buffer-able-to-stay-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_llgyju0j0 RnJvbSAyZmI5NWQ3NjFkNGQ1M2U4YjM0MjUzZDg5ZmQwNmVhMjY3ZjNlYjBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBX ZWQsIDE2IEF1ZyAyMDIzIDAxOjAwOjA3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKmxpc3AvbmV0 L2V3dy5lbDogYGV3dy1vcGVuLWluLW5ldy1idWZmZXInIGFibGUgdG8gc3RheSBvbgogY3VycmVu dCBidWZmZXIKCi0tLQogZG9jL21pc2MvZXd3LnRleGkgfCAgMyArKy0KIGV0Yy9ORVdTICAgICAg ICAgIHwgIDUgKysrKysKIGxpc3AvbmV0L2V3dy5lbCAgIHwgNDkgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0 aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvZXd3LnRleGkg Yi9kb2MvbWlzYy9ld3cudGV4aQppbmRleCBiNjc2MjRhZjlmLi4yMTgxMzU1YTU3IDEwMDY0NAot LS0gYS9kb2MvbWlzYy9ld3cudGV4aQorKysgYi9kb2MvbWlzYy9ld3cudGV4aQpAQCAtMTM3LDcg KzEzNyw4IEBAIEJhc2ljcwogYGB0YWInJyBpbiBvdGhlciBicm93c2Vycy4gIFdoZW4gQGNvZGV7 Z2xvYmFsLXRhYi1saW5lLW1vZGV9IGlzCiBlbmFibGVkLCB0aGlzIGJ1ZmZlciBpcyBkaXNwbGF5 ZWQgaW4gdGhlIHRhYiBvbiB0aGUgd2luZG93IHRhYiBsaW5lLgogV2hlbiBAY29kZXt0YWItYmFy LW1vZGV9IGlzIGVuYWJsZWQsIGEgbmV3IHRhYiBpcyBjcmVhdGVkIG9uIHRoZSBmcmFtZQotdGFi IGJhci4KK3RhYiBiYXIuICBJZiB0aGUgcHJlZml4IGtleSBAa2Jke0MtdX0gaXMgYXZhbGlhYmxl LCBpdCB3aWxsIHN0YXkgb24KK2N1cnJlbnQgYnVmZmVyLgogCiBAZmluZGV4IGV3dy1yZWFkYWJs ZQogQGtpbmRleCBSCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDgwOGI1 OTk2NzIuLjEzYWVkZWUyZDUgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBA IC00NTIsNiArNDUyLDExIEBAIHRoZSBraWxsIHJpbmcuICBBbHRlcm5hdGUgbGlua3MgYXJlIG9w dGlvbmFsIG1ldGFkYXRhIHRoYXQgSFRNTCBwYWdlcwogdXNlIGZvciBsaW5raW5nIHRvIHRoZWly IGFsdGVybmF0aXZlIHJlcHJlc2VudGF0aW9ucywgc3VjaCBhcwogdHJhbnNsYXRlZCB2ZXJzaW9u cyBvciBhc3NvY2lhdGVkIFJTUyBmZWVkcy4KIAorKysrCisqKiogJ2V3dy1vcGVuLWluLW5ldy1i dWZmZXInIHN1cHBvcnQgcHJlZml4IGtleSAiQy11IiB0byBzdGF5IGN1cnJlbnQgYnVmZmVyLgor VGhlIGNvbW1hbmQgYWNjZXB0IHRoZSBwcmVmaXgga2V5ICJDLXUiIHRvIG9wZW4gdGhlIHVybCBp biBhIG5ldworYnVmZmVyIGJ1dCBzdGF5IGluIGN1cnJlbnQgYnVmZmVyLCB3b24ndCBqdW1wIHRv IHRoZSBuZXcgYnVmZmVyLgorCiAqKiBnby10cy1tb2RlCiAKICsrKwpkaWZmIC0tZ2l0IGEvbGlz cC9uZXQvZXd3LmVsIGIvbGlzcC9uZXQvZXd3LmVsCmluZGV4IGNiNzM5MjZmNDYuLmYyZWQ2MGYx NzIgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAg LTU0MiwyNCArNTQyLDM3IEBAIGV3dy1zZWFyY2gtd29yZHMKICAgICAgICAgICAoY2FsbC1pbnRl cmFjdGl2ZWx5ICMnZXd3KSkpCiAgICAgKGNhbGwtaW50ZXJhY3RpdmVseSAjJ2V3dykpKQogCi0o ZGVmdW4gZXd3LW9wZW4taW4tbmV3LWJ1ZmZlciAoKQotICAiRmV0Y2ggbGluayBhdCBwb2ludCBp biBhIG5ldyBFV1cgYnVmZmVyLiIKLSAgKGludGVyYWN0aXZlKQotICAobGV0ICgodXJsIChld3ct c3VnZ2VzdGVkLXVyaXMpKSkKLSAgICAoaWYgKG51bGwgdXJsKSAodXNlci1lcnJvciAiTm8gbGlu ayBhdCBwb2ludCIpCi0gICAgICAod2hlbiAob3IgKGVxIGV3dy1icm93c2UtdXJsLW5ldy13aW5k b3ctaXMtdGFiIHQpCi0gICAgICAgICAgICAgICAgKGFuZCAoZXEgZXd3LWJyb3dzZS11cmwtbmV3 LXdpbmRvdy1pcy10YWIgJ3RhYi1iYXIpCi0gICAgICAgICAgICAgICAgICAgICB0YWItYmFyLW1v ZGUpKQotICAgICAgICAobGV0ICgodGFiLWJhci1uZXctdGFiLWNob2ljZSB0KSkKLSAgICAgICAg ICAodGFiLW5ldykpKQotICAgICAgOzsgY2xvbmUgdXNlZnVsIHRvIGtlZXAgaGlzdG9yeSwgYnV0 Ci0gICAgICA7OyBzaG91bGQgbm90IGNsb25lIGZyb20gbm9uLWV3dyBidWZmZXIKLSAgICAgICh3 aXRoLWN1cnJlbnQtYnVmZmVyCi0gICAgICAgICAgKGlmIChlcSBtYWpvci1tb2RlICdld3ctbW9k ZSkgKGNsb25lLWJ1ZmZlcikKLSAgICAgICAgICAgIChnZW5lcmF0ZS1uZXctYnVmZmVyICIqZXd3 KiIpKQotICAgICAgICAodW5sZXNzIChlcXVhbCB1cmwgKGV3dy1jdXJyZW50LXVybCkpCi0gICAg ICAgICAgKGV3dy1tb2RlKQotICAgICAgICAgIChld3cgKGlmIChjb25zcCB1cmwpIChjYXIgdXJs KSB1cmwpKSkpKSkpCisoZGVmdW4gZXd3LS1vcGVuLXVybC1pbi1uZXctYnVmZmVyICh1cmwpCisg ICJPcGVuIHRoZSBVUkwgaW4gYSBuZXcgRVdXIGJ1ZmZlci4iCisgIDs7IGNsb25lIHVzZWZ1bCB0 byBrZWVwIGhpc3RvcnksIGJ1dAorICA7OyBzaG91bGQgbm90IGNsb25lIGZyb20gbm9uLWV3dyBi dWZmZXIKKyAgKHdpdGgtY3VycmVudC1idWZmZXIKKyAgICAgIChpZiAoZXEgbWFqb3ItbW9kZSAn ZXd3LW1vZGUpIChjbG9uZS1idWZmZXIpCisgICAgICAgIChnZW5lcmF0ZS1uZXctYnVmZmVyICIq ZXd3KiIpKQorICAgICh1bmxlc3MgKGVxdWFsIHVybCAoZXd3LWN1cnJlbnQtdXJsKSkKKyAgICAg IChld3ctbW9kZSkKKyAgICAgIChld3cgKGlmIChjb25zcCB1cmwpIChjYXIgdXJsKSB1cmwpKSkp KQorCisoZGVmdW4gZXd3LW9wZW4taW4tbmV3LWJ1ZmZlciAoJm9wdGlvbmFsIG5vLXNlbGVjdCB1 cmwpCisgICJGZXRjaCBVUkwgaW4gYSBuZXcgRVdXIGJ1ZmZlci4KKworSWYgdGhlIE5PLVNFTEVD VCBpcyBub3QgYG5pbCcsIHRoZSBmb3JjdXMgd2lsbCBzdGF5IG9uIGN1cnJlbnQgYnVmZmVyLgor CitJZiB0aGUgVVJMIGlzIGBuaWwnLCBpdCB3aWxsIHRyeSBgZXd3LXN1Z2dlc3RlZC11cmlzJyB1 bmRlciBjdXJyZW50IGN1cnNvci4iCisgIChpbnRlcmFjdGl2ZSAiUCIpCisgIChpZi1sZXQgKCh1 cmwgKG9yIHVybCAoZXd3LXN1Z2dlc3RlZC11cmlzKSkpKQorICAgICAgKGlmIChvciAoZXEgZXd3 LWJyb3dzZS11cmwtbmV3LXdpbmRvdy1pcy10YWIgdCkKKyAgICAgICAgICAgICAgKGFuZCAoZXEg ZXd3LWJyb3dzZS11cmwtbmV3LXdpbmRvdy1pcy10YWIgJ3RhYi1iYXIpCisgICAgICAgICAgICAg ICAgICAgdGFiLWJhci1tb2RlKSkKKyAgICAgICAgICAobGV0ICgodGFiLWJhci1uZXctdGFiLWNo b2ljZSB0KSkKKyAgICAgICAgICAgICh0YWItbmV3KQorICAgICAgICAgICAgKGV3dy0tb3Blbi11 cmwtaW4tbmV3LWJ1ZmZlciB1cmwpCisgICAgICAgICAgICAod2hlbiBuby1zZWxlY3QKKyAgICAg ICAgICAgICAgKHRhYi1iYXItc3dpdGNoLXRvLXByZXYtdGFiKSkpCisgICAgICAgIChpZiBuby1z ZWxlY3QKKyAgICAgICAgICAgIChzYXZlLXdpbmRvdy1leGN1cnNpb24gKGV3dy0tb3Blbi11cmwt aW4tbmV3LWJ1ZmZlciB1cmwpKQorICAgICAgICAgIChld3ctLW9wZW4tdXJsLWluLW5ldy1idWZm ZXIgdXJsKSkpCisgICAgKHVzZXItZXJyb3IgIk5vIGxpbmsgYXQgcG9pbnQiKSkpCiAKIChkZWZ1 biBld3ctaHRtbC1wIChjb250ZW50LXR5cGUpCiAgICJSZXR1cm4gbm9uLW5pbCBpZiBDT05URU5U LVRZUEUgZGVzaWduYXRlcyBhbiBIVE1MIGNvbnRlbnQgdHlwZS4KLS0gCjIuMjAuNQoK --00000000000098c4ed0603372eeb-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 04:49:59 2023 Received: (at 65346-done) by debbugs.gnu.org; 20 Aug 2023 08:49:59 +0000 Received: from localhost ([127.0.0.1]:53082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXe8E-0004ju-SD for submit@debbugs.gnu.org; Sun, 20 Aug 2023 04:49:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXe8C-0004je-Nn for 65346-done@debbugs.gnu.org; Sun, 20 Aug 2023 04:49:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXe85-0007S4-TX; Sun, 20 Aug 2023 04:49:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FIfjAS6R3ttl8U5X93AGO+4/9E54+00X4VhYzL4MUbo=; b=A2Bmdg0Kzm9ec5Hh3wCv 18OIYZ9CaAmsAB1kGn38TG4J5caFc4cTmdqbFVsvSATsk8le6y/rLAkoiwRyywvNY6fQTheeENNP2 L8nu1eUxPAF8AumSIykjoHbTegHBHvTHKEJNkRRcN9Sks8DD28+TFONlhgLoALZzFKvf0CjIxPRFA qfiQNlH6cSARP3gjsGMODT5zjrekhuF7y0CWvytmtZIDmlBtpC6CeMWdrRJQAkrIgnIKdYGRPiws4 /HbdKLSeGUMtxBjiRQh3VZbk/2gL4yzxbLUPaFUShRutA8Rk9lbogge+cMqSKmf2OENT2HT4cfYXh pDbmD09FnPnWbQ==; Date: Sun, 20 Aug 2023 11:50:04 +0300 Message-Id: <83v8daw11f.fsf@gnu.org> From: Eli Zaretskii To: Lin Sun In-Reply-To: (message from Lin Sun on Fri, 18 Aug 2023 19:03:08 +0000) Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> <83sf8g523j.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65346-done Cc: 65346-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lin Sun > Date: Fri, 18 Aug 2023 19:03:08 +0000 > Cc: 65346@debbugs.gnu.org > > On Fri, Aug 18, 2023 at 5:52 AM Eli Zaretskii wrote: > > This changes the API of a public function in incompatible ways, which > > we try very hard not to do. Instead, the signature or > > eww-open-in-new-buffer should be like this: > > > > (defun eww-open-in-new-buffer (&optional no-select) > > > > and the new NO-SELECT argument should be set non-nil by C-u. > > > > > + (user-error "No avaliable link"))) > > > > This also changes the text of the error message in this case. Was > > that really necessary? The original text was more accurate, I think. > > > > Also, this new feature needs a NEWS entry and a suitable addition to > > the EWW manual. > > The attached patch included changes for the function, error message, > NEWS and EWW manual. > Please help review it. Thanks, installed on master, and closing the bug. Please in the future include a more detailed log of the changes in the commit log message, and please follow our conventions for that as described in CONTRIBUTE. I did it for you this time, but it required quite a lot of manual work. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 10:29:58 2023 Received: (at 65346-done) by debbugs.gnu.org; 20 Aug 2023 14:29:58 +0000 Received: from localhost ([127.0.0.1]:54584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXjRG-000067-1y for submit@debbugs.gnu.org; Sun, 20 Aug 2023 10:29:58 -0400 Received: from sonic307-9.consmr.mail.ne1.yahoo.com ([66.163.190.32]:36489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXjRD-00005g-T3 for 65346-done@debbugs.gnu.org; Sun, 20 Aug 2023 10:29:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692541788; bh=yqthkqcIm7PKU8WMwRAL+oRJQpRK8XheuqA5Jq+O6bY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From:Subject:Reply-To; b=PGvlRpbo4dixgvyedIzYVcQf1kyOdDw2/UgaNeprUypoQiTXGD7JISwU3ZLt6fJZvLI4oldtQUhSYT9HlO3VRdLBawFIC94/+8a5XnLz+t1tpJLaMXmcZuph941rbW7pW4okNf/ifs09zjwZm+CGxy5frHTst1rKEvf/UixpXsBEbaZiT3zngeYNE7FUPDu6zMQSZU+HPTOr+YGSbrbpgxNQfd1yBd8nrjuX3Fi0PgMLvxF/+flLuOME1BxAdn9mpOL6Rkv+SHB8MXBiFo1bs25yad8zrWNltqxq4FY9yz7pWU+UsYKIxDYYv4Fb/VhjtagqACuDymn8AhjY6BvNhQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692541788; bh=AVy2aipfEWMHogbIgRKYa5rYVBZLehViihY3urvMq+M=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=s41LE/ZoQ7ewlaFQ5kOZfqUmAcNRdaPZiQdv0ltLevyj/+5qI5qq+7qL6mrtBoz+FBNcv74O0KiUc0HWloo8bW0iXF4vTtHOIe9jw6qOPclAuH7foATpgcjCuDVgTcjO/tokCU3lLP2uoTSNY0cJilmP6ha9CeKoyRp1c4Dfe1iUKIF+uQBXeNLM4ZzF2XGj83Y5P/IlcS9YNY2zZs2kfIaTKuTGUC0anDzzad3wvEym9+UpK3z8C27TiRK+2+ynl/KQ5M0IDlUNS58e+kkbVGd/P0mG0GbYigLio1rsW0OxNBO6/xghBF6la+9SOHKHTk+h/6FGTaIv7uBHbRRWbg== X-YMail-OSG: UZU.fwkVM1kh4uoH9dko969XpIY6mN_xyB4yFdtAdRUTcV21_bQqHgrUk25mdXQ 9qn6gRyqH6jU8y9x8SkhUFPbFs8_dV.P3Fuibt7aHq8DC8fajkC37jeynLl_KgyYQMRdrnbCnkn8 wMk7ppDY0N_Jyrrf5OTexzhnsjW6a0ed1H9kUWw.mFkS7uRv_kJCWjEonlkEYzcllKK9kMNn2uge gWysky3A5rkx5MRpTKagt6BTYA7xrzWTy7E2VMtwgfhitQIV4hIc0WehHOlC.0V9ee0WA0Defce9 y6sBa2Nmcqq5htdDYrRVn3_qwsGNWsHsMQrITejfMeRDAQJkkm.cqEdWufzm5584QXWSsbV8QF6r hXhkOeLZVboJyaDGiW2waBM_cgxliF0B4eUraJuXq51tdoZsL8nVqz5_BANYpBBdZvYXF5NklXwK m9wD8HxidFFHyeD57E5A0haTaBT9_DXUQahDOp8ngkvdpqpG_u7GtPprYWhD_lVM8yWhsFuXVc2y P1QyLpgmd88PSWrNMkI1JHh4EEj2dlQHBKmnAGZqkFC.sLP1p3xsJ9zJ3YfvImjxvcko4p8giyTu 1DG2qX8lbFiUdRSrRmaYEVGFUPEKfWrAr4I5CO6Dv_c3fxveTO6jPrxmEc0uYjYDszGEXtO7wlit m45ztrpZwK5dACe0Nv_aIN.j1bGwlPkLs_6T3uP30Hdklt3wtGZmZggI_QxgQzBFbPoQP9BETnTG pxqMNO7leM_uP7KMh.PEqiyLLSUNLvOxoiU.efTh6olIKAqcnafS3mAZ.Ocmi_6dDYeL70FpZl3O 1Snr9x2gbDNwFVt8m_afpZzn5cK4fOKACOFP6vPxt6eRVE1HBqcvCb4WzDQcEYJCIpLKUd_5RqfK 4nu8d2M27wv3zjcLU5_f6p1ip6Tiu3mFZeNqkqg23MN70q1c7mtWcLvlpv8eIv9VBG9XH22_qh_3 EePNkaoEE1zFcpcuGoCZgLcyTuIiellbBd9W4_.K5Yup6X.xzZhxgfVXqmRpvNHuvT0OShq8oTSN g3B1LIVvlmxgVMrktMZRPvLEyPN_0cpyM3zQ9mqeNnBU6Ri9zG8cIiR675OlEZDBPC8uzKMz7sk1 EKJzqbVKFJcalwz5WC.icDjJQyN69o1j4phjrQWph4MxL3l3.I4CUFuq2XUbDeoe5RHu71Q2ZfAY kQPBZiRXGJl9IELlXtlNR9SdaIRvLtdTpnFd5_PUQJI8F6PE_JXt.3iZ5QSkczuX5bovdt1Xt9gA LupRYQY6OzrrSMgpW5MsXb4babUm68jMwv72GATGTRXa9wguVJQIgPCSzTVHgoE5Kpx9hGOEPBCk mf0IWzlzd8zydnEbvEG.qHtQ.35uUTwSEfhsIsfmmleSMNMbTt_dDXjHbQIu.GOyBFuIO5DXJgcj AUDw0KaLDKumuJkgtMnkYOJg4AinBLPdHuITHE0H1yYJ0_lCpM5zOK3.ylmVEWPMEqOrf5rRoHgp XvDebzSfltk5LgNJHsCJQL1OFLZyXlwZJhz3eeLva7PLtuud81ZNshtprrKdLLAaAIy1k8Bsvf7p n9s3e8oXTnI9bY0j5lUXswCeMiVLCrkCZfjYdvaiSa2SVKDjCWmsDV3Jee0zk9HiOVegMcC1S3mS kLelDqpk_HaGeEI5fQ3efOCs3MVVct8pKfITWjO6b0at55QfczfJrYwq_CSTLFbWtmnIk3DyXxPv 5I7WvI3X46ZRQqHe7nVUAvpcmfV9wC.OJn461pXyrlSMCd5YCNUvqyIHVF7P5lej7749g7B5b5yu PtDhKKF7GOGMTQuPkoyUiDs.IElMPDCY88HdtDglA2N2uf9wKP2eNw_ycHC2exFwuutFa3Waldhp aLEaZW8LmgevjNojcKPluuQYd9yUPr2ubd9pqMSo2n8AuB1zbq7T_IuhXsXhdZkWhQmY3nzud9L_ q_xK.TtFA5ZeVDafOTTdJbHcJeOYTXoXX0UVQ.u_Q2mr00dl6vSzEK5LUm.fKBoB6UBOmuJj0u.L s46cmNyy4cGQfsf.X7k3Fu6eazC.vSbfRXuiy2bae4PwulLGfjCkQPJ9xW4kp0eqQcEW5X6z9eT3 ge6p1svMJbDRq_6IiQtvs41.RLN6a7GNZiKzdbuKfMQ1dynhUcFGH_BejFofvCm.HPK2LP9jiuiI rQCI1rZVL8mysgZUHvnIzI07pyyeKzcgWmLXYwYcO159_DMinaavJNyhpKlbD5DultLNipfBNE8t zUTvKSqZbZ.2_8MvqRIEknN6mluiDq4GKtUPr8qnfaoIEOX2c_q51idGo9JaRFgynXPflA1KE X-Sonic-MF: X-Sonic-ID: 25e01ee8-a268-4af5-a5d6-4fd55a3bbe66 Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 20 Aug 2023 14:29:48 +0000 Received: by hermes--production-ir2-5cc57b9c45-6bc74 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a497b2a8287855595e40b7fb6538ddb3; Sun, 20 Aug 2023 14:29:44 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-99c1d03e124so309342966b.2 for <65346-done@debbugs.gnu.org>; Sun, 20 Aug 2023 07:29:44 -0700 (PDT) X-Gm-Message-State: AOJu0YzGo+fixu9YGN6ZdOpmwq6K6EDlbFxJ+bXAgxHaWFbMwwBfkhHw OMbVQdufhupbi7Hx/ERUIpN9wu04OwVX72XRyc8= X-Google-Smtp-Source: AGHT+IEOSzUE31Uem7fhV7ZeL3IqKcHiY+G2TpbfL2vLrXNHhMwXbnbVjQrA8oct4nLPr1L8/kdqFS2rNSZdRrwevAw= X-Received: by 2002:a17:906:1013:b0:99e:85d:19a2 with SMTP id 19-20020a170906101300b0099e085d19a2mr3369015ejm.16.1692541783506; Sun, 20 Aug 2023 07:29:43 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> <83sf8g523j.fsf@gnu.org> <83v8daw11f.fsf@gnu.org> In-Reply-To: <83v8daw11f.fsf@gnu.org> From: Lin Sun Date: Sun, 20 Aug 2023 14:29:31 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 441 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 65346-done Cc: 65346-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Eli, On Sun, Aug 20, 2023 at 8:49=E2=80=AFAM Eli Zaretskii wrote: > > Thanks, installed on master, and closing the bug. > > Please in the future include a more detailed log of the changes in the > commit log message, and please follow our conventions for that as > described in CONTRIBUTE. I did it for you this time, but it required > quite a lot of manual work. Thank you so much, really appreciate it ! Best Regards From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 13:27:51 2023 Received: (at 65346) by debbugs.gnu.org; 20 Aug 2023 17:27:51 +0000 Received: from localhost ([127.0.0.1]:54760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXmDO-0004uR-OQ for submit@debbugs.gnu.org; Sun, 20 Aug 2023 13:27:51 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:37755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXmDM-0004tr-B9 for 65346@debbugs.gnu.org; Sun, 20 Aug 2023 13:27:48 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3402D20002; Sun, 20 Aug 2023 17:27:39 +0000 (UTC) From: Juri Linkov To: Lin Sun Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' In-Reply-To: (Lin Sun via's message of "Fri, 18 Aug 2023 19:03:08 +0000") Organization: LINKOV.NET References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> <83sf8g523j.fsf@gnu.org> Date: Sun, 20 Aug 2023 19:44:03 +0300 Message-ID: <861qfyovm8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 65346 Cc: Eli Zaretskii , 65346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > +(defun eww-open-in-new-buffer (&optional no-select url) > + "Fetch URL in a new EWW buffer. > + > +If the NO-SELECT is not `nil', the forcus will stay on current buffer. > + > +If the URL is `nil', it will try `eww-suggested-uris' under current cursor." > + (interactive "P") > + (if-let ((url (or url (eww-suggested-uris)))) > + (if (or (eq eww-browse-url-new-window-is-tab t) > + (and (eq eww-browse-url-new-window-is-tab 'tab-bar) > + tab-bar-mode)) > + (let ((tab-bar-new-tab-choice t)) > + (tab-new) > + (eww--open-url-in-new-buffer url) > + (when no-select > + (tab-bar-switch-to-prev-tab))) tab-bar-switch-to-prev-tab is a wrong function, please use tab-bar-switch-to-recent-tab instead. Also please add a new command to open a tab in background. Then new command could be bound to the standard RET modifier used in all web browsers to open a tab in background. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 12:40:57 2023 Received: (at 65346) by debbugs.gnu.org; 27 Aug 2023 16:40:57 +0000 Received: from localhost ([127.0.0.1]:46109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaIoq-0008VQ-LI for submit@debbugs.gnu.org; Sun, 27 Aug 2023 12:40:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaIop-0008VC-1A for 65346@debbugs.gnu.org; Sun, 27 Aug 2023 12:40:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaIod-0003lQ-8d; Sun, 27 Aug 2023 12:40:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rD53TcmYHOVq98aHrvXcSndxVZRFkjxjqurguGljG3U=; b=RObCEOv5NtD5 1r94X0wh8E7xwfGusak0mglWFqV/Zbt6VbHouhJjimdA5C+dwBFHv0ITbfsVZq9n/HNSbycwghoGP OeG7IWBQQe2K+iY4oY5KUAr6lMgcQ9OEfxFI0bbLzu/cXUa8pWfpgla/tpiqQtlvLy4U2O1LCNPIw koNyzdUFJjSGfk1Boexe60+/zh11n48pu9OgDTpptP1Z3KxfDzk5D9u9nGcbQNa5RL3Z9uZKzA8pu 2hxik84tb5dxacwGvdBjdOpcFuZ13JYzaNHuKFoeL7PRq076iJfKf9QGDJiyoTbQeaJm/sQI0mUFh 4fCWarA81PLPLg/lo9OVEg==; Date: Sun, 27 Aug 2023 19:40:16 +0300 Message-Id: <837cpgjv67.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <861qfyovm8.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 20 Aug 2023 19:44:03 +0300) Subject: Re: bug#65346: 30.0.50; *lisp/net/eww.el: new function 'eww-open-in-new-buffer-background' References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> <83350i6rcy.fsf@gnu.org> <83sf8g523j.fsf@gnu.org> <861qfyovm8.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65346 Cc: sunlin7@yahoo.com, 65346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , 65346@debbugs.gnu.org > Date: Sun, 20 Aug 2023 19:44:03 +0300 > > > +(defun eww-open-in-new-buffer (&optional no-select url) > > + "Fetch URL in a new EWW buffer. > > + > > +If the NO-SELECT is not `nil', the forcus will stay on current buffer. > > + > > +If the URL is `nil', it will try `eww-suggested-uris' under current cursor." > > + (interactive "P") > > + (if-let ((url (or url (eww-suggested-uris)))) > > + (if (or (eq eww-browse-url-new-window-is-tab t) > > + (and (eq eww-browse-url-new-window-is-tab 'tab-bar) > > + tab-bar-mode)) > > + (let ((tab-bar-new-tab-choice t)) > > + (tab-new) > > + (eww--open-url-in-new-buffer url) > > + (when no-select > > + (tab-bar-switch-to-prev-tab))) > > tab-bar-switch-to-prev-tab is a wrong function, please use > tab-bar-switch-to-recent-tab instead. Thanks, done. > Also please add a new command to open a tab in background. > Then new command could be bound to the standard RET modifier > used in all web browsers to open a tab in background. I didn't do that; patches welcome. From unknown Sat Jun 21 12:21:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 25 Sep 2023 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator