GNU bug report logs - #65336
[PATCH 0/2] Update looking-glass-client to B6 and restyle package

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65336: closed ([PATCH 0/2] Update looking-glass-client to B6
 and restyle package)
Date: Tue, 29 Aug 2023 13:06:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 29 Aug 2023 14:05:06 +0100
with message-id <875y4ygfrr.fsf <at> cbaines.net>
and subject line Re: [bug#65336] [PATCH 0/2] Update looking-glass-client to B6 and restyle package
has caused the debbugs.gnu.org bug report #65336,
regarding [PATCH 0/2] Update looking-glass-client to B6 and restyle package
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65336: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65336
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: guix-patches <at> gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 0/2] Update looking-glass-client to B6 and restyle package
Date: Wed, 16 Aug 2023 13:15:49 +0400

Hello Guix,

This series updates and restyles looking-glass-client, and also restores a
configuration parameter that was dropped in the previous update patch. Some
notes for posterity below.

The package builds with "-march=native" GCC parameter by default, which
makes it incompatible with CPUs older than the build machine and causes
crashes with "terminated by signal SIGILL (Illegal instruction)" and perhaps
others. We build it with the minimum supported CPU architecture to fix that.
This also helps with package reproducibility.

Thanks,

Ahmad Draidi (2):
  gnu: looking-glass-client: Update to B6.
  gnu: looking-glass-client: Update package style.

 gnu/packages/virtualization.scm | 146 ++++++++++++++++----------------
 1 file changed, 73 insertions(+), 73 deletions(-)


base-commit: 880ada0bdb9e694573ec42200d48658b27744b9b
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ahmad Draidi <a.r.draidi <at> redscript.org>
Cc: 65336-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#65336] [PATCH 0/2] Update looking-glass-client to B6 and
 restyle package
Date: Tue, 29 Aug 2023 14:05:06 +0100

[Message part 4 (text/plain, inline)]

Ahmad Draidi via Guix-patches via <guix-patches <at> gnu.org> writes:

> This series updates and restyles looking-glass-client, and also restores a
> configuration parameter that was dropped in the previous update patch. Some
> notes for posterity below.
>
> The package builds with "-march=native" GCC parameter by default, which
> makes it incompatible with CPUs older than the build machine and causes
> crashes with "terminated by signal SIGILL (Illegal instruction)" and perhaps
> others. We build it with the minimum supported CPU architecture to fix that.
> This also helps with package reproducibility.
>
> Thanks,
>
> Ahmad Draidi (2):
>   gnu: looking-glass-client: Update to B6.
>   gnu: looking-glass-client: Update package style.
>
>  gnu/packages/virtualization.scm | 146 ++++++++++++++++----------------
>  1 file changed, 73 insertions(+), 73 deletions(-)

Thanks Ahmad, these changes look good to me. I've pushed to master as
02e32197a80e4fc323ffe0e519ad4e58f206fc5d.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.