GNU bug report logs - #65313
[PATCH 0/1] gnu: Add erlang-lfe.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65313: closed ([PATCH 0/1] gnu: Add erlang-lfe.)
Date: Thu, 07 Sep 2023 02:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 06 Sep 2023 22:32:45 -0400
with message-id <87pm2uogqa.fsf <at> gmail.com>
and subject line Re: [PATCH v2] * gnu/packages/erlang.scm (erlang-lfe): New variable.
has caused the debbugs.gnu.org bug report #65313,
regarding [PATCH 0/1] gnu: Add erlang-lfe.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65313: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65313
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tim Johann <t1m <at> phrogstar.de>
To: guix-patches <at> gnu.org
Cc: Tim Johann <t1m <at> phrogstar.de>
Subject: [PATCH 0/1] gnu: Add erlang-lfe.
Date: Tue, 15 Aug 2023 17:23:28 +0200

Please, find attached a package definition for Lisp Flavoured Erlang.

I am aware of the earlier attempt to package LFE by jgart [1] (since a few days), but I was already on track with everything, including the replacement of the 'check' phase, and did not take anything from that solution.

I guess, that jgart's problem was the same as I encountered:  while the binaries are built with a standard gnu Makefile, the tests use rebar3.  rebar3 would download the dependencies instead of reusing existing Guix packages.  My solution was 'inspired' by how the rebar3 build method handles dependencies.  The rebar3-build-system links the dependencies to a subdirectory _checkouts from which the later _build directory is copied and used for fetching all rebar3 plugins, overriding the download locations in rebar.config [2,3].  But with linking the dependencies, the file permissions stay read-only, and with rebar trying multiple times to copy to _build, the 'check' phase would fail with permission denied.  This is the reason for copying dependencies from the store, to be able to modify the permissions.

[1] https://issues.guix.gnu.org/60372
[2] https://blog.erlware.org/rebar3-features-part-6-_checkouts-2/
[3] http://rebar3.org/docs/configuration/dependencies/



Tim Johann (1):
  * gnu/packages/erlang.scm (erlang-lfe): New variable.

 gnu/packages/erlang.scm | 77 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)


base-commit: 2279e3e60479e91838db2d7261e86e91f9891650
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Tim Johann <t1m <at> phrogstar.de>
Cc: 65313-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] * gnu/packages/erlang.scm (erlang-lfe): New variable.
Date: Wed, 06 Sep 2023 22:32:45 -0400

Hi Tim,

Tim Johann <t1m <at> phrogstar.de> writes:

> ---
>  gnu/packages/erlang.scm | 72 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 72 insertions(+)

I've adjusted the commit message like so:

--8<---------------cut here---------------start------------->8---
    gnu: Add erlang-lfe.
    
    * gnu/packages/erlang.scm (erlang-lfe): New variable.
--8<---------------cut here---------------end--------------->8---

Made other small cosmetic changes such as moving the #:make-flags above
the #:phases, the inputs after the build arguments, added a copyright
line with your name, and installed it with commit 5ef28595e.

Thank you for your contribution!

-- 
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.