GNU bug report logs - #6531
patch for rst.el updated (patch format revised)

Previous Next

Full log

View this message in rfc822 format

From: Wei-Wei Guo <wwguocn <at> gmail.com>
To: Martin Blais <blais <at> furius.ca>
Cc: David Goodger <goodger <at> python.org>, Stefan Monnier <monnier <at> IRO.UMontreal.CA>, Stefan Merten <smerten <at> oekonux.de>, 6531 <at> debbugs.gnu.org
Subject: bug#6531: patch for rst.el updated (patch format revised)
Date: Fri, 13 Apr 2012 14:40:45 +0800

在 2012-04-12四的 23:13 -0400，Martin Blais写道：
> On Thu, Apr 12, 2012, at 16:30, Stefan Monnier wrote:
> > > The update including:
> >
> > > - Insert bullet list by 'M-Enter'.
> > > - Insert number list "#." by 'M-Enter' with any prefix.
> > > - Insert number list of a specific number of various styles by 'M-Enter" with a number prefix.
> > > - Insert directive by 'C-c C-d'.
> > > - Insert directive option by 'C-c C-o'.
> > > - Remove the dependency on a2r.el. Now all the patched codes are from mine.
> >
> > > Hope it's helpful.
> >
> > I'd like to hear the opinion of rst.el's maintainers as well.
> 
> Holy smoke, is this a patch from 2008? Major lag in the reviewers!
> Where is the link?
> Is this the one?
> http://debbugs.gnu.org/cgi-bin/bugreport.cgi?bug=1610
> 
> I had a very quick look at this patch--it looks fine to me (other than
> the overuse of mutable locals/setq).
> 
> About the features: I personally care little about bullet insertion
> functions, I find inserting them manually is good enough, but it
> doesn't hurt to have them there, and others might really like them, so
> I would merge it in. Thanks WeiWei! :-)
> 


It's a very old patch and Stefan Merten has a new version of rst.el.
Here is the link of the new rst.el which already merged part of the
patch. 

http://docutils.sourceforge.net/tools/editors/emacs/rst.el

Stefan's codes are much better than mine, so it better to merge the new
rst.el instead of my old patch. 

I sent a email to you with another two extensions of rst.el days ago,
which are rst-directive.el and rst-links.el. If you think those codes
are fine, they can be merged into the rst.el too. I recommend the
rst-directive.el, which I use in my daily work and saves me lots of
time. 

Hope my terrible coding style isn't taking you too much trouble. 


Best wishes,
Wei-Wei

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.