From unknown Tue Jun 17 20:20:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65251 <65251@debbugs.gnu.org> To: bug#65251 <65251@debbugs.gnu.org> Subject: Status: 30.0.50; Duration in compilation buffer Reply-To: bug#65251 <65251@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:20:42 +0000 retitle 65251 30.0.50; Duration in compilation buffer reassign 65251 emacs submitter 65251 Helmut Eller severity 65251 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 14:31:07 2023 Received: (at submit) by debbugs.gnu.org; 12 Aug 2023 18:31:07 +0000 Received: from localhost ([127.0.0.1]:57436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUtOE-0004uR-VQ for submit@debbugs.gnu.org; Sat, 12 Aug 2023 14:31:07 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUtOC-0004tq-Uz for submit@debbugs.gnu.org; Sat, 12 Aug 2023 14:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUtO7-0005Jq-34 for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 14:30:59 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUtO4-0003YQ-6G for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 14:30:58 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-31969580797so670047f8f.3 for ; Sat, 12 Aug 2023 11:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691865053; x=1692469853; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=EfRwO0esaLFoyenGbMMD3419SY8zPDQHC1gJ3gHJo1E=; b=kaEupdgmtl0YRO08p79frwpefFLMe8nYnvKWY+KD4CALUX5j2B7apVTSCxPbqA96lR IBXMb2JozqYqBaiUzzLFOY6wsv/gfGc4bhRB8E6mDQrdoUk8WcBLDuoapMWxP2+TLCDX mNX4WG4rkJ/UUOmraR08fUfzp+4AZBcVNx9JdOXpPh76NRKJm7yqsEsnWIEMMAcg1Q4x nqvPMsVoH48ve+5zycXXRfcEQ1F3tWn1iIVleKvC+dlJx9aO/7pEvOiUOsg3k1PM4u+z hhENQl2ljnjK3Q0aelOJQq/tA1YsWoFBMtEHKUsdhfhUIBJY80ARWdi0W5rGK6DegPGX l9ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691865053; x=1692469853; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EfRwO0esaLFoyenGbMMD3419SY8zPDQHC1gJ3gHJo1E=; b=aNb4U6C4p4SWdfpY6oTXk21v/U/zWgm/GBivKSA6BTbsj5wHSwN6YCTVQl2JCqg+N0 7IIadjXQMG4gGtFD1Ugj6CfPv6E521edH5wnl1s5dazIy0yelAQSNppW7nubiYFPSlJL UmcA8zGofsd2RGg6uILptzB2xe0ImKikwwCIxlX9GJxhOSIy21mSvZksQS2f/u7v+Qwb QGK3JmxnXD0KVTJvAqa2bIxE0m4Du+PbD+CvEqv5y7Y1L5Zx5Whv7FQApRoHp9eDWruO PqmL02GCFpXzZjPvi6pFHeMo9yRTnOpmG7Cci2s/fFDS9gP5VUw75rQ0zrdCyaSSd/sd 5exQ== X-Gm-Message-State: AOJu0YxsCkGqo0Iv0d4BP/AmoSezHiHmGfxW0ZthmjuXMkeLd0l6XxI5 ZTt8E4DHZapFluxYPLn30ZsQhzLmirc= X-Google-Smtp-Source: AGHT+IEIVbljtVgT11dh4rvtWMCp/UkVHRUln9De3EFsP4EfZ8Z2yvOQnBZZY8ZO7+GFumDwcKfR0Q== X-Received: by 2002:a05:6000:1181:b0:319:6bbe:5af5 with SMTP id g1-20020a056000118100b003196bbe5af5mr1326204wrx.3.1691865053393; Sat, 12 Aug 2023 11:30:53 -0700 (PDT) Received: from caladan ([185.127.213.71]) by smtp.gmail.com with ESMTPSA id k7-20020adfe3c7000000b003176c6e87b1sm9211294wrm.81.2023.08.12.11.30.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Aug 2023 11:30:52 -0700 (PDT) From: Helmut Eller To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Duration in compilation buffer Date: Sat, 12 Aug 2023 20:30:51 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=eller.helmut@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain In the *compilation* buffer, we see timestamps when the compilation started and finished. It would be nice to also see how long the compilation command took. The attached patch does that. It looks like this: Compilation finished at Sat Aug 12 20:23:57, 2.52s Helmut --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-When-a-compilation-finishes-show-how-long-it-took.patch >From d6bdf293287a5f252de0cf2dd00cfeaff1c02f80 Mon Sep 17 00:00:00 2001 From: Helmut Eller Date: Sat, 12 Aug 2023 19:17:43 +0200 Subject: [PATCH] When a compilation finishes, show how long it took Insert the duration, not just the timestamp. * lisp/progmodes/compile.el (compilation--start-time): New variable. (compilation-start): Set it. (compilation-handle-exit): Use it to compute the duration and insert it in human readable form. --- lisp/progmodes/compile.el | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 6d151db8a83..276c9a5d3e1 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1862,6 +1862,9 @@ compilation-insert-annotation (apply #'insert args) (put-text-property start (point) 'compilation-annotation t))) +;; The time when the compilation started. +(defvar compilation--start-time nil) + ;;;###autoload (defun compilation-start (command &optional mode name-function highlight-regexp continue) @@ -1993,6 +1996,7 @@ compilation-start mode-name (substring (current-time-string) 0 19)) command "\n") + (setq-local compilation--start-time (current-time)) (setq thisdir default-directory)) (set-buffer-modified-p nil)) ;; Pop up the compilation buffer. @@ -2480,7 +2484,15 @@ compilation-handle-exit (message "%s" (cdr status))) (if (bolp) (forward-char -1)) - (compilation-insert-annotation " at " (substring (current-time-string) 0 19)) + (compilation-insert-annotation + " at " + (substring (current-time-string) 0 19) + ", " + (let* ((secs (float-time (time-since compilation--start-time)))) + (cond ((< secs 1) (format "%.0fms" (* secs 1000))) + ((< secs 10) (format "%.2fs" secs)) + ((< secs 60) (format "%.1fs" secs)) + (t (format-seconds "%hh%mm%z%ss" secs))))) (goto-char (point-max)) ;; Prevent that message from being recognized as a compilation error. (add-text-properties omax (point) -- 2.39.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 15:15:55 2023 Received: (at 65251) by debbugs.gnu.org; 16 Aug 2023 19:15:55 +0000 Received: from localhost ([127.0.0.1]:42114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWLzn-0008Ce-C5 for submit@debbugs.gnu.org; Wed, 16 Aug 2023 15:15:55 -0400 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:58708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWLzl-0008CP-Ed for 65251@debbugs.gnu.org; Wed, 16 Aug 2023 15:15:54 -0400 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b9f0b7af65so104580821fa.1 for <65251@debbugs.gnu.org>; Wed, 16 Aug 2023 12:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692213347; x=1692818147; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=0kvGmiSB3Nth6j3JM8czRuJkSo81VpJ7RCtBlhzvsAI=; b=XHEJ6LmXZvlkqHYLDYdtRlV3HMQ7FY79wM6HUewxFfIqh3CEZcsMnSNekj1+ILjhLF Sl60Ma/7ktoTZylBERKGnlpVxEd/ajZ2BMvKx4un2syL/lhQDy5+o3MYTUZ9VvU3wro9 sJWubH9AQqZ9eYf31/1oo61srgj/3oWCekiqSjdQV1T1eI4lfR1ClK2Ny//xVHWPQRjy kgnzMhlvQ2gRn0Wuqb17OZ5T34SyPwHf/vM34neiO0MXggjrWiNnciVnhiqxy7j2I5lW MtnvY3U3QELpCLi4kVkTET9oPZdvdFUcZkMlZD6VQTHOkjPbD+LiXBI2/ZTEch6iYvQF 4dIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692213347; x=1692818147; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0kvGmiSB3Nth6j3JM8czRuJkSo81VpJ7RCtBlhzvsAI=; b=SR0mNCFqcyK5+vNpSBzEhKNW3gRfz9qwCVycmWKLtHdzfcgpjDN67VMprg4p8Y60pd nnvN4qBtAxeithnBO5tuoZz4ylCgn+8muPYoD9YvREdusrHzpnkPzh7oIip1na1+2iln /7mSd85+rSPMyTD+LforjhuAM7AZjtQzJLSnhe85CKvVOm4BFtvaebc2JUPEcnvwyh4l rpqt4stF5qkGUsY8K6jeJjGH4lMU3G1O8bk810AIMzLzHpzXv1Ajk2TENRSKqoCStVxB iayN9uKSfwf+3t+oIo9rQmsnAKk78FFiOl71eXXTlSGa5IjwWGRgVcg1sD4BpcF+nmkQ d9VQ== X-Gm-Message-State: AOJu0YxHBNi/Znsjwniq8TiDIuszRlhy4dWjKrnqtemMg9K9KvdHeJ2g fdVNF2WwQlQ2o/LI2GyZxJ0= X-Google-Smtp-Source: AGHT+IFW1FTmclk6kmbKyoD9jSc6A67jo6gQ/aNR65Ez357f3nHOdDfhn0ShFu3Dq5uI5x7WxV6t0w== X-Received: by 2002:ac2:455b:0:b0:4fe:8b5:588a with SMTP id j27-20020ac2455b000000b004fe08b5588amr2338386lfm.57.1692213347236; Wed, 16 Aug 2023 12:15:47 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id b10-20020ac247ea000000b004fba6f38f87sm3043380lfp.24.2023.08.16.12.15.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2023 12:15:46 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#65251: 30.0.50; Duration in compilation buffer Message-Id: Date: Wed, 16 Aug 2023 21:15:45 +0200 To: eller.helmut@gmail.com X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65251 Cc: 65251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > In the *compilation* buffer, we see timestamps when the compilation > started and finished. It would be nice to also see how long the > compilation command took. Not a bad idea. =20 > +;; The time when the compilation started. > +(defvar compilation--start-time nil) What about using defvar-local? Then... > + (setq-local compilation--start-time (current-time)) can use plain setq. And if you use (float-time) here, then...=20 > + (let* ((secs (float-time (time-since compilation--start-time)))) ...this becomes a simple subtraction: (- (float-time) = compilation--start-time) > + (cond ((< secs 1) (format "%.0fms" (* secs 1000))) > + ((< secs 10) (format "%.2fs" secs)) > + ((< secs 60) (format "%.1fs" secs)) > + (t (format-seconds "%hh%mm%z%ss" secs))))) First of all, proper style is to separate the number and unit by a = space. The 'ms' case isn't very important -- 745 ms is no more readable than = 0.745 s, probably less so. The last case is also less than readable. Something like 3:45:58 would = be better. The reader would also like to know what this new time indication means. = What about ..., duration 34.5 s or ..., 34.5 s elapsed ? From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 18:37:03 2023 Received: (at 65251) by debbugs.gnu.org; 16 Aug 2023 22:37:03 +0000 Received: from localhost ([127.0.0.1]:42292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWP8R-00056X-5Z for submit@debbugs.gnu.org; Wed, 16 Aug 2023 18:37:03 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:54774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWP8O-000561-Ld for 65251@debbugs.gnu.org; Wed, 16 Aug 2023 18:37:02 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fe501e0b4cso66908515e9.1 for <65251@debbugs.gnu.org>; Wed, 16 Aug 2023 15:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692225415; x=1692830215; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SyyIz1Dj76J779gAwU9ESttTjcVfHugbhtsEqr4sjAg=; b=QG9ta9Ta9f/PSxB+RwawVvFYX7LJu9wZ4cL/XriuaEuioLWl327zrnhsL0R/NhC010 mkshL3U98iuQmi8FDpEoOtpfZHvem2S8uP3DskQsl06rkg8Rl+rA8G2o/DTDUWQlOhQQ 4Mpb5DV9lwMGigtGPXNoIiq0daaSSmhJty2yPtrc0kNNcirOHdeXQ2GVtf60Q8CQce0a OKRqE1ZqMz551CEM3hcCRnuubTcqqUYyGQuE46cHfS07vImYH/q6HIBr5E+YhQoFLXOL gTOk5a8FsTPqp2Eigc2WwsgoxSNORsSYyDR/S3wRPGkgG+gzZZFyLnVAEXqmcULF3s87 oBQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692225415; x=1692830215; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SyyIz1Dj76J779gAwU9ESttTjcVfHugbhtsEqr4sjAg=; b=Z+iz6Jh/BrKmaQ/xYjJDPnf/WFAWckZoPggrtYMTHlrKeNy4utWPEuJQM6n8/n1x+1 5GnRlG1KpiFB67w/WpI0XLvReAqYJEeo3Wp7U3gb7xyLOBB8sMCoZnkqOGLRF3FYGML9 MDjoRef1MeEgKAnn/dOEThzWX+uDIlwVDPraA35Jx6ZYnytLmyl2PZbWpzWK2wuXu/iq ldk+K0dWC0gEjV2KcMaDDdimo5fLZoIeV3i3VIM3w3THKsmTGcbD4IlS7T8uIKeXTSs9 9czDF1NnDTb8n/XW/Z5Z54UpztnwnklNeMPUirIV2aMhjZOhUyQUznvfhAwnA9gTjwvm TFBw== X-Gm-Message-State: AOJu0YwRXshTlyK0klgBzDn1YPpJhP/1/7dz+b870FhbwHlI9D9I7JF5 I9zdVYZiq3JNHjWcMId4vVcDJ323HxY= X-Google-Smtp-Source: AGHT+IEi5lSliTOIldtYum+xAt6rDxvgjVqbwse0G2RHfEVtrKIhP+bFpnSoeSdB0ECps5aMBgo/sA== X-Received: by 2002:a7b:cd94:0:b0:3fb:403d:90c5 with SMTP id y20-20020a7bcd94000000b003fb403d90c5mr2435638wmj.39.1692225414364; Wed, 16 Aug 2023 15:36:54 -0700 (PDT) Received: from caladan (dial-181023.pool.broadband44.net. [212.46.181.23]) by smtp.gmail.com with ESMTPSA id u5-20020a05600c210500b003fc02e8ea68sm780623wml.13.2023.08.16.15.36.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 15:36:53 -0700 (PDT) From: Helmut Eller To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#65251: 30.0.50; Duration in compilation buffer In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 16 Aug 2023 21:15:45 +0200") References: Date: Thu, 17 Aug 2023 00:36:52 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65251 Cc: 65251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Aug 16 2023, Mattias Engdeg=C3=A5rd wrote: >> +;; The time when the compilation started. >> +(defvar compilation--start-time nil) > > What about using defvar-local? Then... > >> + (setq-local compilation--start-time (current-time)) > > can use plain setq. Seems to be a matter of taste. I don't know what the Official Style Guide says about it. > And if you use (float-time) here, then...=20 > >> + (let* ((secs (float-time (time-since compilation--start-time)))) > > ...this becomes a simple subtraction: (- (float-time) compilation--start-= time) > But then we couldn't use bignums. And representing time values as a pair of bignums is cool. So cool that it was worth to require libgmp for Emacs. Oh wait, current-time still doesn't use bignums. But when it switches, it will be sooo cool. Anyway, ERT uses current-time for ert--stats-start-time and I followed that example. >> + (cond ((< secs 1) (format "%.0fms" (* secs 1000))) >> + ((< secs 10) (format "%.2fs" secs)) >> + ((< secs 60) (format "%.1fs" secs)) >> + (t (format-seconds "%hh%mm%z%ss" secs))))) > > First of all, proper style is to separate the number and unit by a space. > The 'ms' case isn't very important -- 745 ms is no more readable than > 0.745 s, probably less so. > The last case is also less than readable. Something like 3:45:58 would > be better. Seems to be a matter of taste. I copied the style used by Go's Duration type: https://pkg.go.dev/time#Duration.String > The reader would also like to know what this new time indication > means. What about > > ..., duration 34.5 s > > or > > ..., 34.5 s elapsed > > ? Seems to be a matter of taste. ERT prints it like Ran 10 tests, 10 results as expected, 0 unexpected (2023-08-17 00:29:48+020= 0, 0.813428 sec)=20 and nobody seems to complain. Helmut From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 01:33:21 2023 Received: (at 65251) by debbugs.gnu.org; 17 Aug 2023 05:33:21 +0000 Received: from localhost ([127.0.0.1]:42557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWVdJ-0002GU-5a for submit@debbugs.gnu.org; Thu, 17 Aug 2023 01:33:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWVdH-0002GF-1N for 65251@debbugs.gnu.org; Thu, 17 Aug 2023 01:33:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWVdB-0005R3-LN; Thu, 17 Aug 2023 01:33:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=AUKy5Wn5gmtpQdySvCq2XD8RVuAC1x5EBa7Fr0WGo3c=; b=YwkEWv9NMvxycU6Y3z0h F5QCSzETiuytiFqdHhIakSI3U2keJPpej9s64Csw8ANHIKAPmhsYDam5f1h8/YC2M3rCPGjo473nI 5+Oe8vMl0n+hhgn8B/2OF9fYe177K1YNihcaP61lHTRuaY9Wz8ypv+deNcyt6vPQCNogy+ovrVBw/ acW+LFMKBNPDVMmNB0/pDj30w76avQiayLsXrk9OZTEdSdTYomlwdjQzx0Sz4nzBIn252javiTdtY MapiaRQxmphXNmjCd7aITNz77a7CQbZHd1wI0I0UHhpVdnUoLNIoo7ISOIco3fQU7lD93SYFmgEPH mvXW7Ph6fpzGow==; Date: Thu, 17 Aug 2023 08:33:19 +0300 Message-Id: <83h6oy6xnk.fsf@gnu.org> From: Eli Zaretskii To: Helmut Eller In-Reply-To: (message from Helmut Eller on Thu, 17 Aug 2023 00:36:52 +0200) Subject: Re: bug#65251: 30.0.50; Duration in compilation buffer References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65251 Cc: mattias.engdegard@gmail.com, 65251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 65251@debbugs.gnu.org > From: Helmut Eller > Date: Thu, 17 Aug 2023 00:36:52 +0200 > > On Wed, Aug 16 2023, Mattias Engdegård wrote: > > >> +;; The time when the compilation started. > >> +(defvar compilation--start-time nil) > > > > What about using defvar-local? Then... > > > >> + (setq-local compilation--start-time (current-time)) > > > > can use plain setq. > > Seems to be a matter of taste. I don't know what the Official Style > Guide says about it. > > > And if you use (float-time) here, then... > > > >> + (let* ((secs (float-time (time-since compilation--start-time)))) > > > > ...this becomes a simple subtraction: (- (float-time) compilation--start-time) > > > > But then we couldn't use bignums. And representing time values as a > pair of bignums is cool. So cool that it was worth to require libgmp > for Emacs. Oh wait, current-time still doesn't use bignums. But when > it switches, it will be sooo cool. > > Anyway, ERT uses current-time for ert--stats-start-time and I followed > that example. > > >> + (cond ((< secs 1) (format "%.0fms" (* secs 1000))) > >> + ((< secs 10) (format "%.2fs" secs)) > >> + ((< secs 60) (format "%.1fs" secs)) > >> + (t (format-seconds "%hh%mm%z%ss" secs))))) > > > > First of all, proper style is to separate the number and unit by a space. > > The 'ms' case isn't very important -- 745 ms is no more readable than > > 0.745 s, probably less so. > > The last case is also less than readable. Something like 3:45:58 would > > be better. > > Seems to be a matter of taste. I copied the style used by Go's Duration > type: https://pkg.go.dev/time#Duration.String > > > The reader would also like to know what this new time indication > > means. What about > > > > ..., duration 34.5 s > > > > or > > > > ..., 34.5 s elapsed > > > > ? > > Seems to be a matter of taste. ERT prints it like > > Ran 10 tests, 10 results as expected, 0 unexpected (2023-08-17 00:29:48+0200, 0.813428 sec) > > and nobody seems to complain. It sounds like you reject all of Mattias's comments? That's somewhat unusual around here. Does that above mean that you insist on submitting your original patch with no further changes, or will you be sending an updated patch? From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 01:55:47 2023 Received: (at 65251) by debbugs.gnu.org; 17 Aug 2023 05:55:47 +0000 Received: from localhost ([127.0.0.1]:42604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWVz1-0002y2-5N for submit@debbugs.gnu.org; Thu, 17 Aug 2023 01:55:47 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:55344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWVyy-0002xo-Ra for 65251@debbugs.gnu.org; Thu, 17 Aug 2023 01:55:45 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fe24dd8898so69338465e9.2 for <65251@debbugs.gnu.org>; Wed, 16 Aug 2023 22:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692251739; x=1692856539; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=VfgjpMdKlUwX/CkkWjF8eu3v+h17/d2q4iCQlEFE0ms=; b=eL7mf+VEh103hY5LqXbn5UlomrvfI1DdnkyusbH28YR1aWYN+f2D9P8WoIsRQEETNL E64E6MnffVy63B9Npm/3MgP9gvgoi95SE8SXC3PTFdr96NrvkxEVGaxAhDN96XREyA/W RdmH6C0tWsUOziaZXaoyu6PraHpL3CwnShUQNvd5Gtg29YLVMZKXGQiHTlJQJmBi4MOm f8b4sLMsG/W5kjzOCigYRrm2B/XPxHCCRFe5z89tG9jv5R8gprYyiZl8/tLTCe2DWpzU e3f1wG4EwQztgzqKlQU8x3aKhkGCbtsiATgok48DKJlN3BuRpN1stjwFzANz/+43xEWX 1kIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692251739; x=1692856539; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VfgjpMdKlUwX/CkkWjF8eu3v+h17/d2q4iCQlEFE0ms=; b=kR7cPQykHr8wtbScCGyxgNZcvF4LqyvOvy8zJLLBKnV/mb6Fn+S7ar7wVOIYLjLLKh 4yyuNTWCTFES6F845x6NG+H45UsPUM766lEyNus1sZfguNTRM+27ewiFlIeIUnPBd50w dPm6JBeQ0IlaafBeKFB4MNN3ITvsctlaJ/hXtngW+KLVP+953/YTSt8ru17zb0gq5vBa 8O4bJW3upWNduBfAjxRL12lIGrjRvCG0I0F/G3jOnc21ld0jlXIn+cieYdDk8BFuw+0D hcv0Gq6FB73fA1OuRFlixBVaJ69Rkx6kqc9xUdWnNUhk4xJB7AWKmhPtATRNf2NkyMrY 2riw== X-Gm-Message-State: AOJu0YxT1OF1sMmM7ucrmO5dMCUoijmYMW4MuKhlZrpbGmPpxnAE4M0A dLWv4cVSQh4/rnoquvK886l1LEvitnI= X-Google-Smtp-Source: AGHT+IFJ7pjHXlS1M5VEalJBFoezVPoyT/9iik6k/3sgwam+fA5DZevtN00pL5Hf5Gi/pPwlttDCYg== X-Received: by 2002:a5d:6acb:0:b0:319:6c90:5274 with SMTP id u11-20020a5d6acb000000b003196c905274mr3003329wrw.30.1692251738921; Wed, 16 Aug 2023 22:55:38 -0700 (PDT) Received: from caladan (dial-181023.pool.broadband44.net. [212.46.181.23]) by smtp.gmail.com with ESMTPSA id a9-20020a5d5089000000b0031434c08bb7sm23741451wrt.105.2023.08.16.22.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 22:55:38 -0700 (PDT) From: Helmut Eller To: Eli Zaretskii Subject: Re: bug#65251: 30.0.50; Duration in compilation buffer In-Reply-To: <83h6oy6xnk.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Aug 2023 08:33:19 +0300") References: <83h6oy6xnk.fsf@gnu.org> Date: Thu, 17 Aug 2023 07:55:37 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65251 Cc: mattias.engdegard@gmail.com, 65251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Aug 17 2023, Eli Zaretskii wrote: > It sounds like you reject all of Mattias's comments? That's somewhat > unusual around here. Does that above mean that you insist on > submitting your original patch with no further changes, or will you be > sending an updated patch? I can submit an updated patch, if it is wanted. But it didn't sound like that me. I can also continue using compilation-finish-functions in my .emacs, if that's easier for you. Helmut From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 02:05:23 2023 Received: (at 65251) by debbugs.gnu.org; 17 Aug 2023 06:05:23 +0000 Received: from localhost ([127.0.0.1]:42646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWW8J-0003Eb-3I for submit@debbugs.gnu.org; Thu, 17 Aug 2023 02:05:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWW8H-0003EA-GP for 65251@debbugs.gnu.org; Thu, 17 Aug 2023 02:05:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWW8B-000385-4p; Thu, 17 Aug 2023 02:05:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dsQxc1deCM1B0suXC3J0w4WeYkbUn5bzFm3zBMhrJxo=; b=rPsZnRs3u8YL ZZcLvLiFBzCT3A81mDATaZ6JHNU/r9os/aCGyLz5R1ZWI/x6YY2gIhs48iuptdQDwUMyq3u9xh7v+ KKSOVfL6rK7fjxKgycwz+Q6T6Qot6NCL3OZXkrfog3Neq1wUs9WilAzRodJleOr+OrcTpjR2MWny7 hvmMFalCjDEANvXbIa4Q7ocfHqfjWTx5WvOl0tASS/Rlq+5XSjb1ZlKcMhAXVW/0vQXTmqJwsDasQ T+1uIx9z2/tH22XDuYZ2d3mwQpvDH/n1Nsnwb1ixkmB3oSeQYJnRGXGhETpuT2Vs6f5yeLuGlH77V tZ32OW0qxI9E4pY6oHoYqg==; Date: Thu, 17 Aug 2023 09:05:19 +0300 Message-Id: <83a5uq6w68.fsf@gnu.org> From: Eli Zaretskii To: Helmut Eller In-Reply-To: (message from Helmut Eller on Thu, 17 Aug 2023 07:55:37 +0200) Subject: Re: bug#65251: 30.0.50; Duration in compilation buffer References: <83h6oy6xnk.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65251 Cc: mattias.engdegard@gmail.com, 65251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Helmut Eller > Cc: mattias.engdegard@gmail.com, 65251@debbugs.gnu.org > Date: Thu, 17 Aug 2023 07:55:37 +0200 > > On Thu, Aug 17 2023, Eli Zaretskii wrote: > > > It sounds like you reject all of Mattias's comments? That's somewhat > > unusual around here. Does that above mean that you insist on > > submitting your original patch with no further changes, or will you be > > sending an updated patch? > > I can submit an updated patch, if it is wanted. But it didn't sound > like that me. I can also continue using compilation-finish-functions in > my .emacs, if that's easier for you. I intended to install this once there are no more review comments, as I think this could be a useful addition. I believe Mattias also thought the idea was a good one. So my preference is for you to post an updated patch, yes. TIA From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 14:48:32 2023 Received: (at 65251) by debbugs.gnu.org; 17 Aug 2023 18:48:32 +0000 Received: from localhost ([127.0.0.1]:45625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWi2q-00041U-8i for submit@debbugs.gnu.org; Thu, 17 Aug 2023 14:48:32 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:50431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWi2o-00040i-62 for 65251@debbugs.gnu.org; Thu, 17 Aug 2023 14:48:31 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3fe5c0e57d2so1642575e9.0 for <65251@debbugs.gnu.org>; Thu, 17 Aug 2023 11:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692298104; x=1692902904; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hEXC0lzBWa8MGAqZCmKMmDAxHe8EKcg2Qyjwygk+dNc=; b=JAhpunvo4zOPOdZPu9S2UF87c4ol806AzgTY0Gt4JSiopzZ2RukvdYrrI3AbCvDSWh Vj2n/q/iAnb4nTdA8TNb6AdB1PM5icAb2/QW34iy+crJ8ujcvGQZUYq64xuQT7cIB6gM Q8CqKavCyYuQF9l7k+xjcNPec8/fb5gFycnv8nv8oVeb9G/XNIVyUvjiMzSiwTsQ+FcQ EXSmsK96PAjgYgAYkUgNea/mXNU7ASDQbRJ7J/LoI+qLeTv2Yv6/q0sZKyWNHm/y0rEi X1R/nPM9fmhhuscJKmqhrNv8/50JhWBcx9dksS1k+pqU5Fw2vA1SoGZCcOXQceHANEcx 6dAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692298104; x=1692902904; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hEXC0lzBWa8MGAqZCmKMmDAxHe8EKcg2Qyjwygk+dNc=; b=PEdx7/QwYJjT2/lg3sWfthTk6AmRMuBsjbdxwaDkkXVUwZDtyEsBukREuhYURC7Qaf Lhs/2/yFYG4l/81w8ImAYvVdXc636jLJK+BnYRFIiNzuBnwuGc/uBT+cMtA6jqxNBPau orWwdFA6YcAuiCGSSy3ycBbHeqv9ngzqDsBX9SLSzektQRD3i8Au3SYXBPZ3rhn9vf8n 5D9HaKl19b2iyfyWRVRYrcBStI0jw28NsjTPsMM0ee6xZDidcucZGUUtEqwsG6+7QFv5 dWdn7noDHFFGBsb9GQj7jqvTSS7va0RnVGhTyX/O/SUtXL1TEN09yzkCumq4gZA1dCJk rMbw== X-Gm-Message-State: AOJu0Yxrqra/m4haP+02I1AVGTeB8maGOZlbfPZCAq+MnzhVgToN6ziC RXu6YXNggqBGXlrW1pdzV3b3AEzP3Lo= X-Google-Smtp-Source: AGHT+IGXWTMBFnO1RKs2Q9cobrYdrtW2JVSg6jMFon3JAA+DxmV/pRl1Hq2wTO0Lz2pZ/b5GDso/5g== X-Received: by 2002:a1c:7211:0:b0:3fc:e7d:ca57 with SMTP id n17-20020a1c7211000000b003fc0e7dca57mr475508wmc.2.1692298104030; Thu, 17 Aug 2023 11:48:24 -0700 (PDT) Received: from caladan (dial-181023.pool.broadband44.net. [212.46.181.23]) by smtp.gmail.com with ESMTPSA id f11-20020a7bcd0b000000b003fbbe41fd78sm383873wmj.10.2023.08.17.11.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 11:48:23 -0700 (PDT) From: Helmut Eller To: Eli Zaretskii Subject: Re: bug#65251: 30.0.50; Duration in compilation buffer In-Reply-To: <83a5uq6w68.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Aug 2023 09:05:19 +0300") References: <83h6oy6xnk.fsf@gnu.org> <83a5uq6w68.fsf@gnu.org> Date: Thu, 17 Aug 2023 20:48:22 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65251 Cc: mattias.engdegard@gmail.com, 65251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Thu, Aug 17 2023, Eli Zaretskii wrote: > I intended to install this once there are no more review comments, as > I think this could be a useful addition. I believe Mattias also > thought the idea was a good one. So my preference is for you to post > an updated patch, yes. Here it is: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-When-a-compilation-finishes-show-how-long-it-took.patch >From 3f41a75a61a08c1e2850bf3e3e4d1d2d137aeedd Mon Sep 17 00:00:00 2001 From: Helmut Eller Date: Thu, 17 Aug 2023 20:46:05 +0200 Subject: [PATCH] When a compilation finishes, show how long it took Insert the duration, not just the timestamp. * lisp/progmodes/compile.el (compilation--start-time): New variable. (compilation-start): Set it. (compilation-handle-exit): Use it to compute the duration and insert it in human readable form. --- lisp/progmodes/compile.el | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 6d151db8a83..a41fca7de1e 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1862,6 +1862,9 @@ compilation-insert-annotation (apply #'insert args) (put-text-property start (point) 'compilation-annotation t))) +;; The time when the compilation started as returned by `float-time'. +(defvar-local compilation--start-time nil) + ;;;###autoload (defun compilation-start (command &optional mode name-function highlight-regexp continue) @@ -1993,6 +1996,7 @@ compilation-start mode-name (substring (current-time-string) 0 19)) command "\n") + (setq compilation--start-time (float-time)) (setq thisdir default-directory)) (set-buffer-modified-p nil)) ;; Pop up the compilation buffer. @@ -2480,7 +2484,14 @@ compilation-handle-exit (message "%s" (cdr status))) (if (bolp) (forward-char -1)) - (compilation-insert-annotation " at " (substring (current-time-string) 0 19)) + (compilation-insert-annotation + " at " + (substring (current-time-string) 0 19) + ", duration " + (let* ((secs (- (float-time) compilation--start-time))) + (cond ((< secs 10) (format "%.2f s" secs)) + ((< secs 60) (format "%.1f s" secs)) + (t (format-seconds "%h:%m:%s" secs))))) (goto-char (point-max)) ;; Prevent that message from being recognized as a compilation error. (add-text-properties omax (point) -- 2.39.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 18 08:06:54 2023 Received: (at 65251) by debbugs.gnu.org; 18 Aug 2023 12:06:54 +0000 Received: from localhost ([127.0.0.1]:46263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWyFi-0003zz-BD for submit@debbugs.gnu.org; Fri, 18 Aug 2023 08:06:54 -0400 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:54699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWyFh-0003zF-0A for 65251@debbugs.gnu.org; Fri, 18 Aug 2023 08:06:53 -0400 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4fe48d0ab0fso1150631e87.1 for <65251@debbugs.gnu.org>; Fri, 18 Aug 2023 05:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692360406; x=1692965206; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=YD0mWGBxR6d8vEGvSPt1ZNIcmVSt5A5l3bfVX7TPTYo=; b=bq11E1lLAruiw/G5Q/FVi0oQeCiBwR9q/pBcH0sYkDBiyRb5Kg3jecO9Sk60heG+7J Bsxm9qbQP8us8rJIJ3uMrzRqao60JN3RpP8qxj/R0bZSGH7bQkMWbKMvG61lzW6U/iw2 GGZFMsd0vUvTBoSz8eO7GtV6PuvYURTH6fnHNvgS2aaDMMXV5W0OmIZ52rSxWE+5xPQ5 UUaNB8ppqTpv5QLAO/v3vqiUKmaDplH7ElTU1aNV6BVNi9RfMjnVbaFd8CtUF80eotZ0 0UArodKoufRLT0/V+6/+CHbO9yJJuRWE8MPdpEGsQfowmjqXzaA8eAezwh3t+sfKIUBX mGRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692360406; x=1692965206; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YD0mWGBxR6d8vEGvSPt1ZNIcmVSt5A5l3bfVX7TPTYo=; b=EUgRSIyaQO1xKW1wzBmGagFxeLtRxO0sNx0KYdaoduLK1KzCy7LphpPA0ByNJVLTxW iez9aiMZNoxfaYj8VY3PLRvzO/KelYREGDyWty4iVOeMxIwor3hO19RJoApPzgYkinQ9 VsKwe8Q2L/1wU50/1COmVZPAEvxTLv+PwgjbpBMyK3VWWcLik502noOWtQY8EDD3btcH StFXZZJd8Nah6Tm58eKtgivhpuiUUqqg3iLwcLydOyTW7/YlTu25ACuqo/fy/1r+zDQq PQjK6OaN80NemLIvU6M1zrp9/abb/DVr0vvPRoJAyEg7JaRJ+8ZR0XnYViVtY6EoS8JA ebMQ== X-Gm-Message-State: AOJu0YyMKxYO9iY4dF7wVc36UWOVIqthQ90YsQ4U3pqnUClLmblo9TcZ Xjf09JOBHBXcjC4xJBi/EUc= X-Google-Smtp-Source: AGHT+IELh9JCbtzcs/NrTIcxz1/KD9rT1pt+SRgVWCDkwlN0jRLusZtrhpMijW+5PU62elOgNetJFQ== X-Received: by 2002:ac2:5b0c:0:b0:4f7:6775:2a66 with SMTP id v12-20020ac25b0c000000b004f767752a66mr1424638lfn.53.1692360406051; Fri, 18 Aug 2023 05:06:46 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id p28-20020ac246dc000000b004ff9ea1ad91sm305677lfo.216.2023.08.18.05.06.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Aug 2023 05:06:45 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#65251: 30.0.50; Duration in compilation buffer From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Fri, 18 Aug 2023 14:06:44 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8C9660DE-04DD-4D51-AA72-F8950ECD3159@gmail.com> References: <83h6oy6xnk.fsf@gnu.org> <83a5uq6w68.fsf@gnu.org> To: Helmut Eller X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65251 Cc: Eli Zaretskii , 65251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 17 aug. 2023 kl. 20.48 skrev Helmut Eller : > Here it is: Thank you! Pushed to master with some very slight editing, under my own = name (but your credit) since you seemed reluctant about the changes -- = hope that is all right. (I think we prefer patches as attachments -- I had to edit it a bit to = apply, which wasn't any trouble since the patch was so short.) Further improvements are perfectly possible, but this is unquestionably = an improvement. Otherwise, if you aren't too unhappy about the resolution, the bug can = be closed. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 18 16:55:20 2023 Received: (at 65251) by debbugs.gnu.org; 18 Aug 2023 20:55:20 +0000 Received: from localhost ([127.0.0.1]:48906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qX6V6-0007Uz-AW for submit@debbugs.gnu.org; Fri, 18 Aug 2023 16:55:20 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:50459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qX6V4-0007Ui-GR for 65251@debbugs.gnu.org; Fri, 18 Aug 2023 16:55:18 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fe32016bc8so12438885e9.1 for <65251@debbugs.gnu.org>; Fri, 18 Aug 2023 13:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692392112; x=1692996912; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tcs2bLpPuhIj3z+hBZbG/Cygz6z0l8JF8a7DIG7/ius=; b=qvhSzyNgX+2bITJvAQPuCiTTzaafyhJoUrnbMd0v048m/wfvymVkjr+a29/5r85OYw IepXyJVHCucA79skdtxQY+w0OCm3g+AZias2TNCU5Z6lbaz/BVI4rNgrpBc6X52cZoeS GgnE7BwmxcbyiA30A9DDBMPhUGh7pGv028v9QX/+5gS3OS99vfbpMrSss4rOPG7N0m8w ByS7xmo8glPpJCgnLStvxKGvshkZ3PzO6NRC55sjmLviEZQzLV7yiL0sYVe6cICuT5qO U5k86sIj4TPWYivMck2T6RvWLjK6eaXqVp3m7cxaLZzK1SSmPaLV7w4h0uZYHO6FrE5x 4IwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692392112; x=1692996912; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tcs2bLpPuhIj3z+hBZbG/Cygz6z0l8JF8a7DIG7/ius=; b=etovRnC7xwPu6noWehhHborLT50ob7A/dUN73/MtNJptoNMfRBLLIBe0aJfw9t2D/D gLcKlrIwEI9GdD7Z2Y5zXsUx7Xz9WkPe43sg7M7Mholc+EGjtCuRcft81XUntyjocimB G30qoZL/9LKp6FAjBH8XrO5GdXWtrU6hbraz5ei6P9TVWStXTDE/IATmYxV9CGUzOtXF wsLJ8/DiQvfOYlwuKflZc5pKeR5KxIh7wgkrJjrUN3iMVLKjwaJ5fUs6nA48J4Lu55j4 xUS6F03SCotzzXL4r8WUY9RevwnddVsQf54zvjKV5SD2k5ZCTscfl3k9Ww/R2GNhZdI5 LY6Q== X-Gm-Message-State: AOJu0YzFjn8u2mphl5ay+XT6lsUbQ9tQsHsFSrQllAxkV3AwjXLIyHZg 2PkyLPcxYgKEiWYwsDXJoend7p+OTtw= X-Google-Smtp-Source: AGHT+IFUD0Ck8k7sWUlL5H83zvU9AaCXj698//kqNaes7eDex0r+ndEJT6RfUYyLPE3ZZu6wQO9aSQ== X-Received: by 2002:a05:600c:3791:b0:3fb:b890:128e with SMTP id o17-20020a05600c379100b003fbb890128emr230188wmr.33.1692392111712; Fri, 18 Aug 2023 13:55:11 -0700 (PDT) Received: from caladan (dial-181023.pool.broadband44.net. [212.46.181.23]) by smtp.gmail.com with ESMTPSA id z17-20020a7bc7d1000000b003fed630f560sm2459675wmk.36.2023.08.18.13.55.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 13:55:11 -0700 (PDT) From: Helmut Eller To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#65251: 30.0.50; Duration in compilation buffer In-Reply-To: <8C9660DE-04DD-4D51-AA72-F8950ECD3159@gmail.com> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 18 Aug 2023 14:06:44 +0200") References: <83h6oy6xnk.fsf@gnu.org> <83a5uq6w68.fsf@gnu.org> <8C9660DE-04DD-4D51-AA72-F8950ECD3159@gmail.com> Date: Fri, 18 Aug 2023 22:55:10 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65251 Cc: Eli Zaretskii , 65251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Aug 18 2023, Mattias Engdeg=C3=A5rd wrote: > Otherwise, if you aren't too unhappy about the resolution, the bug can > be closed. Yes, close it. Helmut From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 19 01:54:38 2023 Received: (at 65251-done) by debbugs.gnu.org; 19 Aug 2023 05:54:38 +0000 Received: from localhost ([127.0.0.1]:49237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXEuz-0000eV-WE for submit@debbugs.gnu.org; Sat, 19 Aug 2023 01:54:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXEuy-0000eH-96 for 65251-done@debbugs.gnu.org; Sat, 19 Aug 2023 01:54:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXEus-0003AT-3k; Sat, 19 Aug 2023 01:54:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Z0SQm0JWC1TDS4r+lKNvMGLw4SRHZ6a3PNp4JkNMUAs=; b=jWkQVC/0RIrvSYKEbZdL hFoz0peSuX3pJfoG74geJxYGFKPENvr1JWhFy4E6rNBxaV0TUMAxbLUPRLT0VkV2pOnF+LFyp7Zsl 77uJ3Oley7KO8G7vUM4MXZwC8+HqK8FyD/DIOeSAQByQINVL7i2KCsk4wvPWMC5E2zUf62XMnPZZK /fivBIvrS1Gr5/pi3b6Cq+fTYK7zxf6ZFdkYczvEo28cgRFOCRi5tLaSaqxx+GqkDpY6q0qCNCFu3 4mwO9qpKAkZI/9MxjRPlvzz2caDc6h79EjSX6jSKiTQBDWcDh+vq6MKJ7Sxfts4hxuCSHuhC2oN/z BsxHXWHUAl2xIg==; Date: Sat, 19 Aug 2023 08:54:40 +0300 Message-Id: <83il9b37bz.fsf@gnu.org> From: Eli Zaretskii To: Helmut Eller In-Reply-To: (message from Helmut Eller on Fri, 18 Aug 2023 22:55:10 +0200) Subject: Re: bug#65251: 30.0.50; Duration in compilation buffer References: <83h6oy6xnk.fsf@gnu.org> <83a5uq6w68.fsf@gnu.org> <8C9660DE-04DD-4D51-AA72-F8950ECD3159@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65251-done Cc: mattias.engdegard@gmail.com, 65251-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Helmut Eller > Cc: Eli Zaretskii , 65251@debbugs.gnu.org > Date: Fri, 18 Aug 2023 22:55:10 +0200 > > On Fri, Aug 18 2023, Mattias Engdegård wrote: > > > Otherwise, if you aren't too unhappy about the resolution, the bug can > > be closed. > > Yes, close it. Thanks, done. From unknown Tue Jun 17 20:20:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 16 Sep 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator