GNU bug report logs - #65245
Possible code removal in eshell/diff (em-unix.el)

Previous Next

Full log

Message #8 received at 65245 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: emacs <at> unbit.co.uk
Cc: 65245 <at> debbugs.gnu.org
Subject: Re: bug#65245: Possible code removal in eshell/diff (em-unix.el)
Date: Sun, 13 Aug 2023 15:18:29 +0200

close 65245 30.1
thanks

Richard Hopkins <emacs <at> unbit.co.uk> writes:

> I think the use of `compilation-finish-functions' and
> #'current-window-configuration can be removed from #'eshell/diff
> as it's no longer called and the intended functionality is achieved
> elsewhere.

I think your analysis is correct and it holds up in my testing.  I
have therefore removed that part on master along with associated
cleanups.

Thanks for the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.