GNU bug report logs - #65245
Possible code removal in eshell/diff (em-unix.el)

Previous Next

Full log

Message #22 received at 65245 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: emacs <at> unbit.co.uk, 65245 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#65245: Possible code removal in eshell/diff (em-unix.el)
Date: Sun, 13 Aug 2023 20:54:48 +0300

> Date: Sun, 13 Aug 2023 10:32:34 -0700
> Cc: emacs <at> unbit.co.uk, 65245 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> On 8/13/2023 9:49 AM, Stefan Kangas wrote:
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> > 
> >> It would have been prudent to wait for the Eshell maintainer
> > 
> > Thanks, I'll keep that in mind for next time.  Kudos to Jim for taking
> > on the work of maintaining eshell!
> 
> Thanks, this all looks right to me, though I haven't tested it out in 
> practice. For minor changes like this (especially for code that long 
> predates my involvement), I don't think there's any real harm in others 
> committing changes without first getting an ok from me. Still, it's 
> probably reasonable to be on the safe side and let me take a look first 
> (unless I'm nonresponsive for a while, of course).

Changes in any Emacs package that has an active maintainer should be
coordinated with that maintainer.  The only exceptions are obvious
fixes like typos, clear omissions, and other such stuff.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.