GNU bug report logs - #65245
Possible code removal in eshell/diff (em-unix.el)

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>, Jim Porter <jporterbugs <at> gmail.com>
Cc: emacs <at> unbit.co.uk, 65245 <at> debbugs.gnu.org
Subject: bug#65245: Possible code removal in eshell/diff (em-unix.el)
Date: Sun, 13 Aug 2023 16:33:30 +0300

> Cc: 65245 <at> debbugs.gnu.org
> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun, 13 Aug 2023 15:18:29 +0200
> 
> Richard Hopkins <emacs <at> unbit.co.uk> writes:
> 
> > I think the use of `compilation-finish-functions' and
> > #'current-window-configuration can be removed from #'eshell/diff
> > as it's no longer called and the intended functionality is achieved
> > elsewhere.
> 
> I think your analysis is correct and it holds up in my testing.  I
> have therefore removed that part on master along with associated
> cleanups.

It would have been prudent to wait for the Eshell maintainer to chime
in, before rushing with the removal.  The suggestion for removal was
posted just one day ago, and that is not long enough to assume the
maintainer is not available.

Jim, any comments on this matter?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.