From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 11 17:45:44 2023 Received: (at submit) by debbugs.gnu.org; 11 Aug 2023 21:45:44 +0000 Received: from localhost ([127.0.0.1]:48196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUZx1-0001db-L7 for submit@debbugs.gnu.org; Fri, 11 Aug 2023 17:45:44 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUZwx-0001co-2h for submit@debbugs.gnu.org; Fri, 11 Aug 2023 17:45:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUZwn-0003jP-Kz for guix-patches@gnu.org; Fri, 11 Aug 2023 17:45:29 -0400 Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUZwl-0003BK-92 for guix-patches@gnu.org; Fri, 11 Aug 2023 17:45:29 -0400 Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-40feecefa84so14564851cf.1 for ; Fri, 11 Aug 2023 14:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691790326; x=1692395126; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=jYKHJhBNVt/SeFScOAF2HJZnoHM1vBlhpzu2GS5Ywms=; b=O8/a3/C0754vJfJ+Z1eUjomTSYp/jSMLfPUcyTUo0hgyt4mFSb70DkOtcbafC8r6JQ EVtaS0A/Lv8vGKUJYFrhKKMEozaitYs10O4Os9ETJLbhKunQPcVoCEiQrnIjz7wxQ/eh DSpiCEYvtp3yKWE56yumcvcMhCizW2go2/Mxd27Rbd0DOL2pqx/o5fO/z+iTWbytm3B2 dbNqRxA2chXPpzijWekUj4grBKGkMhn8LOj9KFXUssewKlEfXrnaxhtnF7M9sXvUvrAQ 40JVqMahHscUTBlDa5g/kCle/qDHps61R6mNs4hQQmkqJTPpi4U/Fow7RpdhoOa+oR5d 1MXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691790326; x=1692395126; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jYKHJhBNVt/SeFScOAF2HJZnoHM1vBlhpzu2GS5Ywms=; b=IscB91XnKW5KuxExe2qszutZ09DBi46E0d9aO7L7KcqBTTDdKPWnIE0R18N2cFBYpx 3I3L+KvEFd2YvMBfZq/+gM0mWtHzALtHV3e1XaiQdHwgWE3Am/XU46bgs0/3Zuq5s6YZ i4HhVjEwF21XAIBlRPJICX7E3FQNQMs/ZwMzCsTCiIID+aNy/rqxS6nL8VFeBaXdx5JC U7vG1E9DyJpwNmuIkrUjkF2XNo1Lst+/CpPe12VZhGI4DSSRjm0rdIviaRdATLf4nGof 8OFCrYD+jRJr1dp0qHTNSG62JYV6n/Tvb8StSRuONLhx6W1MGUFg+xUfYWP6nskHojb1 mmtQ== X-Gm-Message-State: AOJu0YwiF2pDjmM78EK/JtGCDE4SPeN064lGAyLms9Ukuc2kjIhEX5u8 o2nhWFFNu6Mt67xjUeN8LQFPNbt4bALyXQ== X-Google-Smtp-Source: AGHT+IEXd4bRzeSU+TH7i5yiY3wpUzEyOsl0xR8kRhbBcQrAg0PoeQVJlpiZF7BAyMv0hUvuzgFR8Q== X-Received: by 2002:a05:622a:130f:b0:40a:6b19:654d with SMTP id v15-20020a05622a130f00b0040a6b19654dmr3785659qtk.67.1691790325773; Fri, 11 Aug 2023 14:45:25 -0700 (PDT) Received: from localhost.localdomain (dsl-205-236-230-92.b2b2c.ca. [205.236.230.92]) by smtp.gmail.com with ESMTPSA id i10-20020a37c20a000000b0076768dfe53esm1449320qkm.105.2023.08.11.14.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 14:45:24 -0700 (PDT) From: Maxim Cournoyer To: guix-patches@gnu.org, maxim.cournoyer@gmail.com Subject: [PATCH] refresh: Add --to-version option. Date: Fri, 11 Aug 2023 17:45:11 -0400 Message-ID: <7abba6f5c3c2cc32a0f21fa701e64fffe7d27861.1691790311.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::834; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x834.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * guix/scripts/refresh.scm (%options): Register 'to-version' long version. (update-specification->update-spec): Add a fallback-version argument. (options->update-specs): Honor to-version option. * tests/guix-refresh.sh: Test it. * doc/guix.texi (Invoking guix refresh): Document it. --- doc/guix.texi | 20 ++++++++++++++++++++ guix/scripts/refresh.scm | 31 +++++++++++++++++++++++-------- tests/guix-refresh.sh | 7 +++++++ 3 files changed, 50 insertions(+), 8 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 409ca2ad62..ade80dd72a 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -14529,6 +14529,26 @@ Invoking guix refresh @dots{} @end example +In some specific cases, you may have many packages specified via a +manifest or a module selection which should all be updated together; for +these cases, the @option{--to-version} option can be provided to have +them all refreshed to the same version, as shown in the examples below: + +@example +$ guix refresh qtbase qtdeclarative --to-version=6.5.2 +gnu/packages/qt.scm:1248:13: qtdeclarative would be upgraded from 6.3.2 to 6.5.2 +gnu/packages/qt.scm:584:2: qtbase would be upgraded from 6.3.2 to 6.5.2 +@end example + +@example +$ guix refresh --manifest=qt5-manifest.scm --to-version=5.15.10 +gnu/packages/qt.scm:1173:13: qtxmlpatterns would be upgraded from 5.15.8 to 5.15.10 +gnu/packages/qt.scm:1202:13: qtdeclarative would be upgraded from 5.15.8 to 5.15.10 +gnu/packages/qt.scm:1762:13: qtserialbus would be upgraded from 5.15.8 to 5.15.10 +gnu/packages/qt.scm:2070:13: qtquickcontrols2 would be upgraded from 5.15.8 to 5.15.10 +@dots{} +@end example + Sometimes the upstream name differs from the package name used in Guix, and @command{guix refresh} needs a little help. Most updaters honor the @code{upstream-name} property in package definitions, which can be used diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm index a9241aa20d..54ac7ceea3 100644 --- a/guix/scripts/refresh.scm +++ b/guix/scripts/refresh.scm @@ -10,6 +10,7 @@ ;;; Copyright © 2020 Simon Tournier ;;; Copyright © 2021 Sarah Morgensen ;;; Copyright © 2022 Hartmut Goebel +;;; Copyright © 2023 Maxim Cournoyer maxim.cournoyer@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -106,6 +107,9 @@ (define %options (option '(#\m "manifest") #t #f (lambda (opt name arg result) (alist-cons 'manifest arg result))) + (option '("to-version") #t #f + (lambda (opt name arg result) + (alist-cons 'to-version arg result))) (option '(#\e "expression") #t #f (lambda (opt name arg result) (alist-cons 'expression arg result))) @@ -164,6 +168,9 @@ (define (show-help) 'module:(gnu packages guile)'")) (display (G_ " -m, --manifest=FILE select all the packages from the manifest in FILE")) + (display (G_ " + --to-version=VERSION + update the package or packages to VERSION")) (display (G_ " -t, --type=UPDATER,... restrict to updates from the specified updaters (e.g., 'gnu')")) @@ -213,17 +220,20 @@ (define-record-type (define* (update-spec package #:optional version) (%update-spec package version)) -(define (update-specification->update-spec spec) +(define (update-specification->update-spec spec fallback-version) "Given SPEC, a package name like \"guile@2.0=2.0.8\", return a -record with two fields: the package to upgrade, and the target version." +record with two fields: the package to upgrade, and the target version. When +SPEC lacks a version, use FALLBACK-VERSION." (match (string-rindex spec #\=) - (#f (update-spec (specification->package spec) #f)) + (#f (update-spec (specification->package spec) fallback-version)) (idx (update-spec (specification->package (substring spec 0 idx)) (substring spec (1+ idx)))))) (define (options->update-specs opts) "Return the list of records requested by OPTS, honoring options like '--recursive'." + (define to-version (assoc-ref opts 'to-version)) + (define core-package? (let* ((input->package (match-lambda ((name (? package? package) _ ...) package) @@ -263,13 +273,18 @@ (define (options->update-specs opts) ;; Update specs explicitly passed as command-line arguments. (match (append-map (match-lambda (('argument . spec) - ;; Take either the specified version or the - ;; latest one. - (list (update-specification->update-spec spec))) + ;; Take either the specified version or the latest + ;; one. The version specified as part of a spec + ;; takes precedence, with the command-line specified + ;; --to-version used as a fallback. + (list (update-specification->update-spec spec + to-version))) (('expression . exp) - (list (update-spec (read/eval-package-expression exp)))) + (list (update-spec (read/eval-package-expression exp) + to-version))) (('manifest . manifest) - (map update-spec (packages-from-manifest manifest))) + (map (cut update-spec <> to-version) + (packages-from-manifest manifest))) (_ '())) opts) diff --git a/tests/guix-refresh.sh b/tests/guix-refresh.sh index 51d34c4b51..a2be93fce4 100644 --- a/tests/guix-refresh.sh +++ b/tests/guix-refresh.sh @@ -109,6 +109,13 @@ case "$(guix refresh -t test guile=2.0.0 2>&1)" in *"failed to find"*"2.0.0"*) true;; *) false;; esac + +guix refresh -t test guile --to-version=2.0.0 # XXX: should return non-zero? +case "$(guix refresh -t test guile --to-version=2.0.0 2>&1)" in + *"failed to find"*"2.0.0"*) true;; + *) false;; +esac + for spec in "guile=1.6.4" "guile@3=1.6.4" do guix refresh -t test "$spec" base-commit: 77251c5f5af193dcd031dffef744001cfc48f7e5 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 06:40:03 2023 Received: (at 65235) by debbugs.gnu.org; 15 Aug 2023 10:40:03 +0000 Received: from localhost ([127.0.0.1]:35040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVrT0-0007Qx-3f for submit@debbugs.gnu.org; Tue, 15 Aug 2023 06:40:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVrSx-0007QX-9n for 65235@debbugs.gnu.org; Tue, 15 Aug 2023 06:40:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVrSp-000275-NN; Tue, 15 Aug 2023 06:39:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=z+C6RVz3Gz4C6W8QSLuj7AySfLYltCRtSBt/TVVtlTM=; b=CAsIFTviYfPFMNSthoWb dfLiQN3XGTR1TUCYPQ+YbcLRwV7aQBegLQAWR3BcdVhLr87c2oGjwc9lgUT4TUFMbzouuj1R/lXYj M2sp5OrLUvqqDDlRZ7xuzcfjrrpLsCuJMWh6rVEhu8n2Lpai1ZDgs3MmTwWU4SeKdA4S0htrHmVgc oh9xjzEIixJkAsWVI3hgatO4cY+nOxWbWzPIeX3+ROHsCA/Lf8RpSxI8YYT57/NgNsxL1kIiHMqe1 /JMf39fwg7ueP4b+DpsNWmdwhYQ+1C5vqAAHzXih0GMp93CsDPB2ujjaMd1/Q0PgHsGv5XVe0pPvH BPS2m2HRj4i2/g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#65235: [PATCH] refresh: Add --to-version option. References: <7abba6f5c3c2cc32a0f21fa701e64fffe7d27861.1691790311.git.maxim.cournoyer@gmail.com> Date: Tue, 15 Aug 2023 12:39:48 +0200 In-Reply-To: <7abba6f5c3c2cc32a0f21fa701e64fffe7d27861.1691790311.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Fri, 11 Aug 2023 17:45:11 -0400") Message-ID: <87fs4ka8sr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65235 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 65235@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, Maxim Cournoyer skribis: > * guix/scripts/refresh.scm (%options): Register 'to-version' long version. > (update-specification->update-spec): Add a fallback-version argument. > (options->update-specs): Honor to-version option. > * tests/guix-refresh.sh: Test it. > * doc/guix.texi (Invoking guix refresh): Document it. [...] > +In some specific cases, you may have many packages specified via a > +manifest or a module selection which should all be updated together; for > +these cases, the @option{--to-version} option can be provided to have > +them all refreshed to the same version, as shown in the examples below: > + > +@example > +$ guix refresh qtbase qtdeclarative --to-version=3D6.5.2 > +gnu/packages/qt.scm:1248:13: qtdeclarative would be upgraded from 6.3.2 = to 6.5.2 > +gnu/packages/qt.scm:584:2: qtbase would be upgraded from 6.3.2 to 6.5.2 > +@end example > + > +@example > +$ guix refresh --manifest=3Dqt5-manifest.scm --to-version=3D5.15.10 > +gnu/packages/qt.scm:1173:13: qtxmlpatterns would be upgraded from 5.15.8= to 5.15.10 > +gnu/packages/qt.scm:1202:13: qtdeclarative would be upgraded from 5.15.8= to 5.15.10 > +gnu/packages/qt.scm:1762:13: qtserialbus would be upgraded from 5.15.8 t= o 5.15.10 > +gnu/packages/qt.scm:2070:13: qtquickcontrols2 would be upgraded from 5.1= 5.8 to 5.15.10 > +@dots{} > +@end example So the main goal is to avoid repeating the =E2=80=98=3D=E2=80=99 sign as in =E2=80=98qtbase=3D6.5.2=E2=80=99, right? That makes a lot of sense to me. I=E2=80=99d maybe prefer =E2=80=98--target-version=E2=80=99 but otherwise L= GTM! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 10:03:01 2023 Received: (at 65235-done) by debbugs.gnu.org; 15 Aug 2023 14:03:02 +0000 Received: from localhost ([127.0.0.1]:36394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVudR-0006tC-EA for submit@debbugs.gnu.org; Tue, 15 Aug 2023 10:03:01 -0400 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]:60494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVudP-0006sv-QV for 65235-done@debbugs.gnu.org; Tue, 15 Aug 2023 10:03:00 -0400 Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-76cab6fe9c0so488316485a.0 for <65235-done@debbugs.gnu.org>; Tue, 15 Aug 2023 07:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692108174; x=1692712974; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=NhBSd3/+z0xt4cD6VRs0kozw7KTwyBU9I28E/dhQpJY=; b=rXxuwJ9ah/twVN7eBOPtUE8/g4wlplWorAXIHvl6F7vltVqvC3rSPbDtjqbcsv56qD cBitJXq3sAAZT7Ud7FzMWKkackYBLtFcne9adRVgaNHj/W9llo9V4vfqLby1BhV/6Ymc mJ2j7EEXOBf0M72e665PH0hNJvgJWqos1XB/LQJTvYrxCbpAvayZMbdsvtEwYD6gOn5N g7aCmEZFxXXqBmYY3HzbSy1Bmj8rF2qkmdW3D3LR9GdtAfVgJlPRHTcz3r4mNxxWaCnk JJScHG5c8vmZEjEART3l6m8LuEo+2n7kjyRq4gDV5lvJ2gUNOZOhLQXjR66dnfdIf9mx gvDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692108174; x=1692712974; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NhBSd3/+z0xt4cD6VRs0kozw7KTwyBU9I28E/dhQpJY=; b=heHthRfRnAqC0bb/axGC4I5cGFjJWvvsiBU+A8VDj5ltbbrwyTs6DPvRYh+FZrsHub wiXGTd9uITFI2v5BtOwMb3Hwy3m8vOKAMhAtd3E/W3YFln4MUQoO/KDw0BWo4b4XTuEQ UxsDDdyApLMVAD6zxlgji5qFUQrjEaNI4eVV/c8mXPufyqA39W3rU8jH8Qyo6ML/xxNn lPeb3+M9BSF6uxORxesIwlUmqbbllQfNR5OQ6jbtlrt4SDk/sA6w6ck+eshs5natyqvC xgkxF1pG2+KiMTaIg8xuuiT5jrAlxlX3JB//PY94ItxyvNPOY99vCJgyHV0v2hUHT/Px RRxA== X-Gm-Message-State: AOJu0YxqPMdND43H1HvL2nDjKceNFMTUAmIJO3GwOyiICR1UlxoClwPp 0Am4xApWFetyQNN1xeRDFtg= X-Google-Smtp-Source: AGHT+IFDcUMFi0JiG/mf/zchu2hG+VIM1L6L0h2CGYqUuHb3eAUU8xzXxGrgHf097gAUDJXQ84fl+w== X-Received: by 2002:ad4:56ed:0:b0:63d:4a9b:b29f with SMTP id cr13-20020ad456ed000000b0063d4a9bb29fmr9809677qvb.65.1692108174221; Tue, 15 Aug 2023 07:02:54 -0700 (PDT) Received: from hurd (dsl-148-65.b2b2c.ca. [66.158.148.65]) by smtp.gmail.com with ESMTPSA id e27-20020a0caa5b000000b0063cdeac3419sm4192010qvb.110.2023.08.15.07.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 07:02:53 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#65235: [PATCH] refresh: Add --to-version option. References: <7abba6f5c3c2cc32a0f21fa701e64fffe7d27861.1691790311.git.maxim.cournoyer@gmail.com> <87fs4ka8sr.fsf@gnu.org> Date: Tue, 15 Aug 2023 10:02:52 -0400 In-Reply-To: <87fs4ka8sr.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 15 Aug 2023 12:39:48 +0200") Message-ID: <87o7j8jtdf.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65235-done Cc: 65235-done@debbugs.gnu.org, Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> * guix/scripts/refresh.scm (%options): Register 'to-version' long versio= n. >> (update-specification->update-spec): Add a fallback-version argument. >> (options->update-specs): Honor to-version option. >> * tests/guix-refresh.sh: Test it. >> * doc/guix.texi (Invoking guix refresh): Document it. > > [...] > >> +In some specific cases, you may have many packages specified via a >> +manifest or a module selection which should all be updated together; for >> +these cases, the @option{--to-version} option can be provided to have >> +them all refreshed to the same version, as shown in the examples below: >> + >> +@example >> +$ guix refresh qtbase qtdeclarative --to-version=3D6.5.2 >> +gnu/packages/qt.scm:1248:13: qtdeclarative would be upgraded from 6.3.2= to 6.5.2 >> +gnu/packages/qt.scm:584:2: qtbase would be upgraded from 6.3.2 to 6.5.2 >> +@end example >> + >> +@example >> +$ guix refresh --manifest=3Dqt5-manifest.scm --to-version=3D5.15.10 >> +gnu/packages/qt.scm:1173:13: qtxmlpatterns would be upgraded from 5.15.= 8 to 5.15.10 >> +gnu/packages/qt.scm:1202:13: qtdeclarative would be upgraded from 5.15.= 8 to 5.15.10 >> +gnu/packages/qt.scm:1762:13: qtserialbus would be upgraded from 5.15.8 = to 5.15.10 >> +gnu/packages/qt.scm:2070:13: qtquickcontrols2 would be upgraded from 5.= 15.8 to 5.15.10 >> +@dots{} >> +@end example > > So the main goal is to avoid repeating the =E2=80=98=3D=E2=80=99 sign as = in > =E2=80=98qtbase=3D6.5.2=E2=80=99, right? That makes a lot of sense to me. > > I=E2=80=99d maybe prefer =E2=80=98--target-version=E2=80=99 but otherwise= LGTM! I've attempted a quick poll on #guix and Efraim also voted vote --target-version, so I've made change and pushed! Tobias had suggested '--update-version', which also made sense. Thanks for the review! --=20 Maxim From unknown Mon Aug 18 11:31:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Sep 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator