Subject: refresh: Exception in manifest is silenced, cause all packages to be selected

From: Maxim Cournoyer <[email-masked]>
Date: Fri, 11 Aug 2023 16:04:27 -0400

Hi Guix,

Consider the following manifest:

--8<---------------cut here---------------start------------->8---
(use-modules (guix packages)
             (guix profiles)
             (guix utils)
             (gnu packages))

(define %qt-major-version "6")

(manifest
 (map package->manifest-entry
      (fold-packages
       (lambda (package lst)
         (let ((uri (and=> (package-source package)
                           (lambda (x)
                             (and (origin? x)
                                  (origin-uri x))))))
           (if (and uri
                    (string? uri)
                    (string-prefix? "mirror://qt/" uri)
                    (= %qt-major-version (version-major
                                          (package-version package))))
               (cons package lst)
               lst)))
       '())))
--8<---------------cut here---------------end--------------->8---

There's a subtle bug in it, which is the '=' function which is used
instead of 'string=?'.  I'd expect 'guix refresh -m qt-manifest.scm' to
let this exception interrupt execution, but instead it proceeds to
refresh all (?) the packages (taking a long time to compute).

At the REPL, the error is reported as:

--8<---------------cut here---------------start------------->8---
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure =: Wrong type argument in position 1: "6"
--8<---------------cut here---------------end--------------->8---

-- 
Thanks,
Maxim