From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 10 13:19:49 2023 Received: (at submit) by debbugs.gnu.org; 10 Aug 2023 17:19:49 +0000 Received: from localhost ([127.0.0.1]:43952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU9K8-0002Xx-6P for submit@debbugs.gnu.org; Thu, 10 Aug 2023 13:19:49 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU9K4-0002Xh-ET for submit@debbugs.gnu.org; Thu, 10 Aug 2023 13:19:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU9Jz-0000xM-2V for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 13:19:39 -0400 Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU9Jw-0008Kn-E6 for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 13:19:38 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1691687970; cv=none; d=zohomail.eu; s=zohoarc; b=hCSTMOn7KL9He0oK0eIt7E6ZHp4NF9+LDOiGoC6UqNu1N3NIpCPgl5LyQ8hPU8zSWIav2FW0K1MNZT3cOZlcBDOg8AOT9LkrZi0U626jxbAQyx6uozuZAuRZ1zf0bYQbW+bljbCd0SPhZVOjNWn0fSo3aLBLA3QsJzMIkIl5oHQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1691687970; h=Content-Type:Date:From:MIME-Version:Message-ID:Subject:To; bh=g5n+crm8yXZ02OTcMRIUw305lyo/zcVZCXNG4FPtuv8=; b=AuD0yNT2879zgzuUg3AY5jUazMEJr0ozI/axfoYdHr/K+BWjtlbeI3eEtaFa/RZEWBFIvvy+2OZ4EMBYzqHrIko2xll+uztl1nhXYlQKP0KDQuP3vWfgpBNBTdGTqv+ZuyaMOuAOii4GDMkXpdT1idzSk7VBff6XSo/gBfW6gFo= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691687970; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To:Cc; bh=g5n+crm8yXZ02OTcMRIUw305lyo/zcVZCXNG4FPtuv8=; b=mprn6bAM/z/bphlAS6/N9ulhzMd1Sx2YuOjhP+VzSYDFj2u066ccfIqCrF8XzuAH zbJ5kZx4c+AZwOZ3uImUfx/tOFkO3GyvTvt/PJUK2K+lIsOGE5K0C1qC5hjRoUfg2z8 eihr1k+FbMDuHcO/JiYpAlHLpYZn1+Z3WYPFk6Vo= Received: from localhost (81-231-79-170-no600.tbcn.telia.com [81.231.79.170]) by mx.zoho.eu with SMTPS id 1691687968118254.38591775758698; Thu, 10 Aug 2023 19:19:28 +0200 (CEST) User-agent: mu4e 1.10.5; emacs 29.1 From: Rahguzar To: bug-gnu-emacs@gnu.org Subject: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Date: Thu, 10 Aug 2023 19:05:03 +0200 Message-ID: <87il9mddcx.fsf@zohomail.eu> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=31.186.226.249; envelope-from=rahguzar@zohomail.eu; helo=sender11-pp-o91.zoho.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Dear Emacs developers, To reproduce starting from 'emacs -Q' visit an image file. Then repeatedly use 'i +' till the image is taller than the window. The image can be scrolled using mouse wheel. Now do M-x pixel-scroll-precision-mode After this attempting to scroll the image will set the vscroll to 0 and then image can't be scrolled at all. >From some investigation it seems like this behavior is not specific to image-mode. Another way to reproduce the behavior is to evaluate the following lisp code, (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) (height (* (window-text-height win t) 2)) (file "path/to/image")) (select-window win) (erase-buffer) (insert-image (create-image file nil nil)) (goto-char 1) (pixel-scroll-precision-mode) nil) This image thus displayed can not be scrolled. However if the code above is slightly modified to insert a new line after the image, scrolling can be done normally, i.e. (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) (height (* (window-text-height win t) 2)) (file "path/to/image")) (select-window win) (erase-buffer) (insert-image (create-image file nil nil)) (insert "\n") (goto-char 1) (pixel-scroll-precision-mode) nil) produces an image that can be scrolled. Inserting a newline after the text covered by the text property holding the image also fixes the problem in 'image-mode' but that doesn't seem like the right fix to me. Rahguzar In GNU Emacs 29.1 (build 1, x86_64-suse-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-08-07 built on lamb11 System Description: openSUSE Tumbleweed Configured using: 'configure --host=x86_64-suse-linux-gnu --build=x86_64-suse-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-pgtk --with-native-compilation=aot --with-cairo --with-libotf --with-jpeg --with-tiff --with-gif --with-png --with-rsvg --with-xft --with-xml2 --with-dbus --with-sound --with-json --with-mailutils --with-gnutls --with-tree-sitter --enable-locallisppath=/usr/share/emacs/29.1/site-lisp:/usr/share/emacs/site-lisp 'CFLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto' LDFLAGS=-Wl,-O2' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: mu4e:main Minor modes in effect: recentf-mode: t save-place-mode: t global-so-long-mode: t projectile-mode: t which-key-mode: t savehist-mode: t better-jumper-mode: t better-jumper-local-mode: t global-company-mode: t company-mode: t vertico-mode: t all-the-icons-completion-mode: t marginalia-mode: t evil-goggles-mode: t evil-escape-mode: t evil-snipe-override-mode: t evil-snipe-mode: t gcmh-mode: t winner-mode: t smartparens-global-mode: t ws-butler-global-mode: t undo-fu-session-global-mode: t undo-fu-mode: t satchel-mode: t mu4e-search-minor-mode: t global-hl-line-mode: t hl-line-mode: t mu4e-update-minor-mode: t mu4e-context-minor-mode: t dirvish-override-dired-mode: t server-mode: t pixel-scroll-precision-mode: t repeat-mode: t evil-mode: t evil-local-mode: t windmove-mode: t +popup-mode: t +modeline-global-mode: t +modeline-mode: t override-global-mode: t general-override-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t buffer-read-only: t size-indication-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t abbrev-mode: t Load-path shadows: /home/azeem/.emacs.d/.local/straight/build-29.1/emacsql/emacsql-sqlite-builtin hides /home/azeem/.emacs.d/.local/straight/build-29.1/emacsql-sqlite-builtin/emacsql-sqlite-builtin /home/azeem/.emacs.d/.local/straight/build-29.1/citar-embark/citar-embark hides /home/azeem/.emacs.d/.local/straight/build-29.1/citar/citar-embark /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-view hides /usr/share/emacs/site-lisp/mu4e/mu4e-view /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-search hides /usr/share/emacs/site-lisp/mu4e/mu4e-search /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-org hides /usr/share/emacs/site-lisp/mu4e/mu4e-org /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-config hides /usr/share/emacs/site-lisp/mu4e/mu4e-config /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-message hides /usr/share/emacs/site-lisp/mu4e/mu4e-message /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-icalendar hides /usr/share/emacs/site-lisp/mu4e/mu4e-icalendar /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-query-items hides /usr/share/emacs/site-lisp/mu4e/mu4e-query-items /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-notification hides /usr/share/emacs/site-lisp/mu4e/mu4e-notification /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-window hides /usr/share/emacs/site-lisp/mu4e/mu4e-window /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-modeline hides /usr/share/emacs/site-lisp/mu4e/mu4e-modeline /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e hides /usr/share/emacs/site-lisp/mu4e/mu4e /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-vars hides /usr/share/emacs/site-lisp/mu4e/mu4e-vars /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-update hides /usr/share/emacs/site-lisp/mu4e/mu4e-update /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-server hides /usr/share/emacs/site-lisp/mu4e/mu4e-server /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-obsolete hides /usr/share/emacs/site-lisp/mu4e/mu4e-obsolete /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-mark hides /usr/share/emacs/site-lisp/mu4e/mu4e-mark /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-main hides /usr/share/emacs/site-lisp/mu4e/mu4e-main /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-helpers hides /usr/share/emacs/site-lisp/mu4e/mu4e-helpers /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-headers hides /usr/share/emacs/site-lisp/mu4e/mu4e-headers /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-folders hides /usr/share/emacs/site-lisp/mu4e/mu4e-folders /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-draft hides /usr/share/emacs/site-lisp/mu4e/mu4e-draft /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-contrib hides /usr/share/emacs/site-lisp/mu4e/mu4e-contrib /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-context hides /usr/share/emacs/site-lisp/mu4e/mu4e-context /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-compose hides /usr/share/emacs/site-lisp/mu4e/mu4e-compose /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-bookmarks hides /usr/share/emacs/site-lisp/mu4e/mu4e-bookmarks /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-actions hides /usr/share/emacs/site-lisp/mu4e/mu4e-actions /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-speedbar hides /usr/share/emacs/site-lisp/mu4e/mu4e-speedbar /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-lists hides /usr/share/emacs/site-lisp/mu4e/mu4e-lists /home/azeem/.emacs.d/.local/straight/build-29.1/mu4e/mu4e-contacts hides /usr/share/emacs/site-lisp/mu4e/mu4e-contacts Features: (shadow whitespace display-line-numbers adaptive-wrap jit-spell ispell face-remap recentf tree-widget saveplace evil-collection-so-long so-long emacsbug cursor-sensor vertico-repeat link-hint ffap goto-addr avy shr-color jka-compr auto-minor-mode mm-archive sort smiley gnus-cite mail-extr qp textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml disp-table nndraft nnmh nnfolder epa-file network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache projectile lisp-mnt evil-collection-grep grep hide-mode-line evil-collection-which-key which-key savehist better-jumper company-capf company evil-collection-vertico vertico orderless all-the-icons-completion marginalia compat evil-goggles pulse color evil-easymotion evil-escape evil-snipe gcmh winner smartparens-config smartparens-text smartparens dash ws-butler undo-fu-session undo-fu satchel ibuf-ext evil-collection-ibuffer ibuffer ibuffer-loaddefs desktop frameset mu4e mu4e-org evil-collection-org smartparens-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc-natbib oc-csl bibtex oc-biblatex oc org-loaddefs find-func org-version org-compat org-macs mu4e-notification notifications mu4e-main mu4e-view gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus dbus autorevert filenotify gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win evil-collection-gnus gnus nnheader range evil-collection-calendar cal-menu calendar cal-loaddefs mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message shr pixel-fill kinsoku url-file svg xml dom browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse auth-source json map url-vars flow-fill mule-util hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-context mu4e-query-items mu4e-server mu4e-modeline mu4e-vars mu4e-helpers mu4e-config mu4e-window evil-collection-bookmark bookmark ido message sendmail mailcap yank-media puny dirvish transient format-spec eieio eieio-core evil-collection-dired dired dired-loaddefs rfc822 mml mml-sec password-cache evil-collection-epa epa epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader mu4e-obsolete server dtrt-indent ef-spring-theme ef-themes pixel-scroll cua-base repeat midnight html2text let-alist evil-collection-flymake flymake-proc flymake project evil-collection-compile evil-collection-custom cus-edit cus-load wid-edit evil-collection-comint evil-collection annalist compile text-property-search comint ansi-osc ansi-color ibuf-macs evil evil-integration evil-maps evil-commands reveal evil-jumps evil-command-window evil-search evil-types evil-macros evil-repeat evil-states evil-core byte-opt advice evil-common windmove calc calc-loaddefs calc-macs thingatpt rect evil-digraphs evil-vars ring all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons derived edmacro kmacro use-package-bind-key bind-key comp comp-cstr warnings icons rx doom-editor doom-projects doom-ui easy-mmode doom-keybinds pp cl-extra help-mode use-package-core bytecomp byte-compile general tex-site doom-start doom-modules cl-seq doom doom-lib cl-macs cl-loaddefs cl-lib pcase gv harfbuzz jansson dynamic-modules subr-x rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 838555 316547) (symbols 48 42792 15) (strings 32 169060 12011) (string-bytes 1 5569967) (vectors 16 93707) (vector-slots 8 1658949 153955) (floats 8 1309 1539) (intervals 56 17242 89) (buffers 984 18)) From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 10 23:38:56 2023 Received: (at 65214) by debbugs.gnu.org; 11 Aug 2023 03:38:56 +0000 Received: from localhost ([127.0.0.1]:44611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUIzH-0003HO-SC for submit@debbugs.gnu.org; Thu, 10 Aug 2023 23:38:56 -0400 Received: from sonic311-25.consmr.mail.ne1.yahoo.com ([66.163.188.206]:36132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUIzC-0003H4-83 for 65214@debbugs.gnu.org; Thu, 10 Aug 2023 23:38:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691725123; bh=2v3x1v/J8LfEwJowwPLoknxseZPy8PES0PlajeO2Owk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=E6oIqF3nooJzw0UktA/eJJgrl/axnznIGz6n7hNnMIpUsRkH57XbRk/A+1rx58l+3wF0pmChPzk5oi7PpkDiDfVSQyANEae5erO81YEOO/nS8JqFLPE2HldYdatku7bSe5ZBuRSQQpkmEWhMqfeKmuWR5Crq3DPfrpC3tGIbfr/63xVuPXSxvEPkzPpnnRRlYN9U2evtmZ68kp+xu04Uh6ZBZjNmzNMeYt6ckwIyUm5OEywQyHUAEesNwoVvAuO5c0pCsSJWJHMaE2x5cOHir+Vs6qXZFKSdsu1H2cc6OyWB9xUshDZC1+bWcXECYAv572XbpwA7uRPuuOiohkyQkA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691725123; bh=NUQGf8oRK8BaV2bEhRbESG//TncITGYhNGcceTl+sms=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=GGy6Wixa9C2sZujeWwSu+cTFrbG5Za7b2eQMMhb7Z+eZEAfV655C0X/HUKyNeWfGUUYCNRwef/1ry8ccv7gOPY3mEOZm53flDWjcTA6Mck3uf9pYdLfmtHf69HA1v7ELKmElLp5Nk9ZtEqMrWmxIkJrbm+S3jNZFdl3CwUveVv/baAxRbQeGI3s0QsiusbBtk6ICFcnxOQz3c7X7mbHQPsj0URB/QnTfa84b5/vEIePwcfnOXXkJaRS2RgasqRBezzpQs6v9d0R6Mo3jg+j46NTEzq1HWbSpbPLvbgtMcUuzk6TeT7/jd+y8TC+jMv3nVNGDoi8CxM5Xa4NAyCEWAw== X-YMail-OSG: TvzQZEwVM1kmO_6r0MTMiDC6UkSeZ7_K2ysux2nZmhISy7jdOEit102l4hazbqX gPXUv2O36ZgXOTGTjzp3hme2WoCrLLcIH4y5S_K75axI_4sJhDT6go.b13ZZkmHtwBCWa0sx3nhR DRYQq8loXKtfyE4kTCVKhgt7ibn2np8fA0VZ2QwtUBDXivxnGtTo5nPXMsCRVWScgYaLVHA_ly6J IiK0bz1R6vVBmsYZ_pkpV7PMuFVDhKgl.E8fJMnJq01zFBrHa25B_iLJwC2f51jrnx7w71oT4R.T rif9U3I3svmh2OfjfSQUVJkCDgdWqybO7P4duVuJkDScyRjkUhn.FsAuoSgZz7rdP1eEKZye8hcZ a_lgaMcpcaYzUc6ImrzQX0n9cpIs2VNeO2lYAw5VCIZQ9o5VSZspImETofja20.V3BKkXDFhy.St iSMRuRq.eQu79Rxw3VeTqp1zoJRnw2ZgIV6LK9RjmzEOisRLDPecdvDFp0vV4wsY5vNrgvmxAE47 FS6w8W0Kbt8JIzR6maPOC16wFSsXxbWQQBrKz_W.NlM8z.02I1Uslec.tb7TQkEgg9bnj0mFedq_ _bOgE1r89c9ciy0bimN78GvIpUY8j_je7Z8vSH2rNuFjC1WfwE6RJpmYdF01dQuJk9cJOThAyovU M2myqpoyJ_WDbRdQCDxz3FK06NTiDSKF2ZFHIFqdr1mw2xCuYyaMzQHUS70Tr0Ttkqcd.6pKU8Sr va8RBk0zsSHVIAJP4mszRQPuIPBv4uSjqHpbetVIjWbsiCPIw6Q1qVBXaGdEqRynqEWXTkPDiMN0 Dco6XfWAr6545dhtYSYVj.VzUPZkhTj4eyDbTkXT3_mYGggGtLe3sktOt.lwtfEJ7X3ET0k4MGpp wiKRLa6Mqmr7xaig2N.CrbqzgI8ATtWZGecewX8vHyOJ6.B7WBRrT5t5D.CWbtZe9vW8bvitSWP_ r.5CkuT_q.8LtbrfmvsNvh.iZXwGr7HtFOtiEnU95pzrOrVgRoOrbIVn5noHpk4TQJQdOxLYGgeN Hy_WihWLSS5YXdrN1GdoUK_eX.hP1PHw08LkT6oG24XI0ts07aKMK0KrZmPmsCzjFZ6TEQNNRuPB tofYpDIsalb9ZIgUglrbiDBihRtgI.tgqGiTzVQ2wefHMmwoOyxWEWXsHueXa52li4SLNbkygQo6 qAAIp0zgxos1CbmrACf8b0f56poS0eWvRol7oMRrNfQFJ9pAfoDk6icK7OCWlst32MfhoFzEA1Pd pRh4GOzFHyouXQ1CJYAqpKBAYloDQxgFZcSB8.0S7k3vWcHpE9qF72.hwEL4SOKt3yo5IAaoBpGn tV8ZlqDTXNkPqLcJwnAbKrcNQ73Tw8EyyEm8E7Fl4YIydVNDlXqJ94oJOaR_ZQMp0ppmJYpw60J4 68c64IlTUdPS_yPG7.ILdmafpi1z98t5XMINMdEmM9H7ycuJM4vYrPFDPfkrJrvP2INMDKN3PrUg Q7xVel5xQ3wj5_fyIRV8QhPNXVipznAXkWpIZ7LsEgViWG2SQk9nRKYG5vc7XncalWVFWrOdm2vX eUj0_Ywy9kk3TIKdWkbiagXYaHP7SZ7RPLRusQGNpVtSdYHaMJFcEdPdCmOqYujnqjZjH8GKP4Yw yGoWgpmLUZlGQiRDmCPZmReIK_yhtauOFudVy04qsVp.kp9CaowvLzv8cHbat8TocVzTfjj4xZV2 nDU_HzHNhWGECwxBSpGMG.TeWr3xM6aBqN1mPgH3S2v0S6POTfzbBJQPRdRyt.cM0YIoUuOCIGLZ Fj93Bqj87jBgo2wROjL.AYbIUA3nfKwBDqSGF7eZvBUxg08kY.pGk3v30GAFjvx4fjg0WpPN3z6c bMCU.vzev3unWMwnbqhom.XEyXx232z9UjoWqR72hv.xakfIYolJMewg5Tk12nm9c4qOC3tk772e SmmrMRvRWo812NPw4VIOyYjLeiaBqpDJxRWOSENrgAISnOTD1xB43LaOFJz.HRnkEDQuKPHgr_S2 viQPrqKijzJwRj12aEhGE3cs.oArad6tBlZGD3GVSy59USVlHefqP22UOjKmx2XRX1RdTnhZtoC4 eBR7jVvO689DIAyMdlKA5ehhyiRFnBj9d2HrgsdFJPh4_wkOeaIw.fCwbP.STZeLqoZjIm0Ce4jt ZR2eKk8yM1p.bIR7f6O6gfjpwhwDXhFqY0a0uPl3IIxK5nVdZSbDuyvc37cI_uvJOB1oamoYl0Qs DJJxusS7tvrzNDLi_1zuPexBmr_Y_Lyg9hwcH8okqKj_hio3ByVDLsg.4 X-Sonic-MF: X-Sonic-ID: 6d6b09f6-f20f-45e2-9663-b4b33c2b5407 Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Fri, 11 Aug 2023 03:38:43 +0000 Received: by hermes--production-sg3-69654d8bd-l9pxw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b1ebfb866f09376935dd267e673478b1; Fri, 11 Aug 2023 03:38:39 +0000 (UTC) From: Po Lu To: Rahguzar Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on In-Reply-To: <87il9mddcx.fsf@zohomail.eu> (rahguzar@zohomail.eu's message of "Thu, 10 Aug 2023 19:05:03 +0200") References: <87il9mddcx.fsf@zohomail.eu> Date: Fri, 11 Aug 2023 11:38:28 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21695 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1876 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rahguzar writes: > Dear Emacs developers, > > To reproduce starting from 'emacs -Q' visit an image file. Then > repeatedly use 'i +' till the image is taller than the window. The > image can be scrolled using mouse wheel. Now do > > M-x pixel-scroll-precision-mode > > After this attempting to scroll the image will set the vscroll to 0 > and then image can't be scrolled at all. > >>>From some investigation it seems like this behavior is not specific > to image-mode. Another way to reproduce the behavior is to evaluate > the following lisp code, > > (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) > (height (* (window-text-height win t) 2)) > (file "path/to/image")) > (select-window win) > (erase-buffer) > (insert-image (create-image file nil nil)) > (goto-char 1) > (pixel-scroll-precision-mode) > nil) > > This image thus displayed can not be scrolled. However if the code > above is slightly modified to insert a new line after the image, > scrolling can be done normally, i.e. > > (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) > (height (* (window-text-height win t) 2)) > (file "path/to/image")) > (select-window win) > (erase-buffer) > (insert-image (create-image file nil nil)) > (insert "\n") > (goto-char 1) > (pixel-scroll-precision-mode) > nil) > > produces an image that can be scrolled. Inserting a newline after the > text covered by the text property holding the image also fixes the > problem in 'image-mode' but that doesn't seem like the right fix to me. > > Rahguzar This is a known limitation of pixel-scroll-precision-mode: redisplay's automatic recentering impededs adjustment of the vscroll as the image moves outside of the window's text area. Unfortunately, it's not slated to be fixed any time soon. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 11 10:29:14 2023 Received: (at 65214) by debbugs.gnu.org; 11 Aug 2023 14:29:14 +0000 Received: from localhost ([127.0.0.1]:47707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUT8c-0001Bb-1j for submit@debbugs.gnu.org; Fri, 11 Aug 2023 10:29:14 -0400 Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUT8Z-0001BQ-Li for 65214@debbugs.gnu.org; Fri, 11 Aug 2023 10:29:13 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1691764148; cv=none; d=zohomail.eu; s=zohoarc; b=goC22Q1PKC1yfAAJVxVtFCHgmj1GNt4MWPGeRxbDox+tDjOabISaSwi2kNG3MtpPBS83SonB7RdQNluooKJjoTPlrCAbkYBthhsIaNZLxAW33TAItRTPU93q/oP9ccE2M1J4zQh/Jf00tvlMnfbvQTiGCQVzzycudQbs2R270e4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1691764148; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=BrBVdwK9bWsDUNNNBj4zRmH6vL+XvJ2U5rQDUFEbKmI=; b=eU6mVQA4sSfWOAE7otKkRx7VDoVIf3dAidBm52XmQph9m9b1ZxvWXpMgsK36DjjeVMDBQ4CvZcH0niazlW/oiTiLe0/FrxbS2f0bUxdPwfA09JH7EOh3XtyQjJTmXjg3tSXJ3b8eOOvc3i87H8Ex8wnEDIFfT/Q/0GKBZJHg8FE= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691764148; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=BrBVdwK9bWsDUNNNBj4zRmH6vL+XvJ2U5rQDUFEbKmI=; b=GCb6VYDZs7zRxYz7U2kJfEM37tszRFKsxMzQs5i7L2NjIRNqWuVPWPfTKxVbrU4M U9A7d/mPo2AleEELoYgRL23PIdvOoPL1JfNMFD1nxZnDvj9Ivz4IDnK7DEt3b31Yz9p YT396NcDpQYMpH1GzltRDg4kM2FwsF3Z6gOtnZS4= Received: from localhost (130.238.90.230 [130.238.90.230]) by mx.zoho.eu with SMTPS id 1691764145699157.88482012360487; Fri, 11 Aug 2023 16:29:05 +0200 (CEST) References: <87il9mddcx.fsf@zohomail.eu> User-agent: mu4e 1.10.5; emacs 29.1 From: Rahguzar To: Po Lu Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Date: Fri, 11 Aug 2023 15:19:53 +0200 In-reply-to: Message-ID: <875y5ld55b.fsf@zohomail.eu> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Hi Po, In this case it is not the recentering which is causing this problem, it is rather the binding for next-pos in pixel-scroll-precision-scroll-down-page which is the issue. The binding signals an error when downward vertical motion is not possible. However in this scenario scrolling can still be done. Replacing that binding with desired-start allow me to scroll the images. This change for example allows for scrolling tall images, @@ -524,10 +524,12 @@ pixel-scroll-precision-scroll-down-page (next-pos (save-excursion (goto-char desired-start) (when (zerop (vertical-motion (1+ scroll-margin))) - (set-window-start nil desired-start) - (signal 'end-of-buffer nil)) + (unless (let ((remaining-bottom (nth 3 (pos-visible-in-window-p desired-start nil t)))) + (and remaining-bottom (not (zerop remaining-bottom)))) + (signal 'end-of-buffer nil))) (while (when-let ((posn (posn-at-point))) - (< (cdr (posn-x-y posn)) delta)) + (and (< (point) (point-min)) + (< (cdr (posn-x-y posn)) delta))) (when (zerop (vertical-motion 1)) (set-window-start nil desired-start) (signal 'end-of-buffer nil))) I am not sure it is the correct change since I don't understand the while loop but comparing 'point' and 'point-min' doesn't seem the write thing there. On the others hand if there is 'point-min' is 1 and 'point-max' 2, (cdr (posn-x-y posn)) Po Lu writes: > This is a known limitation of pixel-scroll-precision-mode: redisplay's > automatic recentering impededs adjustment of the vscroll as the image > moves outside of the window's text area. Unfortunately, it's not slated > to be fixed any time soon. In this case it is not the recentering which is causing this problem, it is rather the binding for next-pos in pixel-scroll-precision-scroll-down-page which is the issue. The binding signals an error when downward vertical motion is not possible. However in this scenario scrolling can still be done. Replacing that binding with desired-start allow me to scroll the images. This change for example allows for scrolling tall images, @@ -524,10 +524,12 @@ pixel-scroll-precision-scroll-down-page (next-pos (save-excursion (goto-char desired-start) (when (zerop (vertical-motion (1+ scroll-margin))) - (set-window-start nil desired-start) - (signal 'end-of-buffer nil)) + (unless (let ((remaining-bottom (nth 3 (pos-visible-in-window-p desired-start nil t)))) + (and remaining-bottom (not (zerop remaining-bottom)))) + (signal 'end-of-buffer nil))) (while (when-let ((posn (posn-at-point))) - (< (cdr (posn-x-y posn)) delta)) + (and (< (point) (point-min)) + (< (cdr (posn-x-y posn)) delta))) (when (zerop (vertical-motion 1)) (set-window-start nil desired-start) (signal 'end-of-buffer nil))) I am not sure it is the correct change since I don't understand the while loop but comparing 'point' and 'point-min' doesn't seem the write thing there. On the others hand if there is 'point-min' is 1 and 'point-max' 2, (cdr (posn-x-y posn)) is always zero, so that check makes the loop terminate without signaling an error. The behavior is also sub optimal in that it allows for scrolling past the lower edge of the image but how much depends on the speed of the scrolling, but that can be fixed easily. Rahguzar From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 11 10:40:24 2023 Received: (at 65214) by debbugs.gnu.org; 11 Aug 2023 14:40:25 +0000 Received: from localhost ([127.0.0.1]:47733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUTJQ-0001Sa-Cl for submit@debbugs.gnu.org; Fri, 11 Aug 2023 10:40:24 -0400 Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUTJN-0001SN-Nh for 65214@debbugs.gnu.org; Fri, 11 Aug 2023 10:40:23 -0400 Delivered-To: rahguzar@zohomail.eu ARC-Seal: i=1; a=rsa-sha256; t=1691764816; cv=none; d=zohomail.eu; s=zohoarc; b=Ff4t/hBd8c3NE9BLnMNG+Dd2gsp+BxI9fefbMfHgyrPtViOnQwqlZ0BCEVTeJyZrGKu70+5+6gnDzAI5onMIFfGT6R+uhWyWDscg4DX51f5Dkx0BEKmlrceXrMgsgZsfYk+TcQWueC1v/Do1yuFIymbZn5h9et0m3kc5e/rX/0s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1691764816; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=n6GEB+b1yV5DB/YhX+0qC/veszvwjzd3K9IpgRWqLz8=; b=V/tlRBt8W6R7Cf5mDulFstl+kojXOebzHokmqhrl+Z5IEaROe2ChS6u0pURvSfwWawdJIGf5a5g3fzyb+MDd+r8P+YSes6pGOHCFBDavZiMCGGnGL/lbZPEgEHdQf7mg7zrrWZ+Grm1d3OHCaLWnuRUcf22oWihpeE4xBt9Xkss= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691764816; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=n6GEB+b1yV5DB/YhX+0qC/veszvwjzd3K9IpgRWqLz8=; b=hO2PtjTCKF7T2gBs1H3lCcpC02hxisdszpxXxAp1T9Ff6ieVQs0/KAnRi3pE1pMi e68OXGFResOsxouqKtM9f19L3UgU5J3vBZqueNDVGYpvrf8UUNI1cYITJ/HXPGKpPew M6naZ+P8a5HjsyVIZa+DzURBHtWHdkbt7qIbHD4Q= Received: from localhost (130.238.90.230 [130.238.90.230]) by mx.zoho.eu with SMTPS id 1691764815313713.8489656495668; Fri, 11 Aug 2023 16:40:15 +0200 (CEST) References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> User-agent: mu4e 1.10.5; emacs 29.1 From: Rahguzar To: Rahguzar Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Date: Fri, 11 Aug 2023 16:39:22 +0200 In-reply-to: <875y5ld55b.fsf@zohomail.eu> Message-ID: <871qg9d4mp.fsf@zohomail.eu> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65214 Cc: Po Lu , 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) The diff in my last message was not correct, sorry about that. It should be @@ -524,12 +524,15 @@ pixel-scroll-precision-scroll-down-page (next-pos (save-excursion (goto-char desired-start) (when (zerop (vertical-motion (1+ scroll-margin))) - (set-window-start nil desired-start) - (signal 'end-of-buffer nil)) + (unless (let ((remaining-bottom (nth 3 (pos-visible-in-window-p desired-start nil t)))) + (and remaining-bottom (not (zerop remaining-bottom)))) + (set-window-start nil desired-start t) + (signal 'end-of-buffer nil))) (while (when-let ((posn (posn-at-point))) - (< (cdr (posn-x-y posn)) delta)) + (and (< (point) (point-min)) + (< (cdr (posn-x-y posn)) delta))) (when (zerop (vertical-motion 1)) - (set-window-start nil desired-start) + (set-window-start nil desired-start t) (signal 'end-of-buffer nil))) (point))) (scroll-preserve-screen-position nil) Rahguzar writes: > Hi Po, > In this case it is not the recentering which is causing this problem, > it is rather the binding for next-pos in > pixel-scroll-precision-scroll-down-page which is the issue. The > binding signals an error when downward vertical motion is not > possible. However in this scenario scrolling can still be done. > Replacing that binding with desired-start allow me to scroll the > images. > > This change for example allows for scrolling tall images, > @@ -524,10 +524,12 @@ pixel-scroll-precision-scroll-down-page > (next-pos (save-excursion > (goto-char desired-start) > (when (zerop (vertical-motion (1+ scroll-margin))) > - (set-window-start nil desired-start) > - (signal 'end-of-buffer nil)) > + (unless (let ((remaining-bottom (nth 3 (pos-visible-in-window-p desired-start nil t)))) > + (and remaining-bottom (not (zerop remaining-bottom)))) > + (signal 'end-of-buffer nil))) > (while (when-let ((posn (posn-at-point))) > - (< (cdr (posn-x-y posn)) delta)) > + (and (< (point) (point-min)) > + (< (cdr (posn-x-y posn)) delta))) > (when (zerop (vertical-motion 1)) > (set-window-start nil desired-start) > (signal 'end-of-buffer nil))) > > I am not sure it is the correct change since I don't understand the > while loop but comparing 'point' and 'point-min' doesn't seem the write > thing there. On the others hand if there is 'point-min' is 1 and > 'point-max' 2, (cdr (posn-x-y posn)) > > Po Lu writes: > >> This is a known limitation of pixel-scroll-precision-mode: redisplay's >> automatic recentering impededs adjustment of the vscroll as the image >> moves outside of the window's text area. Unfortunately, it's not slated >> to be fixed any time soon. > > In this case it is not the recentering which is causing this problem, > it is rather the binding for next-pos in > pixel-scroll-precision-scroll-down-page which is the issue. The > binding signals an error when downward vertical motion is not > possible. However in this scenario scrolling can still be done. > Replacing that binding with desired-start allow me to scroll the > images. > > This change for example allows for scrolling tall images, > @@ -524,10 +524,12 @@ pixel-scroll-precision-scroll-down-page > (next-pos (save-excursion > (goto-char desired-start) > (when (zerop (vertical-motion (1+ scroll-margin))) > - (set-window-start nil desired-start) > - (signal 'end-of-buffer nil)) > + (unless (let ((remaining-bottom (nth 3 (pos-visible-in-window-p desired-start nil t)))) > + (and remaining-bottom (not (zerop remaining-bottom)))) > + (signal 'end-of-buffer nil))) > (while (when-let ((posn (posn-at-point))) > - (< (cdr (posn-x-y posn)) delta)) > + (and (< (point) (point-min)) > + (< (cdr (posn-x-y posn)) delta))) > (when (zerop (vertical-motion 1)) > (set-window-start nil desired-start) > (signal 'end-of-buffer nil))) > > I am not sure it is the correct change since I don't understand the > while loop but comparing 'point' and 'point-min' doesn't seem the write > thing there. On the others hand if there is 'point-min' is 1 and > 'point-max' 2, (cdr (posn-x-y posn)) is always zero, so that check makes > the loop terminate without signaling an error. > > The behavior is also sub optimal in that it allows for scrolling past > the lower edge of the image but how much depends on the speed of the > scrolling, but that can be fixed easily. > > Rahguzar From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 11 22:23:01 2023 Received: (at 65214) by debbugs.gnu.org; 12 Aug 2023 02:23:01 +0000 Received: from localhost ([127.0.0.1]:48317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUeHN-0000oJ-1W for submit@debbugs.gnu.org; Fri, 11 Aug 2023 22:23:01 -0400 Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:45507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUeHH-0000o0-AG for 65214@debbugs.gnu.org; Fri, 11 Aug 2023 22:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691806969; bh=JKKuGqr7ux4kL0N9ewKyap6vgEaqy93x3Un9DeWbFZ0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=MR/NuX7yweVMLCK2jh73vHVvWTCMgAlBgSnHX2DQ4dUvgxOLZyTq/e3DIWblZCI50iblNLE55MFbvvGVUE7Ewjm5gtQnBfeS7IJa92JDWUxE89JckYwDsw//39IoZ2F0Atq9BOlJe2n7s9zHPJ418Caj+V/d5KU0OpM1+zkCQN/9ksEvlPmaZ25nwygCEZNlX+XuO5/4G1o82BjRAbotPhRwvV71nHrDtRiBEfPLSvzGkuvOoqIu+vK+vT3xleq4n/yiMUvV4RoygairLongpDwW+XcwSB1cgDAa1lw3thZ7VupJAiA2B8+1hO3RJoDpNgDglB3TizG56ZNPeT0nKQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691806969; bh=93W/ergH4cZNzoL2smCW4mB90zGD9GpATw3ccxJ/pbP=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=X800Rd50YGNUjnkQyEHR7KWVt3wxVROyWRUcjJbbGYUQllXWkX+jp1tqJWscgrv6fb6GBOBFvByjOqaSOo01q+PW1CmwNzBueKC99K2TLar5YGU+Rr5iXeceTcWzSRrySdp6gFOBaaGd3Nh8VKhmeotWsjZJjdh49nVo3iAdqaBNk8dmqfYnmk299IdO23ffNb3r6OTi+UVl6LBQo17QWTG/fBeybIMbo1cvhp0cbawgmAmYHDCucmqlssYe85qtbjwBW7vxf4EsamNXV9G6u37qeh9SOw8/OYgiKK1TpZEruMW22tYKurdX/FCmRkVgT+z2xtDTytP7+13PB2tuqg== X-YMail-OSG: An3BIIUVM1k7h6.EoHAmm2zowgyeFEK.gK4euZbgfKNwHChsF59mDZCkoX2FHsW AnuFLrCRmtuiYWZVN3A0rOAMxc4jl8TdQDI0ST65c1Qv5U4p3XvJJRaI2mvRKIE.npxyoKaby6ky dR0tCJx5MODVaLhIfqixc63iVpxtDnLpFuQSzdL0al_RMviUugqzAlQEQG1x2DI27DrqruYlLBnf Be5jqz6eEbgmCpcoKemKAbX1TkLtGU08WayMUgZiyi9lZVJQd2QJaLP6zYjgstpQvC.q1k3txx_c Vt9xTpYwGmd4qlkhPlsMhnO764rj67nRa6Ngto4kOZNgr7ssR3Zy_VcEkoTyCY6NCShCXkeR58Iz 9KbFbPQy.8HUPd5gijrHkTjZs5fx3g8agVWc0DR71KVXaVP3hLlx4lpuXQxIAuq5V_QsjyoBvpL2 TMjflOBB9LSzPTfn5XpB5lPEANiT6EfF8F0vbASNlvBXS6llIdqY1mK3F8mZZMwZY5sXvdVcW36c xFibC_4lu0BHfiKcwoglQU58fGdXBSYfVELQ.QhPzXPC6.YynS3axXQQs.lpQP87bp07ldjG9YqP nPi5K38TZS7iwshxBXnSGIj2HnPFnefzFCSplmuYfrfN.CnNLfnF1l0E3gVM0dGSLUCQ9IESG3oR mQIiDTgYd11AFlw2Z_PflBk3JXGHyC.xY9mH9dfADb0rtmiD1uC__V2gNC3wKf5.5QS4.ebCfApw GyHEuxW9M_1M8QRIvwUAfFWu3ey5WxH53TpyZSqSz0JmjWSO9ZDkUUEewtUuTwAuoiomg9xYlMBN FoJ3woujdQUNy8QnGPwejXIOGiy87NdqbVVVrWQVJFRf7WenxJWYFexflne9b5pKqEOxNMc9bJ6i g7pmm9yCRO8rpvcV_L1.GDEHzz3JK4jx38hFRNGbnN3vnbpc0M.SpTnj.DC0fJiGAaRxJvJ9.91h 2GXuQbcczm2EnQ1Y0KlRxmPzR62_Lir0mMS7nv2ggnesDg.fYdsL9Pd4hQKXDGukg2QKiUE3BTdA LQ9RI13oKRIVMuSpDuvReVCzXYmPlVBM_dFA4G1FikiTf3NjklcScxbCg.yQWt37oAZqE0mebvqY NwmdLqZFujD3q8f.HADII_qB7W5__fZ2ompsuj.z4UbK2ClbthzWWu9cOiULy1Lhujj.br4eVMYl 3Rrf3dg4gIeF14Xdt8bwO16qiF29kWPCbmF6.3PH0JU_WcSWjQGGA2gHGG70bIko6kgyokJ4qRia EjeKSLmuFzRMH7DX081SUgVviBtL0g9QJIjyKSzctjOVId0eTgAsZHFm0LTFZABQAYLchWJfWCob lIPvYSxdmsb2uDi_Bi3wmKwhgXfmcKTHa6tSK1pomsgmPTYMqjqTHPJ64jMwf48C_BmUIZ.5e_T0 cKwLgkgNKjWqKQ_sROIPJCY897v7uy.6p4IskSeFqVcEh4L9HtLseLE.59pLRjhgCTS.0GB6_il0 hWuGPNqM7wPqR96IYDFvv_Mo2nUWaDFGLKGTt4Oz3_rOFwTGubCTmXvw4JbNcmJvwYkraZLrYkCS 4eQ9Y82h1HRjBWFR_rkJKNIXmlLp5NGWLqJps8I9x7D9yxvKDy2nVlAKrnRPrW5OJuen3QWMxxbT xuiNq5FkgB623JYsX1Jlv1TSjNEVFW2zQJw5tepbVLly7RqcSFMzAyvZuk7OBEshTgk20GmIq_7o vsPQMLe4NOul1PW4kq3BAXYcD0oK.w4PuWaHqRz2RS_tFWwCUkZxPhE4wxAZA5CfdFLah7eqoj1e wNdM8jaSmtm5RarxhQFDxu5OE7JlU2KnUYzy1alBEoltdxKaEHr8jzGvmy3mfrK5BkFDchdmC19G B1yoiH_1P71bVHJzYFBdMPRMxWwdC1Pn06Y4UHio.kEVLYFPSzW3K4voQTYBbYpNB7YAZWKJU852 foudYLf3s2tHLwR4rdv_NZqLenfBf2cFtW8g6QRZ1QUeu_uzrwY1MNl7TegoKeeNwNWFn2FB5BRr saAm3E8GMZtft.PNWPsMqH5Emw5wrmP_s2c.TvY.9nlJeqJ8n.bI2COzciraGKsWwUkbJxvzD1tm ORjoMJ4_vZ6_jqYA.lHoV1ck7uTQMrhGkpncEMYVlvV5zBtHcH99bLk3Sk2kX2Sep.hhm7at.X_g exgjIvTtIv3s0N8UlAWgveafZEqiuvXAPNTk7vYysW8u7S3NAqP22BUjad5a_KAO7EZ3Y1rOmB80 hDXhX8yew2ph46E3GzXHleEtpETvkhWf1N5zYM0k10X_6aF6.BW18yu_vwc4sa_krteo- X-Sonic-MF: X-Sonic-ID: d6fff480-12d3-4327-9c80-63c2d79c240f Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 12 Aug 2023 02:22:49 +0000 Received: by hermes--production-sg3-69654d8bd-l9pxw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7e40d9277b94b54749d6447bd5e40995; Sat, 12 Aug 2023 02:22:44 +0000 (UTC) From: Po Lu To: Rahguzar Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on In-Reply-To: <871qg9d4mp.fsf@zohomail.eu> (rahguzar@zohomail.eu's message of "Fri, 11 Aug 2023 16:39:22 +0200") References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> <871qg9d4mp.fsf@zohomail.eu> Date: Sat, 12 Aug 2023 10:22:39 +0800 Message-ID: <87pm3tov80.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21695 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 311 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rahguzar writes: > (set-window-start nil desired-start) > - I tried to fix this differently on master. Please see if it resolves your problem (and other issues with scrolling past large images.) As always, keep an eye out for performance regressions. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 02:56:18 2023 Received: (at 65214) by debbugs.gnu.org; 12 Aug 2023 06:56:19 +0000 Received: from localhost ([127.0.0.1]:48568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUiXq-0003qo-Hr for submit@debbugs.gnu.org; Sat, 12 Aug 2023 02:56:18 -0400 Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUiXn-0003qZ-Jx for 65214@debbugs.gnu.org; Sat, 12 Aug 2023 02:56:17 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1691823372; cv=none; d=zohomail.eu; s=zohoarc; b=HnWCluEvAVN/wdzsrgHOxi3THK+XPtjzRLIUPtSb6wV44yCcGiJY7GPN2kPYQJePVrKneWGOzzBPNW4Kqw6/y5nB8NLlTLhRvti01Xd2gqUPuRds8hTaDaVYDXQhRgSJgngvBOgeDhaL05d05iSgr7A6pfMA1Pf21V32r/mcCiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1691823372; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=lDYLUQ4qk4OkVxGuuLEyFgCYgHLAUN/To3a/qFNbVHM=; b=JQDlZHoha58t0qBcJsiI4zBEyIZdcejouF3Vfal3ayO51D0J0gy7FyC+c3Lv85SiKbCs9CS+Xi4FMXuEJs5hGlewKR6YBJegLDQODX6OAObQsQxhSjKTOsIulr4mnWnI3izCjjuJebhZtIMHsHPrWyEFV2cBiq34p5rAPJH+n/M= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691823372; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=lDYLUQ4qk4OkVxGuuLEyFgCYgHLAUN/To3a/qFNbVHM=; b=MNlRjnZj6dOyFlHPEQcR+Cad24OjtLtTaGXmIwSb7crOmBjBm4U7eIseGXoEpvCz Vv+Lge5NklABE6MMPBQoE5egZQrnPoBfmB/ceV8DOldlkpUsgqLgG8XXghlSEtk8Fcv AAvXrVaegpo2+v4XdnG7TAVY7tcF3FVDd61UTb78= Received: from localhost (81-231-79-170-no600.tbcn.telia.com [81.231.79.170]) by mx.zoho.eu with SMTPS id 169182337096364.60476482175795; Sat, 12 Aug 2023 08:56:10 +0200 (CEST) References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> <871qg9d4mp.fsf@zohomail.eu> <87pm3tov80.fsf@yahoo.com> User-agent: mu4e 1.10.6; emacs 29.1 From: Rahguzar To: Po Lu Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Date: Sat, 12 Aug 2023 08:50:12 +0200 In-reply-to: <87pm3tov80.fsf@yahoo.com> Message-ID: <875y5kn3zq.fsf@zohomail.eu> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Hi Po, Po Lu writes: > I tried to fix this differently on master. Please see if it resolves > your problem (and other issues with scrolling past large images.) > > As always, keep an eye out for performance regressions. Thanks. The issue is still there and can be reproduced by evaluating (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) (height (* (window-text-height win t) 2)) (file "path/to/image")) (select-window win) (erase-buffer) (insert-image (create-image file nil nil)) (goto-char 1) (pixel-scroll-precision-mode) nil) The resulting image cannot be scrolled. In the new code this is because vscroll is reset to 0 inside the binding for `line-after`. Commenting out that line allows me to scroll the image. Rahguzar From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 03:25:19 2023 Received: (at 65214) by debbugs.gnu.org; 12 Aug 2023 07:25:19 +0000 Received: from localhost ([127.0.0.1]:48637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUizv-0004u1-6l for submit@debbugs.gnu.org; Sat, 12 Aug 2023 03:25:19 -0400 Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]:41919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUizs-0004tk-ED for 65214@debbugs.gnu.org; Sat, 12 Aug 2023 03:25:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691825110; bh=GCicvgiAHkfS/VZ2LPT3vhhIjKxVjP3wUtnY57tWbTw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=KZ8fMme9vgWX61TPVPax3ui5QenK+UJxRAIPp+B9s0TZ/6AcRM55s7uP2ACcU/HsPLDaV1Yqh0+ZJoTcjP9P/TcotGyS404BaZcUaKXqWGIDilpHJUawKMk3iWuLDUB0ftaadRePbxx6yf3VESFaBUrcTuUc6mWpDMUoYg0wrwlMGQjbNQCQUu/X+RhUguxlsHboKew1tUDXUJ6O+do1p9qgDwXxSHND4JshbudxjfQOt2dHotT6oD5X2YMCu9pG2d5boxAEJc2pDUW1BciIHXrEDYY2uLThm50yqsghLuNQkWjYnTQYgvaYXPg6BUgV1JHe/FidPKrxuqQsrz2PEA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691825110; bh=gT/21ZlbK6xtneUW+ZdwGxXSNdpGbRTiIzqxcTteh2E=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=mg9BXu/OdtcLPVmLP9LuaBrYwRGfZNumiaqMHDBHeoR7TzZCXfIqQJt3cIsM30WNJ04ZiRzciWJkw8couQ6FhV+C7KUl1gIXffY8PwQqpM+Gvozrp2VwaFFaiXUMMKNwB6kj6LL4PhJHZc90+X4y1y/pkHkUv5LU76YB4l4inWjsLJu8+p5i3XIey/65B6aS2ceKrMtYItXePZb3PK0/LNF1fjNwBlxgUz7338AU4MPMacZIfsf61kam669W7D0bxIQWISyldW4B88PppesE4qgyQa6Zu2sYKm7+MQ5WMs13j3Vw2kejk6YL5VWGtiZ5LarbanF3zt8eZhRoDEvrFQ== X-YMail-OSG: yC1Q284VM1kE943m9tPf5q6COgXdbsj3ymZ8il2vBCjglchJvdgWcjaRcZ3WPB1 JMWrP70VeGWwpvFGAFlgQXUF_P79q3f4tcZyDbMPh2VkIXG3TmEXyk6JZH1Pzp8MWG9LTaBmqpou To2_4TzeVT2lJy5BR3pUJ2clGPj5p8FzeYqOaitVys3IV_8bKLNDT8qFZdQjvtIE3a3cICTdckMM yPT09IqfpZCScaZWFfePjLoRDLV5AL4__XX3O4QITkoOkiD9m71luRa81T7F3mPOD2DEYmmEVtqi LC.OxWUrHOFRexFWU1Up3e3iPJCAEBrwJYg6OALYHj7rLK_foSMmEZx.HE4cKPAXe7AkbCfMIN6J MpHHsvhNzZ842OnLzFWb2vqPJbgyaAkEyW9.gk8qY7bjhif9l8XZ7.4zidbUqREaWmmDdhzIop99 OjuF3Yx4FCa3m61fX7cBLwo1JSwNNnvax89uuCnNF2mwcOj51IYDRZsPgkOByr_DZFzTEtQlGIyS CZVlvIbX76vFcC_hUqx3TBiQ7t9N0uVRiRPMp2DMlfGrD1PNdnJ7XX3HXK_Su.QEr3MV7X4s1tUi Y93hIe_FpgAvgekUe4RWGYl8lQ_blPLTdoJOSbVD5.wtEe8RgqY_XSxvdCRQozSXplEmN95_0kaD hCAMgAtOO6cV3Z2DtoA4R5w0uzkl9ZAtfNWlFddr1GKGMzo5themZzJ.6_6ZnzqGNCRHyCk2VV5k Tu7FBD2zaOiHNQGJ0YGUJhUJBa9B7MRXg2bPaFlNAafJA..tTvzQgJMCgnW4_4GpqciVnmnB49x_ GB2DVTfkV7r48NQQ75IuJqYW5fbbDli1J7xAqz1eOpu01ixg6VW8STr.sq.lRvBFT7R_22Ut3F1z FWCdtTXF6Ci_4DoHuvJNYUpzcAXzicDNLlOoBY9KGJy8cpkabqPLHj1Nu95tFn2S6tT1FanMAF1D DCr4YVG7rsybvYfWljHRyMEmJXd4nWsD5i9aCYnr9g7GULhGTMIfg94DSDtpG19IO6_DYmhBUy9L 7oWcK4mbH5Bb_hntDvybksLaBRCEJMrZLlG1Gufsw_0GH60KAffFS7Z2cEvWr96jqhLaAbGpdrUS BchNHKb4XBg_3VRwZWN3hRPA.sgzqP8PZZ6Hwry7NOxilu49RDLq8Kb8JaoPZg0vDUFS_aY9uZ9B 8W0LbK2253VXHyMnvawOR5.MBVV6uEKNKrzneECjY4Q_H0iJRGgf3AIjz1JMm9j3uiDLolhQ8Y5w D02E08YPX1km2FF5s.7sa80ro8j8WdBDpmQN82ZP7Uk3nynDNG_Ii18ZOBu0pVUQzNjSZnRrUKb1 fKyjZb5T6cCNHBvicgRrSpQWcaZFiujCu0NhRLgUCXyICxYBDVHqbM9YCLC_MI5NAMwLcy6hKOCW _zlXsL228RPlC4pETyhzTwbaN.7sq0HqshM3ZphOpqOBcYgSVl_CZKwSPo6xHikQbJxQ_cX9.906 dDzndp9tpeiAygP.Vyw786uLopVEbXAPRdj24PV0VQqPU2CQVaGKZAi.icovLqnuWQWt3MSU_P7l 5xCWFxl5qJ_niaaZvOQoOnwM9VPPCNkLU97_CtBEZbn1RDty5fpR2U1i0ViJ0c77bTxb7t7b0bBR P.bo7RT.WCNdnWAX3IwTvdn7mlnjgicB3vNjv3XPpbTFowaFgaLQbq.XGIO5BiXcSnMhkQ7vTedE kQloHXKf0jIpyfCJRyVxupIZSCYtQTbF_cGjCsIftt1r4F9CENlM_XAsPVwxCTj2bkygU9Ps8tva EIHpJGZEOQYyIvdbExshqBwgXR_pmUEzhb.HDLSo2VquePO.VpMd.wgeD1N6tL3AzvL47NA9Qxwm SxPRG9iyxVD_Opr5MMDGzo6kgNi1c4R1YVmT6zkUuVXbXduVhHNHOllU..kttAxMq2hX0z3S3dAg HB450qzy_gDeVMG8etL4S1y607XIcCKmP7Rpm5KaLf5VgeTMnq_OMfLN1ivCgOcDdvFKRoj1uZh_ nmHa.D3pDZBe_iTvxu6f52g8Bf0nXfhEkIexTAAx8RDNXXnLySadj1DLkvz_aXbbDUYPUMCbxfJY VyjsQCQSrLV3DkJTSFMp_pVS8XxKFL6IkdxbrWD7tzBlQEtTuT._V8xxELyijVU1cGxCgQJpBtnb pyDj.RI1SF9MT2DtfBdyTnn23JKbtCE1mn2kU1dgJ3UefFU0np3mHe5AChsPYHLoFT3X31NCOhLQ 3tJHfHdduvUxAXNuqN_uWf_2cwOza3ybghrEdnSTs6MER2w3AJoGxwPyMvEaPi1cC X-Sonic-MF: X-Sonic-ID: b6fbedf5-7fbc-4ade-bdec-e25dadeabd3a Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Sat, 12 Aug 2023 07:25:10 +0000 Received: by hermes--production-sg3-69654d8bd-hj7c9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID bd8fec83af96f8f72d2662510961a441; Sat, 12 Aug 2023 07:25:04 +0000 (UTC) From: Po Lu To: Rahguzar Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on In-Reply-To: <875y5kn3zq.fsf@zohomail.eu> (rahguzar@zohomail.eu's message of "Sat, 12 Aug 2023 08:50:12 +0200") References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> <871qg9d4mp.fsf@zohomail.eu> <87pm3tov80.fsf@yahoo.com> <875y5kn3zq.fsf@zohomail.eu> Date: Sat, 12 Aug 2023 15:25:00 +0800 Message-ID: <87cyzspvsj.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21695 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 2724 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rahguzar writes: > Hi Po, > > Po Lu writes: > >> I tried to fix this differently on master. Please see if it resolves >> your problem (and other issues with scrolling past large images.) >> >> As always, keep an eye out for performance regressions. Thanks. > > > The issue is still there and can be reproduced by evaluating > > (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) > (height (* (window-text-height win t) 2)) > (file "path/to/image")) > (select-window win) > (erase-buffer) > (insert-image (create-image file nil nil)) > (goto-char 1) > (pixel-scroll-precision-mode) > nil) > > The resulting image cannot be scrolled. > > In the new code this is because vscroll is reset to 0 inside the binding > for `line-after`. Commenting out that line allows me to scroll the > image. But as a repercussion, scrolling past the image will result in the window being vscrolled indefinitely. That is unacceptable, because redisplay grows exponentially slower as vscroll increases. Is this compromise acceptable? It will enable scrolling within the last line of the window, but will reset vscroll entirely once the window start becomes invisible, resulting in a visually disconnected ``jump'' back to the top of that line. diff --git a/lisp/pixel-scroll.el b/lisp/pixel-scroll.el index 488f6781254..8961f196ec7 100644 --- a/lisp/pixel-scroll.el +++ b/lisp/pixel-scroll.el @@ -543,14 +543,18 @@ pixel-scroll-precision-scroll-down-page (let ((line-after (save-excursion (goto-char new-start-position) (if (zerop (vertical-motion 1)) - (progn - (set-window-vscroll nil 0 t t) - nil) ; nil means move to new-start-position. + nil ; nil means move to new-start-position. (point))))) (if (not line-after) (progn (goto-char new-start-position) - (signal 'end-of-buffer nil)) + ;; If vscroll has resulted in the entire line being + ;; scrolled outside the window's text area, set it to + ;; the height of the last line. + (let ((visibility (pos-visible-in-window-p new-start-position nil t))) + (unless visibility + (set-window-vscroll nil 0) + (signal 'end-of-buffer nil)))) (if (pos-visible-in-window-p line-after nil t) (goto-char line-after) (goto-char new-start-position)))))))) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 06:49:53 2023 Received: (at 65214) by debbugs.gnu.org; 12 Aug 2023 10:49:54 +0000 Received: from localhost ([127.0.0.1]:48804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUmBt-0005oS-Fw for submit@debbugs.gnu.org; Sat, 12 Aug 2023 06:49:53 -0400 Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUmBr-0005o9-Mx for 65214@debbugs.gnu.org; Sat, 12 Aug 2023 06:49:52 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1691837387; cv=none; d=zohomail.eu; s=zohoarc; b=HzTe3cYod9AzfWWa8QI1FT7cjr8mubPyaf1FcaXomtXusGwMJiGojzQRyN6FZZylnlwK2HOcJhFvBkH4RyC8PmY5FxInno+xKAf/b3qjRwEOuS+WQ+KTu/E5k94gDkbfCfS6Nu5RmMn3vWlnALkKj3LQayRLZUsqZrWIiWgHZY8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1691837387; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=rWmR5aKfw/Iqy8ComBvligGDoARZSEdSqB663Rob2Cg=; b=XMwjb+yRh+ZtwOSilxvZSadvJ2rp3GTFduXoeRfMoIWodxIqi40686z3Z+Ixe7faLKw0yUQVEULetFUjvIh/HLX1rtHVYyjmwdZrxvl5Xcr/DCz5PWOIQxsPSdTcxhugI7ynFS4TrnoTMSaKYj6Q3dVNyRScBkY8Ez4CoGE+9Pc= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691837387; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=rWmR5aKfw/Iqy8ComBvligGDoARZSEdSqB663Rob2Cg=; b=GDKGEfz8ix7F/lgKle4BAv4ClzMSC6z5x/iuxadVkhuhKy8FSrx5FsN7+ZKQS4DQ Iz0gAVkCB2uTCoA/qlwqzewnaQZH0z+0h/ZHkeDbRNzWm9V83bCgtwqCmDNq+WCIeLf SjvE1W/avl7DwyNn2Bt1p1JWCWGN2Tyvd0mr/qR0= Received: from localhost (81-231-79-170-no600.tbcn.telia.com [81.231.79.170]) by mx.zoho.eu with SMTPS id 1691837385541638.0361169182298; Sat, 12 Aug 2023 12:49:45 +0200 (CEST) References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> <871qg9d4mp.fsf@zohomail.eu> <87pm3tov80.fsf@yahoo.com> <875y5kn3zq.fsf@zohomail.eu> <87cyzspvsj.fsf@yahoo.com> User-agent: mu4e 1.10.6; emacs 29.1 From: Rahguzar To: Po Lu Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Date: Sat, 12 Aug 2023 12:43:58 +0200 In-reply-to: <87cyzspvsj.fsf@yahoo.com> Message-ID: <871qg8mt6f.fsf@zohomail.eu> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Hi Po, Po Lu writes: > Rahguzar writes: > >> Hi Po, >> >> Po Lu writes: >> >>> I tried to fix this differently on master. Please see if it resolves >>> your problem (and other issues with scrolling past large images.) >>> >>> As always, keep an eye out for performance regressions. Thanks. >> >> >> The issue is still there and can be reproduced by evaluating >> >> (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) >> (height (* (window-text-height win t) 2)) >> (file "path/to/image")) >> (select-window win) >> (erase-buffer) >> (insert-image (create-image file nil nil)) >> (goto-char 1) >> (pixel-scroll-precision-mode) >> nil) >> >> The resulting image cannot be scrolled. >> >> In the new code this is because vscroll is reset to 0 inside the binding >> for `line-after`. Commenting out that line allows me to scroll the >> image. > > But as a repercussion, scrolling past the image will result in the > window being vscrolled indefinitely. That is unacceptable, because > redisplay grows exponentially slower as vscroll increases. > > Is this compromise acceptable? It will enable scrolling within the last > line of the window, but will reset vscroll entirely once the window > start becomes invisible, resulting in a visually disconnected ``jump'' > back to the top of that line. > > diff --git a/lisp/pixel-scroll.el b/lisp/pixel-scroll.el > index 488f6781254..8961f196ec7 100644 > --- a/lisp/pixel-scroll.el > +++ b/lisp/pixel-scroll.el > @@ -543,14 +543,18 @@ pixel-scroll-precision-scroll-down-page > (let ((line-after (save-excursion > (goto-char new-start-position) > (if (zerop (vertical-motion 1)) > - (progn > - (set-window-vscroll nil 0 t t) > - nil) ; nil means move to new-start-position. > + nil ; nil means move to new-start-position. > (point))))) > (if (not line-after) > (progn > (goto-char new-start-position) > - (signal 'end-of-buffer nil)) > + ;; If vscroll has resulted in the entire line being > + ;; scrolled outside the window's text area, set it to > + ;; the height of the last line. > + (let ((visibility (pos-visible-in-window-p new-start-position nil t))) > + (unless visibility > + (set-window-vscroll nil 0) > + (signal 'end-of-buffer nil)))) > (if (pos-visible-in-window-p line-after nil t) > (goto-char line-after) > (goto-char new-start-position)))))))) That is much better. Thank you! I think even better would be to replace the (set-window-vscroll nil 0) with (set-window-vscroll nil current-vs t t) but that doesn't seem to work and the entire line scrolls out of view which I agree is undesirable. I don't understand why it doesn't work. Can you please explain why if possible? Rahguzar From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 03:55:55 2023 Received: (at 65214) by debbugs.gnu.org; 27 Aug 2023 07:55:56 +0000 Received: from localhost ([127.0.0.1]:44036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaAcl-0002oZ-FS for submit@debbugs.gnu.org; Sun, 27 Aug 2023 03:55:55 -0400 Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaAch-0002oL-No for 65214@debbugs.gnu.org; Sun, 27 Aug 2023 03:55:55 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1693122942; cv=none; d=zohomail.eu; s=zohoarc; b=Ab+MPGSDS+Ndzkie5w5x8dKxuX0+AadsiEF/o1lLRWfTN/hjTA/ieDO/JSQVxIf+QWt861nq0htPAC2JMY+UkB2IBFbwGIek9k+h1ktlCetttoYCrdMrhQtQEMejpiL5RHQm84D6rMBlKQpret0ybHXXE1HGxZXM9yEWPE7AnFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1693122942; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=+6t6c2gSLHjj+NBPnXYsL63tWStJd3DRXtVDX52T/yQ=; b=aVhqcgsqDZL3dzQOJoFh+FkduD5/uwOg6Lxr2giOe6T55oBtiTobHmjYskKlDSN6o8UL6QpvMaRw0qtvp1LkhVlDV5CdgFIj2DgoiAGSDJH2p9q8aKH4VaP6GFLu/lY/gkTsmjdiHpkFcWe2Au1w5yy8MtG4oHuGBkXtrTn886E= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1693122942; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=+6t6c2gSLHjj+NBPnXYsL63tWStJd3DRXtVDX52T/yQ=; b=atGd0Jd7sNO2civmDfN+gtWFggYsPxTWzacf/G7sIu/UanWNSaWCeR9Chvrzi8hh CKKbAwFWstvOMqeq2lmWKnknKy4EAxM/M/le/nyTNnCwQBx1UonIADwkVufmw8d5WG/ Ix+A/mSt36IKyHJf8fVfF6j1Dw8jrRaDvWJQGgjA= Received: from localhost (81-231-79-170-no600.tbcn.telia.com [81.231.79.170]) by mx.zoho.eu with SMTPS id 1693122941130328.2298973197966; Sun, 27 Aug 2023 09:55:41 +0200 (CEST) References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> <871qg9d4mp.fsf@zohomail.eu> <87pm3tov80.fsf@yahoo.com> <875y5kn3zq.fsf@zohomail.eu> <87cyzspvsj.fsf@yahoo.com> User-agent: mu4e 1.10.6; emacs 29.1 From: Rahguzar To: Po Lu Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Date: Sun, 27 Aug 2023 09:53:16 +0200 In-reply-to: <87cyzspvsj.fsf@yahoo.com> Message-ID: <874jkkc41v.fsf@zohomail.eu> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Po, Po Lu writes: > Rahguzar writes: > >> Hi Po, >> >> Po Lu writes: >> >>> I tried to fix this differently on master. Please see if it resolves >>> your problem (and other issues with scrolling past large images.) >>> >>> As always, keep an eye out for performance regressions. Thanks. >> >> >> The issue is still there and can be reproduced by evaluating >> >> (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) >> (height (* (window-text-height win t) 2)) >> (file "path/to/image")) >> (select-window win) >> (erase-buffer) >> (insert-image (create-image file nil nil)) >> (goto-char 1) >> (pixel-scroll-precision-mode) >> nil) >> >> The resulting image cannot be scrolled. >> >> In the new code this is because vscroll is reset to 0 inside the binding >> for `line-after`. Commenting out that line allows me to scroll the >> image. > > But as a repercussion, scrolling past the image will result in the > window being vscrolled indefinitely. That is unacceptable, because > redisplay grows exponentially slower as vscroll increases. > > Is this compromise acceptable? It will enable scrolling within the last > line of the window, but will reset vscroll entirely once the window > start becomes invisible, resulting in a visually disconnected ``jump'' > back to the top of that line. > > diff --git a/lisp/pixel-scroll.el b/lisp/pixel-scroll.el > index 488f6781254..8961f196ec7 100644 > --- a/lisp/pixel-scroll.el > +++ b/lisp/pixel-scroll.el > @@ -543,14 +543,18 @@ pixel-scroll-precision-scroll-down-page > (let ((line-after (save-excursion > (goto-char new-start-position) > (if (zerop (vertical-motion 1)) > - (progn > - (set-window-vscroll nil 0 t t) > - nil) ; nil means move to new-start-position. > + nil ; nil means move to new-start-position. > (point))))) > (if (not line-after) > (progn > (goto-char new-start-position) > - (signal 'end-of-buffer nil)) > + ;; If vscroll has resulted in the entire line being > + ;; scrolled outside the window's text area, set it to > + ;; the height of the last line. > + (let ((visibility (pos-visible-in-window-p new-start-position nil t))) > + (unless visibility > + (set-window-vscroll nil 0) > + (signal 'end-of-buffer nil)))) > (if (pos-visible-in-window-p line-after nil t) > (goto-char line-after) > (goto-char new-start-position)))))))) This is just a ping. Any chance these changes will be part of Emacs 29.2? I think they are a big improvement over large images not scrolling at all. Thanks, Rahguzar From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 04:16:36 2023 Received: (at 65214) by debbugs.gnu.org; 27 Aug 2023 08:16:36 +0000 Received: from localhost ([127.0.0.1]:44056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaAwl-0003MR-Qg for submit@debbugs.gnu.org; Sun, 27 Aug 2023 04:16:36 -0400 Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]:39928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaAwj-0003MB-FQ for 65214@debbugs.gnu.org; Sun, 27 Aug 2023 04:16:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693124180; bh=HjdUy9/Y3qAIhjBU8h8KUZNvi54xuQ3HWkT8d5WJz48=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=eX+Kpc3iEFfc68BWX1iNsZWPv2VTu9VLPbrOzhlKKn7CmIxzEiypdxBpBFvzOZTzdlJxsHW1Z7QnAUXs4kNrP60aNhemYFORpiCV5rBZom3NgETbJzCAkLJAcPkqFuDkIPgqBChY/jpqBSlIAmUvrGOarU2UUzlkXA5RCN1oXI45zYvvQPnRgaEwtg46OH8CZPA/PR+I3wfese5tk9/Vnm5HSIvn2UejF5gbgGdIEbBsWjSQpkB423Tu0NC2kqnnqpfNQd/lCQiSdufewjduvjfzaq5W48vbbtPZtD2i7WS7m7Ji0GOmA1kukN0elFcMOWRnYNYOH/VpOwlgaK4goA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1693124180; bh=AJm86N5uhwkali8RHAmjwKRNOO5+ra6FIBFeXxoAxQq=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=L0l6oQkvWQiMVFQz1PAiJfqFvo6XPki6EAYjZazXgKtHSMVO9D78kcdW1ca7qNGZzUbz/NmLcvgdBxUO0LsTy9MTLh5lD//bEZJFUH1cRqn28PZFKXtbNwoWyhCjmi/7OK26+OT5OhbnGPAFT69j50VBgFU/rLB2Pq/zcgSDQGFiUTgI5JEL0UqIeLI9hZdtJKDDYcNZI3HoDOuvVBjPAuxu0G/9SCblBODhROAKzjWRWNp1e4yIBJDxbJ/4RwI5xDlmzXTeQxS7J/+L6XK/0+KptSYMbmX4dEVJuViQwghW36UPwkKc47LX9dxagIMTXiQ6UvApeMHeA4yeFyCeNA== X-YMail-OSG: NYREiHMVM1leViMWKMNsphpewqzWO8osat5sfK7LZi1Oz.nh6fs3Bvc1CeqwjyS kHN5mqtKWZrd0tbVeFe55T691q0oBuMf8_Ihtm5FWv0BRbIzZiSinlrj0liy6yDeBtdTAon6jUA8 KnFcHuu7_THPNX6JaRWk_AZ9Yswqc93u2h9BRbKA_hy4Tw_7MovjTDrxCRJKukP5vy9f8.OfMsUm pjRcbxIcw8G5uQiJ.K4rDHFr8I31qdHeCbZx4HG8ljHXPJ1zPwBAGaI9Vu_YonAjUUU7_40dLjey F0yR4CtPTvl5YtCatNSOfvuQmSIOeQ.NIAotM6xpyDKIPaJK1pCe2_wPMop6qMEnrsWdI9NB9IeS .ji_7d3aN_RO9tg64TqzeUi9auW9Rak6HfBgpp19KFNRWFkIojBzX.XavMP9FOsp0_zU_SlI6KZn xLW1yvIfZVkujkCLuSCRhWOLGP0GShrfn82FJgrgcwFeitJshCIfjoz7HldObIk.hqFr031Rw7_K Hpapb5No4.Y_Gvp6TsoVbuOXpMK0slbKEyC_JpdIsAhYsiEt5PGTjwH9fcpmjcTKuv0U2jbABJCV iCr_IlbbOm2gBK2y20ArcEmyrWjYYnLok1FuyZ7Fnb8TzGzz6P9Zv7drw3wxImLRTWtyw94.z33O bdgLjp3EXmIGQlGLFfXcE_NqKPS4ZI34.4.wk28Kb7PV.Y7jJ0vJriGAqCrPMVpT4Yvckxxu9W.m qtJlUnkXxmYcbOaGimnVdww3V25lJPWBVN.0k0hCqX.JlrxXBCF_puNphhf5AhB.1ZMenJ9Frz8W o4OiBOPjZYY1FOh5BPMluzoz3CV2cBcgTsjeRykfW7hpB0C7WMREKXS5gikRAPn8Gyuvm8jpIjf0 uO328mqZdhlxB9qfSvjGLcyDCrAf1a5cjt6fNwpf9MGyjD4GlvBUUvvbzDGr10BZUGoTzATIHCRC TPunYiu1rq1I6Po1BCbFM90zMLMXSRNZyLTJU3G3Mnxn3UVrjsbhIVlbX4gRPXYVY_Lopw2L.fjU qkOl57GNVzOp4lZ6zKWyB24rotJhkutsg.FY9XGpYKbUD9uxyBZN2MmYTMQtL4M3knpjg9l932KK EHReLAIfDxvzVHzxdt1IRyVepMLEx6RnjlQgkuXXqYL9on7El3uClVrCMVlxOhc8SSNRgQ4bzakv f2R9Lw02iYLYFSHV3fpgeXiM2A6CCu4nxsTWVStHkz_f4208EHbOAURG4VlBLk6EzGEAYBfzxaaG pjrfGiyPYstom03dPPCy8hCF9QbkAP4Nwrwpf43E0lClHUTO9WlL_9ojG_Wn.sGd9vIJwhEMMe0w 123Ov1aY6Yb498YNLj3U.K_Uaq_nVRTIHnWIIEWt680qG_fJVGhDOBf5iPSYtA_NnXhltPB1iFj6 cyBz0FZYD8_JNpvlVD9U6iO35QPqPaVmj6KSZxWCjB6z.7h.n9W1ZvpkP7BDw.1ZVV5x1Xl84boa v1Tvrnz5Jp88Ylt_i89HG.eLJ7f7rOH4046FTRhKAFeSWtmWl5ctZewIuJFV6ik2iuFGetxBPPwk Lr0NlYsnYS3oGnjZ50Z2lOSyCog416LUkt.Up4fYOxoLRJ3kXAjWYoJFUOy.70HUxdMHawZRKFCb AZZLnbTfADv_MFxJ82oHj9W5vEGLEEGk656Jr86SCHsi3tYfTlrlU7V2kpwqjkm7F6JR4b1wzpMq Ls5FJ3uv_JpzhDXBZe8pRZzXCs9E1rt6icCZesvJCUHEC5unHIiU1icmxxPNi6hiBUANYlHcboB6 ZTHCqbdC1Yla.SbuLvvecq7ZoLUJvQYFukcseCKX1ZnZXxY1ksyq7zDLEKDE0q2M.Z.e4OxctImV tHRMzIRvtUrhoBYpK4VI8MbRD1gOtUoQIAgc1x_Y7hjN90cIl9fwgucN4ydSIUuFPjGxrmiVfc.v OEXIkGFxwn8sjfi1cvuXxQAnlgZjcTRHGMEyVz.WJ31a3I8ouS1vSkOqt8r8dwLVgdDlyqScs_Qa jTPA84PGhZG9bhG4TMg5JTkNO43Gx2UEPph3StoRWaF7stXhaTLLSpKXsw2DYkbjDdwMIM663FOd JLWLTIVjq4jQmjSewuTPqPw10i4CGLmzOZ3r4.MkZUM2Hqmt2foj9LWJnx2Gm7m4WtY5swtLNM.W co287wXFkcvFrkkideoEA94emhI0XOyTr3MOaPwQzxPX95jXiCArxnQnT58_7iJYYsDekpQ884hv Kl43PVyarN1S7JPThbRQA8gilJbJiN_YrebHMj0zbEnoSKPGcHwnCl26Q2TgTHZNsRF4bnmjm X-Sonic-MF: X-Sonic-ID: 68591712-b5f4-429b-b743-91d2578a215c Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Sun, 27 Aug 2023 08:16:20 +0000 Received: by hermes--production-sg3-69654d8bd-d8v2r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9d8ac9346ad311d1d1abbc5568c60767; Sun, 27 Aug 2023 08:16:15 +0000 (UTC) From: Po Lu To: Rahguzar Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on In-Reply-To: <874jkkc41v.fsf@zohomail.eu> (rahguzar@zohomail.eu's message of "Sun, 27 Aug 2023 09:53:16 +0200") References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> <871qg9d4mp.fsf@zohomail.eu> <87pm3tov80.fsf@yahoo.com> <875y5kn3zq.fsf@zohomail.eu> <87cyzspvsj.fsf@yahoo.com> <874jkkc41v.fsf@zohomail.eu> Date: Sun, 27 Aug 2023 16:16:06 +0800 Message-ID: <87msyczyrd.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21763 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 413 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rahguzar writes: > This is just a ping. Any chance these changes will be part of Emacs > 29.2? I think they are a big improvement over large images not scrolling > at all. Alas no, by reason of our policy against risky behavioral changes to the release branch. I have asked several other users of p-s-p-m to comment on this offline, but am still waiting for responses from some of them. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 05:07:02 2023 Received: (at 65214) by debbugs.gnu.org; 27 Aug 2023 09:07:02 +0000 Received: from localhost ([127.0.0.1]:44156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaBjZ-0004iJ-Md for submit@debbugs.gnu.org; Sun, 27 Aug 2023 05:07:02 -0400 Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaBjU-0004hq-N1 for 65214@debbugs.gnu.org; Sun, 27 Aug 2023 05:07:00 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1693127206; cv=none; d=zohomail.eu; s=zohoarc; b=ILlINV+RrRNlS12UxiQ+a6VqDkLMnBB2lOggPVXjKONMRg+FqPdiVUegNyAH/suvICdRgCNfCbGSAar7O13XsVQFjSTVD3SEkTAnoCik+ZVeHfVY+YwaklIb9k13LgSbea9LeE1xdWWxbuf3VPrhq6zx8xpjLFzvulHDb4aupjk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1693127206; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=vREwCO1KmEE6pfUA6WuoVqHWG0M8zEHMIRjNQvNViWo=; b=URSGBDsubgW6OkABWtyziR/maO9kySVA8LbpK8iAp/4DT0iQlEfrvPR9aITztym5ZGMi2FIkFSLlJ04iLShbVP7PvVh1rewVzvdf6+A9b6yRx+LmZQd7h3z0FemgF6+ZUXuMvQ8t3msm8yWm0HTe2H14qatTI6PIWZv377yEOi4= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1693127206; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=vREwCO1KmEE6pfUA6WuoVqHWG0M8zEHMIRjNQvNViWo=; b=HCNQXanmvidb9SYwlXxwNrF3K8vmokXCpGlnLzzzgObzDvsrOeHqAtd5AX//Q0jA oepK2tepEGmzb5EQz6qqG9/70BErv+MXnGKolAEco7O0OJDVfxcfR2CxAVtIUMa3Mt7 N4iswQQz/hgboIyaBl/6ovLT+zl8F0848Hmq9xg4= Received: from localhost (81-231-79-170-no600.tbcn.telia.com [81.231.79.170]) by mx.zoho.eu with SMTPS id 1693127205511825.4427089765753; Sun, 27 Aug 2023 11:06:45 +0200 (CEST) References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> <871qg9d4mp.fsf@zohomail.eu> <87pm3tov80.fsf@yahoo.com> <875y5kn3zq.fsf@zohomail.eu> <87cyzspvsj.fsf@yahoo.com> <874jkkc41v.fsf@zohomail.eu> <87msyczyrd.fsf@yahoo.com> User-agent: mu4e 1.10.6; emacs 29.1 From: Rahguzar To: Po Lu Subject: Re: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Date: Sun, 27 Aug 2023 10:53:20 +0200 In-reply-to: <87msyczyrd.fsf@yahoo.com> Message-ID: <87zg2cam70.fsf@zohomail.eu> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65214 Cc: 65214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Po, Po Lu writes: > Rahguzar writes: > >> This is just a ping. Any chance these changes will be part of Emacs >> 29.2? I think they are a big improvement over large images not scrolling >> at all. > > Alas no, by reason of our policy against risky behavioral changes to the > release branch. > > I have asked several other users of p-s-p-m to comment on this offline, > but am still waiting for responses from some of them. Makes sense, since the problem is in an edge case. Since it affects, 'image-mode' which is built in and also some modes which rely on the functionality provided 'image-mode' is it possible to go with one of the following workarounds: 1) Special case the handling of buffers with only one line. I don't know if this can be made safe enough. 2) Modify the 'image-mode' to have a newline after the image. It seems like a good enough solutions to me: as far as I can tell 'image-mode' commands just care about the fact that point-min has the display property holding the image. But most likely there are unintended consequences I am not thinking of. 3) Have an easy way of disable 'pixel-scroll-precision-mode' buffer locally. This can then be used by 'image-mode' and others modes. This might be the best solution since 'image-mode' has sets its own 'mwheel-scroll-up/down-function' to keep track of 'vscroll' and reapplies it when needed. As far as I can tell this bookkeeping can't be done with 'pixel-scroll-precision-mode'. I think a non-default value for 'mwheel-scroll-up/down-function' is a good heuristic for when not to enable 'pixel-scroll-precision-mode' in a buffer but that might also be too broad a measure. Or maybe some other way I am not thinking of. Best, Rahguzar