From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 10 13:03:33 2023 Received: (at submit) by debbugs.gnu.org; 10 Aug 2023 17:03:33 +0000 Received: from localhost ([127.0.0.1]:43944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU94M-000292-1t for submit@debbugs.gnu.org; Thu, 10 Aug 2023 13:03:33 -0400 Received: from lists.gnu.org ([2001:470:142::17]:47642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU7Tr-0007qv-4m for submit@debbugs.gnu.org; Thu, 10 Aug 2023 11:21:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU7Th-0008H9-9U for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 11:21:35 -0400 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qU7Te-0008M5-5d for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 11:21:33 -0400 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-76cc4d495deso49104085a.0 for ; Thu, 10 Aug 2023 08:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691680886; x=1692285686; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=EcXGtn8s2IO2wOBrGCx1iRBkYS2m7HwIUXAoFjueiZE=; b=GbgH9pv61fIluY6LPCtCiMjl15F6t+dAEdQmwlk4+hwTC2G60AdiskcZYO5zS+B2w5 3SvgfKWTGOJLLGLZF4HZZpXKE9tcMuGbgVq+UQGERXmVPKJTCR7iVEWcptCKHQtSDxoA izDNAGUJDuzto7PHDfX3YessBV6eAtP8mYRZw7nwY94HMj5W7h3QkwHkbQK2gG1ihRZX p+Q3TRT1p5pD1WZZVmPC+rclXcMDiPv3Y6N02cgfzTILgNjZHssXow3iXctLOm6WHwGT cvJsxum/e/prrO2R25zPA7TGVm1XFKMLhZM40RlT9JKhTOH9RafXaiV3XtY97588T1VN zCwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691680886; x=1692285686; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EcXGtn8s2IO2wOBrGCx1iRBkYS2m7HwIUXAoFjueiZE=; b=VrW70ldpZwpjBC7cKssI4xRLgyY0lUBOkBVS8V+CUYe1fj4wE5iG1Q1egu23rVL+yL 1J3T03hpjsiLXW9KuOv44gM92yA0xMQUllbNX65GB1Lh8POxAvvo7dfqHE/UIaD2HJ5C Mnf2blJcpYKcQ3Vpl29DkrXETsWcBt+vNy17UWhuVKghaUbG/Vq683/42XLGi3QzWzxG o5xFaq2FrEAgmSQqGVzyCZUyq59JvEes2yF579vu+OFefxt0gQ8jfler5KmAN+EVbe69 IvxRsQ1DyZSBEr3Jf13RIxQr9JQkmJeaAWXPxZpN2+HLAWGsJ1Io2r171SbYbh1Y6w9b 7MCg== X-Gm-Message-State: AOJu0YyZsEkz0fb1CdTrL5JNBTA7U+nABiR2/ScyYcYVdYxzI7oeEPFt e8IlZ71/K8/T/AxqoVyGj8yBCo7pDmHnzQ== X-Google-Smtp-Source: AGHT+IHrQeKK7+40wuSCh1dM9DEd50XfOsX+nkwzTPlZYaZoPxka8z52eEbDfo6PF37Q2a4L8SYqxw== X-Received: by 2002:a05:620a:3189:b0:76c:ba9d:3ec7 with SMTP id bi9-20020a05620a318900b0076cba9d3ec7mr2971318qkb.6.1691680886130; Thu, 10 Aug 2023 08:21:26 -0700 (PDT) Received: from localhost (pool-71-105-109-55.nycmny.fios.verizon.net. [71.105.109.55]) by smtp.gmail.com with ESMTPSA id i15-20020a05620a074f00b0076c60b95b87sm547664qki.96.2023.08.10.08.21.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 08:21:25 -0700 (PDT) From: matthewktromp@gmail.com To: bug-gnu-emacs@gnu.org Subject: [PATCH] Substitute command keys in ielm-header at use time Date: Thu, 10 Aug 2023 11:21:22 -0400 Message-ID: <85wmy2rki5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::734; envelope-from=matthewktromp@gmail.com; helo=mail-qk1-x734.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 10 Aug 2023 13:03:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch Tags: patch Fixes an ielm bug In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) Repository revision: b28d44d4226497c4b2582bc15a59fc817eb3ce0a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: NixOS 23.05 (Stoat) Configured using: 'configure --prefix=/nix/store/ri7x0w6iqs38vr7vgwc76i9dwy5ikd8i-emacs-git-20230503.0 --disable-build-details --with-modules --with-x-toolkit=lucid --with-xft --with-cairo' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Substitute-command-keys-in-ielm-header-at-use-time.patch >From 4a09a067bd09987291081b5b42a3ba0125765f60 Mon Sep 17 00:00:00 2001 From: Matthew Tromp Date: Thu, 10 Aug 2023 10:41:24 -0400 Subject: [PATCH] Substitute command keys in ielm-header at use time Before, command keys were substituted into the ielm-header when ielm.el was loaded, which resulted in the substitutions depending on the user's current buffer instead of the ielm buffer. For example, if the user was in an info-mode buffer, the key would appear as 'H' instead of 'C-h m'. Now, the command key is substituted after the ielm buffer has been created. * lisp/ielm.el (ielm-header): Remove substitute-command-keys. (inferior-emacs-lisp-mode): Add substitute-command-keys. --- lisp/ielm.el | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lisp/ielm.el b/lisp/ielm.el index 5c370733c05..578422001a5 100644 --- a/lisp/ielm.el +++ b/lisp/ielm.el @@ -148,9 +148,8 @@ such as `edebug-defun' to work with such inputs." This variable is buffer-local.") (defvar ielm-header - (substitute-command-keys "*** Welcome to IELM *** Type (describe-mode) or press \ -\\[describe-mode] for help.\n") +\\[describe-mode] for help.\n" "Message to display when IELM is started.") (defvaralias 'inferior-emacs-lisp-mode-map 'ielm-map) @@ -615,7 +614,7 @@ Customized bindings may be defined in `ielm-map', which currently contains: (setq-local comint-inhibit-carriage-motion t) ;; Add a silly header - (insert ielm-header) + (insert (substitute-command-keys ielm-header)) (ielm-set-pm (point-max)) (unless comint-use-prompt-regexp (let ((inhibit-read-only t)) -- 2.31.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 03:16:25 2023 Received: (at 65213-done) by debbugs.gnu.org; 12 Aug 2023 07:16:25 +0000 Received: from localhost ([127.0.0.1]:48625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUirI-0004d3-RX for submit@debbugs.gnu.org; Sat, 12 Aug 2023 03:16:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUirH-0004cj-0y for 65213-done@debbugs.gnu.org; Sat, 12 Aug 2023 03:16:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUirB-0002gg-G4; Sat, 12 Aug 2023 03:16:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aLRQy9jo/X1VlLHcH5QgzK/meL5tk2YA2YeDimH7ZdY=; b=HCosss20GgWt 7J0GShV9ncu7iO2EF/cGb9fsBqmJ9nKXB88tGDzGAm75cn7RhlVh54X80ehqIwqUKFW3Aeq3zET1e AWNKCzgDI24sH4S5QxeHnK3xGS+rFKtNPGbaJr68jo5k7OF3FnFPVOvXe31+kAl7sfaEVdvLeeiuh noqNRvAfhNQoBTGt43VcQF4Bbls3eSR+gpYpZJWY6oWwd3JYkYUivtr4birflf4vxgdsOIcALQiYZ G8wNx22+8AxtE+UJMgzbOcBqXsJLF5IJ9zJZIsmKir2vHTgvhWgLHy6YEeVap038Saw6XbRDn1I7K RD/4olusyKw9/Ax9ncZn5w==; Date: Sat, 12 Aug 2023 10:16:47 +0300 Message-Id: <83v8dkenmo.fsf@gnu.org> From: Eli Zaretskii To: matthewktromp@gmail.com In-Reply-To: <85wmy2rki5.fsf@gmail.com> (matthewktromp@gmail.com) Subject: Re: bug#65213: [PATCH] Substitute command keys in ielm-header at use time References: <85wmy2rki5.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65213-done Cc: 65213-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: matthewktromp@gmail.com > Date: Thu, 10 Aug 2023 11:21:22 -0400 > > >From 4a09a067bd09987291081b5b42a3ba0125765f60 Mon Sep 17 00:00:00 2001 > From: Matthew Tromp > Date: Thu, 10 Aug 2023 10:41:24 -0400 > Subject: [PATCH] Substitute command keys in ielm-header at use time > > Before, command keys were substituted into the ielm-header when > ielm.el was loaded, which resulted in the substitutions depending on > the user's current buffer instead of the ielm buffer. > > For example, if the user was in an info-mode buffer, the key would > appear as 'H' instead of 'C-h m'. > > Now, the command key is substituted after the ielm buffer has been > created. > > * lisp/ielm.el (ielm-header): Remove substitute-command-keys. > (inferior-emacs-lisp-mode): Add substitute-command-keys. Thanks, installed on the emacs-29 branch and closing the bug. From unknown Fri Aug 15 17:22:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Sep 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator