GNU bug report logs - #65204
[PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 65204 <at> debbugs.gnu.org
Subject: [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher.
Date: Mon, 21 Aug 2023 16:03:27 +0200

Hi,

Hilton Chain <hako <at> ultrarare.space> skribis:

> * gnu/packages/golang.scm (go-github-com-tdewolff-parse-v2)[#:phases]: Add
> phase 'regenerate-hash.
> [native-inputs]: Add go-github-com-tdewolff-hasher.

[...]

> +     (list #:import-path "github.com/tdewolff/parse/v2"
> +           #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'regenerate-hash
> +                 (lambda* (#:key import-path #:allow-other-keys)
> +                   (for-each
> +                    (lambda (dir)
> +                      (with-directory-excursion
> +                          (format #f "src/~a/~a" import-path dir)
> +                        (make-file-writable "hash.go")
> +                        (format #t "Generating `hash.go' for ~a...~%" dir)
> +                        (invoke "go" "generate")))

Maybe you can remove ‘hash.go’ in a snippet, for good measure, and add a
comment clarifying that it’s a generated file.

Otherwise the patch series LGTM!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.