Subject: [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 21 Aug 2023 16:03:27 +0200

Hi,

Hilton Chain <[email-masked]> skribis:

> * gnu/packages/golang.scm (go-github-com-tdewolff-parse-v2)[#:phases]: Add
> phase 'regenerate-hash.
> [native-inputs]: Add go-github-com-tdewolff-hasher.

[...]

> +     (list #:import-path "github.com/tdewolff/parse/v2"
> +           #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'regenerate-hash
> +                 (lambda* (#:key import-path #:allow-other-keys)
> +                   (for-each
> +                    (lambda (dir)
> +                      (with-directory-excursion
> +                          (format #f "src/~a/~a" import-path dir)
> +                        (make-file-writable "hash.go")
> +                        (format #t "Generating `hash.go' for ~a...~%" dir)
> +                        (invoke "go" "generate")))

Maybe you can remove ‘hash.go’ in a snippet, for good measure, and add a
comment clarifying that it’s a generated file.

Otherwise the patch series LGTM!

Ludo’.