Subject: bug#65198: 29.1; Emacs29.1 crash in function face_for_font

From: Eli Zaretskii <[email-masked]>
Date: Thu, 10 Aug 2023 21:36:26 +0300

> From: 张云峰 <[email-masked]>
> Date: Fri, 11 Aug 2023 01:58:34 +0800
> Cc: [email-masked]
> 
> 2023-08-11_01-53.png
> when popup frame has the warning-icon (marked in picture) , emacs will crash immediately.

Can you try the patch below and see if it prevents the crash in these
cases?

diff --git a/src/xdisp.c b/src/xdisp.c
index 9cddcfe..b25bdc7 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -8312,9 +8312,14 @@ get_next_display_element (struct it *it)
       && success_p
       && FRAME_WINDOW_P (it->f))
     {
-      struct face *face = FACE_FROM_ID (it->f, it->face_id);
+      struct face *face = FACE_FROM_ID_OR_NULL (it->f, it->face_id);
 
-      if (it->what == IT_COMPOSITION && it->cmp_it.ch >= 0)
+      if (!face)
+	{
+	  it->what = IT_GLYPHLESS;
+	  it->glyphless_method = GLYPHLESS_DISPLAY_EMPTY_BOX;
+	}
+      else if (it->what == IT_COMPOSITION && it->cmp_it.ch >= 0)
 	{
 	  /* Automatic composition with glyph-string.   */
 	  Lisp_Object gstring = composition_gstring_from_id (it->cmp_it.id);