GNU bug report logs - #65186
29.0.91; `dired-free-space' is a step backward

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Wed, 9 Aug 2023 22:04:02 UTC

Severity: normal

Found in version 29.0.91

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Drew Adams <drew.adams <at> oracle.com>
Subject: bug#65186: closed (Re: [External] : Re: bug#65186: 29.0.91;
 `dired-free-space' is a step backward)
Date: Thu, 10 Aug 2023 17:44:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#65186: 29.0.91; `dired-free-space' is a step backward

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65186 <at> debbugs.gnu.org.

-- 
65186: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65186
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 65186-done <at> debbugs.gnu.org
Subject: Re: [External] : Re: bug#65186: 29.0.91; `dired-free-space' is a step
 backward
Date: Thu, 10 Aug 2023 20:43:55 +0300
> From: Drew Adams <drew.adams <at> oracle.com>
> CC: "65186 <at> debbugs.gnu.org" <65186 <at> debbugs.gnu.org>
> Date: Thu, 10 Aug 2023 15:42:57 +0000
> 
> > > Two main problems with this self-styled enhancement:
> > >
> > > 1. The default behavior should be what we've always had, which
> > > corresponds to NONE of the `dired-free-space' option values.
> > 
> > The 'separate' value (which is not the default) produces the behavior
> > we had in Emacs 28 and older, so why do you say that "what we always
> > had corresponds to none" of the option's values?
> 
> No, it doesn't.  Not with `emacs -Q' on MS Windows (which uses ls-lisp), at least.  Not in 28.2 or ANY earlier release, going back to when `dired-hide-details-mode' was first introduced.  In all releases, if you use `(' to hide details then that "separate" line is one of the details that's _removed_.

If this is about hiding the disk space information, then it's your
item 2, and is now fixed.  With that taken care of, the 'separate'
value produces the disk space display identical to what Emacs 28 and
older did.

> > > 2. Even if you set the option to `separate', so you see the full info,
> > > you can't get the superior previous behavior, which is that there's _no
> > > such info_ shown when you hide details (`(').
> > >
> > > Instead, Someone(TM) maybe thought that those interested in what
> > > Someone(TM) doesn't think interesting - the full info - always want to
> > > see that info, even with details hidden.  Blinders...
> > 
> > I think it was just an oversight, now fixed on the emacs-29 branch.
> 
> Thank you very much, Eli.
> (I don't build Emacs, but I'm guessing you mean what I hope you mean. ;-))

The change I installed makes '(' hide the disk space information when
it is displayed on a separate line, under dired-free-space = 'separate'.  
This is for consistency with previous behavior of Dired.

> IF all you changed was to make `separate' be the default or IF it was only to hide all such info when hiding details, then that doesn't fix what I'd like to see fixed.

'separate' will not become default.  Emacs 29 was already released
with a different default, so that ship has sailed.  We will only
revert back to 'separate' if there will be user outcry to that effect.

> 1. The default behavior as it was before: when details aren't hidden, show the full info on a separate line, and when details are hidden, don't show any such info (available, used, etc.).
> 
> 2. For _each_ of the option values: when details are hidden, don't show any such info.  (Unless you add a separate option value for something different.  At least let users get the old behavior exactly, as one possibility) 

The default display of the disk space info is on the same line as the
directory name.  It doesn't get hidden when you press '(', and I'm not
sure it should.  I made it be hidden for the 'separate' display,
because that's how it behaved before Emacs 29, but there's no such
precedent for the default value of 'first', and so what you want to
happen in that case is just your personal opinion.  We don't need to
agree about that.

And with that, I'm closing this bug.

[Message part 3 (message/rfc822, inline)]
From: Drew Adams <drew.adams <at> oracle.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.91; `dired-free-space' is a step backward
Date: Wed, 9 Aug 2023 22:03:36 +0000
Dunno how such a change was made to the _default_ Emacs behavior.
Shouldn't have happened, IMHO.

Two main problems with this self-styled enhancement:

1. The default behavior should be what we've always had, which
corresponds to NONE of the `dired-free-space' option values.

(It's maybe telling that the option name is about free space, whereas
the detailed info is much more than that.  Maybe that's all that
Someone(TM) thought was important.)

2. Even if you set the option to `separate', so you see the full info,
you can't get the superior previous behavior, which is that there's _no
such info_ shown when you hide details (`(').

Instead, Someone(TM) maybe thought that those interested in what
Someone(TM) doesn't think interesting - the full info - always want to
see that info, even with details hidden.  Blinders...

In GNU Emacs 29.0.91 (build 2, x86_64-w64-mingw32) of 2023-05-14 built
 on AVALON
Windowing system distributor 'Microsoft Corp.', version 10.0.19045
System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.3208)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation
 --without-compress-install --with-tree-sitter CFLAGS=-O2'

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

(NATIVE_COMP present but libgccjit not available)




This bug report was last modified 1 year and 196 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.