GNU bug report logs - #65152
[PATCH] services: Modify cgit-configuration fields

Previous Next

Full log

Message #8 received at 65152 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Thomas Albers <thomas <at> thomaslabs.org>
Cc: 65152 <at> debbugs.gnu.org
Subject: Re: bug#65152: [PATCH] services: Modify cgit-configuration fields
Date: Mon, 21 Aug 2023 19:22:18 +0200

Hi,

Thomas Albers <thomas <at> thomaslabs.org> skribis:

> * gnu/services/cgit.scm (cgit-configuration)[root-readme]: Accept
> 'file-object' instead of only 'string'

[...]

>    (root-readme
> -   (string "")
> +   (file-object "")
>     "The content of the file specified with this option will be included
>  verbatim below the \"about\" link on the repository index page.")

I think it’s a good idea but (1) we should preserve backward
compatibility for users passing a string (file contents), and (2) update
the docstrings and its copy in the manual.

Could you send a second version to address these?  Let me know if
anything’s unclear.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.