GNU bug report logs - #65152
[PATCH] services: Modify cgit-configuration fields

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Thomas Albers <thomas <at> thomaslabs.org>
Subject: bug#65152: closed (Re: bug#65152: [PATCH] services: Modify
 cgit-configuration fields)
Date: Sat, 09 Sep 2023 10:33:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65152: [PATCH] services: Modify cgit-configuration fields

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65152 <at> debbugs.gnu.org.

-- 
65152: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65152
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Thomas Albers Raviola <thomas <at> thomaslabs.org>
Cc: 65152-done <at> debbugs.gnu.org
Subject: Re: bug#65152: [PATCH] services: Modify cgit-configuration fields
Date: Sat, 09 Sep 2023 12:32:13 +0200

Hi,

Thomas Albers Raviola <thomas <at> thomaslabs.org> skribis:

> in this context `file-object' is defined to be either a `file-like'
> object or a `string'. As such this wouldn't break backward compatibility
> but include a superset of possible values.
>
> Also the original string is not used as the contents of the readme file
> but as a file path.

Oh right, my bad, I had misunderstood that.  So it’s all good, applied!

Eventually we should probably replace ‘file-object’ by ‘file-like’,
unless there’s a clear use case for passing out-of-band file names (a
use case would be passwords, but probably not ‘README’ files).

Thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Thomas Albers <thomas <at> thomaslabs.org>
To: guix-patches <at> gnu.org
Cc: Thomas Albers <thomas <at> thomaslabs.org>
Subject: [PATCH] services: Modify cgit-configuration fields
Date: Tue,  8 Aug 2023 18:37:10 +0200

* gnu/services/cgit.scm (cgit-configuration)[root-readme]: Accept
'file-object' instead of only 'string'
---
 gnu/services/cgit.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/cgit.scm b/gnu/services/cgit.scm
index e33cb9e7db..684ab73f76 100644
--- a/gnu/services/cgit.scm
+++ b/gnu/services/cgit.scm
@@ -581,7 +581,7 @@ (define-configuration cgit-configuration
    (string "a fast webinterface for the git dscm")
    "Text printed below the heading on the repository index page.")
   (root-readme
-   (string "")
+   (file-object "")
    "The content of the file specified with this option will be included
 verbatim below the \"about\" link on the repository index page.")
   (root-title
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.