Subject: bug#65152: closed (Re: bug#65152: [PATCH] services: Modify cgit-configuration fields)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 09 Sep 2023 10:33:02 +0000

Your bug report

#65152: [PATCH] services: Modify cgit-configuration fields

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
65152: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65152
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#65152: [PATCH] services: Modify cgit-configuration fields
From: Ludovic Courtès <[email-masked]>
To: Thomas Albers Raviola <[email-masked]>
Cc: [email-masked]
Date: Sat, 09 Sep 2023 12:32:13 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Thomas Albers Raviola <[email-masked]> skribis:

> in this context `file-object' is defined to be either a `file-like'
> object or a `string'. As such this wouldn't break backward compatibility
> but include a superset of possible values.
>
> Also the original string is not used as the contents of the readme file
> but as a file path.

Oh right, my bad, I had misunderstood that.  So it’s all good, applied!

Eventually we should probably replace ‘file-object’ by ‘file-like’,
unless there’s a clear use case for passing out-of-band file names (a
use case would be passwords, but probably not ‘README’ files).

Thanks!

Ludo’.

Subject: [PATCH] services: Modify cgit-configuration fields
From: Thomas Albers <[email-masked]>
To: [email-masked]
Cc: Thomas Albers <[email-masked]>
Date: Tue, 8 Aug 2023 18:37:10 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/services/cgit.scm (cgit-configuration)[root-readme]: Accept
'file-object' instead of only 'string'
---
 gnu/services/cgit.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/cgit.scm b/gnu/services/cgit.scm
index e33cb9e7db..684ab73f76 100644
--- a/gnu/services/cgit.scm
+++ b/gnu/services/cgit.scm
@@ -581,7 +581,7 @@ (define-configuration cgit-configuration
    (string "a fast webinterface for the git dscm")
    "Text printed below the heading on the repository index page.")
   (root-readme
-   (string "")
+   (file-object "")
    "The content of the file specified with this option will be included
 verbatim below the \"about\" link on the repository index page.")
   (root-title
-- 
2.41.0