From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 08 12:37:37 2023 Received: (at submit) by debbugs.gnu.org; 8 Aug 2023 16:37:37 +0000 Received: from localhost ([127.0.0.1]:37617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTPiD-0005cO-26 for submit@debbugs.gnu.org; Tue, 08 Aug 2023 12:37:37 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTPiA-0005c4-Lj for submit@debbugs.gnu.org; Tue, 08 Aug 2023 12:37:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTPi4-0002oF-54 for guix-patches@gnu.org; Tue, 08 Aug 2023 12:37:28 -0400 Received: from gamma.thomaslabs.org ([38.242.253.186] helo=localhost) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTPi2-0004K2-Bb for guix-patches@gnu.org; Tue, 08 Aug 2023 12:37:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; t=1691512642; bh=KbthDCvRQZ4kecdhb0Ev0KUb88AD0sDQ72KUjjiY8TU=; h=date:subject:cc:to: from; d=thomaslabs.org; b=fPxwvgIxm3rbmotuD8sLHdHUzkaiFEUPWD/A7WfN1sCa Q0joH3VL77eg3SYHLSlNJs1CnxAjwCnGN2aQFBmUD6o6gV4QDZT8oLgAziF3yR1PaU1s9U Mf1MLHhln/Fv929a7kI3KjLrPZS0Rxub9KeOeQDQLs7PUpuMQxv7XYFF3/AMV1oo+0TPXh fzZPxhPv48CcAZIzBFzNzPVltOajTzwY9oba/b0qAqZ/X3UGvvIlxllxKZTGoTCwDNdZh3 KXe1KA9ZyiRvbKZpjSjCPCYRaiqO/S/PVHsDrVy0s1SoHTj+LrcUJntz9vP4+6OnJH/msz p1v72n+CVsnFF0L02Q== Received: from alpha.wlan.uni-bremen.de (dslb-088-068-101-085.088.068.pools.vodafone-ip.de [88.68.101.85]) by localhost (OpenSMTPD) with ESMTPSA id 861dc756 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 8 Aug 2023 16:37:22 +0000 (UTC) From: Thomas Albers To: guix-patches@gnu.org Subject: [PATCH] services: Modify cgit-configuration fields Date: Tue, 8 Aug 2023 18:37:10 +0200 Message-ID: <20230808163710.22801-1-thomas@thomaslabs.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=38.242.253.186; envelope-from=thomas@thomaslabs.org; helo=localhost X-Spam_score_int: 17 X-Spam_score: 1.7 X-Spam_bar: + X-Spam_report: (1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FSL_HELO_NON_FQDN_1=0.001, HELO_LOCALHOST=3.828, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Thomas Albers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/services/cgit.scm (cgit-configuration)[root-readme]: Accept 'file-object' instead of only 'string' --- gnu/services/cgit.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/services/cgit.scm b/gnu/services/cgit.scm index e33cb9e7db..684ab73f76 100644 --- a/gnu/services/cgit.scm +++ b/gnu/services/cgit.scm @@ -581,7 +581,7 @@ (define-configuration cgit-configuration (string "a fast webinterface for the git dscm") "Text printed below the heading on the repository index page.") (root-readme - (string "") + (file-object "") "The content of the file specified with this option will be included verbatim below the \"about\" link on the repository index page.") (root-title -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 13:22:40 2023 Received: (at 65152) by debbugs.gnu.org; 21 Aug 2023 17:22:40 +0000 Received: from localhost ([127.0.0.1]:57642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY8bw-0006BW-5V for submit@debbugs.gnu.org; Mon, 21 Aug 2023 13:22:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY8bt-0006BF-9C for 65152@debbugs.gnu.org; Mon, 21 Aug 2023 13:22:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY8bd-0001LY-P2; Mon, 21 Aug 2023 13:22:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ikphQIeCK6UkMb9Bbz8mWqd9z4p2Qdz+UzuLVMnFVVk=; b=IpDxkqD+jW4lP6t+WkL7 HGXjgs5YNNBgnPM1KVjAxJzrbHTyKsuW56ysfhwygQshicVcyCYfOZ9cl3YtzzgEMTq7wCPVbn1z0 ejLOzlYPh115w3BxNGUZqYuA4qXYa6UI60Lu0824pYeDuXR+4cHbLlCYYCMqo2ogZ/T9uVUB73fBB 1KKYIdo1Q2eHp9yHc4emz+lNXN+zidZmlLx2+KR0wvZnw1hiGK8Chn2pPbwBbewbmgKEjyR/HyuyR NTiDhgNK/DOyOCaI0ZBrVz13+3oXjY6leSK/zu1NKbcublthPI9tRfOu65Zdf7fQlhmrDxHCHeIXU KHf00MPc6yVPUQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Thomas Albers Subject: Re: bug#65152: [PATCH] services: Modify cgit-configuration fields References: <20230808163710.22801-1-thomas@thomaslabs.org> Date: Mon, 21 Aug 2023 19:22:18 +0200 In-Reply-To: <20230808163710.22801-1-thomas@thomaslabs.org> (Thomas Albers's message of "Tue, 8 Aug 2023 18:37:10 +0200") Message-ID: <875y588g51.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65152 Cc: 65152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Thomas Albers skribis: > * gnu/services/cgit.scm (cgit-configuration)[root-readme]: Accept > 'file-object' instead of only 'string' [...] > (root-readme > - (string "") > + (file-object "") > "The content of the file specified with this option will be included > verbatim below the \"about\" link on the repository index page.") I think it=E2=80=99s a good idea but (1) we should preserve backward compatibility for users passing a string (file contents), and (2) update the docstrings and its copy in the manual. Could you send a second version to address these? Let me know if anything=E2=80=99s unclear. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 22 05:18:48 2023 Received: (at 65152) by debbugs.gnu.org; 22 Aug 2023 09:18:49 +0000 Received: from localhost ([127.0.0.1]:58580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYNXE-00067O-NP for submit@debbugs.gnu.org; Tue, 22 Aug 2023 05:18:48 -0400 Received: from gamma.thomaslabs.org ([38.242.253.186]:59574 helo=localhost) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYNXB-00067E-VQ for 65152@debbugs.gnu.org; Tue, 22 Aug 2023 05:18:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; t=1692695921; bh=8aIOJYgcJ+b5UDtnXUuG0vwsY5c2qxAYM+ZGB37popk=; h=date:references: in-reply-to:subject:cc:to:from; d=thomaslabs.org; b=UVNMT2th7cEq3cuhOZ 5W4Kjo3OORWRXqTaI+Mqwrs2sRE4JdQBU17Rv0mSaZ+/GWtgF1b89bS3jNGCw2RxauOKTk 0vf1RePrCC8hZRfsIMX/LpaOVnuemlXux7zSmCSARYyqQk43v1bREkthoAEOD3RF0mf1r7 Ap9PZPbgP+DdtpFk8NfuZ4SPTePMwAP+m/kHrJSVrbZPLzLNBuvs5iX9LQI5ky+J5Ycuge Y11LWgfpemvvvP/60UzUFlBNLqbCn1/C9xNbIKMvgDSKVcWKYgwnhRLdozQTkZlBAhV/qt kQ365YBnIgV8WsZScfuakwHTqhM6yFhCYQKQiMseIRFw== Received: from localhost (dslb-002-201-212-172.002.201.pools.vodafone-ip.de [2.201.212.172]) by localhost (OpenSMTPD) with ESMTPSA id 9c8955c1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 22 Aug 2023 09:18:41 +0000 (UTC) From: Thomas Albers Raviola To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#65152: [PATCH] services: Modify cgit-configuration fields In-Reply-To: <875y588g51.fsf@gnu.org> References: <20230808163710.22801-1-thomas@thomaslabs.org> <875y588g51.fsf@gnu.org> Date: Tue, 22 Aug 2023 11:18:37 +0200 Message-ID: <87a5uj8mfm.fsf@alpha.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, in this context `file-object' is defined to be either a `file-like' object or a `string'. As such this wouldn't break backward compatibility but include a superset of possible values. Also the original string is not used as the contents of the readme file but as a file path. Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FSL_HELO_NON_FQDN_1 No description available. 3.6 HELO_LOCALHOST No description available. -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 65152 Cc: 65152@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, in this context `file-object' is defined to be either a `file-like' object or a `string'. As such this wouldn't break backward compatibility but include a superset of possible values. Also the original string is not used as the contents of the readme file but as a file path. Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FSL_HELO_NON_FQDN_1 No description available. 3.6 HELO_LOCALHOST No description available. -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hi, in this context `file-object' is defined to be either a `file-like' object or a `string'. As such this wouldn't break backward compatibility but include a superset of possible values. Also the original string is not used as the contents of the readme file but as a file path. However if you still think something should be changed I can send a second patch addressing any further issues. Greetings, Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 09 06:32:26 2023 Received: (at 65152-done) by debbugs.gnu.org; 9 Sep 2023 10:32:26 +0000 Received: from localhost ([127.0.0.1]:46211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qevGM-0003CP-4J for submit@debbugs.gnu.org; Sat, 09 Sep 2023 06:32:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qevGK-0003CC-Ca for 65152-done@debbugs.gnu.org; Sat, 09 Sep 2023 06:32:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qevGB-0005Sa-7G; Sat, 09 Sep 2023 06:32:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Xtoeu41RXLlC8l0RoRMOrEaqXHbnk0uwBzLdJqzE1Z8=; b=AVWVAaASTJ/1RQPGfmZh GLAoQM30j0RUEXKFgsjYrsWs33NUSkdfb0wTMPNSYtqRZaxEiET8kgCdQ4NUkr5Hxtw7COO/VYINg BWBkeeS7bXmLXrfgMvjb+t0iIAgNRH8sk+ZpQTVkAQfqbV500k5DBnN+m8FqVno+1MfqTuICRK5Gc vWBGerKwqYjkiU4HnZYh+7h/DNnL1jb+71fYeYlntj9ZpxiaNr534e4OY2JhYHJd2oBPX6KMTmpSx r926s09Zzs2EX/egnA0V1+FPNt68p+g3AB4H7ABv4JuwsE2/hgr4EFW6KlkpEPeJVjPlq2cCxWzsG t4tn/OG5xvTbAw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Thomas Albers Raviola Subject: Re: bug#65152: [PATCH] services: Modify cgit-configuration fields References: <20230808163710.22801-1-thomas@thomaslabs.org> <875y588g51.fsf@gnu.org> <87a5uj8mfm.fsf@alpha.mail-host-address-is-not-set> Date: Sat, 09 Sep 2023 12:32:13 +0200 In-Reply-To: <87a5uj8mfm.fsf@alpha.mail-host-address-is-not-set> (Thomas Albers Raviola's message of "Tue, 22 Aug 2023 11:18:37 +0200") Message-ID: <87sf7nzlg2.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65152-done Cc: 65152-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Thomas Albers Raviola skribis: > in this context `file-object' is defined to be either a `file-like' > object or a `string'. As such this wouldn't break backward compatibility > but include a superset of possible values. > > Also the original string is not used as the contents of the readme file > but as a file path. Oh right, my bad, I had misunderstood that. So it=E2=80=99s all good, appl= ied! Eventually we should probably replace =E2=80=98file-object=E2=80=99 by =E2= =80=98file-like=E2=80=99, unless there=E2=80=99s a clear use case for passing out-of-band file names = (a use case would be passwords, but probably not =E2=80=98README=E2=80=99 file= s). Thanks! Ludo=E2=80=99. From unknown Sun Jun 22 11:36:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Oct 2023 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator