Subject: bug#6515: closed (Re: 24.0.50; unneeded let-binded variable in bookmark.el)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 27 Jun 2010 18:05:02 +0000

Your bug report

#6515: 24.0.50; unneeded let-binded variable in bookmark.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
6515: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: 24.0.50; unneeded let-binded variable in bookmark.el
From: Chong Yidong <[email-masked]>
To: Christoph <[email-masked]>
Cc: [email-masked], Thierry Volpiatto <[email-masked]>
Date: Sun, 27 Jun 2010 14:04:54 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

> Find attached a bugfix for bug #6515
> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review.
>
> Imho, the bug report is valid. I don't think the code in question should
> override globally set variable bookmark-automatically-show-annotations.
> Therefore, the let variables were removed.

Yes, checked in, thanks.

Subject: 24.0.50; unneeded let-binded variable in bookmark.el
From: Thierry Volpiatto <[email-masked]>
To: [email-masked]
Date: Fri, 25 Jun 2010 23:13:20 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,
bookmark-bmenu-switch-other-window
bookmark-bmenu-2-window
bookmark-bmenu-other-window

(let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed?

Indeed it's not needed, worst, it anhile effect of global
bookmark-automatically-show-annotations

Thierry.