From unknown Sat Aug 16 18:43:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6515: 24.0.50; unneeded let-binded variable in bookmark.el Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Jun 2010 21:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6515 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6515@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.127750198313868 (code B ref -1); Fri, 25 Jun 2010 21:40:03 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jun 2010 21:39:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGcg-0003bd-Fz for submit@debbugs.gnu.org; Fri, 25 Jun 2010 17:39:42 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGcf-0003bY-4S for submit@debbugs.gnu.org; Fri, 25 Jun 2010 17:39:41 -0400 Received: from lists.gnu.org ([199.232.76.165]:37254) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OSGca-0001OZ-LH for submit@debbugs.gnu.org; Fri, 25 Jun 2010 17:39:36 -0400 Received: from [140.186.70.92] (port=56426 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSGGD-00044I-MY for bug-gnu-emacs@gnu.org; Fri, 25 Jun 2010 17:16:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OSGGC-0003DW-L5 for bug-gnu-emacs@gnu.org; Fri, 25 Jun 2010 17:16:29 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:41374) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGGC-0003DH-GG for bug-gnu-emacs@gnu.org; Fri, 25 Jun 2010 17:16:28 -0400 Received: by wyb39 with SMTP id 39so1982742wyb.0 for ; Fri, 25 Jun 2010 14:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:organization :date:message-id:user-agent:mime-version:content-type; bh=mSSQ2rNrlmruEiHhJUIj28/KF0twu6BFc8LCk9nxjgE=; b=UZKQ2gf8dFVCy2E3wvJC/MSBJptze5icboLppdLqlRiyFXEcXnbr2KUhXjeZxI3a0e Vzc13jFxCGo9sKH1HKqDI1yVYnqFkCYg6An/f+czXYcKGrDkOLVMJoy7rqgUFerAbcNl Akd+V3wwhv0HMfi9TDl2qNeX9p56qwazuO8yE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:organization:date:message-id:user-agent :mime-version:content-type; b=qLeEAa1lze2AY65n/eH8Y6B+FpiKt6DEvTKxvwF2YmQ5htin+2r7iA9IgVwDElZz/3 vDqWhXAbA7ac5hIeM8AB6wBox/bRahEYi8penrSmGNx8ofdwk+/RQoSEa8JTq4ccvmdL reKQWDJKZJrW6rhaZW8Y1s25/Fm+pwXYiPkr0= Received: by 10.227.127.137 with SMTP id g9mr1135424wbs.58.1277500586639; Fri, 25 Jun 2010 14:16:26 -0700 (PDT) Received: from tux.homenetwork ([77.197.77.33]) by mx.google.com with ESMTPS id n31sm45859300wba.21.2010.06.25.14.16.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 25 Jun 2010 14:16:26 -0700 (PDT) From: Thierry Volpiatto Organization: ThierryVolpiatto Date: Fri, 25 Jun 2010 23:13:20 +0200 Message-ID: <87lja2rf2n.fsf@tux.homenetwork> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.2 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Hi, bookmark-bmenu-switch-other-window bookmark-bmenu-2-window bookmark-bmenu-other-window (let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed? Indeed it's not needed, worst, it anhile effect of global bookmark-automatically-show-annotations Thierry. From unknown Sat Aug 16 18:43:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6515: Patch for bug #6515: unneeded let-bound variables in bookmark.el References: <87lja2rf2n.fsf@tux.homenetwork> In-Reply-To: <87lja2rf2n.fsf@tux.homenetwork> Resent-From: Christoph Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Jun 2010 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6515 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6515@debbugs.gnu.org Received: via spool by 6515-submit@debbugs.gnu.org id=B6515.127758878722609 (code B ref 6515); Sat, 26 Jun 2010 21:47:02 +0000 Received: (at 6515) by debbugs.gnu.org; 26 Jun 2010 21:46:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSdCl-0005sc-7K for submit@debbugs.gnu.org; Sat, 26 Jun 2010 17:46:27 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSdBl-0005rg-Ef for 6515@debbugs.gnu.org; Sat, 26 Jun 2010 17:45:26 -0400 Received: by gyh4 with SMTP id 4so5624618gyh.3 for <6515@debbugs.gnu.org>; Sat, 26 Jun 2010 14:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type; bh=Lj9pgqJQWN5RgzPqtn3ycBqojGj+J7hIEIEjgTuCSBI=; b=vkJR0E+lJ2qb0/MoCxfPZzRMUGus33ZvCHNzX+gx2GI/WZVnXjW6IttGQDlgPoaysO +jPB3Ne8gjKX3xFwcH1ui/tbLndhEWq9d8UOGAzQ9kO0XRXjiBUyitJs1klTKUHTfZHX CjwgmPlDf5u2k+B2MMc9ydEZY9EU2W9s6S1Fo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; b=dEDrAiyviBL6Qe/3qtcX8ts08S5Ib2s+a9PQdqK/79CcBf0IR98J4T6at7Gej7faT+ PuXTlbNIZ+xWoMwB7MvYwENzIoruSRPOWrO1DBULwd76abImvQygGTLwh9OAPskGPPD4 YSMEvGOqWHQruEwUkeRf09/LSbhZp/XsGIWr8= Received: by 10.100.81.9 with SMTP id e9mr3503232anb.115.1277588721110; Sat, 26 Jun 2010 14:45:21 -0700 (PDT) Received: from [192.168.1.4] (184-96-96-143.hlrn.qwest.net [184.96.96.143]) by mx.google.com with ESMTPS id f7sm26706561anb.7.2010.06.26.14.45.19 (version=SSLv3 cipher=RC4-MD5); Sat, 26 Jun 2010 14:45:20 -0700 (PDT) Message-ID: <4C2674EE.9060706@gmail.com> Date: Sat, 26 Jun 2010 15:45:18 -0600 From: Christoph User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080707020005070900080207" X-Spam-Score: -2.6 (--) X-Mailman-Approved-At: Sat, 26 Jun 2010 17:46:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------080707020005070900080207 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Find attached a bugfix for bug #6515 (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review. Imho, the bug report is valid. I don't think the code in question should override globally set variable bookmark-automatically-show-annotations. Therefore, the let variables were removed. I sent in my signed paperwork a while ago, but haven't heard anything back, so I hope this is minor enough to maybe go through without it. Christoph --------------080707020005070900080207 Content-Type: text/plain; name="bugfix_6515.txt.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="bugfix_6515.txt.txt" # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: cschol2112@gmail.com-20100626175327-syboc05tlvbvcjwg # target_branch: http://bzr.savannah.gnu.org/r/emacs/trunk/ # testament_sha1: ed110efd0fe83dca9884a93319ad8d3447b1eb7c # timestamp: 2010-06-26 11:57:42 -0600 # base_revision_id: eliz@gnu.org-20100626144112-032airiym9h9hy1p # # Begin patch === modified file 'lisp/bookmark.el' --- lisp/bookmark.el 2010-04-14 15:07:53 +0000 +++ lisp/bookmark.el 2010-06-26 17:53:27 +0000 @@ -1860,8 +1860,7 @@ (pop-up-windows t)) (delete-other-windows) (switch-to-buffer (other-buffer)) - (let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed? - (bookmark--jump-via bmrk 'pop-to-buffer)) + (bookmark--jump-via bmrk 'pop-to-buffer) (bury-buffer menu))) @@ -1875,8 +1874,7 @@ "Select this line's bookmark in other window, leaving bookmark menu visible." (interactive) (let ((bookmark (bookmark-bmenu-bookmark))) - (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed? - (bookmark--jump-via bookmark 'switch-to-buffer-other-window)))) + (bookmark--jump-via bookmark 'switch-to-buffer-other-window))) (defun bookmark-bmenu-switch-other-window () @@ -1887,8 +1885,7 @@ (pop-up-windows t) same-window-buffer-names same-window-regexps) - (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed? - (bookmark--jump-via bookmark 'display-buffer)))) + (bookmark--jump-via bookmark 'display-buffer))) (defun bookmark-bmenu-other-window-with-mouse (event) "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible." # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWSskWiYAA1jfgEAQWOf/91oA CgC////wUAXtDzonbDVnKUIBy4SSTRMRMwAU0zQ0EyI0PUzSBJTUyYRkmENTUYQBoZDQ0ASRAg1M UepoAAMgGgADDQ0AAAGgAAAABJICJmppkZMmSbURppPU2oBoGcpryRanH54HQeVlN8CTrJZbdKtZ C5+0UsUkkrRj4MIFJ7SCCwuVMzXSDjsMxs8UviBKTOxVjNo4kHNrEz3Pak7n4PZe/e48VfZmszFh wkcc2A7w5+7q6WIBxQY6J6+yHvckbAyTTbzBj7gvuWC+ScNXkmZVgGJkvAt/La12Q87LcRiow4CJ TIVGZlFB6RUgisUwpjAq9KNOLnO0Z9vORIcN4cj3ZINYqyhwCfpuguG7y7KJ9XhUJqDxOSB84LjG yQoCsSfYSdd/nrUTGttL0q3uRUygm+hIBe2oalnmbivVBBYVhF5IyeqGHHPPXciINPJhMKt0hZNN bnEqERneNjgMqVgGkKGbCowb2Cfu4oHI5oVGuOsea7rlxaC2ElkLpBGIggWaGxJTwurT2SCg4XW0 /8RrAy4CigVvfaS6u6mCzxUq58C+ES6XQ1lJwumsRanJV6SL6EDnRUcnyaxfdgUool3MjaulyJv7 oKc3Qx4FUwnpmYXIxw56HUsJBMWahQe+ul220VLTBMVCN8WGLJCKXPB4CI0snLmUDMrK0pHO5VEG J3RfAbk1KiwpLwK4XmKd+bq8MCfDODJBY3IuIrFILzPgeOz6ZRqYlIbFshwb7Re2WmkDdMNfQVbR hJ6tJ8i+wi9wu2JJ0SitzNju0HiwmIvF7xFq0EcGxxTdhLldAdiOCbiCHLIcUfAusenKenGZIFO2 SwFMUiRs6oxMiaFSThORFy7RTUuxV/vLHKpkGWBfBy0mKajAzHXGYwnjCcESSaARSjIceo8Q7yeo anezNBjf9mbSVEHCta1FbxhhMfXSoYjuYGI6VvZ4e6y2OLogONMYZPM93eYiXSwfpMuvnyMUshBc vnMs8YmJUr7hETgJasb+mCLTIkcYJ7Jxj7X2kVhIRxx6jDqJj+LExGPV+scnVgtwjhSKflxxtKJF bTzLu2Kx3bxB9EovN4USiC0vLxnIYcM77nkFK9KGRhQzmjymLoPIHYR4mL5QKy0s00Lq4Ywk/uiZ QFmUgvPJEnaZaPZqtp1izcnl9lUBLvhPUnJzIMh1BGl16mszmajy4ypY6m16RTlVbjWWxHTkKeqh 9hj0v+48PouqOgmFgs565noc6siBrE6mwPtAhFATU4XQdKNgqdxbtLXhyEwUBwWnmbjqbPg3wBMM x+iR7i4TZ+q6IIIo/kBbDoGCbcB5bIAR9EKoStIVvU4UGk6H2J7h5EcgjpEGAnhTalXpj+MCoeb7 ANCuKgOJLSaOJOoFCpBqleKuFOZAwZJfCRx6iY7iBwDxBwA4DwvTBtI8MDaepFcMjY3vEcShLuJ6 A+ExIQeSR0R5zO5eGhUPKFzKQ8MPZVTA5klOAF8RxoPIfMQ0TYVohxNwrxavFticy0WV4pQ4JHuC HVgiAHuYhNIjqxYWsl9hORB4qWzqx38EYIsSI6DDC/6AdlIJ/rTOo+NROJ7dhDkuSwLoiJG48JCg T+WHY0UebCJoeWdarzqkWKcmE5aiM1DI1EETBMMVMzHAtAYmVMMw9SBxADnEVocRhxyDEkw+ZU2B xk8dsVDwFUwQYoJ3sLE7BML6uzr1B5fo3O0/y0rbLwZYC0FsqCquE3NZgXvoKFsxRF6rH3+qccrB XmjBurBSmuBbBDqjKw/xdyRThQkCskWiYA== --------------080707020005070900080207-- From unknown Sat Aug 16 18:43:39 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thierry Volpiatto Subject: bug#6515: closed (Re: 24.0.50; unneeded let-binded variable in bookmark.el) Message-ID: References: <87wrtk2vy1.fsf@stupidchicken.com> <87lja2rf2n.fsf@tux.homenetwork> X-Gnu-PR-Message: they-closed 6515 X-Gnu-PR-Package: emacs Reply-To: 6515@debbugs.gnu.org Date: Sun, 27 Jun 2010 18:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1277661902-25857-1" This is a multi-part message in MIME format... ------------=_1277661902-25857-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6515: 24.0.50; unneeded let-binded variable in bookmark.el which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6515@debbugs.gnu.org. --=20 6515: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6515 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1277661902-25857-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6515-done) by debbugs.gnu.org; 27 Jun 2010 18:05:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSwE1-0006is-Fy for submit@debbugs.gnu.org; Sun, 27 Jun 2010 14:05:01 -0400 Received: from pantheon-po41.its.yale.edu ([130.132.50.98]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSwDy-0006im-SN for 6515-done@debbugs.gnu.org; Sun, 27 Jun 2010 14:04:59 -0400 Received: from furry (dhcp128036163046.central.yale.edu [128.36.163.46]) (authenticated bits=0) by pantheon-po41.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o5RI4sCd031845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 27 Jun 2010 14:04:54 -0400 Received: by furry (Postfix, from userid 1000) id 5785016EC25; Sun, 27 Jun 2010 20:04:54 +0200 (CEST) From: Chong Yidong To: Christoph Subject: Re: 24.0.50; unneeded let-binded variable in bookmark.el Date: Sun, 27 Jun 2010 14:04:54 -0400 Message-ID: <87wrtk2vy1.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6515-done Cc: 6515-done@debbugs.gnu.org, Thierry Volpiatto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) > Find attached a bugfix for bug #6515 > (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review. > > Imho, the bug report is valid. I don't think the code in question should > override globally set variable bookmark-automatically-show-annotations. > Therefore, the let variables were removed. Yes, checked in, thanks. ------------=_1277661902-25857-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Jun 2010 21:39:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGcg-0003bd-Fz for submit@debbugs.gnu.org; Fri, 25 Jun 2010 17:39:42 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGcf-0003bY-4S for submit@debbugs.gnu.org; Fri, 25 Jun 2010 17:39:41 -0400 Received: from lists.gnu.org ([199.232.76.165]:37254) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OSGca-0001OZ-LH for submit@debbugs.gnu.org; Fri, 25 Jun 2010 17:39:36 -0400 Received: from [140.186.70.92] (port=56426 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSGGD-00044I-MY for bug-gnu-emacs@gnu.org; Fri, 25 Jun 2010 17:16:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OSGGC-0003DW-L5 for bug-gnu-emacs@gnu.org; Fri, 25 Jun 2010 17:16:29 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:41374) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGGC-0003DH-GG for bug-gnu-emacs@gnu.org; Fri, 25 Jun 2010 17:16:28 -0400 Received: by wyb39 with SMTP id 39so1982742wyb.0 for ; Fri, 25 Jun 2010 14:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:organization :date:message-id:user-agent:mime-version:content-type; bh=mSSQ2rNrlmruEiHhJUIj28/KF0twu6BFc8LCk9nxjgE=; b=UZKQ2gf8dFVCy2E3wvJC/MSBJptze5icboLppdLqlRiyFXEcXnbr2KUhXjeZxI3a0e Vzc13jFxCGo9sKH1HKqDI1yVYnqFkCYg6An/f+czXYcKGrDkOLVMJoy7rqgUFerAbcNl Akd+V3wwhv0HMfi9TDl2qNeX9p56qwazuO8yE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:organization:date:message-id:user-agent :mime-version:content-type; b=qLeEAa1lze2AY65n/eH8Y6B+FpiKt6DEvTKxvwF2YmQ5htin+2r7iA9IgVwDElZz/3 vDqWhXAbA7ac5hIeM8AB6wBox/bRahEYi8penrSmGNx8ofdwk+/RQoSEa8JTq4ccvmdL reKQWDJKZJrW6rhaZW8Y1s25/Fm+pwXYiPkr0= Received: by 10.227.127.137 with SMTP id g9mr1135424wbs.58.1277500586639; Fri, 25 Jun 2010 14:16:26 -0700 (PDT) Received: from tux.homenetwork ([77.197.77.33]) by mx.google.com with ESMTPS id n31sm45859300wba.21.2010.06.25.14.16.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 25 Jun 2010 14:16:26 -0700 (PDT) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 24.0.50; unneeded let-binded variable in bookmark.el Organization: ThierryVolpiatto Date: Fri, 25 Jun 2010 23:13:20 +0200 Message-ID: <87lja2rf2n.fsf@tux.homenetwork> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) Hi, bookmark-bmenu-switch-other-window bookmark-bmenu-2-window bookmark-bmenu-other-window (let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed? Indeed it's not needed, worst, it anhile effect of global bookmark-automatically-show-annotations Thierry. ------------=_1277661902-25857-1--