GNU bug report logs - #65146
30.0.50; Build fails with CHECK_STRUCTS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65146 in the body.
You can then email your comments to 65146 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Build fails with CHECK_STRUCTS
Date: Tue, 08 Aug 2023 12:44:16 +0200

[Message part 1 (text/plain, inline)]

The new text_conversion_style_ field:

[0001-Update-Android-port.patch (text/x-diff, inline)]

From cf24b61985c26cbf2e5a24cb0b64a8528aa3a9cc Mon Sep 17 00:00:00 2001
From: Po Lu <luangruo <at> yahoo.com>
Date: Wed, 15 Feb 2023 22:51:44 +0800
Subject: [PATCH] Update Android port

* src/buffer.h (struct buffer, bset_text_conversion_style): New
fields.
---
 src/buffer.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/buffer.h b/src/buffer.h
index e700297a264..e71ffe28045 100644
--- a/src/buffer.h
+++ b/src/buffer.h
@@ -566,6 +566,11 @@ #define BVAR(buf, field) ((buf)->field ## _)
   /* A list of tree-sitter parsers for this buffer.  */
   Lisp_Object ts_parser_list_;
 #endif
+
+  /* What type of text conversion the input method should apply to
+     this buffer.  */
+  Lisp_Object text_conversion_style_;
+
   /* Cursor type to display in non-selected windows.
      t means to use hollow box cursor.
      See `cursor-type' for other values.  */
-- 
2.40.1

[Message part 3 (text/plain, inline)]

Is unknown to the pdumper with --enable-checking=structs:

  CC       pdumper.o
pdumper.c: In function ‘dump_buffer’:
pdumper.c:2751:3: error: #error "buffer changed. See CHECK_STRUCTS comment in config.h."

Does the field need any special handling, or can HASH_buffer be safely
updated?

Thanks,

-- 
Basil

[build.txt (text/plain, attachment)]

[Message part 5 (text/plain, inline)]

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw3d scroll bars) of 2023-08-06 built on tia
Repository revision: 4a973ed2bfb1da91a457a49a3a4089589fdf2d5f
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure 'CFLAGS=-Og -ggdb3' -C --prefix=/home/blc/.local
 --enable-checking=structs --with-file-notification=yes
 --with-x-toolkit=lucid --with-x'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM
LUCID ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Message #8 received at 65146 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 65146 <at> debbugs.gnu.org
Subject: Re: bug#65146: 30.0.50; Build fails with CHECK_STRUCTS
Date: Tue, 08 Aug 2023 20:23:28 +0800

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> The new text_conversion_style_ field:
>
>>From cf24b61985c26cbf2e5a24cb0b64a8528aa3a9cc Mon Sep 17 00:00:00 2001
> From: Po Lu <luangruo <at> yahoo.com>
> Date: Wed, 15 Feb 2023 22:51:44 +0800
> Subject: [PATCH] Update Android port
>
> * src/buffer.h (struct buffer, bset_text_conversion_style): New
> fields.
> ---
>  src/buffer.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/src/buffer.h b/src/buffer.h
> index e700297a264..e71ffe28045 100644
> --- a/src/buffer.h
> +++ b/src/buffer.h
> @@ -566,6 +566,11 @@ #define BVAR(buf, field) ((buf)->field ## _)
>    /* A list of tree-sitter parsers for this buffer.  */
>    Lisp_Object ts_parser_list_;
>  #endif
> +
> +  /* What type of text conversion the input method should apply to
> +     this buffer.  */
> +  Lisp_Object text_conversion_style_;
> +
>    /* Cursor type to display in non-selected windows.
>       t means to use hollow box cursor.
>       See `cursor-type' for other values.  */
> -- 
> 2.40.1
>
>
> Is unknown to the pdumper with --enable-checking=structs:
>
>   CC       pdumper.o
> pdumper.c: In function ‘dump_buffer’:
> pdumper.c:2751:3: error: #error "buffer changed. See CHECK_STRUCTS comment in config.h."
>
> Does the field need any special handling, or can HASH_buffer be safely
> updated?
>
> Thanks,

No special treatment is necessary.  Please proceed with updating the
hash, thanks.

Message #13 received at 65146-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 65146-done <at> debbugs.gnu.org
Subject: Re: bug#65146: 30.0.50; Build fails with CHECK_STRUCTS
Date: Tue, 08 Aug 2023 15:01:00 +0200

close 65146 30.1
quit

Po Lu [2023-08-08 20:23 +0800] wrote:

> No special treatment is necessary.  Please proceed with updating the
> hash, thanks.

Done, thanks.

; Update pdumper dump_buffer hash (bug#65146).
d2f29bd3ce7 2023-08-08 14:57:34 +0200
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=d2f29bd3ce7

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.