Subject: bug#65125: closed (Re: bug#65125: [PATCH] gnu: ntp: Fix cross-compilation inputs.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 12 Aug 2023 20:32:02 +0000

Your bug report

#65125: [PATCH] gnu: ntp: Fix cross-compilation inputs.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
65125: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65125
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#65125: [PATCH] gnu: ntp: Fix cross-compilation inputs.
From: Ludovic Courtès <[email-masked]>
To: Jean-Pierre De Jesus DIAZ <[email-masked]>
Cc: [email-masked]
Date: Sat, 12 Aug 2023 22:30:52 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Jean-Pierre De Jesus DIAZ <[email-masked]> skribis:

> * gnu/packages/ntp.scm (ntp)[inputs]: Use `target-linux?' instead of
>   the manual string comparison as it would not add the libcap input
>   correctly when cross-compiling as the platform ends in `-linux-gnu'
>   unlike the system string which ends in `-linux'.

Applied, thanks!

Ludo’.

Subject: [PATCH] gnu: ntp: Fix cross-compilation inputs.
From: Jean-Pierre De Jesus DIAZ <[email-masked]>
To: [email-masked]
Cc: Jean-Pierre De Jesus DIAZ <[email-masked]>
Date: Mon, 7 Aug 2023 14:17:49 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/ntp.scm (ntp)[inputs]: Use `target-linux?' instead of
  the manual string comparison as it would not add the libcap input
  correctly when cross-compiling as the platform ends in `-linux-gnu'
  unlike the system string which ends in `-linux'.

Signed-off-by: Jean-Pierre De Jesus DIAZ <[email-masked]>
---
 gnu/packages/ntp.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/ntp.scm b/gnu/packages/ntp.scm
index 1a72efbc79..4ab8ab6631 100644
--- a/gnu/packages/ntp.scm
+++ b/gnu/packages/ntp.scm
@@ -139,8 +139,7 @@ (define-public ntp
            libevent
            ;; Build with POSIX capabilities support on GNU/Linux.  This allows
            ;; 'ntpd' to run as non-root (when invoked with '-u'.)
-           (if (string-suffix? "-linux"
-                               (or (%current-target-system) (%current-system)))
+           (if (target-linux?)
                (list libcap)
                '())))
    (arguments
-- 
2.34.1