GNU bug report logs - #65119
[PATCH 0/8] Sharing service code between Home and System

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: bug#65119: closed (Re: bug#65119: [PATCH 0/8] Sharing service
 code between Home and System)
Date: Sun, 20 Aug 2023 21:24:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65119: [PATCH 0/8] Sharing service code between Home and System

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65119 <at> debbugs.gnu.org.

-- 
65119: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65119
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: 宋文武 <iyzsong <at> envs.net>
Cc: paren <at> disroot.org, 65119-done <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: bug#65119: [PATCH 0/8] Sharing service code between Home and
 System
Date: Sun, 20 Aug 2023 23:23:17 +0200

Hi,

宋文武 <iyzsong <at> envs.net> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> [...]
>>
>> This patch lets us map System services to Home and uses the new
>> mechanism for three services: mcron, dicod, and syncthing.
>>
>>   services: dicod: Remove Shepherd < 0.9.0 compatibility layer.
>>   services: dicod: Pre-build the GCIDE index.
>>   services: syncthing: Use 'match-record'.
>>   services: Define 'for-home'.
>>   home: services: Support mapping of System services to Home services.
>>   home: services: mcron: Define as a mapping of the system service.
>>   home: services: Add dicod.
>>   home: services: Add Syncthing.
>
> I didn't test them, but those changes look good to me!

Pushed as 7605c01fccb20b387f5a0d98d6b81074b3039e23, thanks for taking a
look!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/8] Sharing service code between Home and System
Date: Sun,  6 Aug 2023 23:04:54 +0200

Hello Guix!

Some services make as much sense as a System and as a Home service.
Two examples that came up recently are Syncthing and dicod:

  https://issues.guix.gnu.org/63758
  https://issues.guix.gnu.org/62401

In these cases, we’d rather avoid code duplication and have a common
code base for both the System and the Home service.

This patch lets us map System services to Home and uses the new
mechanism for three services: mcron, dicod, and syncthing.

Feedback welcome!

Ludo’.

Ludovic Courtès (8):
  services: dicod: Remove Shepherd < 0.9.0 compatibility layer.
  services: dicod: Pre-build the GCIDE index.
  services: syncthing: Use 'match-record'.
  services: Define 'for-home'.
  home: services: Support mapping of System services to Home services.
  home: services: mcron: Define as a mapping of the system service.
  home: services: Add dicod.
  home: services: Add Syncthing.

 doc/guix.texi                   | 96 ++++++++++++++++++++++++++++++++-
 gnu/home/services.scm           | 69 +++++++++++++++++++++++-
 gnu/home/services/dict.scm      | 32 +++++++++++
 gnu/home/services/mcron.scm     | 96 ++++-----------------------------
 gnu/home/services/shepherd.scm  |  4 +-
 gnu/home/services/syncthing.scm | 30 +++++++++++
 gnu/local.mk                    |  2 +
 gnu/services.scm                | 25 ++++++++-
 gnu/services/dict.scm           | 84 ++++++++++++++---------------
 gnu/services/mcron.scm          | 80 ++++++++++++---------------
 gnu/services/syncthing.scm      | 56 ++++++++++---------
 11 files changed, 372 insertions(+), 202 deletions(-)
 create mode 100644 gnu/home/services/dict.scm
 create mode 100644 gnu/home/services/syncthing.scm


base-commit: 0ab46ef3f9719f03d9b191a16e5aa91619e95451
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.