GNU bug report logs - #65118
[PATCH 0/9]: gnu: Add NSQ.

Previous Next

Full log

Message #47 received at 65118 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 65118 <at> debbugs.gnu.org
Subject: Re: bug#65118: [PATCH 0/9]: gnu: Add NSQ.
Date: Sat, 26 Aug 2023 22:13:43 -0400

Hi,

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

> * gnu/packages/golang.scm (go-github-com-mreiferson-go-svc): New variable.
> ---
>  gnu/packages/golang.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index ce46e02158..7890e4d583 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -6256,6 +6256,34 @@ (define-public go-github-com-mr-tron-base58
>  encoding and 8 times faster decoding.")
>        (license license:expat))))
>  
> +(define-public go-github-com-mreiferson-go-svc
> +  ;; NSQ specific fork of github.com/judwhite/go-svc, as Guix go build system
> +  ;; does not support go.mod with `replace' statement.
> +  (let ((commit "7a96e00010f68d9436e3de53a70c53f209a0c244")
> +        (revision "0"))
> +    (package
> +      (name "go-github-com-mreiferson-go-svc")
> +      (version (git-version "1.2.1" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/mreiferson/go-svc")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1acgb0n3svhnraqj1fz5qc5n3b4vc5ffwyk9vfi6gcfkibm0hgmd"))))
> +      (build-system go-build-system)
> +      (arguments
> +       '(#:import-path "github.com/judwhite/go-svc"))
> +      (propagated-inputs (list go-golang-org-x-sys))
> +      (home-page "https://github.com/mreiferson/go-svc")
> +      (synopsis "Go Windows Service wrapper that plays nice with Linux")
> +      (description
> +       "Go Windows Service wrapper that plays nice with Linux.  Windows tests
> +@@url{https://github.com/judwhite/go-svc/raw/master/svc/svc_windows_test.go,here}.")
> +      (license license:expat))))

Reading this makes me wonder when the code path would ever be used on
GNU/Linux.  Probably never.  Perhaps an alternative would eb to edit it
out of the go.mod, if it still builds without too many problems.

Otherwise, LGTM.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.