GNU bug report logs - #65110
eshell variable triggers error

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65110 in the body.
You can then email your comments to 65110 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raoul Comninos <revcomninos <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: eshell variable triggers error
Date: Sun, 6 Aug 2023 10:51:44 +0200

[Message part 1 (text/plain, inline)]

If I set this variable:

(setq eshell-list-files-after-cd t)

Emacs egnerates an error in eshell when changing directories:

Assertion failed: (> (cdar handle) 0), 0

The error disappears if the variable is set to nil.

I am running:GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2023-08-03

Windows 11

Kindest regards,
Raoul Comninos

[Message part 2 (text/html, inline)]

Message #8 received at 65110 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Raoul Comninos <revcomninos <at> gmail.com>, 65110 <at> debbugs.gnu.org
Subject: Re: bug#65110: eshell variable triggers error
Date: Sun, 6 Aug 2023 12:20:26 -0700

On 8/6/2023 1:51 AM, Raoul Comninos wrote:
> If I set this variable:
> 
> (setq eshell-list-files-after-cd t)
> 
> Emacs egnerates an error in eshell when changing directories:
> 
> Assertion failed: (> (cdar handle) 0), 0

It looks like this regressed due to commit 
073da412a139e317959f56e359ed12de726a0a35, which fixed bug#59545. I'll 
take a look at resolving this.

The I/O refcounting code in Eshell is pretty tricky. I have a WIP patch 
that will hopefully make it less error-prone, but I'll worry about that 
later...

Message #11 received at 65110 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Raoul Comninos <revcomninos <at> gmail.com>, 65110 <at> debbugs.gnu.org
Subject: Re: bug#65110: eshell variable triggers error
Date: Sun, 6 Aug 2023 13:44:21 -0700

[Message part 1 (text/plain, inline)]

On 8/6/2023 12:20 PM, Jim Porter wrote:
> The I/O refcounting code in Eshell is pretty tricky. I have a WIP patch 
> that will hopefully make it less error-prone, but I'll worry about that 
> later...

Happily, this issue *wasn't* a bug in the I/O refcounting code. The 
failed assertion (which is new in Emacs 30 and exists for exactly this 
reason) just revealed a bug in another part of Eshell. Fix attached 
(plus fixing another issue mentioned in the code comments) with some 
regression tests.

Let me know if this works for you, or if you see any further issues.

[0001-Fix-listing-of-directory-contents-after-cd-in-Eshell.patch (text/plain, attachment)]

Message #16 received at 65110-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Raoul Comninos <revcomninos <at> gmail.com>, 65110-done <at> debbugs.gnu.org
Subject: Re: bug#65110: eshell variable triggers error
Date: Mon, 7 Aug 2023 19:41:35 -0700

On 8/6/2023 1:44 PM, Jim Porter wrote:
> Happily, this issue *wasn't* a bug in the I/O refcounting code. The 
> failed assertion (which is new in Emacs 30 and exists for exactly this 
> reason) just revealed a bug in another part of Eshell. Fix attached 
> (plus fixing another issue mentioned in the code comments) with some 
> regression tests.
> 
> Let me know if this works for you, or if you see any further issues.

After discussing this off-list, this looks good (thanks for testing!). 
Merged to master as 301e6a747ac, and closing this now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.