GNU bug report logs - #65102
30.0.50; `byte-recompile-directory' ignores every file

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65102 in the body.
You can then email your comments to 65102 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wing Hei Chan <whmunkchan <at> outlook.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.50; `byte-recompile-directory' ignores every file
Date: Sat, 5 Aug 2023 13:16:41 +0000

The `ignore-files-regexp' in `byte-recompile-directory' is bound to the
result of (mapconcat #'identity byte-compile-ignore-files "\\|"),
which is simply an empty string when `byte-compile-ignore-files' is
empty.  In turn, this causes every file to be ignored, since
`string-match-p' matches every string when given an empty regexp.

Message #8 received at 65102 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Wing Hei Chan <whmunkchan <at> outlook.com>
Cc: 65102 <at> debbugs.gnu.org
Subject: Re: bug#65102: 30.0.50; `byte-recompile-directory' ignores every file
Date: Sun, 06 Aug 2023 06:08:24 +0200

Wing Hei Chan <whmunkchan <at> outlook.com> writes:

> The `ignore-files-regexp' in `byte-recompile-directory' is bound to the
> result of (mapconcat #'identity byte-compile-ignore-files "\\|"),
> which is simply an empty string when `byte-compile-ignore-files' is
> empty.  In turn, this causes every file to be ignored, since
> `string-match-p' matches every string when given an empty regexp.

Indeed (to reproduce one has to make sure that one tries a call where
files are actually expected to be compiled, and even in this case
nothing is done - thanks for finding this!).

We probably should use regexp-unmatchable instead of an empty string
when the option is nil.

Do we also need to wrap the regexps into shy groups, or something else?


Thx,
Michael.

Message #13 received at 65102-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Wing Hei Chan <whmunkchan <at> outlook.com>, 65102-done <at> debbugs.gnu.org
Subject: Re: bug#65102: 30.0.50; `byte-recompile-directory' ignores every file
Date: Sat, 5 Aug 2023 21:32:21 -0700

On 8/5/2023 6:16 AM, Wing Hei Chan wrote:
> The `ignore-files-regexp' in `byte-recompile-directory' is bound to the
> result of (mapconcat #'identity byte-compile-ignore-files "\\|"),
> which is simply an empty string when `byte-compile-ignore-files' is
> empty.  In turn, this causes every file to be ignored, since
> `string-match-p' matches every string when given an empty regexp.

This should be fixed by commit 1e8322bb26e, now merged to both master 
and the release branch. (I had to read up on how gitmerge.el works, so 
hopefully I did the merge properly.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.