GNU bug report logs - #65052
30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 65052 <at> debbugs.gnu.org
Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired
Date: Sat, 05 Aug 2023 13:02:53 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: 65052 <at> debbugs.gnu.org
> Date: Sat, 05 Aug 2023 11:27:08 +0200
> 
> >> Hmm... okay, but I wonder why not call image-dired-track-original-file
> >> and image-dired--update-header-line directly from each of these new
> >> commands, after scroll-up/down, instead of implementing this as a
> >> macro (which calls another macro).  That would have been much simpler
> >> and easier to follow.  Or is there something I'm missing here?
> >
> > Yes it would be much simpler.  I was trying to "stay in line" with the
> > current code.  I could try to add the scroll-up/down feature and maybe,
> > in a later patch, try to remove thoses macros.  WDYT?
> 
> Here.  The code is more obvious this way and I think we should do the
> same for other movements.

Yes, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.