GNU bug report logs - #65052
30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired

Previous Next

Full log

Message #26 received at 65052 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 65052 <at> debbugs.gnu.org
Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update
 tracking info in image-dired
Date: Sat, 05 Aug 2023 11:27:08 +0200

[Message part 1 (text/plain, inline)]

Manuel Giraud <manuel <at> ledu-giraud.fr> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> [...]
>
>> Hmm... okay, but I wonder why not call image-dired-track-original-file
>> and image-dired--update-header-line directly from each of these new
>> commands, after scroll-up/down, instead of implementing this as a
>> macro (which calls another macro).  That would have been much simpler
>> and easier to follow.  Or is there something I'm missing here?
>
> Yes it would be much simpler.  I was trying to "stay in line" with the
> current code.  I could try to add the scroll-up/down feature and maybe,
> in a later patch, try to remove thoses macros.  WDYT?

Here.  The code is more obvious this way and I think we should do the
same for other movements.
-- 
Manuel Giraud

[0001-Scroll-up-and-down-in-image-dired.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.