GNU bug report logs - #65052
30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired

Previous Next

Full log

View this message in rfc822 format

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 65052 <at> debbugs.gnu.org
Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired
Date: Fri, 04 Aug 2023 22:58:25 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

[...]

> OK, but then this part:
>
>> +  ;; "one line" dance to update tracking and header
>> +  (image-dired-next-line)
>> +  (image-dired-previous-line))
>
> looks like a kludge.  Can't we have a cleaner code for updating the
> header data?  If image-dired-previous/next-line can update the data,
> why cannot the scroll commands do the same without calling the
> line-movement commands?

You're right.  Here is a cleaner version inspired by
`image-dired--movement-command-line'.
-- 
Manuel Giraud

[0001-Scroll-up-and-down-in-image-dired.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.