From unknown Fri Aug 15 15:30:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65052 <65052@debbugs.gnu.org> To: bug#65052 <65052@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired Reply-To: bug#65052 <65052@debbugs.gnu.org> Date: Fri, 15 Aug 2025 22:30:11 +0000 retitle 65052 30.0.50; [PATCH] Scroll-{up, down} does not update tracking i= nfo in image-dired reassign 65052 emacs submitter 65052 Manuel Giraud severity 65052 normal tag 65052 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 04 10:56:02 2023 Received: (at submit) by debbugs.gnu.org; 4 Aug 2023 14:56:02 +0000 Received: from localhost ([127.0.0.1]:54506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRwDh-0001jR-HU for submit@debbugs.gnu.org; Fri, 04 Aug 2023 10:56:02 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRwDf-0001jA-DX for submit@debbugs.gnu.org; Fri, 04 Aug 2023 10:56:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwDZ-00089T-OM for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 10:55:53 -0400 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwDV-00021R-V5 for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 10:55:53 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=/Nw2GWYW P9Nj3TaLhtZ+thqN8VTjf+ytduxvPTKl71Y=; h=date:subject:to:from; d=ledu-giraud.fr; b=HHZOpeTbsq25pdj6xl0hQYYUUvFr7qvBBIf88aSmPnkb+J2clB zbuZ0Izq5rPT3o6gOVjF6K+PKm2w0rG9KcBA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=/Nw2GWYWP9Nj3TaL htZ+thqN8VTjf+ytduxvPTKl71Y=; h=date:subject:to:from; d=ledu-giraud.fr; b=ABzasztHn0n/Q1f1Hzog9Xmp0CUcheI5dwOdMCVkzIU1xXxCOl Fx+FRUCf9tQBPXNZrx1ol4DqmI2w68OQvLsyWnWdlLjz3c2NV7phhVydr9l4ivZylyCXOJ ktxQjOWA0KF+3y/vFwLs43HeB/DHNPgEPq8+a/1vt0adWeioGRXvEcT/8rQ9q1DYRsiv8B lPewLtsbRTioXJp1dszuCcwvrIXddER+YXjE36tp6gRUL6rrOaiX5Mt0e8oB8gB+iI8qVQ FPbPmg4zv8na3xL96X7/rpCL6fi8F9/4gPdtFv/QZYnt7drvH9/Q3wCh5Gnvpgck421D6L dYX6TCK6NTIA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 1012ddde (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 4 Aug 2023 16:55:46 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired Date: Fri, 04 Aug 2023 16:55:45 +0200 Message-ID: <87ttteq2ku.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Hi, Here is a patch that updates header tracking in image-dired when scrolling up or down. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Scroll-up-and-down-in-image-dired.patch >From 48910a1c0f97387edafa8616537ff1538dca65f8 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 9 Mar 2023 14:35:31 +0100 Subject: [PATCH] Scroll up and down in image-dired * lisp/image/image-dired.el (image-dired-scroll-up) (image-dired-scroll-down): Scroll up and down command in image-dired. (image-dired-thumbnail-mode-map): Use them. --- lisp/image/image-dired.el | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 33beb5b3e49..b514730d0d9 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -770,6 +770,22 @@ image-dired-move-end-of-line (interactive nil image-dired-thumbnail-mode) (image-dired--movement-command (pos-eol) 'reverse)) +(defun image-dired-scroll-up () + "Scroll up the in thumbnail buffer." + (interactive nil image-dired-thumbnail-mode) + (scroll-up) + ;; "one line" dance to update tracking and header + (image-dired-next-line) + (image-dired-previous-line)) + +(defun image-dired-scroll-down () + "Scroll down the in thumbnail buffer." + (interactive nil image-dired-thumbnail-mode) + (scroll-down) + ;; "one line" dance to update tracking and header + (image-dired-previous-line) + (image-dired-next-line)) + ;;; Header line @@ -980,6 +996,8 @@ image-dired-thumbnail-mode-map " " #'image-dired-end-of-buffer " " #'image-dired-move-beginning-of-line " " #'image-dired-move-end-of-line + " " #'image-dired-scroll-up + " " #'image-dired-scroll-down :menu '("Image-Dired" -- 2.40.0 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 2, x86_64-unknown-openbsd7.3, cairo version 1.17.8) of 2023-08-04 built on computer Repository revision: 60e5f212182ca2f41f89a4315075e38433bc8ac0 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD computer 7.3 GENERIC.MP#1125 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --with-toolkit-scroll-bars=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t paredit-mode: t display-time-mode: t display-battery-mode: t server-mode: t override-global-mode: t repeat-mode: t desktop-save-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/ef-themes-1.2.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs Features: (shadow misearch multi-isearch sort gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml gnus-topic mm-archive url-cache qp utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss emacsbug magit-patch magit-extras face-remap magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff git-commit log-edit add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-section magit-utils dash ibuf-ext ibuffer ibuffer-loaddefs image-file image-converter image-dired image-dired-tags image-dired-external image-dired-util org-agenda mule-util on-screen css-mode sgml-mode facemenu imenu vc org-indent pascal vc-hg conf-mode view reveal texinfo texinfo-loaddefs smerge-mode diff emacs-news-mode oc-basic org-element org-persist org-id avl-tree ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-version org-compat org-macs whitespace vc-cvs vc-rcs log-view pcvs-util make-mode sh-script smie treesit executable vc-git diff-mode vc-dispatcher vc-svn bug-reference paredit gnus-dired time battery cus-load exwm-randr xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server modus-operandi-theme modus-themes zone speed-type url-http url-auth url-gw nsm compat ytdious mingus libmpdee reporter edebug debug backtrace detached-init detached autorevert filenotify transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base pcase timezone icalendar gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit visual-basic-mode cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint ansi-osc ansi-color ring hyperspec thingatpt slime-autoloads edmacro kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-x dired-aux dired dired-loaddefs notifications dbus xml cl-extra help-mode use-package-core repeat easy-mmode desktop frameset debbugs-autoloads detached-autoloads ebdb-autoloads ef-themes-autoloads exwm-autoloads hyperbole-autoloads magit-autoloads git-commit-autoloads finder-inf magit-section-autoloads md4rd-autoloads dash-autoloads on-screen-autoloads osm-autoloads paredit-autoloads request-autoloads rust-mode-autoloads s-autoloads speed-type-autoloads transmission-autoloads tree-mode-autoloads visual-fill-column-autoloads with-editor-autoloads info compat-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 1057313 730582) (symbols 48 63122 23) (strings 32 306271 44990) (string-bytes 1 9931531) (vectors 16 189944) (vector-slots 8 3240300 61907) (floats 8 662 1451) (intervals 56 27960 3941) (buffers 984 134)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 04 11:24:12 2023 Received: (at 65052) by debbugs.gnu.org; 4 Aug 2023 15:24:12 +0000 Received: from localhost ([127.0.0.1]:54575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRwex-0002b0-L3 for submit@debbugs.gnu.org; Fri, 04 Aug 2023 11:24:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRwev-0002an-T6 for 65052@debbugs.gnu.org; Fri, 04 Aug 2023 11:24:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRweq-0002Cl-0a; Fri, 04 Aug 2023 11:24:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VoP4EkZqMdvSpQQm9OieJvd7jZHVQ4rDFBCKp6yorYg=; b=PalwJsIYfgwn KyoVelr+xnyZKaRGwukXnCjtsxihYSgoIA5H92GEqUv4+XwVJoibmjswrZCikiFa2XIW5bxhHG+TM /O+9ODYve/VzB0bgY4HIUUADh8G3AfyLTW++6AxzjLqdwGKURijWjyIhRVDj16GQ16HpxzNArdicH lp2H6f7xiCdTxkj+wuulhovYHnw4JZJUbHzokBlcR9O6XSflrhunbbCa7B+O819SYGa9/tOWIc8Rp ipcVnjRxqjf+gmycyQy/aAET4gi3WYV52mYJftLY0bNg2GfmYxexx2V1iJJHPtNrHZQKnc8ZwkXFW peQlW4ExdU+WKpoXV6z7Ug==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwep-0007Zr-6A; Fri, 04 Aug 2023 11:24:03 -0400 Date: Fri, 04 Aug 2023 18:24:16 +0300 Message-Id: <83il9uvnj3.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87ttteq2ku.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 04 Aug 2023 16:55:45 +0200 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Here is a patch that updates header tracking in image-dired when > scrolling up or down. What is "header tracking"? More generally, could you please explain what problem are you trying to solve here? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 04 14:25:36 2023 Received: (at 65052) by debbugs.gnu.org; 4 Aug 2023 18:25:36 +0000 Received: from localhost ([127.0.0.1]:54860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRzUV-0004c2-M0 for submit@debbugs.gnu.org; Fri, 04 Aug 2023 14:25:35 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:11116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRzUT-0004bu-Hy for 65052@debbugs.gnu.org; Fri, 04 Aug 2023 14:25:34 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=GyqxXZnJ /LZwzt9/hQ4bl2F8qFRdqvniVod/hecZmZk=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=O4IWMoIG1lw62stn0hBqPhdUaTXMIJ 0POn4uHgJJp+6UMKEc6CAZRPPlPrrp4oUbMqSskBQSi61njymOaXuNAQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=GyqxXZnJ/LZwzt9/ hQ4bl2F8qFRdqvniVod/hecZmZk=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Tiw+ONrkj2ey4WcPrLDrgxYrduRzHq8JwLEm9p 5JcBcM6COnn0hA3mFFuTbKGREgoqUA7qRkwBttK6ViuIIa0LjCo/hZbduk+3FRmgqxkHVb ilmOqQ1CpPQhJ2VGr7XYBAxlhETSJqkwKm/VHqOJ89MuQ8BRibKmxEukUX8+37mlmpZCZu wzg4wfdb8SDgmvUMLdv+hS0e3nCHBdwSzLck6Lmbq7qxkXinSIgyn67YW4SaPJA2Q1saeN BYUaxfm8kGdZZ8mqSPT2AcJ9R6XrXP5PzgU2aeKFJFjtsbUVyhLbyDyqFD5KhS9bM8+SMf 2bZXqBpQ/5VWByTZepk0cp3Q== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id a61388a6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 4 Aug 2023 20:25:32 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired In-Reply-To: <83il9uvnj3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Aug 2023 18:24:16 +0300") References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> Date: Fri, 04 Aug 2023 20:25:30 +0200 Message-ID: <87pm42psv9.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Fri, 04 Aug 2023 16:55:45 +0200 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Here is a patch that updates header tracking in image-dired when >> scrolling up or down. > > What is "header tracking"? > > More generally, could you please explain what problem are you trying > to solve here? Yes, sorry. When you are using image-dired, there is a header line with some informations (by default name of the file, its size and so on, see `image-dired-display-properties-format'). Those informations are updated when you move from one thumbnail to another (by mean of C-{f,b,n,p}). But they are not updated with C-v/M-v. This patch fixes this. (BTW "tracking" is not the correct word here as it means something else in image-dired) -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 04 15:07:03 2023 Received: (at 65052) by debbugs.gnu.org; 4 Aug 2023 19:07:03 +0000 Received: from localhost ([127.0.0.1]:54883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS08d-0005qE-Du for submit@debbugs.gnu.org; Fri, 04 Aug 2023 15:07:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS08b-0005pi-IV for 65052@debbugs.gnu.org; Fri, 04 Aug 2023 15:07:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qS08U-0002rG-HJ; Fri, 04 Aug 2023 15:06:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OdQ46Q0lE6NogwwM/zio5cdw/oifsYG1A3kekfRs6YM=; b=AY22+0txMOvs nRQMzHmV29eYF4pvmN7m6HvLH/81RkwO3mJsu/0pNmAfbfwIz7UgTuMgGDYsFnUbkT7sAM29IECDU c9CicU122LELQ+wBKUKuZUM2Ny5+9ibIimw2F/zFjIUcw+az6VeBdl6Q9NnKI2x2+pcHtmJiIXipg MCzXYo+wx8UjMd2Ao150A23dMRoNN0KgqhyN6SoR0h2th3/135eLsaBAfjXvPvQzktjdxY7gPe/vT 4/52WHd84PZjCy0KvNLMb9xLWeCltLdp2LbWWKaunifZUblMiTG43/V0NuZ1boMm9jfMT/V/T3iP+ KwJB3WjB0DDaqNwWXkJPJw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qS08U-0006aa-5g; Fri, 04 Aug 2023 15:06:54 -0400 Date: Fri, 04 Aug 2023 22:07:07 +0300 Message-Id: <834jlevd7o.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87pm42psv9.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 04 Aug 2023 20:25:30 +0200) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Fri, 04 Aug 2023 20:25:30 +0200 > > Eli Zaretskii writes: > > >> Date: Fri, 04 Aug 2023 16:55:45 +0200 > >> From: Manuel Giraud via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> Here is a patch that updates header tracking in image-dired when > >> scrolling up or down. > > > > What is "header tracking"? > > > > More generally, could you please explain what problem are you trying > > to solve here? > > Yes, sorry. When you are using image-dired, there is a header line with > some informations (by default name of the file, its size and so on, see > `image-dired-display-properties-format'). Those informations are > updated when you move from one thumbnail to another (by mean of > C-{f,b,n,p}). But they are not updated with C-v/M-v. This patch fixes > this. OK, but then this part: > + ;; "one line" dance to update tracking and header > + (image-dired-next-line) > + (image-dired-previous-line)) looks like a kludge. Can't we have a cleaner code for updating the header data? If image-dired-previous/next-line can update the data, why cannot the scroll commands do the same without calling the line-movement commands? From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 04 16:58:32 2023 Received: (at 65052) by debbugs.gnu.org; 4 Aug 2023 20:58:32 +0000 Received: from localhost ([127.0.0.1]:54964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS1sW-0000Gn-9o for submit@debbugs.gnu.org; Fri, 04 Aug 2023 16:58:32 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:48703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS1sT-0000Gd-BR for 65052@debbugs.gnu.org; Fri, 04 Aug 2023 16:58:31 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=uZP1VW31 Ht6P60E75QMm1KBnA03Frd2jXv7BMLV2CvE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=vF7bAD61sC9RmHtUFtS+6y2h8E4AsS tm6kyRNnHQzcbnxK3BD8fIxCQiGFvYIUc+9/RfiUtjBwt5bStfdSf/CQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=uZP1VW31Ht6P60E7 5QMm1KBnA03Frd2jXv7BMLV2CvE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=ofl+q9lufmrmlKDFxHE11mlaCeKrR6bchSiYVU AxuuZ+nAjGn1xat16uJs4I1NTLb7Mdzg8GrohFIBnKpoaEZSCMhmNFXhyoKB++ivZmnaEQ GvF2M2KSHA2mfS7E1JmxRc19tI+7QJPpMOfxhsfCnFWOIlqgnav5VEc5Qd862XpLouA3q4 dVupJaIU1E7uijqPotkSLVL4H2Hm+bK5JiZ+OhoAUQMyqyrfgEHj2Lgu4dIjtlxgXDfi4H zuMvEtOWVBpHSdXJMETfp1QREHdknvrG1OCctupe9WpOErnenQbxMGTbw6FSm7IJbaZcT6 Dy5qjh4BIL0ariPk6VnydGgQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id a2513069 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 4 Aug 2023 22:58:27 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired In-Reply-To: <834jlevd7o.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Aug 2023 22:07:07 +0300") References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> Date: Fri, 04 Aug 2023 22:58:25 +0200 Message-ID: <87r0oied8u.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > OK, but then this part: > >> + ;; "one line" dance to update tracking and header >> + (image-dired-next-line) >> + (image-dired-previous-line)) > > looks like a kludge. Can't we have a cleaner code for updating the > header data? If image-dired-previous/next-line can update the data, > why cannot the scroll commands do the same without calling the > line-movement commands? You're right. Here is a cleaner version inspired by `image-dired--movement-command-line'. -- Manuel Giraud --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Scroll-up-and-down-in-image-dired.patch >From 9395c814d5664f5d31490ee63de43fa3478b7143 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 9 Mar 2023 14:35:31 +0100 Subject: [PATCH] Scroll up and down in image-dired * lisp/image/image-dired.el (image-dired--movement-command-scroll): Macro to manage scroll in image-dired. (image-dired-scroll-up, image-dired-scroll-down): Scroll up and down command in image-dired. (image-dired-thumbnail-mode-map): Use them. --- lisp/image/image-dired.el | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 33beb5b3e49..067134fd331 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -740,6 +740,16 @@ image-dired--movement-command-line (point)) ,reverse)) +(defmacro image-dired--movement-command-scroll (&optional reverse) + `(image-dired--movement-command + (let ((goal-column (current-column))) + ,(if reverse + '(scroll-down) + '(scroll-up)) + (move-to-column goal-column) + (point)) + ,reverse)) + (defun image-dired-next-line () "Move to next line in the thumbnail buffer." (interactive nil image-dired-thumbnail-mode) @@ -770,6 +780,16 @@ image-dired-move-end-of-line (interactive nil image-dired-thumbnail-mode) (image-dired--movement-command (pos-eol) 'reverse)) +(defun image-dired-scroll-up () + "Scroll up the in thumbnail buffer." + (interactive nil image-dired-thumbnail-mode) + (image-dired--movement-command-scroll)) + +(defun image-dired-scroll-down () + "Scroll down the in thumbnail buffer." + (interactive nil image-dired-thumbnail-mode) + (image-dired--movement-command-scroll 'reverse)) + ;;; Header line @@ -980,6 +1000,8 @@ image-dired-thumbnail-mode-map " " #'image-dired-end-of-buffer " " #'image-dired-move-beginning-of-line " " #'image-dired-move-end-of-line + " " #'image-dired-scroll-up + " " #'image-dired-scroll-down :menu '("Image-Dired" -- 2.40.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 01:43:29 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 05:43:29 +0000 Received: from localhost ([127.0.0.1]:55233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSA4X-0008Fi-Aj for submit@debbugs.gnu.org; Sat, 05 Aug 2023 01:43:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSA4W-0008FU-0w for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 01:43:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSA4Q-0006D6-2j; Sat, 05 Aug 2023 01:43:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zG20PSfqujhU62U1WQa4Jf8TzW7JNCBx2CafyvdhK90=; b=Uq69Atkp/fw6 /JtGgEHM8VMFzUsIYvPsuwgSau314SYmoGyNxTKrNoO/IuA13CbWSxlapTM8FFvlJqhxbMz0q2Oqp O3BIuIoC7EBC+5NXo29ZABXINEFyXb9RQNSzvovcvCIjD/dfZNRixFFLPxsCujFbjnKjRrfKSjD1W jQJPTzZBPopuIX4L/Bu96L5XmySaRVIXF6RTRMdADiQL44M4yfbGrlh2dHoHOq2xXzR2M29s6n5kU aXUnXbLgL7hbnBKneRgCnqkhKSYkpG6un0j+kU/y+qxii1QVBXakMb7XC4pkuWZK3SSuYS7hUjjiP ExEAJcC3GuHJYv6ZJCoLKg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSA4O-0000z8-K3; Sat, 05 Aug 2023 01:43:21 -0400 Date: Sat, 05 Aug 2023 08:43:35 +0300 Message-Id: <83y1iqt56g.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87r0oied8u.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 04 Aug 2023 22:58:25 +0200) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Fri, 04 Aug 2023 22:58:25 +0200 > > Eli Zaretskii writes: > > [...] > > > OK, but then this part: > > > >> + ;; "one line" dance to update tracking and header > >> + (image-dired-next-line) > >> + (image-dired-previous-line)) > > > > looks like a kludge. Can't we have a cleaner code for updating the > > header data? If image-dired-previous/next-line can update the data, > > why cannot the scroll commands do the same without calling the > > line-movement commands? > > You're right. Here is a cleaner version inspired by > `image-dired--movement-command-line'. Hmm... okay, but I wonder why not call image-dired-track-original-file and image-dired--update-header-line directly from each of these new commands, after scroll-up/down, instead of implementing this as a macro (which calls another macro). That would have been much simpler and easier to follow. Or is there something I'm missing here? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 04:32:46 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 08:32:46 +0000 Received: from localhost ([127.0.0.1]:55449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSCiL-0006kY-Oj for submit@debbugs.gnu.org; Sat, 05 Aug 2023 04:32:46 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:32601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSCiI-0006kN-Uw for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 04:32:44 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=KcrEOjSa 9B2NlDh6wrpF11L7u1aMyGscWisWRsgj3F0=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=mw5/NbSI/8CQNUDs2iMQgzTYoVs8cG DcawxvUtB3xDeKRSULtV+PcPaAtnP1TuZh1MjWifQdppzbke0OjVZRDQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=KcrEOjSa9B2NlDh6 wrpF11L7u1aMyGscWisWRsgj3F0=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=p9a9hDRYpXwX6Hq5tJ8Odwmyj56rxQhTBd7dIv db+XioBpGrodOwA9WlJDz6R8Mnz1oUMuiKHAG5Fu/ry0/5T1iSNAQOLzNJLJwIOW+ssPPn RdB8ODQdxyr1l2QVjQJFUZ5jVE8S4twVWGWWzlm8PauM/OlTF7cKT15KpWs1g6z4W3WIxH /bnw3MUYae6J/SWqMlwVxUNiA/CverkJV3+U8EBKwTBHUVBrmVBj/LQfMr4HICIMladwYY vv6d+0ghRHNJplHU0rz5ChjWDxYEA/7vTgqLBtfVCiYHbnkwS+gbehJ3hods/wNT0QyVwT fHvA2PRDh+MrTCLY3R8Drr/g== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 20ee7646 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Aug 2023 10:32:41 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired In-Reply-To: <83y1iqt56g.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Aug 2023 08:43:35 +0300") References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> Date: Sat, 05 Aug 2023 10:32:39 +0200 Message-ID: <87msz5evo8.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > Hmm... okay, but I wonder why not call image-dired-track-original-file > and image-dired--update-header-line directly from each of these new > commands, after scroll-up/down, instead of implementing this as a > macro (which calls another macro). That would have been much simpler > and easier to follow. Or is there something I'm missing here? Yes it would be much simpler. I was trying to "stay in line" with the current code. I could try to add the scroll-up/down feature and maybe, in a later patch, try to remove thoses macros. WDYT? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 05:27:16 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 09:27:16 +0000 Received: from localhost ([127.0.0.1]:55661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSDZ5-0008WT-U6 for submit@debbugs.gnu.org; Sat, 05 Aug 2023 05:27:16 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:36106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSDZ3-0008WD-G2 for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 05:27:15 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=d7d2o36l NCl+cWeyzbpo5X3AKVOp3ROPccmBTzgmW4w=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=PTr/wO8vCbXoER38WY8AbBWOJWZCa9 sEY6DB8ZN8hBj/t6J2jZsZEII6xVdGF8C5hwTaB5C+lemAgI9rvMb5Aw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=d7d2o36lNCl+cWey zbpo5X3AKVOp3ROPccmBTzgmW4w=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=WBhbiX6bmAFbDSD93q92QdglUDgWqgCVAVbmlR 2tYya2XQ3bYntyGLM5sv0q2+twU9gT0f1cDg3IXRQ/zPRb5WmuDsNNKbv3Gdkn1nkHpwIJ OfsvS/b7LtYCDF+2wwgToJ4fLZdH3QieiRTCGhWSfbKwMMywsMomMvhKNFSUnSRckJdGYl OUmB57W+YpL12h+ilUV4P1WiWrOsviVryYJ2IIXvmZQdWYbQOHphNlyTqitMvB5vlWgA/u VH1JW4PDde+5UAozy0p7XaWzXXeCM3ddCIIGVaBuZvZ3z2wPyL/Pv9bbwC49gtfbAN5O0d bXtxQJXsnObuMkWJgrcrQpJg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id e511b406 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Aug 2023 11:27:11 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired In-Reply-To: <87msz5evo8.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Sat, 05 Aug 2023 10:32:39 +0200") References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> Date: Sat, 05 Aug 2023 11:27:08 +0200 Message-ID: <87zg35c00j.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Manuel Giraud writes: > Eli Zaretskii writes: > > [...] > >> Hmm... okay, but I wonder why not call image-dired-track-original-file >> and image-dired--update-header-line directly from each of these new >> commands, after scroll-up/down, instead of implementing this as a >> macro (which calls another macro). That would have been much simpler >> and easier to follow. Or is there something I'm missing here? > > Yes it would be much simpler. I was trying to "stay in line" with the > current code. I could try to add the scroll-up/down feature and maybe, > in a later patch, try to remove thoses macros. WDYT? Here. The code is more obvious this way and I think we should do the same for other movements. -- Manuel Giraud --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Scroll-up-and-down-in-image-dired.patch >From 4983e589f1e841c6a49a93d166970a18d4359a88 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 9 Mar 2023 14:35:31 +0100 Subject: [PATCH] Scroll up and down in image-dired * lisp/image/image-dired.el (image-dired-scroll): Function to manage scroll in image-dired. (image-dired-scroll-up, image-dired-scroll-down): Scroll up and down command in image-dired. (image-dired-thumbnail-mode-map): Use them. --- lisp/image/image-dired.el | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 33beb5b3e49..4e213587e7a 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -770,6 +770,24 @@ image-dired-move-end-of-line (interactive nil image-dired-thumbnail-mode) (image-dired--movement-command (pos-eol) 'reverse)) +(defun image-dired-scroll (&optional down) + "Scroll in the thumbnail buffer." + (let ((goal-column (current-column))) + (if down (scroll-down) (scroll-up)) + (move-to-column goal-column) + (image-dired--movement-ensure-point-pos down) + (when image-dired-track-movement + (image-dired-track-original-file)) + (image-dired--update-header-line))) + +(defun image-dired-scroll-up () + (interactive nil image-dired-thumbnail-mode) + (image-dired-scroll)) + +(defun image-dired-scroll-down () + (interactive nil image-dired-thumbnail-mode) + (image-dired-scroll 'down)) + ;;; Header line @@ -980,6 +998,8 @@ image-dired-thumbnail-mode-map " " #'image-dired-end-of-buffer " " #'image-dired-move-beginning-of-line " " #'image-dired-move-end-of-line + " " #'image-dired-scroll-up + " " #'image-dired-scroll-down :menu '("Image-Dired" -- 2.40.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 05:29:10 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 09:29:10 +0000 Received: from localhost ([127.0.0.1]:55667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSDaw-00008E-HC for submit@debbugs.gnu.org; Sat, 05 Aug 2023 05:29:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSDav-000081-9h for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 05:29:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSDaq-0005jt-10; Sat, 05 Aug 2023 05:29:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=l2FgviO3wDJ5fbLJACf4RFq2myFyNjVNKD/c3Jgqeho=; b=NcVf/mtnGVse NtPbmzb+J7heSBFigD5XDgTDFJzTk/yxQZpfZxTNwWNOD5GBd+F4gL7JMzQfXcAvRn2sQbhNuteDX OOGzif4gIyE9BC/ycubviXkO9ncec+Xh5w5Yb1xv3yJPRmNno2PLPrjM/5YEbFjNoFvAPUKcg+8XM xnZeHVlOaClqGoe2MRfuXz9libm/SOJFXsGt3+buTyN8rKpjxGMjBO5fYy/1Xmzz0Ju8jX89V9ps+ 0piqH8VrvQRpN7Uj3q5VfWfPyrgQAILEo+Df/IqXD3z1nyBxlYkIKjI57cIJ94pEKtFcrs/oRnQra yc8SnpO05C9GdlxyQq5QBQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSDai-0004D5-2F; Sat, 05 Aug 2023 05:29:03 -0400 Date: Sat, 05 Aug 2023 12:29:11 +0300 Message-Id: <835y5tu9aw.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87msz5evo8.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 05 Aug 2023 10:32:39 +0200) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Sat, 05 Aug 2023 10:32:39 +0200 > > Eli Zaretskii writes: > > [...] > > > Hmm... okay, but I wonder why not call image-dired-track-original-file > > and image-dired--update-header-line directly from each of these new > > commands, after scroll-up/down, instead of implementing this as a > > macro (which calls another macro). That would have been much simpler > > and easier to follow. Or is there something I'm missing here? > > Yes it would be much simpler. I was trying to "stay in line" with the > current code. I could try to add the scroll-up/down feature and maybe, > in a later patch, try to remove thoses macros. WDYT? Fine by me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 06:02:48 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 10:02:48 +0000 Received: from localhost ([127.0.0.1]:55707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSE7T-00013c-Ph for submit@debbugs.gnu.org; Sat, 05 Aug 2023 06:02:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSE7S-00013R-OB for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 06:02:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSE7M-0003Di-Nn; Sat, 05 Aug 2023 06:02:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SVnPn0ZDZqxg87UMEI6PQSdJuBZgYvCZF4sxOK48Bho=; b=DSnG3GYvyUjt xUx3tKil5B/nDdMqLTkhNvNtzblgNInInvyd/RkXeMrEUkhsr1loICYHqDeDe6DNVkrbHZnGASPGP blPpKCGv5JQsYt9QpCR22q9NGc3bYaMR3yxbYubSGDAxd67LEoO4Gro+KH2Ho6LXLYCgCbYxS9YfS jLFrG+06MGjvu2eGAu1Z/DXQPYfcLY0zeASu85NMcFXO3EiW/7u+bRUTeDLcWNl3EXh1UbnS+FMNI eRwYk7DYw59azGoIP7oZL9s3A7Y+q2nShgQwazwSDyoQpnr9cMLIiI6OXvuAoupxyUGm0xBWohLeT G2w3Fj7eoNraNCPOtHcBRA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSE7K-0007im-H5; Sat, 05 Aug 2023 06:02:39 -0400 Date: Sat, 05 Aug 2023 13:02:53 +0300 Message-Id: <83y1ipst6a.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87zg35c00j.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 05 Aug 2023 11:27:08 +0200) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Sat, 05 Aug 2023 11:27:08 +0200 > > >> Hmm... okay, but I wonder why not call image-dired-track-original-file > >> and image-dired--update-header-line directly from each of these new > >> commands, after scroll-up/down, instead of implementing this as a > >> macro (which calls another macro). That would have been much simpler > >> and easier to follow. Or is there something I'm missing here? > > > > Yes it would be much simpler. I was trying to "stay in line" with the > > current code. I could try to add the scroll-up/down feature and maybe, > > in a later patch, try to remove thoses macros. WDYT? > > Here. The code is more obvious this way and I think we should do the > same for other movements. Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 08:58:22 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 12:58:22 +0000 Received: from localhost ([127.0.0.1]:56068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSGrO-0005SK-A8 for submit@debbugs.gnu.org; Sat, 05 Aug 2023 08:58:22 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:6508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSGrL-0005S8-M3 for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 08:58:21 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=lcZCQ2Hp TUfRw+B0t43Ii3q6L5QOVTJDDPHc4OKuUPo=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=gwbWh86ccYND9TGW6IvOOmkAUF/Fxr l3jK3uVTaDRu9dhS/M+XBQcqx0LP+6o97/1eCQSD1pUgsAYK9vFmVsBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=lcZCQ2HpTUfRw+B0 t43Ii3q6L5QOVTJDDPHc4OKuUPo=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=j4SniEpzqfex4jqTL4WOGxC1DbR6O/jaS5Yn/c 3vvEFD1nvqTFoaUXH7Sha7eWjCFwN/DYSlRfVBA4orLtxKw6qR/OCe8ynv4VD6HNalr1ah N2skfqMaVe0CGWJyXYw4ZHCKlqmdhSgBzXbGuLIvU3t/walsAB2yPtoCfLQh4End9hzndd u28j3n9blnryWxOWK9bj5f1ffVZEBUM8VKJFfzqUlcgCiqjGmK6MEI1dY48JC31hZ5IMEt /lS0fkGaRkqowzc91PLlQ5r6qVD5PUPMBhJQ4KBjZZ3DhjtWVcbrbqNgQ2aizbTY44HEO0 k1GaX7c4/mj6EDnun8YHN8qQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 8e69346b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Aug 2023 14:58:17 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired In-Reply-To: <83y1ipst6a.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Aug 2023 13:02:53 +0300") References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> Date: Sat, 05 Aug 2023 14:58:16 +0200 Message-ID: <87v8dtbq8n.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 65052@debbugs.gnu.org >> Date: Sat, 05 Aug 2023 11:27:08 +0200 >> >> >> Hmm... okay, but I wonder why not call image-dired-track-original-file >> >> and image-dired--update-header-line directly from each of these new >> >> commands, after scroll-up/down, instead of implementing this as a >> >> macro (which calls another macro). That would have been much simpler >> >> and easier to follow. Or is there something I'm missing here? >> > >> > Yes it would be much simpler. I was trying to "stay in line" with the >> > current code. I could try to add the scroll-up/down feature and maybe, >> > in a later patch, try to remove thoses macros. WDYT? >> >> Here. The code is more obvious this way and I think we should do the >> same for other movements. > > Yes, thanks. Maybe I should do that into another bug report? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 09:12:14 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 13:12:14 +0000 Received: from localhost ([127.0.0.1]:56093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSH4o-0005pp-53 for submit@debbugs.gnu.org; Sat, 05 Aug 2023 09:12:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSH4m-0005pc-RT for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 09:12:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSH4g-0001vC-Sc; Sat, 05 Aug 2023 09:12:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5t/Y3gAlssTclawHf4syxXo2wlR/Z++c4GSc05Z1CGE=; b=nTXW8PNHpCPj pRIEDQq6HUVOfCwkEePACR2+qE8djLBz+uqwPASwBib00apaNc/IvYGEObuhopyh1uGF1bJSzHXJf zhHofrqLqW7rkPDXcslRHYzU3+6vPPaKLdqJU2QMlhetG3PbvkPeHYCICkOcJk/+5vBwVOsF6Djjw t6PPOeQMtwix0442SuYwqvEu0cLWktiawoHKLkcvqRynQCguPGTTvkWo/9BIbegbBRHekN9GVcujn jfUmT1MOM0isT3WPz4MUS2SXwInNg+6mjW1ck9zb5wLoOvhivudpnI1SlC8QJCkbrN/wSsyMS5XC0 hZ4g+1iGzxNsprVBOPlzug==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSH4g-0006mN-CM; Sat, 05 Aug 2023 09:12:06 -0400 Date: Sat, 05 Aug 2023 16:12:21 +0300 Message-Id: <83bkflskei.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87v8dtbq8n.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 05 Aug 2023 14:58:16 +0200) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> <87v8dtbq8n.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Sat, 05 Aug 2023 14:58:16 +0200 > > Eli Zaretskii writes: > > >> From: Manuel Giraud > >> Cc: 65052@debbugs.gnu.org > >> Date: Sat, 05 Aug 2023 11:27:08 +0200 > >> > >> >> Hmm... okay, but I wonder why not call image-dired-track-original-file > >> >> and image-dired--update-header-line directly from each of these new > >> >> commands, after scroll-up/down, instead of implementing this as a > >> >> macro (which calls another macro). That would have been much simpler > >> >> and easier to follow. Or is there something I'm missing here? > >> > > >> > Yes it would be much simpler. I was trying to "stay in line" with the > >> > current code. I could try to add the scroll-up/down feature and maybe, > >> > in a later patch, try to remove thoses macros. WDYT? > >> > >> Here. The code is more obvious this way and I think we should do the > >> same for other movements. > > > > Yes, thanks. > > Maybe I should do that into another bug report? It's up to you. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 09:27:22 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 13:27:23 +0000 Received: from localhost ([127.0.0.1]:56182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSHJS-0006HP-FN for submit@debbugs.gnu.org; Sat, 05 Aug 2023 09:27:22 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:16843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSHJO-0006HC-Ul for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 09:27:20 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=Qpuvi+Ep rIFxIYaNdYHqsJde7LRnkVzSs9qaeCdw9vA=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=BtXAURaRbAXMILw+T90Ka4+gAJNCFL iKS9m5TSwAp/3+xr16cfEcm4vwibg2XVT54JkB01vbph79sWK0KMs5AQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=Qpuvi+EprIFxIYaN dYHqsJde7LRnkVzSs9qaeCdw9vA=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Hh0AqMjGqCV/AiwabGOvGN+M7nyWZ39x8iJgrG tipCdd2ZfPEk8+mKO4PcCWzMPBE6v6kOBpbZFLg2/FbXIWlw5SU18tvRRq2D5b/pImLpuf 0944tNsalMvwBL9mjbZDkgs9bK4aS7KTTRP/3S52DH45nzok/ArwMw+2MDWmiprzxdxF/l iu1PP3bIuZgYLjVa+PAu3qV3fSHQYxLv53aivVFxEBKMHItbcaU7yKC42KCu2GZu7CCKY5 Ijmjt56rMXa0jMVeqS8yqVgPMfPTEc8sCgAhA136uC0KEmU79Bckkk2cm3H0UzqIhjsf5M wuOz7+OutQYjWmwkRxOIuoKw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id b711155a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Aug 2023 15:27:16 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired In-Reply-To: <83bkflskei.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Aug 2023 16:12:21 +0300") References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> <87v8dtbq8n.fsf@ledu-giraud.fr> <83bkflskei.fsf@gnu.org> Date: Sat, 05 Aug 2023 15:27:14 +0200 Message-ID: <87r0ohbowd.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] >> >> > Yes it would be much simpler. I was trying to "stay in line" with the >> >> > current code. I could try to add the scroll-up/down feature and maybe, >> >> > in a later patch, try to remove thoses macros. WDYT? >> >> >> >> Here. The code is more obvious this way and I think we should do the >> >> same for other movements. >> > >> > Yes, thanks. >> >> Maybe I should do that into another bug report? > > It's up to you. Ok then I'd prefer having this macros cleanage into another bug report. Do you think you could apply the last one to master and close this bug report? I'll start from here. Thanks. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 11:28:35 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 15:28:36 +0000 Received: from localhost ([127.0.0.1]:57958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSJCj-0001au-2q for submit@debbugs.gnu.org; Sat, 05 Aug 2023 11:28:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSJCf-0001ad-3y for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 11:28:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSJCZ-0001X9-Hu; Sat, 05 Aug 2023 11:28:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=F70sdsEuWcgs1Q1Pk7dEZ4pF0yjOwZ52BmHJxywQbU4=; b=hFkk43SsSi1T S5WNA5A1EmgSWUhbRFJfzALyEQoE44c4hVSgDMfDV1d+K6OYyzXgJgIiKSQ9MEadS7lTbAc7AB/h9 oTdJXfPqPYM5WagTFpng9ezGCkGDssqesQgCQZF/X0HzcVyoIwjpJjqYwvMN1EgmFm0/LGvHNg7mJ VKY1yBcXODA9lS30yNc2wEZZ2eEy1b+OxlaftMJjlbav5seCNTagc6ccFhy7FEcpqN/fDfmTDvk34 sjD8FDK9NUWhaOV6vrEVVN8mNXMqB2Gnl9gETctijT7hCyDukYESyEU6qN9IOHwFMcCadHfQjbIXT GBYylzbgqTNUCM3zQ3QSWw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSJCZ-0007eV-1g; Sat, 05 Aug 2023 11:28:23 -0400 Date: Sat, 05 Aug 2023 18:28:38 +0300 Message-Id: <834jldse3d.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87r0ohbowd.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 05 Aug 2023 15:27:14 +0200) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> <87v8dtbq8n.fsf@ledu-giraud.fr> <83bkflskei.fsf@gnu.org> <87r0ohbowd.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Sat, 05 Aug 2023 15:27:14 +0200 > > >> Maybe I should do that into another bug report? > > > > It's up to you. > > Ok then I'd prefer having this macros cleanage into another bug report. > Do you think you could apply the last one to master and close this bug > report? I'll start from here. Thanks. Which is "the last one" that you want me to install? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 13:39:53 2023 Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 17:39:53 +0000 Received: from localhost ([127.0.0.1]:58083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSLFo-0007l3-OH for submit@debbugs.gnu.org; Sat, 05 Aug 2023 13:39:53 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:46908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSLFl-0007kr-Bc for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 13:39:51 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=/m5ndLF4 B8FIwFm/EC1Ki4KO+CRddPLVe3dBtRf6iJQ=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=VnqFa6F3cpoYmuBnUtcSgbe485vo6o by6Kw4/9cIlPLjeKwjpluI18hLh2GqRclpswGG35KMd376OOethOqVCw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=/m5ndLF4B8FIwFm/ EC1Ki4KO+CRddPLVe3dBtRf6iJQ=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=je4otLPGWKca94AvtNsq7Rlw8iM7s2RZiqQ/WB utH8YOfVs9jXioen/wqiusTZ4pXdxkOI/FwDjPk7q36YEG5px9StMsJts0jLeTPYOmj160 rfpHUMx6iyfssUoLNLYoKl46Ln+cayHQJ1JeUp7BnlSieoWZzq7Z6oOPTaal+k9IRUmOb5 IrQH9TOO0qSChTKguKO6LopADzttm5o7LmnQ9QWsWyUezN7FdPsxAxs0SXw7ry18W3hFa1 6ZvyqCQifFiFel/+GW6SNAQm0NOu0HX9qX2yTIxPR6ZkMHSHo6Zg8V1LLIRXc0CeW/GNv5 0u4dpoTTJ38DjFb+B6X+c2/Q== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id f6af8656 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Aug 2023 19:39:46 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired In-Reply-To: <834jldse3d.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Aug 2023 18:28:38 +0300") References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> <87v8dtbq8n.fsf@ledu-giraud.fr> <83bkflskei.fsf@gnu.org> <87r0ohbowd.fsf@ledu-giraud.fr> <834jldse3d.fsf@gnu.org> Date: Sat, 05 Aug 2023 19:39:45 +0200 Message-ID: <87il9tbd7i.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 65052@debbugs.gnu.org >> Date: Sat, 05 Aug 2023 15:27:14 +0200 >> >> >> Maybe I should do that into another bug report? >> > >> > It's up to you. >> >> Ok then I'd prefer having this macros cleanage into another bug report. >> Do you think you could apply the last one to master and close this bug >> report? I'll start from here. Thanks. > > Which is "the last one" that you want me to install? Sorry. This is the one attached with this mail. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Scroll-up-and-down-in-image-dired.patch >From 4983e589f1e841c6a49a93d166970a18d4359a88 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 9 Mar 2023 14:35:31 +0100 Subject: [PATCH] Scroll up and down in image-dired * lisp/image/image-dired.el (image-dired-scroll): Function to manage scroll in image-dired. (image-dired-scroll-up, image-dired-scroll-down): Scroll up and down command in image-dired. (image-dired-thumbnail-mode-map): Use them. --- lisp/image/image-dired.el | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 33beb5b3e49..4e213587e7a 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -770,6 +770,24 @@ image-dired-move-end-of-line (interactive nil image-dired-thumbnail-mode) (image-dired--movement-command (pos-eol) 'reverse)) +(defun image-dired-scroll (&optional down) + "Scroll in the thumbnail buffer." + (let ((goal-column (current-column))) + (if down (scroll-down) (scroll-up)) + (move-to-column goal-column) + (image-dired--movement-ensure-point-pos down) + (when image-dired-track-movement + (image-dired-track-original-file)) + (image-dired--update-header-line))) + +(defun image-dired-scroll-up () + (interactive nil image-dired-thumbnail-mode) + (image-dired-scroll)) + +(defun image-dired-scroll-down () + (interactive nil image-dired-thumbnail-mode) + (image-dired-scroll 'down)) + ;;; Header line @@ -980,6 +998,8 @@ image-dired-thumbnail-mode-map " " #'image-dired-end-of-buffer " " #'image-dired-move-beginning-of-line " " #'image-dired-move-end-of-line + " " #'image-dired-scroll-up + " " #'image-dired-scroll-down :menu '("Image-Dired" -- 2.40.0 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 10 05:11:43 2023 Received: (at 65052) by debbugs.gnu.org; 10 Aug 2023 09:11:43 +0000 Received: from localhost ([127.0.0.1]:41362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU1hm-00063v-TC for submit@debbugs.gnu.org; Thu, 10 Aug 2023 05:11:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU1hk-00063i-MU for 65052@debbugs.gnu.org; Thu, 10 Aug 2023 05:11:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU1he-0006rk-DM; Thu, 10 Aug 2023 05:11:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dvj9xyMIzE25qHxeYW7YhbIpqgI/rTmNcyJdYdpaDVU=; b=gzh/Ja+7n0ss sBKQlY2AL1+KFpMID+M+h2JydU1VHG7BIY29bjSVUD5ErpYHlv4iDBbSvSMywggUd+XA79ZW6hSfp NjV/jKYJh0HGPP1nDhjZoqPzmr1fQXsSxYwXf+wKG7/E+0qY4UhkfstIuR69yizv82hfIv2JQNHe2 D5WKsLTj6gGogSNHPgbfjt8Jf9wokwDX+IquIHNAaVYlxbpDUlm4RrYs1mHt5P8t1dTw/tnbiLsJg zHWnAjY/jXowsc2vRNLRx4EzVQeufjZAV2kdumO8jkwAxd/efF0CKvaRUFdoM0OJkVhsU/eZM9owB gVH1aMYmSsszE7Z+NWOktg==; Date: Thu, 10 Aug 2023 12:11:59 +0300 Message-Id: <83350rjm74.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87il9tbd7i.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 05 Aug 2023 19:39:45 +0200) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> <87v8dtbq8n.fsf@ledu-giraud.fr> <83bkflskei.fsf@gnu.org> <87r0ohbowd.fsf@ledu-giraud.fr> <834jldse3d.fsf@gnu.org> <87il9tbd7i.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Sat, 05 Aug 2023 19:39:45 +0200 > > > Which is "the last one" that you want me to install? > > Sorry. This is the one attached with this mail. Thanks, installed. Btw, I noticed that the Date of the commit is a few months ago: Date: Thu, 9 Mar 2023 14:35:31 +0100 Is that right? The Git log will show this as AuthorDate of the commit. Also, should this bug be closed now? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 04:56:16 2023 Received: (at 65052) by debbugs.gnu.org; 12 Aug 2023 08:56:16 +0000 Received: from localhost ([127.0.0.1]:48697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUkPv-0007q8-JH for submit@debbugs.gnu.org; Sat, 12 Aug 2023 04:56:15 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:34403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUkPr-0007pp-QC for 65052@debbugs.gnu.org; Sat, 12 Aug 2023 04:56:14 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=vfwHrzGu XZfXJetXCXY3GEhTzO6GtZJY6fO+O/AUKS0=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=iL9bu8Lv5utFfPwLNHOJM1fnCc9ROL gN0nrcPEAC8Q4u7j0rGoNpy5QSBgSIHOiJXg4ugZyQNQzmYKkkE1m3Cw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=vfwHrzGuXZfXJetX CXY3GEhTzO6GtZJY6fO+O/AUKS0=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=JVNyvigz7ZZoMLXiYvvMSZCEFWvkr3CI6G/Gkw D9fEU141pPXutcAoAQExuRw/TGPuCbeaFsyovQ2/PvkvQi1feY9vgd76a5R3NZc6Kle6e8 cBZugDjdoY2Jvu79BYRTff5dAuWVrvSeQZFPNRZmHU5qtF9oUnqt3SW8kYaajUw+evomwi Mt1zNmQo7NwkI8DEsw6nbcA0fFwVsuSO3wAVU9dEcuTHvSRz1iXsDdPCjoksjYc5/SAlTn nYKSHXlRDcgTzV5TFnvEIjmTexeVIQ/6ZdLBUyYyabAJcjUEf9ypnOLaTWgOqntFDGH1DB G9TwV1UksE9IaIGynlIfehqQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 801aacc3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 12 Aug 2023 10:56:09 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired In-Reply-To: <83350rjm74.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Aug 2023 12:11:59 +0300") References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> <87v8dtbq8n.fsf@ledu-giraud.fr> <83bkflskei.fsf@gnu.org> <87r0ohbowd.fsf@ledu-giraud.fr> <834jldse3d.fsf@gnu.org> <87il9tbd7i.fsf@ledu-giraud.fr> <83350rjm74.fsf@gnu.org> Date: Sat, 12 Aug 2023 10:56:07 +0200 Message-ID: <87350o7i6w.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65052 Cc: 65052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 65052@debbugs.gnu.org >> Date: Sat, 05 Aug 2023 19:39:45 +0200 >> >> > Which is "the last one" that you want me to install? >> >> Sorry. This is the one attached with this mail. > > Thanks, installed. > > Btw, I noticed that the Date of the commit is a few months ago: > > Date: Thu, 9 Mar 2023 14:35:31 +0100 > > Is that right? The Git log will show this as AuthorDate of the > commit. Hi Eli, Yes it was the date I worked on it for the first time. I've just amend on top of it afterward. I don't really care and I don't know if this is important for the Emacs log. > Also, should this bug be closed now? Yes you could close it now. I'll try to work on removing the other macros usage for movements in another report. Thanks. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 04:58:46 2023 Received: (at 65052-done) by debbugs.gnu.org; 12 Aug 2023 08:58:46 +0000 Received: from localhost ([127.0.0.1]:48708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUkSL-0007zI-NE for submit@debbugs.gnu.org; Sat, 12 Aug 2023 04:58:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUkSK-0007yw-Eg for 65052-done@debbugs.gnu.org; Sat, 12 Aug 2023 04:58:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUkSF-0004LM-5L; Sat, 12 Aug 2023 04:58:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eRjyck/hXII9WeUsONc/AKw1b/qr1+wJkOh0QYeIhGM=; b=JrX1VobaGldj YaCy61wbcCCNuIX8fvAEhXIl176BiwOCIiDPXZ4hNY7BSwR4l4H58S7SAHHmAmiLSXQzyNNIa8/fQ jPuxjDda18DSMyTp6OPt3tBDhnu2DZZwDdewR6L5rCG/4D/jDuFblI8DGi+4zuWHmxl7/fX0C0veO e/fabhF64dJ7bN0MhT8duFZ2Xe2RyoYAkj6yKoDUzMSpGeP508TGQ6V6akYsNpE63qRZgX5HhJcLs hTin3ckD8P8kuuexfcrPSHMGgbOgdQ97PLRoAyjlyAVD0JfkRTwvVLDlsz6cgOC8ojqMPGtqHcud7 UJ7i3d+Nj6VX8XcEyFFRfA==; Date: Sat, 12 Aug 2023 11:59:10 +0300 Message-Id: <83jzu0eiw1.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87350o7i6w.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 12 Aug 2023 10:56:07 +0200) Subject: Re: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> <87v8dtbq8n.fsf@ledu-giraud.fr> <83bkflskei.fsf@gnu.org> <87r0ohbowd.fsf@ledu-giraud.fr> <834jldse3d.fsf@gnu.org> <87il9tbd7i.fsf@ledu-giraud.fr> <83350rjm74.fsf@gnu.org> <87350o7i6w.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65052-done Cc: 65052-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Sat, 12 Aug 2023 10:56:07 +0200 > > Eli Zaretskii writes: > > > Btw, I noticed that the Date of the commit is a few months ago: > > > > Date: Thu, 9 Mar 2023 14:35:31 +0100 > > > > Is that right? The Git log will show this as AuthorDate of the > > commit. > > Hi Eli, > > Yes it was the date I worked on it for the first time. I've just amend > on top of it afterward. I don't really care and I don't know if this is > important for the Emacs log. The date will appear in the ChangeLog which we generate from the Git logs. I don't know if this matters, either. > > Also, should this bug be closed now? > > Yes you could close it now. Done, thanks. From unknown Fri Aug 15 15:30:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Sep 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator