GNU bug report logs - #65051
internal_equal manipulates symbols with position without checking symbols-with-pos-enabled.

Previous Next

Full log

Message #14 received at 65051 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 65051 <at> debbugs.gnu.org, acm <at> muc.de
Subject: Re: bug#65051: internal_equal manipulates symbols with position
 without checking symbols-with-pos-enabled.
Date: Fri, 04 Aug 2023 18:27:55 +0300

> Date: Fri, 4 Aug 2023 14:59:58 +0000
> Cc: 65051 <at> debbugs.gnu.org, acm <at> muc.de
> From: Alan Mackenzie <acm <at> muc.de>
> 
> > What will happen to the comparison in internal_equal when
> > symbols_with_pos_enabled is zero and the two objects have different
> > positions, or one has a position, the other doesn't?
> 
> In these cases, equal will return nil.  This is correct.

It is?  I thought when symbols with position are disabled, symbols
that are 'eq', but have different positions, should compare equal?
Why not?

> In the other case, when two symbols with position have the same base
> symbol and the same position, yet aren't identical, this will also return
> nil, which is incorrect.

How can they be not identical if the symbols and the positions are the
same?  Or maybe I don't understand what you mean by "base symbol"?

> > And which branch are you proposing this change for?
> 
> master.  It doesn't seem important enough for the release branch.

OK.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.