GNU bug report logs - #6505
make the Gtk+ port compile with -DGSEAL_ENABLE in preparation for Gtk+-3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6505 in the body.
You can then email your comments to 6505 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: make the Gtk+ port compile with -DGSEAL_ENABLE in preparation for
	Gtk+-3
Date: Thu, 24 Jun 2010 14:34:19 -0400

Gtk+-3 will make some structure members private.

Compiling with -DGSEAL_ENABLE points out the problems.

See also http://live.gnome.org/GnomeGoals/UseGseal
for more info

Message #6 received at 6505 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 6505 <at> debbugs.gnu.org
Subject: Re: bug#6505: make the Gtk+ port compile with -DGSEAL_ENABLE
	in	preparation for Gtk+-3
Date: Fri, 25 Jun 2010 15:50:00 +0200

Dan Nicolaescu skrev 2010-06-24 20.34:
>
> Gtk+-3 will make some structure members private.
>
> Compiling with -DGSEAL_ENABLE points out the problems.
>
> See also http://live.gnome.org/GnomeGoals/UseGseal
> for more info
>
>

It is currently not an issue, configure checks for gtk+-2.0, so 3.0 isn't 
considered yet.  Also, other libraries (rsvg, gconf possibly dbus) must also 
be moved forward.

Apart from that, it is the question of how old Gtk+ we should support. 
Currently we say 2.6 (which is really old) or newer.  Most accessor functions 
in Gtk+ where introduced in 2.14, some in 2.16, and in one case, 2.20.

We could add #ifdef:s, but I rather not do that unless we really need to.

That said, I have a private branch that works with Gtk+ 3.0, and some of the 
fixes there can go in the trunk.  Maybe we should bump required to 2.14 and 
get most of the work checked in.

	Jan D.

Message #9 received at 6505 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 6505 <at> debbugs.gnu.org
Subject: Re: bug#6505: make the Gtk+ port compile with -DGSEAL_ENABLE
	in	preparation for Gtk+-3
Date: Fri, 25 Jun 2010 17:02:03 -0400

Jan Djärv wrote:

> That said, I have a private branch that works with Gtk+ 3.0, and some
> of the fixes there can go in the trunk.  Maybe we should bump required
> to 2.14 and get most of the work checked in.

For the record, RHEL 5, the most recent Red Hat Enterprise Linux, only
has 2.10. I don't have an opinion whether that is important or not.
There will probably be a RHEL 6 (with 2.18) before Emacs 24.1.

Message #12 received at 6505 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 6505 <at> debbugs.gnu.org
Subject: Re: bug#6505: make the Gtk+ port compile with -DGSEAL_ENABLE
	in	preparation for Gtk+-3
Date: Fri, 25 Jun 2010 17:42:52 -0400

Jan Djärv <jan.h.d <at> swipnet.se> writes:

> Dan Nicolaescu skrev 2010-06-24 20.34:
>>
>> Gtk+-3 will make some structure members private.
>>
>> Compiling with -DGSEAL_ENABLE points out the problems.
>>
>> See also http://live.gnome.org/GnomeGoals/UseGseal
>> for more info
>>
>>
>
> It is currently not an issue, configure checks for gtk+-2.0, so 3.0
> isn't considered yet.  Also, other libraries (rsvg, gconf possibly
> dbus) must also be moved forward.
>
> Apart from that, it is the question of how old Gtk+ we should
> support. Currently we say 2.6 (which is really old) or newer.  Most
> accessor functions in Gtk+ where introduced in 2.14, some in 2.16, and
> in one case, 2.20.
>
> We could add #ifdef:s, but I rather not do that unless we really need to.
>
> That said, I have a private branch that works with Gtk+ 3.0, and some
> of the fixes there can go in the trunk.  Maybe we should bump required
> to 2.14 and get most of the work checked in.

Good to hear you already have some solution.
IMHO the main thing is that emacs should not be seen as lagging
behind.  When the first distribution switches to version 3, it would be
good to have something available...

Message #15 received at 6505 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: "6505 <at> debbugs.gnu.org" <6505 <at> debbugs.gnu.org>
Subject: Re: bug#6505: make the Gtk+ port compile with -DGSEAL_ENABLE
	in	preparation for Gtk+-3
Date: Sat, 26 Jun 2010 00:43:32 +0200

25 jun 2010 kl. 23:42 skrev Dan Nicolaescu <dann <at> gnu.org>:
>>> 
>>> 
>>> 
>>> 
>>> 
>> 
>> 
>> 
>> 
> Good to hear you already have some solution.
> IMHO the main thing is that emacs should not be seen as lagging
> behind.  When the first distribution switches to version 3, it would be
> good to have something available...

I 
 we must see a Gnome based on Gtk 3.0 first. It is not possible (without #ifdefs) to support < 2.14 and 3.0. 

If it is just a few ifdefs I will add them.  But we need to decide if configure should start to check for Gtk 3.0. Maybe now is the time.

     Jan D.

Message #18 received at 6505 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Glenn Morris <rgm <at> gnu.org>
Cc: "6505 <at> debbugs.gnu.org" <6505 <at> debbugs.gnu.org>
Subject: Re: bug#6505: make the Gtk+ port compile with -DGSEAL_ENABLE
	in	preparation for Gtk+-3
Date: Sat, 26 Jun 2010 00:47:55 +0200

25 jun 2010 kl. 23:02 skrev Glenn Morris <rgm <at> gnu.org>:

> Jan Djärv wrote:
> 
>> That said, I have a private branch that works with Gtk+ 3.0, and some
>> of the fixes there can go in the trunk.  Maybe we should bump required
>> to 2.14 and get most of the work checked in.
> 
> For the record, RHEL 5, the most recent Red Hat Enterprise Linux, only
> has 2.10. I don't have an opinion whether that is important or not.
> There will probably be a RHEL 6 (with 2.18) before Emacs 24.1.

Good to know. Thanks. 

    Jan D.

Message #21 received at 6505 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: Dan Nicolaescu <dann <at> gnu.org>,
	"6505 <at> debbugs.gnu.org" <6505 <at> debbugs.gnu.org>
Subject: Re: bug#6505: make the Gtk+ port compile with -DGSEAL_ENABLE
	in	preparation for Gtk+-3
Date: Sun, 27 Jun 2010 13:56:26 -0400

Jan Djärv <jan.h.d <at> swipnet.se> writes:

> 25 jun 2010 kl. 23:42 skrev Dan Nicolaescu <dann <at> gnu.org>:
>
>> Good to hear you already have some solution.
>> IMHO the main thing is that emacs should not be seen as lagging
>> behind.  When the first distribution switches to version 3, it would be
>> good to have something available...
>
> I we must see a Gnome based on Gtk 3.0 first. It is not possible
> (without #ifdefs) to support < 2.14 and 3.0.
>
> If it is just a few ifdefs I will add them.  But we need to decide if
> configure should start to check for Gtk 3.0. Maybe now is the time.

Yes, I think bumping the requirement to 2.14 in the trunk is fine, as is
adding support for 3.0, provided it does not interfere with the GTK-2
support.  Thanks for working ahead on this.

Message #24 received at 6505 <at> debbugs.gnu.org (full text, mbox):

From: Yavor Doganov <yavor <at> gnu.org>
To: 6505 <at> debbugs.gnu.org
Subject: Re: bug#6505: make the Gtk+ port compile with
	-DGSEAL_ENABLE	in	preparation for Gtk+-3
Date: Mon, 28 Jun 2010 10:03:08 +0300

Chong Yidong wrote:
> Yes, I think bumping the requirement to 2.14 in the trunk is fine,

That would be unfortunate since gNewSense DeltaH has 2.12.

Message #29 received at 6505-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 6505-done <at> debbugs.gnu.org
Subject: Re: bug#6505: make the Gtk+ port compile with -DGSEAL_ENABLE in
	preparation for Gtk+-3
Date: Mon, 28 Jun 2010 12:19:31 +0200

The required effort to keep supporting 2.6 and newer compared to bumping up to 
2.14 was small (I still had to make backwards compatible macros for functions 
introduced in 2.16, 2.18 and 2.20), so I kept that as minimum version.

Configure now accepts --with-x-toolkit=gtk3 to compile with Gtk+ 3.0 (actually 
2.90 as 3.0 isn't out yet).

	Jan D.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.