GNU bug report logs - #65049
29.1; vc-do-command fails in windows emacs 29.1

Previous Next

Package: emacs;

Reported by: Maxim Kim <habamax <at> gmail.com>

Date: Fri, 4 Aug 2023 07:51:01 UTC

Severity: normal

Found in version 29.1

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

Full log


Message #41 received at 65049 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: habamax <at> gmail.com, 65049 <at> debbugs.gnu.org
Subject: Re: bug#65049: Minor update to the repro steps
Date: Mon, 21 Aug 2023 09:53:28 +0300
>> > Yes, but where did the file git-patchyYAcN5 come from in the first
>> > place?  It's that file that is the problem, not how we apply the
>> > diffs in that file.
>>
>> It's created in 'vc-git-checkin':
>>
>>         (let ((patch-file (make-nearby-temp-file "git-patch")))
>>           (with-temp-file patch-file
>>             (insert vc-git-patch-string))
>>           (unwind-protect
>>               (vc-git-command nil 0 patch-file "apply" "--cached")
>
> Then this should set up EOL conversion correctly for the temporary
> file.  Something like (untested):
>
>         (let ((patch-file (make-nearby-temp-file "git-patch")))
>           (with-temp-file patch-file
>             (insert vc-git-patch-string)
>             (set-buffer-file-coding-system 'unix)))
>           (unwind-protect
>               (vc-git-command nil 0 patch-file "apply" "--cached")

Sorry, I can't test this on Windows.




This bug report was last modified 232 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.