Subject: Re: bug#65044: [PATCH] gnu: alacritty: Install example configuration.

From: John Kehayias <[email-masked]>
Date: Fri, 18 Aug 2023 15:50:32 +0000

Hello,

On Thu, Aug 17, 2023 at 05:51 PM, Ludovic Courtès wrote:

> Hi,
>
> John Kehayias <[email-masked]> skribis:
>
>> From 08831e7530a1c5ef6b87e293051c4b92f10d1513 Mon Sep 17 00:00:00 2001
>> Message-ID: <08831[email-masked]>
>> From: John Kehayias <[email-masked]>
>> Date: Thu, 3 Aug 2023 15:54:52 -0400
>> Subject: [PATCH] gnu: alacritty: Install example configuration.
>>
>> * gnu/packages/terminals.scm (alacritty)[phases]{install}: Install example
>> configuration.
>> ---
>>  gnu/packages/terminals.scm | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
>> index 081ef19af1..d54910bce7 100644
>> --- a/gnu/packages/terminals.scm
>> +++ b/gnu/packages/terminals.scm
>> @@ -1515,6 +1515,9 @@ (define-public alacritty
>>                 (mkdir-p man)
>>                 (copy-file "extra/alacritty.man"
>>                            (string-append man "/alacritty.1"))
>> +               ;; Install example configuration.
>> +               (install-file "alacritty.yml"
>> +                             (string-append share "/doc/alacritty-" ,version "/example"))
>
> Nitpick: ,(package-version this-package)
>
> That means it will pick the right version string when inheriting, as in:
>
>   (package
>     (inherit alacritty)
>     (version "42.0")
>     …)
>

Good point, thanks.

> Otherwise LGTM, thanks!

Made the change and pushed as d1c811268d130041b5af1ba8f8b41cdafe8f08b5 (and followed up with another commit to update source and home-page URLs as guix lint noted a redirect.)

John