GNU bug report logs - #65039
30.0.50; [PATCH] Add bookmark handler for M-x shell

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 65039 <at> debbugs.gnu.org, michael.albinus <at> gmx.de, prot <at> protesilaos.com, visuweshm <at> gmail.com
Subject: bug#65039: [PATCH] Add bookmark handler for shell-mode
Date: Wed, 12 Feb 2025 14:18:33 +0200

> From: Ship Mints <shipmints <at> gmail.com>
> Date: Tue, 11 Feb 2025 14:56:08 -0500
> Cc: 65039 <at> debbugs.gnu.org
> 
> +---

Should we mention this feature in the user manual?

> +*** Shell buffers now support bookmarks support.
> +
> +You can now bookmark shell buffers using the bookmark menu
> +'bookmark-bmenu-list', or by using the command 'bookmark-set'.  Shell
> +bookmarks can be loaded via the menu, or by using the command
> +'bookmark-jump'.
> +
> +Remote shell bookmarks remember the buffer's remote 'default-directory'
> +at the time you create a bookmark, along with the shell you used to
> +start the remote shell.  You can inhibit remote connections during
> +bookmark loading.  This is useful when restoring sessions with
> +'desktop-load', where the time delays to establish a connection for each
> +remote shell can be long.  When you reload an unconnected remote buffer
> +using 'C-x C-v', a connection will be initiated.
> +
> +You can customize the bookmark naming function to suit your preferences.
> +The default option is to use the final component of the buffer's
> +'default-directory'.  An alternate provided option uses the buffer's
> +name with its 'rename-uniquely' suffix brackets "<>" stripped.  You can
> +supply your own function.

AFAU, this doesn't explain what it means to "jump to a shell
bookmark".  Does it start a shell, does it change the current
directory in an existing shell buffer, does it initiate a connection
to the remote host, does it do something else?  I don't think the
answers to these questions are trivial, so I suggest to have them
answered in the NEWS entry.

By contrast, the second and the third paragraphs describe aspects of
secondary importance, and should perhaps be in the doc strings and not
in NEWS.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.