From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 02:54:57 2023 Received: (at submit) by debbugs.gnu.org; 3 Aug 2023 06:54:57 +0000 Received: from localhost ([127.0.0.1]:50575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRSEa-0002de-Am for submit@debbugs.gnu.org; Thu, 03 Aug 2023 02:54:57 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRRni-0001n3-PO for submit@debbugs.gnu.org; Thu, 03 Aug 2023 02:27:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRRnd-0006aD-Ii for guix-patches@gnu.org; Thu, 03 Aug 2023 02:27:05 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRRnb-0004Xw-Ob for guix-patches@gnu.org; Thu, 03 Aug 2023 02:27:05 -0400 Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-406b9bcad5dso3746411cf.2 for ; Wed, 02 Aug 2023 23:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691044022; x=1691648822; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eT4AR7XzqJFQybjDC6NPCBQTYQAVtl5+UxQfE2vRTdU=; b=rboqdQNvjcS36KSZbiohwTgvcF6p7RUDNstRMmpbWLCRdOd3xjoRVhiWchUlGA0/4I wS2t7fmB+66ZZEQPGYW/ywK4qiCtNpjo8NM/Dei9pVbuRhn2j6bfQQd7EZNhG+f4xEDs GU3P0Z1aKMXHTaWqY5ctfNmhesL6Lmem2K+xNP7iyPB+PI/2O5od5I9YqnEsRRbzmwny SDpxz0nWmjwEPCVkxzPEkPgMdx+IB4fhcFylJQPZ4Pyt8a1ssg8NywOFlyOMzZjYpRGD OPNPKloS2IyAPr3sF5xVZG0y+3Ai581xwPK2qECU7ZNwxpT3x1Z4L4N/54PD6S1SYD90 U3IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691044022; x=1691648822; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eT4AR7XzqJFQybjDC6NPCBQTYQAVtl5+UxQfE2vRTdU=; b=ksSot7AXRUzKELy5JzrEpxnrKk85klwbQgINHyG/En0eRABvbGFZ8zzVP1Wt9inmvA ZY8/AoWaTKNXjVph3rh3YIs7AQ9c9stf80rwCyNaxmWKhOBRM5wOWYgxjz00xL1l5a68 Jadz3XXwcOAyn+sjb/rT70eZn5wPfJNi/9Y6qT2p+2xJYbvFLuexRzuquIsJ/j4tqPqd M8C12BLJdKxc8cuRHEKBiwUY63M2wmDSHko3x/XYn9I5/dYHT6gmuYi/mCRN6CfhdmXX zXNUdmHMIRSWQwbsDGu966meLXDf6axPb+s8fRWm83bXRJgO6tNfqDzYeNIR0Y3I607A ZRaQ== X-Gm-Message-State: ABy/qLaLOJqYjjceGuafTMqre8Ck8ceNOEc0RXBsQ2LrB7OayiaRGT0Y IvM6LTAA4tdBIp2LDoBM+Y41Mcl4N+4= X-Google-Smtp-Source: APBJJlHr9BPOSHgkQZ0c2qSYDvxFoSjEcph9HnXeKoC3PazhrjLZx/jW2iLi+CRs8eK0vAFzJ6kobA== X-Received: by 2002:a05:622a:110:b0:405:407c:1008 with SMTP id u16-20020a05622a011000b00405407c1008mr17104797qtw.24.1691044021929; Wed, 02 Aug 2023 23:27:01 -0700 (PDT) Received: from localhost.localdomain (ool-18bb63f6.dyn.optonline.net. [24.187.99.246]) by smtp.gmail.com with ESMTPSA id cq3-20020a05622a424300b00403e80cad67sm5978156qtb.41.2023.08.02.23.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 23:27:01 -0700 (PDT) From: aurtzy To: guix-patches@gnu.org Subject: [PATCH] gnu: Add syncplay. Date: Thu, 3 Aug 2023 00:35:28 -0400 Message-ID: <20230803061517.27336-1-aurtzy@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=aurtzy@gmail.com; helo=mail-qt1-x82c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 03 Aug 2023 02:54:55 -0400 Cc: aurtzy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/networking.scm (syncplay): New variable. --- gnu/packages/networking.scm | 52 +++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 488d015107..10eb19e980 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -60,6 +60,7 @@ ;;; Copyright © 2023 Bruno Victal ;;; Copyright © 2023 Yovan Naumovski ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> +;;; Copyright © 2023 aurtzy ;;; ;;; This file is part of GNU Guix. ;;; @@ -4644,3 +4645,54 @@ (define-public dropwatch recording packets that are dropped by the kernel. It provides the commands @command{dropwatch} and @command{dwdump}.") (license license:gpl2+))) + +(define-public syncplay + (package + (name "syncplay") + (version "1.7.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Syncplay/syncplay.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "061kpnb48lad8rr8v58xac33mwpbrixfbhn7d0xa63zpxg43bvsd")))) + (build-system gnu-build-system) + (arguments + (list #:imported-modules `(,@%gnu-build-system-modules (guix build + qt-utils) + (guix build utils)) + #:modules '((guix build gnu-build-system) + (guix build qt-utils) + (guix build utils)) + #:make-flags #~`("DESTDIR=" ,(string-append "PREFIX=" + (assoc-ref %outputs + "out"))) + #:phases #~(modify-phases %standard-phases + (delete 'configure) + (delete 'build) + (delete 'check) + (add-after 'install 'wrap-qt + (lambda* (#:key inputs #:allow-other-keys) + (wrap-qt-program "syncplay" + #:output #$output + #:inputs inputs)))))) + (inputs (list bash-minimal qtwayland-5)) + (propagated-inputs (list python + python-service-identity + python-twisted + python-pyside-2 + python-certifi + python-idna)) + (home-page "https://syncplay.pl") + (synopsis "Client/server to synchronize media playback on many computers") + (description + "Syncplay is a solution to synchronize video playback across multiple +instances of media players over the Internet. When one person pauses/unpauses +playback or skips to a position in the video, this is replicated across all +media players connected to the same server and in the same \"room\" (viewing +session). A built-in text chat for discussing the synced media is also +included for convenience.") + (license license:asl2.0))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 10:54:58 2023 Received: (at 65031) by debbugs.gnu.org; 5 Sep 2023 14:54:58 +0000 Received: from localhost ([127.0.0.1]:57653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXSB-0003BD-1r for submit@debbugs.gnu.org; Tue, 05 Sep 2023 10:54:58 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:58653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXS7-0003Av-9k for 65031@debbugs.gnu.org; Tue, 05 Sep 2023 10:54:54 -0400 Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-64a5f9a165eso12484566d6.1 for <65031@debbugs.gnu.org>; Tue, 05 Sep 2023 07:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693925685; x=1694530485; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=hESwWN9pRWdE4kOFoo7ZkvZJwaGO+YwKLaNPi1SI5cU=; b=aJHHmq5tMT0SCXOvReUAoeembP+h/am2eLT3/CJ6UfOuK0ZCAcmLjUVb1fAuuFe38r YEFbCYfndfs2fbfJNz00Pgn6NIbSrYjp3b2YQJwjUyyjKVRIQ0TDHPn51Ci9Bz1IGx1x GfJpPsAvJ1xAmD6OLrK3AVmpw6nv8TY7csTLl87LoEt5Huws+Q00yAp4Z1hEUCXrtA2q juojbiK7aNFudtXgtaqyS6GuGKqZNxdES0QqzhZQmo1uATI3pkrYq9o4Z9od6hhF61P1 RiJujmjgH9u2GVh9lOhKE3vUVqokEZHV5dF1QHgolmEaIXc5GeHnga7TLY+kEwL5sip/ onHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693925685; x=1694530485; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hESwWN9pRWdE4kOFoo7ZkvZJwaGO+YwKLaNPi1SI5cU=; b=lBc+CPE+XuSHhhifl7aLVrfBQYPCJAAVgZhi+8eup8mOjVA6tgjmdLawKn3AuPOe2a exBm7Ioh4atxToVWMEsMh05P9uA9Rm/51TcYjAyGCH2FQWVYKxumAkDG22e6N+IX/uvv vZeBDaBxXFNaWzTSNfMdTtFCGeiKONcMjphq314NAUss60UWJ1Onz1XchZ4GHYwi3pPv eX0B2Bcjlb2bsp3LPlpvU1jbbzgE1LIjd9fJyqVpNCpnQLm28kgUD7Z964eIPIirEph9 A3kACxVDRxJDi1q+2Ut6E5clOgb4eBJ2CgWP8ITNuYfgEwvIA/T6ijrf3KhMLbg2moA5 UtOg== X-Gm-Message-State: AOJu0YzabO3AKytdy/P9mf5uM/ZHSXNXW0O2OKT2pPTjx69pupyPoC7A kCr4LF5GZVl8dBNwd1Rs2Tvz65VMdE2OKw== X-Google-Smtp-Source: AGHT+IG/9e6gLu2pIqkE6juRBQN4vV2ifdfjf1KJ8hNP4bfwXpMe632/qYfFHrIHEh6eLlESHQLVaQ== X-Received: by 2002:a0c:f250:0:b0:63d:5e01:8a99 with SMTP id z16-20020a0cf250000000b0063d5e018a99mr11077981qvl.17.1693925684708; Tue, 05 Sep 2023 07:54:44 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id d10-20020a0cb2ca000000b0064f53943626sm4556162qvf.89.2023.09.05.07.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 07:54:44 -0700 (PDT) From: Maxim Cournoyer To: aurtzy Subject: Re: bug#65031: [PATCH] gnu: Add syncplay. References: <20230803061517.27336-1-aurtzy@gmail.com> Date: Tue, 05 Sep 2023 10:54:43 -0400 In-Reply-To: <20230803061517.27336-1-aurtzy@gmail.com> (aurtzy@gmail.com's message of "Thu, 3 Aug 2023 00:35:28 -0400") Message-ID: <871qfck6vg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65031 Cc: 65031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, aurtzy writes: > * gnu/packages/networking.scm (syncplay): New variable. > --- > gnu/packages/networking.scm | 52 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm > index 488d015107..10eb19e980 100644 > --- a/gnu/packages/networking.scm > +++ b/gnu/packages/networking.scm > @@ -60,6 +60,7 @@ > ;;; Copyright =C2=A9 2023 Bruno Victal > ;;; Copyright =C2=A9 2023 Yovan Naumovski > ;;; Copyright =C2=A9 2023 Zheng Junjie <873216071@qq.com> > +;;; Copyright =C2=A9 2023 aurtzy > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -4644,3 +4645,54 @@ (define-public dropwatch > recording packets that are dropped by the kernel. It provides the comma= nds > @command{dropwatch} and @command{dwdump}.") > (license license:gpl2+))) > + > +(define-public syncplay > + (package > + (name "syncplay") > + (version "1.7.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Syncplay/syncplay.git") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "061kpnb48lad8rr8v58xac33mwpbrixfbhn7d0xa63zpxg43bvsd"))= )) > + (build-system gnu-build-system) > + (arguments > + (list #:imported-modules `(,@%gnu-build-system-modules (guix build > + qt-uti= ls) > + (guix build utils)) > + #:modules '((guix build gnu-build-system) > + (guix build qt-utils) > + (guix build utils)) > + #:make-flags #~`("DESTDIR=3D" ,(string-append "PREFIX=3D" > + (assoc-ref %outpu= ts > + "out")= )) > + #:phases #~(modify-phases %standard-phases > + (delete 'configure) > + (delete 'build) > + (delete 'check) > + (add-after 'install 'wrap-qt > + (lambda* (#:key inputs #:allow-other-keys) > + (wrap-qt-program "syncplay" > + #:output #$output > + #:inputs inputs)))))) > + (inputs (list bash-minimal qtwayland-5)) Is it compatible with Qt 6? To try it, replace qtwayland-5 with qtwayland, and specify a #:qtbase qtbase argument. > + (propagated-inputs (list python > + python-service-identity > + python-twisted > + python-pyside-2 > + python-certifi > + python-idna)) These should be inputs, not propagated-inputs, unless it can be used as a library? Also, please sort the inputs alphabetically. > + (home-page "https://syncplay.pl") > + (synopsis "Client/server to synchronize media playback on many compu= ters") > + (description > + "Syncplay is a solution to synchronize video playback across multip= le > +instances of media players over the Internet. When one person pauses/un= pauses > +playback or skips to a position in the video, this is replicated across = all > +media players connected to the same server and in the same \"room\" (vie= wing > +session). A built-in text chat for discussing the synced media is also > +included for convenience.") > + (license license:asl2.0))) The rest LGTM. Could you please send a v2? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 10:54:59 2023 Received: (at control) by debbugs.gnu.org; 5 Sep 2023 14:54:59 +0000 Received: from localhost ([127.0.0.1]:57656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXSF-0003BS-At for submit@debbugs.gnu.org; Tue, 05 Sep 2023 10:54:59 -0400 Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]:57594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdXSB-0003B2-Rc for control@debbugs.gnu.org; Tue, 05 Sep 2023 10:54:58 -0400 Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-6493389c56fso14051086d6.2 for ; Tue, 05 Sep 2023 07:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693925689; x=1694530489; darn=debbugs.gnu.org; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=9yzwEh/p2u8Ncpqn8domZcczhDPHj79ROr/EBq+H3OU=; b=RpVTumli1sko4uijZgt41Dh6ZY7pfKIzNV7JTMS0tKwsw4fCz4m0iaIGt3p4Jb470d D8afC53x572O1iqJyvxg5HaDuV9hIJd9yhz0uDq/iHhyopFXRhbc62TFwTHUhn8X0WPn orgz4sIVl6+rege1z94X5BwbF/uufTMWvy41DJStUcZYgTjo33HnVY7QXkykWYNDpmGD OKkH5ENvEIyWp2RXPXsd1dAsRCltoRwuY/2K7iq+UkXuW35FDfkbcUr45ZAcjrPDoMYm 2uDeMxq3jPKBui4mo3rw5BUfjPwLcnw0V646qEuYzz2L6PtIzfDerfTOdaD8tYQ4+iJZ 2Onw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693925689; x=1694530489; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9yzwEh/p2u8Ncpqn8domZcczhDPHj79ROr/EBq+H3OU=; b=DFekWqCUeDQI2qxuztG8KaivSymTVmsQ0Xk/L5FgRYJGpOQ2wgKf0aZJgKHJXBiSau zREckPUwAtzFdqhwRZB4ASzaZ6ODeC/ZAgER0YqGyprLem1W2aqVCJLUG/oPjjYkEj/t Imo1ANuQm7B7kUNXTjg8BgMzroykjjG/sQXYL3GPjJiskxs2etfLSWRxX/eVXqWRZyWF itynGpMV4XRFpbT//Sp6I+DMqJQ5zHU80fDRghnMtZXZzc01f4aG86Buk5UTpEPZ02RD wfhXpESz33fza81NTJAT70x7guls+X6/1IidNDRIvHSEpmdkBdVviz/buZhpGifr4bxr RxyA== X-Gm-Message-State: AOJu0Yy8oVQTkqsxk5MVuHOIj4HDYkkhWXT//b/wT8R0O5x6KGjWjzuT /iG34AD2wqvovoW4C5HdMhOFhSrPmLIewQ== X-Google-Smtp-Source: AGHT+IFIXrAjZIWneYDtrKoYH8u1cf2kWL7/wU91Mnc85YtOfOn2Zy6BnCN8p+9UvjRRIJ8BfyN4Hw== X-Received: by 2002:a05:6214:5d12:b0:635:dda5:bb8e with SMTP id me18-20020a0562145d1200b00635dda5bb8emr13516909qvb.22.1693925689485; Tue, 05 Sep 2023 07:54:49 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id b10-20020a0c9b0a000000b0064f75162d49sm4557246qve.90.2023.09.05.07.54.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 07:54:49 -0700 (PDT) Date: Tue, 05 Sep 2023 10:54:48 -0400 Message-Id: <87zg20isav.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #65031 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 65031 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 21 18:52:04 2023 Received: (at 65031) by debbugs.gnu.org; 21 Sep 2023 22:52:04 +0000 Received: from localhost ([127.0.0.1]:34961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjSWf-0003sV-LV for submit@debbugs.gnu.org; Thu, 21 Sep 2023 18:52:04 -0400 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:58555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjQTl-00009T-8I for 65031@debbugs.gnu.org; Thu, 21 Sep 2023 16:40:57 -0400 Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-76ef6d98d7eso88432385a.0 for <65031@debbugs.gnu.org>; Thu, 21 Sep 2023 13:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695328836; x=1695933636; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Et+hi0p4lanzoPCGNJwwRIazpY3P3f+h+NYp6NFZUz8=; b=QmdXWm3F0zhOzulokVnb5YefCQjgf5e1I2JOqDHNiL0w2OQ2IZllv5DHEhJZpMEnnS qDWMeFRhmR353wfkXDego6P2txgMUSipwvQ2Y4l6nKnUneSCy0Ojv2JDfvM36ntfjh7i rxo9o+yHTdPD7cD6l8PhvnV5VW2dQ0l/re1S77E/2B8pJF0Fy8/OZVlMNuGnbboaDu4B VEyofz9mcZjGWSj7t/ETZwpNncemJZ2MxllKIFOp+j9XRaG9irnL38b8d7KuPbDvZ6WN uiW3VRtRD/xoMdMCzDngSIartb30UBZ4O5XzuG+8XNAWjeV2NXPFkrEaMxe950G+oEnI KPLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695328836; x=1695933636; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Et+hi0p4lanzoPCGNJwwRIazpY3P3f+h+NYp6NFZUz8=; b=j3YjueW7lCDleqVntb004oUjg4LvxLL3dorFOEO1xwLA6FvAfDrWsuP93xSBMPODcv zp2D9UVSLR89eGDQ48uqywcudrGNwwZWgyWSAMcfmRF24CCx/6XWWEW1KIF1NVLLsb1f ih6t26sFIAqJOZRsaR1CQbPoYDdlRLIc3UteWC988mMioPb8YoFyRjAlNKNY71StM6b5 +Q9FYZ6sG63/N33BPOJHrQe7GoHq93PM6hgUAOcHPf/GSUE3KfFn6CuxM4Ny7cNKXMNG qC5LlIr32fIOFvYhYwuw+bbtxUSL5B3pL3GC1FGmXLYDindtahBP4wEjzP5xprFkKtgl 89pA== X-Gm-Message-State: AOJu0YzL6JKub6OVABwLcZc0H6RBVFPk/SusT4tdH6Mv2KyMaaSrMTU0 6BAzG0FeWx4DvF8EbFHthWme2EiQGDS8ETJbc94= X-Google-Smtp-Source: AGHT+IHFnkqDzg3KEZ8rc99FwWGmpGD3qSBn8zfj4D1JjVNKAJZDBhVzc+p0DnBz7/osVebE4l5tBQ== X-Received: by 2002:a05:620a:408d:b0:76f:1230:3187 with SMTP id f13-20020a05620a408d00b0076f12303187mr8350772qko.67.1695328836343; Thu, 21 Sep 2023 13:40:36 -0700 (PDT) Received: from al-laptop.stonybrook.edu ([129.49.100.0]) by smtp.gmail.com with ESMTPSA id g24-20020a05620a13d800b0076f18be9a64sm881670qkl.81.2023.09.21.13.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 13:40:35 -0700 (PDT) From: aurtzy To: 65031@debbugs.gnu.org Subject: [PATCH v2] gnu: Add syncplay. Date: Thu, 21 Sep 2023 15:37:06 -0400 Message-ID: <20230921203812.3649-2-aurtzy@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65031 X-Mailman-Approved-At: Thu, 21 Sep 2023 18:51:57 -0400 Cc: aurtzy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/networking.scm (syncplay): New variable. * gnu/packages/patches/syncplay-fix-typeerror.patch: New file. --- > Is it compatible with Qt 6? To try it, replace qtwayland-5 with > qtwayland, and specify a #:qtbase qtbase argument. Looks like it is! #:qtbase doesn't seem to be supported by gnu-build-system or python-build-system (switched to the latter for this v2; elaborated further below) and I had to make a few other adjustments to get it working, so I may need advice if I've missed anything here. A patch has been added to fix a Qt 6 issue causing Syncplay to crash. > These should be inputs, not propagated-inputs, unless it can be used as > a library? Also, please sort the inputs alphabetically. Fixed; not a library. It appears I was using an inappropriate build system for this package - I originally made them propagated because gnu-build-system wasn't doing whatever wrapping python-build-system does to make the inputs available, so this v2 uses python-build-system instead now. Best, aurtzy gnu/packages/networking.scm | 54 +++++++++++++++++++ .../patches/syncplay-fix-typeerror.patch | 25 +++++++++ 2 files changed, 79 insertions(+) create mode 100644 gnu/packages/patches/syncplay-fix-typeerror.patch diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index c1cab1fe0d..a7fde61ea8 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -60,6 +60,7 @@ ;;; Copyright © 2023 Bruno Victal ;;; Copyright © 2023 Yovan Naumovski ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> +;;; Copyright © 2023 aurtzy ;;; ;;; This file is part of GNU Guix. ;;; @@ -4700,3 +4701,56 @@ (define-public dropwatch recording packets that are dropped by the kernel. It provides the commands @command{dropwatch} and @command{dwdump}.") (license license:gpl2+))) + +(define-public syncplay + (package + (name "syncplay") + (version "1.7.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Syncplay/syncplay.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "061kpnb48lad8rr8v58xac33mwpbrixfbhn7d0xa63zpxg43bvsd")) + (patches (search-patches "syncplay-fix-typeerror.patch")))) + (build-system python-build-system) + (arguments + (list #:imported-modules `(,@%python-build-system-modules + (guix build qt-utils) + (guix build utils)) + #:modules '((guix build python-build-system) + (guix build qt-utils) + (guix build utils)) + #:phases #~(modify-phases %standard-phases + (delete 'check) + (replace 'install + (lambda _ + (invoke "make" "install" "DESTDIR=" + (string-append "PREFIX=" + (assoc-ref %outputs "out"))))) + (add-after 'install 'wrap-qt + (lambda* (#:key inputs #:allow-other-keys) + (wrap-qt-program "syncplay" + #:output #$output + #:inputs inputs + #:qt-major-version "6")))))) + (native-inputs (list python-pyside-6)) + (inputs (list bash-minimal + python-certifi + python-idna + python-service-identity + python-twisted + qtwayland)) + (home-page "https://syncplay.pl") + (synopsis "Client/server to synchronize media playback on many computers") + (description + "Syncplay is a solution to synchronize video playback across multiple +instances of media players over the Internet. When one person pauses/unpauses +playback or skips to a position in the video, this is replicated across all +media players connected to the same server and in the same \"room\" (viewing +session). A built-in text chat for discussing the synced media is also +included for convenience.") + (license license:asl2.0))) diff --git a/gnu/packages/patches/syncplay-fix-typeerror.patch b/gnu/packages/patches/syncplay-fix-typeerror.patch new file mode 100644 index 0000000000..6b1168a0e9 --- /dev/null +++ b/gnu/packages/patches/syncplay-fix-typeerror.patch @@ -0,0 +1,25 @@ +From b62b038cdf58c54205987dfc52ebf228505ad03b Mon Sep 17 00:00:00 2001 +From: Etoh +Date: Tue, 11 Apr 2023 20:22:52 +0100 +Subject: [PATCH] Fix ArchLinux GUI TypeError (#600) + +--- + syncplay/ui/gui.py | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/syncplay/ui/gui.py b/syncplay/ui/gui.py +index 7c100542..ca0f5d4a 100755 +--- a/syncplay/ui/gui.py ++++ b/syncplay/ui/gui.py +@@ -2106,7 +2106,10 @@ def __init__(self, passedBar=None): + if isMacOS(): + self.setWindowFlags(self.windowFlags()) + else: +- self.setWindowFlags(self.windowFlags() & Qt.AA_DontUseNativeMenuBar) ++ try: ++ self.setWindowFlags(self.windowFlags() & Qt.AA_DontUseNativeMenuBar) ++ except TypeError: ++ self.setWindowFlags(self.windowFlags()) + self.setWindowTitle("Syncplay v" + version + revision) + self.mainLayout = QtWidgets.QVBoxLayout() + self.addTopLayout(self) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 29 17:45:23 2024 Received: (at 65031) by debbugs.gnu.org; 29 Jun 2024 21:45:23 +0000 Received: from localhost ([127.0.0.1]:53878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNfso-0001vO-DZ for submit@debbugs.gnu.org; Sat, 29 Jun 2024 17:45:22 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:49484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNfsm-0001v2-8d for 65031@debbugs.gnu.org; Sat, 29 Jun 2024 17:45:21 -0400 Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-701ef9594a2so973936a34.3 for <65031@debbugs.gnu.org>; Sat, 29 Jun 2024 14:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719697455; x=1720302255; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pNAwDxZLL6PhSEjfNcC/111X8TCylH5qIZp53nzSvVI=; b=diBd5l7nnNQ1wZjIBheFkygpkS7p5NsqyqVpL20avG/AVw5OhWVYvse2xdnKVJylqN dLTwqgX9/ryXAmrMROhb3yL+ErHkQqHPSTJzR6GlntfV4614RS/x0iZhZsAIX91hTEnz GSzCPrW6BiEaeQuaUx9yDjfpAD6G33odg3xCsLJDzAegqf+8gfaTQTE6iIoZs4Y+gAA5 9mTygRLGNX3YM7MZiFQ9Pmp408E5PI0xC6OKVnN2azOObLOtB553bwf8W/paCV8LbUi/ 0VWXBrabGuqwlkM+lxDvzU9nPzYlC6Wf9QwC/sEm8FHFEx2ZQLFjEQxQpFk8D0I53i0c azFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719697455; x=1720302255; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pNAwDxZLL6PhSEjfNcC/111X8TCylH5qIZp53nzSvVI=; b=lLGBopIot3mm4127KSV6aMOy5mlAqfy3TgOyamdFjbuhyR8swMK7ZlEpWpTHD16gvH Q4CVy9QdZPnl8hYT5ppHBztvkbQT9pqg+Fm9OzFyLzwcGrf1TRfLrbLm9vllaku+1qQD 6NdxW5rI06qALVcVjgJp7CZUwsTngNxdblPW2C5yZa/JtpG5QRDW+0HDeBCwS0/79vHA bRc7I126DrGuO1F+l0TYZuhFZQTFbZkDFBLQ1cGeq+QqLaoZKG11OR+eTDQRz63h+DaW VQduORR7dmeY8LOg9exRBVtW+MXhawgEaad9zHQ6D3OEvxhmW2Fugl5NtJzpnZyGWa3f klQg== X-Gm-Message-State: AOJu0Yw3BVQD0c7NACDTvzW+kV4PbVzCZe7HGAHW6gH8xngsdSh6Pshx 2MX9aJ4edwZdN6SX90mG5oqxaKJE1eQi4y6erSopBE1W5/cquQb1lgJANw== X-Google-Smtp-Source: AGHT+IE55Pk+Clrz4QRUTUT04GZMZmR8lsTkCsIsUpxNW7b3jeQI1QXFHeC61UJ1qcN2Hm4gYFDP9A== X-Received: by 2002:a05:6808:144d:b0:3d6:2cc2:6b3c with SMTP id 5614622812f47-3d6b472718emr2744742b6e.46.1719697454408; Sat, 29 Jun 2024 14:44:14 -0700 (PDT) Received: from localhost.localdomain ([2600:4808:a053:7600::6242]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79d692797besm195031185a.29.2024.06.29.14.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jun 2024 14:44:14 -0700 (PDT) From: aurtzy To: 65031@debbugs.gnu.org Subject: [PATCH v3] gnu: Add syncplay. Date: Sat, 29 Jun 2024 17:37:55 -0400 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Debbugs-Cc: aurtzy , Maxim Cournoyer Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65031 Cc: aurtzy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (syncplay): New variable. Change-Id: I72cdfa3db2b4b7ef6c3ef0b8585d138c272046a7 --- Hi Maxim, Just got around to looking at this package again with a new patch as things have changed since my last reply (and I didn't cc you before, oops..). In addition to addressing your initial review, notable changes from v2 include: - Update to current latest version of Syncplay (1.7.3). - Patch is no longer needed. - This patch puts syncplay in (gnu packages video) instead of the previous (gnu packages networking) since the latter seemed more concerned with system-level networking. Does this make sense? > > Is it compatible with Qt 6? To try it, replace qtwayland-5 with > > qtwayland, and specify a #:qtbase qtbase argument. > > Looks like it is! #:qtbase doesn't seem to be supported by gnu-build-system or > python-build-system (switched to the latter for this v2; elaborated further > below) and I had to make a few other adjustments to get it working, so I may > need advice if I've missed anything here. > > A patch has been added to fix a Qt 6 issue causing Syncplay to crash. > > > These should be inputs, not propagated-inputs, unless it can be used as > > a library? Also, please sort the inputs alphabetically. > > Fixed; not a library. It appears I was using an inappropriate build system for > this package - I originally made them propagated because gnu-build-system wasn't > doing whatever wrapping python-build-system does to make the inputs available, > so this v2 uses python-build-system instead now. > > Best, > > aurtzy Cheers, aurtzy gnu/packages/video.scm | 54 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 411ad4c2bf..57a05f3eff 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -68,6 +68,7 @@ ;;; Copyright © 2023 Saku Laesvuori ;;; Copyright © 2023 Jaeme Sifat ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> +;;; Copyright © 2024 aurtzy ;;; ;;; This file is part of GNU Guix. ;;; @@ -6349,3 +6350,56 @@ (define-public svtplay-dl broadcasters including SVT Play, Sveriges Radio, TV4 Play, along with many others.") (license license:expat))) + +(define-public syncplay + (package + (name "syncplay") + (version "1.7.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Syncplay/syncplay") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "08bgndszja4n2kql2qmzl6qrzawxvcwmywsc69lq0dzjnpdk96la")))) + (build-system python-build-system) + (arguments + (list + #:imported-modules `(,@%python-build-system-modules + (guix build qt-utils) + (guix build utils)) + #:modules '((guix build python-build-system) + (guix build qt-utils) + (guix build utils)) + #:phases #~(modify-phases %standard-phases + (delete 'check) + (replace 'install + (lambda _ + (invoke "make" "install" "DESTDIR=" + (string-append "PREFIX=" + #$output)))) + (add-after 'install 'wrap-qt + (lambda* (#:key inputs #:allow-other-keys) + (wrap-qt-program "syncplay" + #:output #$output + #:inputs inputs + #:qt-major-version "6")))))) + (native-inputs (list python-pyside-6)) + (inputs (list bash-minimal + python-certifi + python-idna + python-service-identity + python-twisted + qtwayland)) + (home-page "https://syncplay.pl") + (synopsis "Client/server to synchronize media playback on many computers") + (description + "Syncplay is a solution to synchronize video playback across multiple +instances of media players over the Internet. When one person pauses/unpauses +playback or skips to a position in the video, this is replicated across all +media players connected to the same server and in the same \"room\" (viewing +session). A built-in text chat for discussing the synced media is also +included for convenience.") + (license license:asl2.0))) base-commit: 78b881722f08325c76096557313a0faee847c66f -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 09 22:48:11 2024 Received: (at 65031) by debbugs.gnu.org; 10 Jul 2024 02:48:11 +0000 Received: from localhost ([127.0.0.1]:54597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRNNJ-00074j-A5 for submit@debbugs.gnu.org; Tue, 09 Jul 2024 22:48:11 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:48600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRNNE-00073y-5s for 65031@debbugs.gnu.org; Tue, 09 Jul 2024 22:48:07 -0400 Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-449537c62d1so4452411cf.1 for <65031@debbugs.gnu.org>; Tue, 09 Jul 2024 19:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720579612; x=1721184412; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/gtsa9YBCyVKW1zx9CuYP5/QWRVUcLev8cFroY3Ti+s=; b=YPr/5+iFVXzzVd+++uSuY9P57b0DZIRjhxmYOFHA6nMvy/MSzQtCkvOQfnxlJ1Jg/k hjU1gY/8mTx/znWL6RJ0lNnH9Ot38qnU0hdTOb+/R1VARN1ealzNjXvLvTgC5cBGPwUH xwhvouoz0RYHmjVrpynQ/4/MOUqvWtkOvtaKFvFHoEPMzmTFSgbLEY6JwjlmpFlvbwcU 1WZlqix3w+FfNO6Q0b3kdYL0ql7mWVxtZcKg65flvEnzfPRNEsc8+RMEnS50CFl6F1kf 23dJRxb0Aii7/BrWOHm3oASgz/g7/2Vv4+Wog8p0bHzrgz7kiz754a8uN45lmUyahcoa 9ddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720579612; x=1721184412; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/gtsa9YBCyVKW1zx9CuYP5/QWRVUcLev8cFroY3Ti+s=; b=t+LCunU+ztqNMtQelZY5V8e69NC0saken6HnKT/GlKA2ZR9geXL9dk/Efb3vnRF+BS b3a8IOhnhHB95UF9SzhxITkBkiO/X/EPf8lqCyHnm0JMcwrNGaq9xikbqVbqvZsJx8K1 gambiQ6sRRJMNsJiVAcqAQ0yJteceASsXn4jB7ZRB/DWGHTce6099g/ZyljE8dX3UXEm lvqallN6k5FKlDS4eHmEnndtjZNiezgDZOD6Sr3qBCcgSnrSVVLkyV/YUEzkp7Q+lh63 8LbRySyO3hP1phJnIfjbMSCNVbjPnH+rZPpIOBcVETAWg+MId3FyBdMBCc2HhHKP71R3 LmCw== X-Gm-Message-State: AOJu0Yz5UT8ck5Wc1VoVDCCQj1hZ7D9cc6XKosXHP2YGMuu53ShFV4OK gcCpixNuxhAtmyxYB5AAM0L6N72MStak4r1R2tYgBBIZG5U8FUrtaGhiSg== X-Google-Smtp-Source: AGHT+IEp0A8nzeeydPHQBOxfxeQSCwlNEIyqQwU+F9mqNACgDzMgiV+ykMu7iRgEdb8ROwXdME/2nw== X-Received: by 2002:a05:622a:1a9f:b0:446:5538:40e1 with SMTP id d75a77b69052e-447fa86961fmr49027511cf.17.1720579611792; Tue, 09 Jul 2024 19:46:51 -0700 (PDT) Received: from hurd (dsl-205-236-230-124.b2b2c.ca. [205.236.230.124]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-447f9bf8d06sm16109251cf.97.2024.07.09.19.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 19:46:51 -0700 (PDT) From: Maxim Cournoyer To: aurtzy Subject: Re: [bug#65031] [PATCH v3] gnu: Add syncplay. In-Reply-To: (aurtzy@gmail.com's message of "Sat, 29 Jun 2024 17:37:55 -0400") References: <20230803061517.27336-1-aurtzy@gmail.com> Date: Tue, 09 Jul 2024 22:46:50 -0400 Message-ID: <87jzhuufol.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65031 Cc: 65031@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello! aurtzy writes: > * gnu/packages/video.scm (syncplay): New variable. > > Change-Id: I72cdfa3db2b4b7ef6c3ef0b8585d138c272046a7 > --- > > Hi Maxim, > > Just got around to looking at this package again with a new patch as thin= gs > have changed since my last reply (and I didn't cc you before, oops..). > > In addition to addressing your initial review, notable changes from v2 > include: > > - Update to current latest version of Syncplay (1.7.3). > - Patch is no longer needed. > - This patch puts syncplay in (gnu packages video) instead of the previous > (gnu packages networking) since the latter seemed more concerned with > system-level networking. Does this make sense? It does make sense :-). This sounds good. [...] > gnu/packages/video.scm | 54 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 411ad4c2bf..57a05f3eff 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -68,6 +68,7 @@ > ;;; Copyright =C2=A9 2023 Saku Laesvuori > ;;; Copyright =C2=A9 2023 Jaeme Sifat > ;;; Copyright =C2=A9 2023 Zheng Junjie <873216071@qq.com> > +;;; Copyright =C2=A9 2024 aurtzy > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -6349,3 +6350,56 @@ (define-public svtplay-dl > broadcasters including SVT Play, Sveriges Radio, TV4 Play, along with ma= ny > others.") > (license license:expat))) > + > +(define-public syncplay > + (package > + (name "syncplay") > + (version "1.7.3") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Syncplay/syncplay") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "08bgndszja4n2kql2qmzl6qrzawxvcwmywsc69lq0dzjnpdk96la"))= )) > + (build-system python-build-system) > + (arguments > + (list > + #:imported-modules `(,@%python-build-system-modules > + (guix build qt-utils) > + (guix build utils)) > + #:modules '((guix build python-build-system) > + (guix build qt-utils) > + (guix build utils)) > + #:phases #~(modify-phases %standard-phases > + (delete 'check) > + (replace 'install > + (lambda _ > + (invoke "make" "install" "DESTDIR=3D" > + (string-append "PREFIX=3D" > + #$output)))) > + (add-after 'install 'wrap-qt > + (lambda* (#:key inputs #:allow-other-keys) > + (wrap-qt-program "syncplay" > + #:output #$output > + #:inputs inputs > + #:qt-major-version "6")))))) > + (native-inputs (list python-pyside-6)) > + (inputs (list bash-minimal > + python-certifi > + python-idna > + python-service-identity > + python-twisted > + qtwayland)) > + (home-page "https://syncplay.pl") > + (synopsis "Client/server to synchronize media playback on many compu= ters") > + (description > + "Syncplay is a solution to synchronize video playback across multip= le > +instances of media players over the Internet. When one person pauses/un= pauses > +playback or skips to a position in the video, this is replicated across = all > +media players connected to the same server and in the same \"room\" (vie= wing > +session). A built-in text chat for discussing the synced media is also > +included for convenience.") > + (license license:asl2.0))) > > base-commit: 78b881722f08325c76096557313a0faee847c66f This looks well crafted! Thank you! Reviewed-by: Maxim Cournoyer From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 22:26:35 2024 Received: (at 65031) by debbugs.gnu.org; 12 Sep 2024 02:26:35 +0000 Received: from localhost ([127.0.0.1]:39819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soZXW-0000dX-Oa for submit@debbugs.gnu.org; Wed, 11 Sep 2024 22:26:35 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:52392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soZXU-0000dH-3S for 65031@debbugs.gnu.org; Wed, 11 Sep 2024 22:26:33 -0400 Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7a9b72749bcso39215785a.0 for <65031@debbugs.gnu.org>; Wed, 11 Sep 2024 19:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726107919; x=1726712719; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language:subject :references:cc:to:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=g1nQVyse/6fNvSudyQY62djpwV1Rs95xuEiysuHSgQs=; b=QXBRcYWvA+d3Ig6jvXqC7eEIX7dKsWA/6Rf5QsuiV6jmg0w5WC5DWlgYhYbvDG7gKV Uoo6DgiYUJ3WWwvuuSVBbOmRkppl9spJkkdpRklkxFc55XR65EShvun7uTljMAqOYTc/ QFqU1e8PAwUvcilsJ8yp5ARFFKCWf7OfUHaHACsy3eB2d+wZM428wgozyMbwqI+tLGpy KT014/u+KCpqMIsMujKrfzFBvtqtu5U5aPzFOSnuduEa/jIu5U+yX91vkTMtZ8mMKw2Q WratPiO51XS5zytWPOCyf5kd/kLnM38VFYjjjmEx47fwKgWh8R9cgRnqRbXdIFQJ9hXS oNVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726107919; x=1726712719; h=content-transfer-encoding:in-reply-to:from:content-language:subject :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g1nQVyse/6fNvSudyQY62djpwV1Rs95xuEiysuHSgQs=; b=JuGw90eNIyJKLKQEOf0rtoXZoVPF0zgEly8C5RwO8jZwmCmmKqzzLUrmBvWrpFuDld VuoxYdZmxvyCNEUqmFgCoX+5VEJUOzDw8hEX2lZ3JbaoIhyQZ2cbdVVkGqN3vS3BY3t8 BYPM/LOXE8w/6beoev92fOrZ3UT8rmUhua0TNblXrFnLos6nJOOh6Srkj9S4id2a1Au5 qxLtTxYtTD8084yI+AamJ4cusUZWkPrmmwLgdIYmKUgYx6FJxntYgQTuaQJJVc/SaqMA gVkwuCR4BvGuYdN1LlREply5cm1N7mdFdbl0dMqiTYKRvBM3TaFAqncGIx9u1u7QeiRQ cBkQ== X-Gm-Message-State: AOJu0YzVCuh/kuMS2oNsJ6rPH1ZtyaUDUwAwvLuxJAIYV4r2O/z32TxJ gRXqkO6FeCtcXZOs/AvarcIv826xKqpA/ZQ1NsZLQ2ocb5bxii47fJMNLw== X-Google-Smtp-Source: AGHT+IHzT5WBpOj2PUm3C+O0kyoBTYmKNb8fvcgjfUL7fuolJy+R1K+lKo1jo7wooFtTK2yUCgcF+Q== X-Received: by 2002:a05:622a:1887:b0:458:2f22:ee74 with SMTP id d75a77b69052e-45860328ea3mr20735431cf.32.1726107918892; Wed, 11 Sep 2024 19:25:18 -0700 (PDT) Received: from ?IPV6:2600:4808:a053:7600::e413? ([2600:4808:a053:7600::e413]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45822e7bb60sm47645011cf.32.2024.09.11.19.25.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 19:25:18 -0700 (PDT) Message-ID: Date: Wed, 11 Sep 2024 22:25:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: 65031@debbugs.gnu.org References: <87jzhuufol.fsf@gmail.com> Subject: Re: [PATCH] gnu: Add syncplay. Content-Language: en-US From: aurtzy In-Reply-To: <87jzhuufol.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65031 Cc: aurtzy , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, Small poke on this issue - is there anything else I can help with to get this merged? Cheers, aurtzy > Hello! > > aurtzy writes: > > > * gnu/packages/video.scm (syncplay): New variable. > > > > Change-Id: I72cdfa3db2b4b7ef6c3ef0b8585d138c272046a7 > > --- > > > > Hi Maxim, > > > > Just got around to looking at this package again with a new patch as things > > have changed since my last reply (and I didn't cc you before, oops..). > > > > In addition to addressing your initial review, notable changes from v2 > > include: > > > > - Update to current latest version of Syncplay (1.7.3). > > - Patch is no longer needed. > > - This patch puts syncplay in (gnu packages video) instead of the previous > > (gnu packages networking) since the latter seemed more concerned with > > system-level networking. Does this make sense? > > It does make sense :-). This sounds good. > > [...] > > > gnu/packages/video.scm | 54 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > > index 411ad4c2bf..57a05f3eff 100644 > > --- a/gnu/packages/video.scm > > +++ b/gnu/packages/video.scm > > @@ -68,6 +68,7 @@ > > ;;; Copyright © 2023 Saku Laesvuori > > ;;; Copyright © 2023 Jaeme Sifat > > ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> > > +;;; Copyright © 2024 aurtzy > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -6349,3 +6350,56 @@ (define-public svtplay-dl > > broadcasters including SVT Play, Sveriges Radio, TV4 Play, along with many > > others.") > > (license license:expat))) > > + > > +(define-public syncplay > > + (package > > + (name "syncplay") > > + (version "1.7.3") > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/Syncplay/syncplay") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 "08bgndszja4n2kql2qmzl6qrzawxvcwmywsc69lq0dzjnpdk96la")))) > > + (build-system python-build-system) > > + (arguments > > + (list > > + #:imported-modules `(,@%python-build-system-modules > > + (guix build qt-utils) > > + (guix build utils)) > > + #:modules '((guix build python-build-system) > > + (guix build qt-utils) > > + (guix build utils)) > > + #:phases #~(modify-phases %standard-phases > > + (delete 'check) > > + (replace 'install > > + (lambda _ > > + (invoke "make" "install" "DESTDIR=" > > + (string-append "PREFIX=" > > + #$output)))) > > + (add-after 'install 'wrap-qt > > + (lambda* (#:key inputs #:allow-other-keys) > > + (wrap-qt-program "syncplay" > > + #:output #$output > > + #:inputs inputs > > + #:qt-major-version "6")))))) > > + (native-inputs (list python-pyside-6)) > > + (inputs (list bash-minimal > > + python-certifi > > + python-idna > > + python-service-identity > > + python-twisted > > + qtwayland)) > > + (home-page "https://syncplay.pl") > > + (synopsis "Client/server to synchronize media playback on many computers") > > + (description > > + "Syncplay is a solution to synchronize video playback across multiple > > +instances of media players over the Internet. When one person pauses/unpauses > > +playback or skips to a position in the video, this is replicated across all > > +media players connected to the same server and in the same \"room\" (viewing > > +session). A built-in text chat for discussing the synced media is also > > +included for convenience.") > > + (license license:asl2.0))) > > > > base-commit: 78b881722f08325c76096557313a0faee847c66f > > This looks well crafted! Thank you! > > Reviewed-by: Maxim Cournoyer From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 13 12:09:50 2024 Received: (at 65031-done) by debbugs.gnu.org; 13 Sep 2024 16:09:50 +0000 Received: from localhost ([127.0.0.1]:44132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sp8rm-00006M-Bp for submit@debbugs.gnu.org; Fri, 13 Sep 2024 12:09:50 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:56361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sp8rl-000062-65 for 65031-done@debbugs.gnu.org; Fri, 13 Sep 2024 12:09:49 -0400 Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-205722ba00cso20848335ad.0 for <65031-done@debbugs.gnu.org>; Fri, 13 Sep 2024 09:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726243713; x=1726848513; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dnNR6VK/eBgx7jt1KKobnEnInSlljLotWGfi0DGVPXA=; b=ITrEAJqvoTMWKV2IspyuvFzNqHIkBCYpA87BBThxt5JvpQYO0rZiyeDomPK0/lSVl4 2BVy1sWq8MuC7w15XAKsqZXaROtY0I0LWCBFYv+Sb95CPFpZDoS6PkLvDyJin0tBLUKL n+ya5MQAe3+/CQhNhYPXrqUpesCY/Z+6qBPQRsphaPkL2FLoz9Si8HeC1vTGXzAm2/Uv WzTOIbDwx04DH66inLU4VVDjRCt7psdm+EPJk6yypvE+mFM85l2eKZHNPxjSGiIttOW8 hzkzquDrFmOcOHgRV6s+rj2+GCoC633aQjgBedSUhWCnGlC3D++7voOCJdy2orZKDcGf fyVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726243713; x=1726848513; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dnNR6VK/eBgx7jt1KKobnEnInSlljLotWGfi0DGVPXA=; b=jo30UFciWLoSZ48KOHT754mWmNk4ZAgRAUTQYcg8fPS3uc6SHrIjdL2Pcg9NySXPQ4 z8tfxkWZHFQWmsUePBNrQL2+6kIVNY2RzYROvjEnF1KVkkrGlC6fzdcPCuEIaJ9lyWwm ersRM3AzoQMiHGMpoB4X9+1dWFOuTqB48EMikNU2BfejGBZt44gy4EeY6JrQx6QthxGT Oc3UfEOe1HOL2HUj9DfRYr4FJ1MNhI1XD5SpIORaQccilQQI3MCnVXZ2weTr5YULZdh+ Vvb9pYWrN+/3pIn0aWE09/jQe5PIXF1oQbZeydxcZ7+l+PMHnAXgHXzsN5mMasFEHjLE FhQw== X-Gm-Message-State: AOJu0YxQTO7hwhvMIkPu4Tq5vkt6YHRvHxCu3gjuyVG1JRlXWTLUdPva XYz1COqEzuuGm0XZDHVHjLg0wN3CW72vHKxDuhdKf8clY9vPo0ivZJwT0vh0 X-Google-Smtp-Source: AGHT+IFeCCE8vwlg1dprxi6SD/BdxmNQxrWskHU/C56voa3xLzBFF1O8BaviwcG37JmN4n/RnmGuyg== X-Received: by 2002:a17:902:e84b:b0:207:1826:2f0d with SMTP id d9443c01a7336-2076e4ebdf9mr93866025ad.59.1726243713420; Fri, 13 Sep 2024 09:08:33 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076b01b3fasm29452665ad.289.2024.09.13.09.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 09:08:32 -0700 (PDT) From: Maxim Cournoyer To: aurtzy Subject: Re: [PATCH] gnu: Add syncplay. In-Reply-To: (aurtzy@gmail.com's message of "Wed, 11 Sep 2024 22:25:17 -0400") References: <87jzhuufol.fsf@gmail.com> Date: Sat, 14 Sep 2024 01:08:30 +0900 Message-ID: <87h6ajtu2p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 65031-done Cc: 65031-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello! aurtzy writes: > Hi Maxim, > > Small poke on this issue - is there anything else I can help with to > get this merged? Sorry for the delay! I've now merged it. -- Thanks, Maxim From unknown Fri Jun 20 07:17:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 12 Oct 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator