GNU bug report logs - #65030
30.0.50; Check keyword args of make-process

Previous Next

Package: emacs;

Reported by: Helmut Eller <eller.helmut <at> gmail.com>

Date: Thu, 3 Aug 2023 06:49:01 UTC

Severity: normal

Found in version 30.0.50

Full log


Message #8 received at 65030 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Helmut Eller <eller.helmut <at> gmail.com>,
 Mattias EngdegÄrd <mattiase <at> acm.org>
 Robert Pluim <rpluim <at> gmail.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 65030 <at> debbugs.gnu.org
Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process
Date: Sat, 05 Aug 2023 12:21:40 +0300
> From: Helmut Eller <eller.helmut <at> gmail.com>
> Date: Thu, 03 Aug 2023 08:47:44 +0200
> 
> The functions make-process and make-network-process have many keyword
> arguments and it's somewhat easy to misspell some of them.  E.g. using
> :coding-system instead of :coding.  These functions don't detect such
> mistakes at runtime.  What would people think about adding some checks
> as a compiler macro as with the patch below?
> 
> I didn't know where to put this, so I just left it in bytecomp.el.
> 
> Perhaps the advertised-calling-convention declaration could do this, but
> since keyword arguments seem to be generally discouraged, a special case
> for make-process and make-network-process maybe simpler.

Mattias, Robert and Stefan: any comments on this?

Thanks.




This bug report was last modified 1 year and 316 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.