GNU bug report logs - #65030
30.0.50; Check keyword args of make-process

Previous Next

Full log

View this message in rfc822 format

From: Mattias Engdegård <mattiase <at> acm.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rpluim <at> gmail.com, 65030 <at> debbugs.gnu.org, eller.helmut <at> gmail.com, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#65030: 30.0.50; Check keyword args of make-process
Date: Sun, 6 Aug 2023 10:49:59 +0200

6 aug. 2023 kl. 06.58 skrev Eli Zaretskii <eliz <at> gnu.org>:

> Any specific comments to the proposed patch?  Or do you think it is
> good to go?

Good to go as far as I'm concerned. It will be genuinely useful, and I see no serious problems with the implementation.

It can be extended but that would not prevent it from being committed as-is. For example, something that detects omitted values in the middle, not just the end, of the argument list. (The feasibility of this depends on the likelihood of argument values being keywords themselves.)

The main objection is that `make-process`, due to its design, is often called indirectly using `apply` which would not trigger the application of this compiler macro, so perhaps we should improve the error handling of Fmake_process instead.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.