Subject: Re: [PATCH] gnu: Add xwinwrap.

From: Jean Pierre De Jesus DIAZ <[email-masked]>
Date: Wed, 02 Aug 2023 13:59:29 +0000

Hello Sergio,

>+    (version "0.0.6")

It seems that the project doesn't contain any tag in the upstream
repository and doesn't contain mention of any version released.

So in that case the common convention is to use 0.0.0 as the version
and also it could use (git-version "0.0.0" revision commit) where
revision usually starts at 0 and commit is the commit used for the
source like other packages do.  For example:

```
(define-public xwinwrap
  (let ((revision "0")
        (commit "ec32e9b72539de7e1553a4f70345166107b431f7"))
    (package
      (version (git-version "0.0.0" revision commit)))))
```

And on the origin's git-reference the string can be simply replaced by
the commit variable defined at the top of the package.

>+     '(#:phases (modify-phases %standard-phases

The new style for defining packages is using G-Expressions, so
it would be expressed as:

```
(list #:phases
      #~(modify-phases %standard-phases
          ...))
```

When using G-Exps, this:

>+                      (mkdir-p (string-append %output "/bin")w

Also becomes:

```
(mkdir-p (string-append #$output "/bin"))
```

So, %output can be replaced by #$output in general.

>+                  (delete 'check)

This can be removed and instead the argument `#:tests? #f` could be
added, along with an explanation for the motive, i.e. no tests.

Cheers,

—
Jean-Pierre De Jesus DIAZ