GNU bug report logs - #65006
29.1.50; c-ts-mode: else block not indented right on TAB

Previous Next

Package: emacs;

Reported by: Mohammed Sadiq <sadiq <at> sadiqpk.org>

Date: Wed, 2 Aug 2023 02:44:01 UTC

Severity: normal

Merged with 65026

Found in versions 29.1.50, 30.0.50

Fixed in version 29.2

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: sadiq <at> sadiqpk.org, 65006 <at> debbugs.gnu.org
Subject: bug#65006: 29.1.50; c-ts-mode: else block not indented right on TAB
Date: Wed, 02 Aug 2023 20:05:22 +0300
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Wed, 2 Aug 2023 09:46:54 -0700
> Cc: Mohammed Sadiq <sadiq <at> sadiqpk.org>,
>  65006 <at> debbugs.gnu.org
> 
> >> afair, this did seem to work in the past.  May be this
> >> happened after I updated treesitter-c module, idk.
> 
> Yeah, (sign) I can reproduce this with the latest tree-sitter-c grammar but not the old one. Someone decides to add an else_clause node into the grammar [1] two weeks ago.

How was the else clause parsed in the previous versions of the
grammar?

Will the proposed fix work with the older versions of the grammar?

> > Yuan, can you look into this, please?
> 
> Should the fix go into emacs-29 or master?

To emacs-29, please.

> We really need some way to mandate a version of grammar. These breaking changes are far more frequent than I originally thought.

Who will track all those versions and record which ones are supported?
And many grammar libraries don't have versions at all, so we will have
to track commits instead.




This bug report was last modified 1 year and 303 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.