From unknown Wed Jun 18 23:16:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64989 <64989@debbugs.gnu.org> To: bug#64989 <64989@debbugs.gnu.org> Subject: Status: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer Reply-To: bug#64989 <64989@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:16:48 +0000 retitle 64989 29.1; Comment or uncomment lines in elisp-mode will show mess= age in minibuffer reassign 64989 emacs submitter 64989 Eason Huang severity 64989 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 07:14:33 2023 Received: (at submit) by debbugs.gnu.org; 1 Aug 2023 11:14:33 +0000 Received: from localhost ([127.0.0.1]:47253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQnKj-0004JZ-5u for submit@debbugs.gnu.org; Tue, 01 Aug 2023 07:14:33 -0400 Received: from lists.gnu.org ([2001:470:142::17]:47980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQnKc-0004J9-Sb for submit@debbugs.gnu.org; Tue, 01 Aug 2023 07:14:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQnKW-0006HZ-P9 for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 07:14:20 -0400 Received: from out162-62-57-64.mail.qq.com ([162.62.57.64]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQnKS-0002rN-2g for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 07:14:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1690888445; bh=Bz16XaZSSWnI+HMkDxiUfnDBD+oUJ+cGYiu2SE1PN6M=; h=From:To:Subject:Date; b=p183evWQsJO1hEn2NBaG9Wz0kUWTZJ/s7wn2meHgdhhJx1SZ1WPKAuzKuaCF8Nd1v c7Sq2b4IYVnbAv5HqiU85cqKOEU/FVQazd61pMhdNWHuv0ATZgc+i1gFuyq6GZOx6L amZUd8YlcLFskIvSRCWywmoJlvnmcsJ+3LVkKQ2s= Received: from macbook ([114.82.34.133]) by newxmesmtplogicsvrszb1-0.qq.com (NewEsmtp) with SMTP id 38422EA1; Tue, 01 Aug 2023 19:14:04 +0800 X-QQ-mid: xmsmtpt1690888444t5jbdqqfh Message-ID: X-QQ-XMAILINFO: MZIGq93qkLWzx546sDhaP/OE6u6yHwqVAuGgrpfQq8qtidh6Xp9JWEgninPU6g I78f4mKXvhEf+zZpSWo70IZmJienNsgas3nvJusiw9KRTpzi9dWHgF2G0Q5O/FPmWxhesXM1rOQl vQQp0JYGRS9DiCIx/NDiFOkrTXriLi8CYROI8cT3FaFjJ6SQ5ys2ox2kAIwtMr+WbW65JzeS2gZ5 E5edGFM7wXNiU9SDhomROWQsvt0yYhPtowxQEQCuxxMuI9oOcyIVSrdBvvv7ztj8WE1aqbgw/K5E fTKkZYS+iL9DsYRq4F7Va3pTbpUMCTjfQz0T/uah/T9kq52LePzf3+FofiCxVEZxB6rvWEYbqV+P m6zRJ9fuzUBl6Ur24+R7TYvjh9w58AgGUts3RYtNXZvn1cvEZUJq0XFsH6zU6uxvHHoY0j5TCoZO XRAtKO94cYSwWa5/r0nOSJe4vRTeuw+hYA0y5vBMIDav5YC7M+LmmAwoYMOcu9rXKDE4kSf4SdKL XHd3+cjARUebxDloivfhc5IDzCuJRiZk2OcVzuPAPetimmkQf+eP8ahCdpQJpoiiDy8prdhJuAkl 7A1vFka6soBjUk67ceCwNAII+3dHr7bdC8YdWKFMZGTDRie2tky0rRYF2KX1j8ibHTQEX4k3ac9d B7iYTKI80Fkut/hOs8nMLSerISORhEHI/Mksm4O+nB9mQ4ixWKhVnmgtpwP5XrH856C1sFcQYX5F NCU10jP5A5kXy/X15wpwXPxTHcESLeMkRP96UHk7JZfaTUFYEgs+f/p8FjDzqlLjs1wAL3K2ekhe mFNztIyd6Cs9tKtAt1yGBp+7UyFI/7bOygUAdpTvQ0Uer+0ZpyaqxisebRrMmfGlWgzcYx3qKL2g yk5kQYHOHWmMWvWjfKiXiv0+HqOSeV56JHM26KCI94xxvSO5EPndVCrsYasyrwQpXWN4bH21Nifm /k6UOeHiyyE+tJ1XQgOg== X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= From: Eason Huang To: bug-gnu-emacs@gnu.org Subject: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer Date: Tue, 01 Aug 2023 19:13:59 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=162.62.57.64; envelope-from=aqua0210@foxmail.com; helo=out162-62-57-64.mail.qq.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Emacs, When update to the new released Emacs 29.1, I found that when comment or uncomment lines in emacs-lisp-mode will show message in minibuffer as below: ``` combine-change-calls: buffer-undo-list broken [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Hello Emacs, When update to the new released Emacs 29.1, I found that when comment or uncomment lines in emacs-lisp-mode will show message in minibuffer as below: ``` combine-change-calls: buffer-undo-list broken ``` Steps to reproduce: 1. create a test.el file with any Elisp code. such as: ``` (message "Test") ``` 2. start emacs and open the test.el file with `emacs -Q ~/test.el` 3. Use C-x C-; (comment-line) to comment the code in test.el 4. Now you will see the message mentioned above. This issue also happened on Emacs 29.1 on Windows OS. ---- Best regard, Eason Huang In GNU Emacs 29.1 (build 1, x86_64-apple-darwin22.6.0, NS appkit-2299.70 Version 13.5 (Build 22G74), git sha1 a9b28224af0) of 2023-07-30 built on macbook Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.5 Configured using: 'configure --with-native-compilation=aot --without-dbus 'CPPFLAGS=-I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk' 'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-rpath /opt/local/lib/gcc12 -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -arch x86_64'' Configured features: ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-git diff-mode easy-mmode vc-dispatcher shortdoc text-property-search help-fns radix-tree cl-loaddefs comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 91885 14315) (symbols 48 7745 3) (strings 32 22830 1629) (string-bytes 1 698877) (vectors 16 17037) (vector-slots 8 356967 18443) (floats 8 85 110) (intervals 56 538 16) (buffers 984 14)) From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 09:20:26 2023 Received: (at 64989) by debbugs.gnu.org; 1 Aug 2023 13:20:26 +0000 Received: from localhost ([127.0.0.1]:47402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQpIY-0004KS-EO for submit@debbugs.gnu.org; Tue, 01 Aug 2023 09:20:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQpIV-0004K7-0w for 64989@debbugs.gnu.org; Tue, 01 Aug 2023 09:20:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQpIO-0004nB-IF; Tue, 01 Aug 2023 09:20:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=N235XF7c2V7DoZAXg15u4f64bRYDC/IplueoOelMbTY=; b=Kh9jwmSmvrZq 6p1ijunN5erzgY9UlEiRtrAoXMDtVq8JY6RLUCJjVDP91Q7rOjsMUpHEeykMGEInfyaWCoOBJb2P3 TO5d33sWHSarAPgMGTXqgNiRszg22cDNFfEo+YqWmBW3BL1Ipva+crJYpfeA0Ms5welxH4CUsXE+T phBLFbXdxpP5eSZbK5mOJjutqdUI84IW0Q/4N+X/zOqomuJ9ZMnWemfip+j8JN0K9c4aDctjHFW4H oYkcc1RcUorM4ybVBPwOMCXU3L1AwKjgNrxXoV25AlBcywwn4cRhn72NNmz771kEndqzkTPBUT6Pb ae8zQa2iRwObG3w5eOEvgA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQpIO-0003OT-1F; Tue, 01 Aug 2023 09:20:16 -0400 Date: Tue, 01 Aug 2023 16:20:20 +0300 Message-Id: <83leeu292j.fsf@gnu.org> From: Eli Zaretskii To: Eason Huang , Stefan Monnier In-Reply-To: (message from Eason Huang on Tue, 01 Aug 2023 19:13:59 +0800) Subject: Re: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64989 Cc: 64989@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eason Huang > Date: Tue, 01 Aug 2023 19:13:59 +0800 > > Hello Emacs, > > When update to the new released Emacs 29.1, I found that when comment or > uncomment lines in emacs-lisp-mode will show message in minibuffer as > below: > ``` > combine-change-calls: buffer-undo-list broken > ``` > Steps to reproduce: > 1. create a test.el file with any Elisp code. such as: > ``` > (message "Test") > ``` > 2. start emacs and open the test.el file with `emacs -Q ~/test.el` > 3. Use C-x C-; (comment-line) to comment the code in test.el > 4. Now you will see the message mentioned above. Thanks. Stefan, I think this is due to the commit below: | Author: Stefan Monnier | AuthorDate: Fri Jan 13 17:38:04 2023 -0500 | Commit: Stefan Monnier | CommitDate: Fri Jan 13 17:38:04 2023 -0500 | | * lisp/subr.el (combine-change-calls-1): Fix bug#60467 | | Don't stop at timestamps. Strip them for now, to be on the safe side. | Don't merge into `master` where we'll use a better fix. My "partial bisecting" indicates that the bug was introduced between Dec 31, 2022 and Jan 31, 2023, and the above is the only commit in-between that could matter. If indeed this is the culprit, can we perhaps backport the "better fix" from master to the emacs-29 branch? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 02:43:37 2023 Received: (at 64989) by debbugs.gnu.org; 12 Aug 2023 06:43:37 +0000 Received: from localhost ([127.0.0.1]:48501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUiLY-0003OG-UZ for submit@debbugs.gnu.org; Sat, 12 Aug 2023 02:43:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUiLV-0003Nv-Mf for 64989@debbugs.gnu.org; Sat, 12 Aug 2023 02:43:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUiLO-0004xT-JM; Sat, 12 Aug 2023 02:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ppKIll32GMqwjTtrpjhdHShmQYHjG25k0kpRgCn39Vc=; b=I3RvPIFzKcOQ 0wtCSlcpFOza7w6Ti7N9kstd09/y0a79CaAS3fIE+mSx06XS3ekC4kqrPUmTbyQstcYykX/CPRdB/ kO6vI6uYZok94srfKax55xkXaJ5RmUYcPbfB5aBNwSmWS5d/wCtxFukRqFAMumjZtbLHPT5TqUUSr arOH6olLJa+ySsetC4iVKC+lp9yOa9CC6MBWkQ7iv/5TsNOG4LmHmgkPXsxHiCPIZnn+eeUMmFwc/ bmB/6QXq6pmgRFO6nPhb1bXXsiPDel+iXKbuS1+aOPh/B6Jn03r5q3GIyd+7R154WNqdo7wMXxK5r 8L0P9DKJCIZKewgw9Hizhw==; Date: Sat, 12 Aug 2023 09:43:54 +0300 Message-Id: <83fs4og3px.fsf@gnu.org> From: Eli Zaretskii To: monnier@iro.umontreal.ca In-Reply-To: <83leeu292j.fsf@gnu.org> (message from Eli Zaretskii on Tue, 01 Aug 2023 16:20:20 +0300) Subject: Re: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer References: <83leeu292j.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64989 Cc: aqua0210@foxmail.com, 64989@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Stefan, any suggestions? > Cc: 64989@debbugs.gnu.org > Date: Tue, 01 Aug 2023 16:20:20 +0300 > From: Eli Zaretskii > > > From: Eason Huang > > Date: Tue, 01 Aug 2023 19:13:59 +0800 > > > > Hello Emacs, > > > > When update to the new released Emacs 29.1, I found that when comment or > > uncomment lines in emacs-lisp-mode will show message in minibuffer as > > below: > > ``` > > combine-change-calls: buffer-undo-list broken > > ``` > > Steps to reproduce: > > 1. create a test.el file with any Elisp code. such as: > > ``` > > (message "Test") > > ``` > > 2. start emacs and open the test.el file with `emacs -Q ~/test.el` > > 3. Use C-x C-; (comment-line) to comment the code in test.el > > 4. Now you will see the message mentioned above. > > Thanks. > > Stefan, I think this is due to the commit below: > > | Author: Stefan Monnier > | AuthorDate: Fri Jan 13 17:38:04 2023 -0500 > | Commit: Stefan Monnier > | CommitDate: Fri Jan 13 17:38:04 2023 -0500 > | > | * lisp/subr.el (combine-change-calls-1): Fix bug#60467 > | > | Don't stop at timestamps. Strip them for now, to be on the safe side. > | Don't merge into `master` where we'll use a better fix. > > My "partial bisecting" indicates that the bug was introduced between > Dec 31, 2022 and Jan 31, 2023, and the above is the only commit > in-between that could matter. > > If indeed this is the culprit, can we perhaps backport the "better > fix" from master to the emacs-29 branch? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 09:39:26 2023 Received: (at control) by debbugs.gnu.org; 12 Aug 2023 13:39:26 +0000 Received: from localhost ([127.0.0.1]:48898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUopy-0005P9-3q for submit@debbugs.gnu.org; Sat, 12 Aug 2023 09:39:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUopv-0005On-1P; Sat, 12 Aug 2023 09:39:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUopp-00073u-1n; Sat, 12 Aug 2023 09:39:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Oz1WVs5RQ9u15wW4AUJKok6q0aEQInwcyaq5nUMkwjU=; b=Ol8UN1T/YkQO nMYaBDcE/ysYvBNL8Dy4sYjNjyCvkP9Ehp4g2xlU+TDJ5QNve1eVWEk28p21+FIVoiskTa57SScRr +MnzLCwzWn4YjVBAItzWnHBj40pmdbE/wW2UTEIZGegss4n+COgzxWTjZ4bEkDikbNuCseCIg4xVD ZAcccNh0LE/+3qzCkZ+1aTwarIIGxIEziaiOPsJknwMoQ+fALJOp7Z+yIjjqj9lliN1k6JED3f/OU np47/ah4mFPmCp2SNTZkZeRKwS+XBKz3I1CygAUDwSamRPnSUNcoePAhhPfhrFZ4G0YzkXtIXgrfd BhCTmufpWHJMTkOg/9uXRw==; Date: Sat, 12 Aug 2023 16:39:47 +0300 Message-Id: <83bkfce5wc.fsf@gnu.org> From: Eli Zaretskii To: Rittwik Chatterjee In-Reply-To: (message from Rittwik Chatterjee on Sat, 12 Aug 2023 19:01:17 +0530) Subject: Re: bug#65246: comment-or-uncomment-region breaks buffer-undo-list on visiting file References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 65246@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 65246 64989 thanks > From: Rittwik Chatterjee > Date: Sat, 12 Aug 2023 19:01:17 +0530 > > Subject: 29.1; comment-or-uncomment-region breaks buffer-undo-list on visiting file > Date: Sat, 12 Aug 2023 18:58:00 +0530 > Message-ID: <87fs4opezj.fsf@rittwik-b450mhdvr40.mail-host-address-is-not-set> > --text follows this line-- > > 1. emacs -Q > 2. C-x C-f and visit any file > 3. select any region (using mouse or keyboard) > 4. M-x comment-or-uncomment-region > I get the message "combine-change-calls: buffer-undo-list broken" > > Interstingly, if I select anything in scratch buffer and run comment-or-uncomment-region everything is > fine. > It seems that the bug is affecting only when I am visiting a "real" file. This is a duplicate of a known bug#64989. We are currently discussing how best to fix it and in which version of Emacs. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 12:12:18 2023 Received: (at 64989) by debbugs.gnu.org; 16 Aug 2023 16:12:18 +0000 Received: from localhost ([127.0.0.1]:41900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWJ86-0003pn-7R for submit@debbugs.gnu.org; Wed, 16 Aug 2023 12:12:18 -0400 Received: from heytings.org ([95.142.160.155]:40896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWJ84-0003pf-Qn for 64989@debbugs.gnu.org; Wed, 16 Aug 2023 12:12:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1692202336; bh=Puv2AgU7TSKVk6HHjeCR/dv2etnab/DDOLRIUT9Cx/g=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=yx/2iF1QODvk7a3QTFzeWH6X+y94lUtdfCsDQYYPv7aUgbJwvrbM0XLCtrTh333y6 Ck9mdsQJeRrDzFjar753op42kjzJzEhd4fMHTGDcNSPX/v12P1WY8v+FVnZB/+Gapb vn35Za6+qMeNo7lrp+F8UiMndhTH+YckceKih+3Ynz8oz006C+9rzvJVoJw6Ln2923 Mo9B4evO69uq/BAE58KOeu06IugPMKGENBXaaicsuKW8Tn12+5FZukzQsqDk6xW9V0 q5tRGcJUfCIXd+Kmhy2SRMf1+23YwqWXygm0JJnpRfWR+gqGrTg2R4JhgO2lGqF6xj Bc4UY9thkC/Pw== Date: Wed, 16 Aug 2023 16:12:15 +0000 From: Gregory Heytings To: Eli Zaretskii Subject: Re: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer In-Reply-To: <83fs4og3px.fsf@gnu.org> Message-ID: <77cdab43393e362338ad@heytings.org> References: <83leeu292j.fsf@gnu.org> <83fs4og3px.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64989 Cc: aqua0210@foxmail.com, monnier@iro.umontreal.ca, 64989@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) As mentioned in bug#60467, this is the same bug. I suggest backporting d622602452 to emacs-29 once you are confident enough that it does not break anything (if it does indeed not break anything!). From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 02:19:30 2023 Received: (at 64989) by debbugs.gnu.org; 24 Aug 2023 06:19:31 +0000 Received: from localhost ([127.0.0.1]:35970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ3go-00088f-Hu for submit@debbugs.gnu.org; Thu, 24 Aug 2023 02:19:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ3gl-00088Q-Ve for 64989@debbugs.gnu.org; Thu, 24 Aug 2023 02:19:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ3ga-0005uI-Qo; Thu, 24 Aug 2023 02:19:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=83m9uC9R9O7v5Hg/mvDHoTJiii0HaMIWy/fUXEiY2Hg=; b=n8815COSVbnj ODFFS5zNeWARB0A147QY6hSGVNKTQ1LqJV12RdV0mLM9XZwxhuHUAusJv1tIq6xwkBqhqIwCSQveZ hZaYm4BvuhnBWWzKcIU3wOrEG3UpcfsfB3G/6n68aVsxyOQxcZ8ZGke4NWL5+m6fejWa1Vy7bWyGg Z0SCzHUtPwDChIWiWYKyfUseHFKf+Hns4IwrglDC2lq89jVrlq02pEHoXj5LVPJ+px9+sAq5dSK85 C7LA2DhX6VD3hRYTxvc95w3i1e76OHGKwtc9GHXCNQ+SoRTLK49W8HfLrYhzUi5Q3JwFryj1se94N gN+SYYCEiAYHhyAUjAkJ9w==; Date: Thu, 24 Aug 2023 09:19:41 +0300 Message-Id: <835y55q7wi.fsf@gnu.org> From: Eli Zaretskii To: monnier@iro.umontreal.ca In-Reply-To: <83fs4og3px.fsf@gnu.org> (message from Eli Zaretskii on Sat, 12 Aug 2023 09:43:54 +0300) Subject: Re: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer References: <83leeu292j.fsf@gnu.org> <83fs4og3px.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64989 Cc: aqua0210@foxmail.com, 64989@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Ping! > Cc: aqua0210@foxmail.com, 64989@debbugs.gnu.org > Date: Sat, 12 Aug 2023 09:43:54 +0300 > From: Eli Zaretskii > > Ping! Stefan, any suggestions? > > > Cc: 64989@debbugs.gnu.org > > Date: Tue, 01 Aug 2023 16:20:20 +0300 > > From: Eli Zaretskii > > > > > From: Eason Huang > > > Date: Tue, 01 Aug 2023 19:13:59 +0800 > > > > > > Hello Emacs, > > > > > > When update to the new released Emacs 29.1, I found that when comment or > > > uncomment lines in emacs-lisp-mode will show message in minibuffer as > > > below: > > > ``` > > > combine-change-calls: buffer-undo-list broken > > > ``` > > > Steps to reproduce: > > > 1. create a test.el file with any Elisp code. such as: > > > ``` > > > (message "Test") > > > ``` > > > 2. start emacs and open the test.el file with `emacs -Q ~/test.el` > > > 3. Use C-x C-; (comment-line) to comment the code in test.el > > > 4. Now you will see the message mentioned above. > > > > Thanks. > > > > Stefan, I think this is due to the commit below: > > > > | Author: Stefan Monnier > > | AuthorDate: Fri Jan 13 17:38:04 2023 -0500 > > | Commit: Stefan Monnier > > | CommitDate: Fri Jan 13 17:38:04 2023 -0500 > > | > > | * lisp/subr.el (combine-change-calls-1): Fix bug#60467 > > | > > | Don't stop at timestamps. Strip them for now, to be on the safe side. > > | Don't merge into `master` where we'll use a better fix. > > > > My "partial bisecting" indicates that the bug was introduced between > > Dec 31, 2022 and Jan 31, 2023, and the above is the only commit > > in-between that could matter. > > > > If indeed this is the culprit, can we perhaps backport the "better > > fix" from master to the emacs-29 branch? > > > > From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 26 11:09:39 2023 Received: (at 64989) by debbugs.gnu.org; 26 Aug 2023 15:09:39 +0000 Received: from localhost ([127.0.0.1]:43307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZuux-0001fB-3F for submit@debbugs.gnu.org; Sat, 26 Aug 2023 11:09:39 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZuur-0001er-SF for 64989@debbugs.gnu.org; Sat, 26 Aug 2023 11:09:37 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 41B1080250; Sat, 26 Aug 2023 11:09:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1693062562; bh=Lv7ZtGyylwRm0MhHKUSiZofIUUE/UAZgPIZSSw+i31M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OOAV9yCinav5C6de7iSKkcxk2HXavMeEO1UbedTGP2lLsuEFk+vLqN/gud0jVsbgf bECQ91rDMAZkNwsH0wgF71Lgvz79M0BHlgavA9JN7uLoo90jVkZtm6VnvvIzBfXIfV jgUuR3Tf7M/byKbqNQwEWMJWNqHl0v7myRDzqMq4j2sIO+KtauoynHRzULwGTxXzl5 FeA4KMiuQ4APA818v9OxEqcNxgN7RyWoPP9Mqnn8LbTyxci2RMt/+4ewpsPuAlf105 MxLMBKblQ6la6ujt6Nr0NuIqWBMaf/7vNNU5F+xryReHq5wbF0tvMMxfiQB9aovyfB IzT7q2nZz/4ag== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 037F3803D3; Sat, 26 Aug 2023 11:09:22 -0400 (EDT) Received: from pastel (unknown [108.175.234.188]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C9FB01201FC; Sat, 26 Aug 2023 11:09:21 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer In-Reply-To: <83leeu292j.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 01 Aug 2023 16:20:20 +0300") Message-ID: References: <83leeu292j.fsf@gnu.org> Date: Sat, 26 Aug 2023 11:09:21 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64989 Cc: Eason Huang , 64989@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> When update to the new released Emacs 29.1, I found that when comment or >> uncomment lines in emacs-lisp-mode will show message in minibuffer as >> below: >> ``` >> combine-change-calls: buffer-undo-list broken >> ``` >> Steps to reproduce: >> 1. create a test.el file with any Elisp code. such as: >> ``` >> (message "Test") >> ``` >> 2. start emacs and open the test.el file with `emacs -Q ~/test.el` >> 3. Use C-x C-; (comment-line) to comment the code in test.el >> 4. Now you will see the message mentioned above. > > Thanks. > > Stefan, I think this is due to the commit below: Yup. The message is just wrong in this case: (cdr ptr) is nil simply because `buffer-undo-list` was nil initially, not because the `buffer-undo-list` has been shortened by the GC. > If indeed this is the culprit, can we perhaps backport the "better > fix" from master to the emacs-29 branch? That would work as well. The patch below should do the trick, tho, if you prefer to keep changes to a minimum. Stefan diff --git a/lisp/subr.el b/lisp/subr.el index 28473f1d38c..ec30637b526 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -5002,7 +5002,7 @@ combine-change-calls-1 ;; Don't include a timestamp entry. (setcdr ptr (cddr ptr)) (setq ptr (cdr ptr)))) - (unless (cdr ptr) + (unless (or (cdr ptr) (null old-bul)) (message "combine-change-calls: buffer-undo-list broken")) (setcdr ptr nil) (push ap-elt buffer-undo-list) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 28 12:13:44 2023 Received: (at 64989-done) by debbugs.gnu.org; 28 Aug 2023 16:13:45 +0000 Received: from localhost ([127.0.0.1]:48864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaes4-0001rY-LP for submit@debbugs.gnu.org; Mon, 28 Aug 2023 12:13:44 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaes3-0001rI-EP for 64989-done@debbugs.gnu.org; Mon, 28 Aug 2023 12:13:43 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4097E4414C7; Mon, 28 Aug 2023 12:13:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1693239205; bh=PyAiZPl0DcNQS3vFtbqWS9QMALRDEFcBCN7DQ/c4h40=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=av9IwEJYvlOeHhhIgAWXhXl7OT1jlh7be/UmVFdy5dwiaACktn6s3HPI1JoRLi3E6 2Zv1eXafTVIR11UwGWz7O7Vi2Q/zAv+JwDLJWjk5+1gX99G3CwOtPv8Xgn813LvBn+ 94JzwzKoEH+lZGD95UHIDA7YZeZppalVIMhB0UJSWjg8SfcgRMatTVNyW5nQxAFg77 WbKgaeYFncLb1MJ46+vLCyNbfljKWz1kz8o9UsufVDyifBvHl1MOsISbePGzYmeg/6 NA7ouBpdMuZgjD4BSV/tSWcXfB4ersCfbJHmOTLEivWlMEDflbe0N5RgRmsNJaGqjV z0NLxQXcCVbcQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 99AC1442EE0; Mon, 28 Aug 2023 12:13:25 -0400 (EDT) Received: from pastel (unknown [108.175.234.188]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 760461201A6; Mon, 28 Aug 2023 12:13:25 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer In-Reply-To: (Stefan Monnier's message of "Sat, 26 Aug 2023 11:09:21 -0400") Message-ID: References: <83leeu292j.fsf@gnu.org> Date: Mon, 28 Aug 2023 12:13:24 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64989-done Cc: Eason Huang , 64989-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > That would work as well. The patch below should do the trick, tho, if > you prefer to keep changes to a minimum. Pushed to `emacs-29`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 28 12:36:07 2023 Received: (at 64989-done) by debbugs.gnu.org; 28 Aug 2023 16:36:07 +0000 Received: from localhost ([127.0.0.1]:48899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qafDj-0002Th-1I for submit@debbugs.gnu.org; Mon, 28 Aug 2023 12:36:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qafDg-0002T6-3e for 64989-done@debbugs.gnu.org; Mon, 28 Aug 2023 12:36:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qafDQ-0005kF-0f; Mon, 28 Aug 2023 12:35:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1u2vcDRhIJXg+RIUY8vPyIXj/K7JIGwpHTYLoQ7CO24=; b=F5Hmdajx9hb/ EBq98x4sT3uPkOhVa5qF0HQcv8H1xwcm5owvRBHjRA2mv7ocr1ivqcPAKwiyzXA/X/7AwwrePq6ov Zgl95LGcIAjItDgPfuL7Cn3I/vcAo5BCnpDk7RSUEipTNcmo9Wr9TNp9WN9H0JHuZMGFoPqcm//m1 FBTbZHg05s2zJs5EMfXIVRzRn/QPM+irHkIecBXD16evOznz4gXtxR6KRysgkmzOYXAN2w4UYKK7g RynZg4kF7Jex4epMdubQXwAMY2kyJlV7tf769+IHmiQMzR/C+AViVhvp1wunCwzoESAN3BnlV9bMe D5FN04UJAz2xXepkn8x7ag==; Date: Mon, 28 Aug 2023 19:35:23 +0300 Message-Id: <83a5ubi0qc.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Mon, 28 Aug 2023 12:13:24 -0400) Subject: Re: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer References: <83leeu292j.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64989-done Cc: aqua0210@foxmail.com, 64989-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eason Huang , 64989-done@debbugs.gnu.org > Date: Mon, 28 Aug 2023 12:13:24 -0400 > > > That would work as well. The patch below should do the trick, tho, if > > you prefer to keep changes to a minimum. > > Pushed to `emacs-29`. Thanks! From unknown Wed Jun 18 23:16:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Sep 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator