Subject: Re: bug#64985: 30.0.50; package-recompile-all and package-recompile do not recompile anything, seems related to the patch associated with bug #64985

From: Jim Porter <[email-masked]>
Date: Fri, 4 Aug 2023 13:05:56 -0700

On 8/4/2023 12:37 PM, Vincenzo Pupillo wrote:
> It seems to be a problem related to the patch attached to the bug #64985
> My byte-compile-ignore-files is nil as a result, If I've made no mistake,
> (mapconcat #'identity byte-compile-ignore-files "\\|") is an empty string.
> Could this be the problem?

Oops. Does this patch fix things?

From 1ca1492a15eb97e7ab7929fd2166f1bf53e8dbbb Mon Sep 17 00:00:00 2001
From: Jim Porter <[email-masked]>
Date: Fri, 4 Aug 2023 13:01:35 -0700
Subject: [PATCH] Fix handling of 'byte-compile-ignore-files' when nil

Before this fix, when 'byte-compile-ignore-files' was nil,
'byte-recompile-directory' would ignore every file (bug#64985).

* lisp/emacs-lisp/bytecomp.el (byte-recompile-directory): Handle case
when 'byte-compile-ignore-files' is nil.
---
 lisp/emacs-lisp/bytecomp.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 65ccb60726f..d093d95a775 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1923,7 +1923,9 @@ byte-recompile-directory
     (let ((directories (list default-directory))
 	  (default-directory default-directory)
           (ignore-files-regexp
-           (mapconcat #'identity byte-compile-ignore-files "\\|"))
+           (if byte-compile-ignore-files
+               (mapconcat #'identity byte-compile-ignore-files "\\|")
+             regexp-unmatchable))
 	  (skip-count 0)
 	  (fail-count 0)
 	  (file-count 0)
-- 
2.25.1