From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 06:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 64985@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169087083419615 (code B ref -1); Tue, 01 Aug 2023 06:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Aug 2023 06:20:34 +0000 Received: from localhost ([127.0.0.1]:47013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQikE-00056J-Cz for submit@debbugs.gnu.org; Tue, 01 Aug 2023 02:20:34 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQikD-000566-BQ for submit@debbugs.gnu.org; Tue, 01 Aug 2023 02:20:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQik8-0008BW-1E for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 02:20:28 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQik6-000435-5z for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 02:20:27 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-686bc261111so3771160b3a.3 for ; Mon, 31 Jul 2023 23:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690870824; x=1691475624; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=oJc13hxy21DqKxvcuUZkjkJd+BudhGB/InGSFtXhU6Q=; b=CohrBo8b4KSWIRtSTvCEoKQqMGvfKPJnWGj5UioPoMvydGUKIKhJZJDVKkjo3luBq6 O+aEbr9jQfw8STItnB+dQplyrO1SB7Gd8qXGkN/KkHU3zRonrv8KqFbQwdlLBhHG4K3t BYOQnOkegFf5V4bkLFWd9ilmCr6bUwnpaUJJ5YGSldGnrRQKpJGccvTelAu7gk9cOIwU Zpm0pCMQ27zYDrdVJHwF9luVMOBBP+IuL3ToVTbR6TrX3OvKplC56N0LnTOSV+x5itpr njvzObqW6YgJlxfWpBLc5gt4eRZFDh2fuYXwgMk0hvrmqCIVwPL705U/EeAQ84rWkQiC kSkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690870824; x=1691475624; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oJc13hxy21DqKxvcuUZkjkJd+BudhGB/InGSFtXhU6Q=; b=dV2TmVoWpvsTS0EwJlZMBo7mnPo+pjMONmO0sLiYR8lZEQxzNPYsFAJKQmh65acSCs gH/gkwKYCLHSckQGukDXM58it0aDmluooEUgdXTflyaujs/rWAFPEbUc99/h78OK1rZG 1WLvOlm0kBdzDW3GquH7OhaEr19ygu5EZd6jOXVTzs2glgzPyDjVrl4xbWKWAp7Q7cqp uoIOqKZwMHxiwXamcfo/1pCeZ85Vbw+hGgQYJXYw95MlvPecFj0GLlhu37wMzr83S/Db G0hS4q+qrR11JJWu3IiyTWXSsYsG1jhmBKGbew7vM/E3JNTkN9o72vNXmIrYInCTs+Ai ysUA== X-Gm-Message-State: ABy/qLbJO0KcUdOmepBX2slDUgwuRkw5Km+8bWkGw+5kcwcIaFPG6/Ul gPbZRsbu2F3KGxj0H0JT73UqXBwImcM= X-Google-Smtp-Source: APBJJlGh6mMbJ+ht2dhI5D2f1RXF5W1IUdKDR8I4ZvhRPSQcE2UC+Cm9aC0DIUHgAN39jCf+FZHiwA== X-Received: by 2002:a05:6a21:3b4a:b0:137:9622:17b7 with SMTP id zy10-20020a056a213b4a00b00137962217b7mr11666784pzb.25.1690870824271; Mon, 31 Jul 2023 23:20:24 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m14-20020a638c0e000000b0055fedbf1938sm9142827pgd.31.2023.07.31.23.20.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 23:20:23 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------0YBeEpaFCClTbTacSBedp7LF" Message-ID: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> Date: Mon, 31 Jul 2023 23:20:21 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------0YBeEpaFCClTbTacSBedp7LF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit When using the various package-vc installation functions, Emacs byte-compiles the source (good). However, it doesn't ignore sources that match wildcards in ".elpaignore" (bad). That's because, even though 'byte-compile-ignore-files' is documented to be a list of regexps, 'byte-recompile-directory' treats it as a list of strings. To reproduce this, install a package via VC, for example via M-x package-vc-install RET https://github.com/jimporter/urgrep.git RET. Then notice how "urgrep-tests.el" got compiled, even though it matches a wildcard in ".elpaignore". Patch attached to fix this. Eli, would this be safe enough for 29.2? 'byte-compile-ignore-files' is a new feature in 29.1, so hopefully no one else is relying on its current semantics just yet. --------------0YBeEpaFCClTbTacSBedp7LF Content-Type: text/plain; charset=UTF-8; name="0001-Fix-handling-of-.elpaignore-file-when-compiling-pack.patch" Content-Disposition: attachment; filename*0="0001-Fix-handling-of-.elpaignore-file-when-compiling-pack.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYzRlMTk4ZmI5Yzg3NjUzZDFlNjUyODg5NjliZWQxZmY1NDg2ODNjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMzEgSnVsIDIwMjMgMjM6MTA6MDMgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggaGFuZGxpbmcgb2YgIi5lbHBhaWdub3JlIiBmaWxlIHdoZW4gY29tcGlsaW5n IHBhY2thZ2VzCgoqIGxpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCAoYnl0ZS1yZWNvbXBp bGUtZGlyZWN0b3J5KTogVHJlYXQKJ2J5dGUtY29tcGlsZS1pZ25vcmUtZmlsZXMnIGFzIGEg bGlzdCBvZiByZWdleHBzIHBlciBpdHMgZG9jc3RyaW5nLgotLS0KIGxpc3AvZW1hY3MtbGlz cC9ieXRlY29tcC5lbCB8IDEwICsrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2Vy dGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNw L2J5dGVjb21wLmVsIGIvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLmVsCmluZGV4IDViMWQ5 NThlNmMyLi5kMTIzZTY4YTA4OCAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL2J5dGVj b21wLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbApAQCAtMTk5NSw5ICsx OTk1LDggQEAgYnl0ZS1yZWNvbXBpbGUtZGlyZWN0b3J5CiAJCSAgICAgIChvciAobnVsbCBh cmcpIChlcSAwIGFyZykKIAkJCSAgKHktb3Itbi1wIChjb25jYXQgIkNoZWNrICIgc291cmNl ICI/ICIpKSkKICAgICAgICAgICAgICAgICAgICAgICA7OyBEaXJlY3RvcnkgaXMgcmVxdWVz dGVkIHRvIGJlIGlnbm9yZWQKLSAgICAgICAgICAgICAgICAgICAgICAobm90IChzdHJpbmct bWF0Y2gtcAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZWdleHAtb3B0IGJ5dGUt Y29tcGlsZS1pZ25vcmUtZmlsZXMpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgc291 cmNlKSkKKyAgICAgICAgICAgICAgICAgICAgICAobm90IChzZXEtc29tZSAobGFtYmRhIChl eCkgKHN0cmluZy1tYXRjaC1wIGV4IHNvdXJjZSkpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYnl0ZS1jb21waWxlLWlnbm9yZS1maWxlcykpCiAgICAgICAgICAg ICAgICAgICAgICAgKHNldHEgZGlyZWN0b3JpZXMgKG5jb25jIGRpcmVjdG9yaWVzIChsaXN0 IHNvdXJjZSkpKSkKICAgICAgICAgICAgICAgIDs7IEl0IGlzIGFuIG9yZGluYXJ5IGZpbGUu ICBEZWNpZGUgd2hldGhlciB0byBjb21waWxlIGl0LgogICAgICAgICAgICAgICAgKGlmIChh bmQgKHN0cmluZy1tYXRjaCBlbWFjcy1saXNwLWZpbGUtcmVnZXhwIHNvdXJjZSkKQEAgLTIw MDcsOSArMjAwNiw4IEBAIGJ5dGUtcmVjb21waWxlLWRpcmVjdG9yeQogICAgICAgICAgICAg ICAgICAgICAgICAgKG5vdCAoYXV0by1zYXZlLWZpbGUtbmFtZS1wIHNvdXJjZSkpCiAgICAg ICAgICAgICAgICAgICAgICAgICAobm90IChtZW1iZXIgc291cmNlIChkaXItbG9jYWxzLS1h bGwtZmlsZXMgZGlyZWN0b3J5KSkpCiAgICAgICAgICAgICAgICAgICAgICAgICA7OyBGaWxl IGlzIHJlcXVlc3RlZCB0byBiZSBpZ25vcmVkCi0gICAgICAgICAgICAgICAgICAgICAgICAo bm90IChzdHJpbmctbWF0Y2gtcAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJl Z2V4cC1vcHQgYnl0ZS1jb21waWxlLWlnbm9yZS1maWxlcykKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHNvdXJjZSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAo c2VxLXNvbWUgKGxhbWJkYSAoZXgpIChzdHJpbmctbWF0Y2gtcCBleCBzb3VyY2UpKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnl0ZS1jb21waWxlLWlnbm9y ZS1maWxlcykpKQogICAgICAgICAgICAgICAgICAgIChwcm9nbiAoY2wtaW5jZgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHBjYXNlIChieXRlLXJlY29tcGlsZS1maWxlIHNvdXJj ZSBmb3JjZSBhcmcpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgnbm8tYnl0ZS1j b21waWxlIHNraXAtY291bnQpCi0tIAoyLjI1LjEKCg== --------------0YBeEpaFCClTbTacSBedp7LF-- From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter , Philip Kaludercic , Stefan Monnier Cc: 64985@debbugs.gnu.org Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169088892517347 (code B ref 64985); Tue, 01 Aug 2023 11:23:02 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 11:22:05 +0000 Received: from localhost ([127.0.0.1]:47259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQnS1-0004Vi-AV for submit@debbugs.gnu.org; Tue, 01 Aug 2023 07:22:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQnRy-0004VB-VF for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 07:22:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQnRs-0007Q4-MI; Tue, 01 Aug 2023 07:21:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qbgWeox0Q3y9qArklz5iJ+YtLYcChPuRBshmhHXODcc=; b=Ew3cOwWM5m+Q ZiOC9lORhTWzI/+oLaq6s/B2GPKSxxm+TM+ta2uoVqe4fYyBfeoY6spQ48snBI8KE/1PtAloLero6 yTkHLRUwqdxF2p6D4u2l7lUsJwDDN9av8aNlH+Gx0Cmn2K1E6Iczujo2HruKBSj/WzkoM1Hn0E6WV gvLEaxGtdCSKwMho8xIgiQ3TTPX6aeJ0Dx1VM5vsGV2XHFVXNWv7CMW2tJt5O6qVlC5EV5d5A1HkE JApSF7LrmfSZJLZRz+1AaCVYz11+s6QX/O4hfAy5TuNQjcKcCw3D9EQlvggiobuaG9/aGy4bXSfcd aKm/RBMjNQ/+LwmM9W48+w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQnRs-0000r7-4r; Tue, 01 Aug 2023 07:21:56 -0400 Date: Tue, 01 Aug 2023 14:21:59 +0300 Message-Id: <83sf930zzc.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> (message from Jim Porter on Mon, 31 Jul 2023 23:20:21 -0700) References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 31 Jul 2023 23:20:21 -0700 > From: Jim Porter > > When using the various package-vc installation functions, Emacs > byte-compiles the source (good). However, it doesn't ignore sources that > match wildcards in ".elpaignore" (bad). That's because, even though > 'byte-compile-ignore-files' is documented to be a list of regexps, > 'byte-recompile-directory' treats it as a list of strings. > > To reproduce this, install a package via VC, for example via M-x > package-vc-install RET https://github.com/jimporter/urgrep.git RET. Then > notice how "urgrep-tests.el" got compiled, even though it matches a > wildcard in ".elpaignore". > > Patch attached to fix this. Eli, would this be safe enough for 29.2? > 'byte-compile-ignore-files' is a new feature in 29.1, so hopefully no > one else is relying on its current semantics just yet. If Philip and Stefan agree with the patch, I don't mind installing it on the release branch. byte-compile-ignore-files is (a) not documented anywhere except in its doc string, and (b) is a defvar, so kind-of internal. So who will tell us whether the doc string is right and the code wrong, or the other way around? Btw, do we have somewhere the documentation of all those features, including the .elpaignore file and what it can include? I don't see this documented anywhere, so it's a small wonder people make such mistakes (if they are mistakes). From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 12:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 64985@debbugs.gnu.org Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.1690892446945 (code B ref 64985); Tue, 01 Aug 2023 12:21:01 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 12:20:46 +0000 Received: from localhost ([127.0.0.1]:47371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQoMo-0000FA-3z for submit@debbugs.gnu.org; Tue, 01 Aug 2023 08:20:46 -0400 Received: from mout02.posteo.de ([185.67.36.66]:54895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQoMl-0000Ew-OL for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 08:20:44 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C6BE8240103 for <64985@debbugs.gnu.org>; Tue, 1 Aug 2023 14:20:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690892437; bh=i4DYQFQEIxU3X/5fMVYewUgl+6jxlRfkddOltBQzPBc=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=XoAT5h1UiGfJZWJAj8MeCaf1qtXydUO8CERwn8Xt3Cmd1s31GJNMHBSV9ffXx750I 0AtURJRb6ln0PoKppxPQXsx233pDCMgjBEWe8Az0fxgew666rU5i839B9mR28zTX2q 3HeFB1VIgDA2mdf1R06EQW+/VujOP/fRnmHPlvKS4d5lewaoiPcZ+xuO5HOIJ5bdhl KHeWUQomdXSBMHB6cs1DD3pyzniJDizdk9uoELJiXkBisyWu0jhx5Qj3wAWbRWTvGc LIYNzThEQ2FPHDX0BttD3KVrhzcYuaAFDltm8mQcsLd9wK6k8RGKT5Mj38Z9ffERB6 LgHt48id1GitA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RFZ2F2VNJz9sS4; Tue, 1 Aug 2023 14:20:37 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> (Jim Porter's message of "Mon, 31 Jul 2023 23:20:21 -0700") References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Tue, 01 Aug 2023 12:20:36 +0000 Message-ID: <87edknj6nf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Jim Porter writes: > When using the various package-vc installation functions, Emacs > byte-compiles the source (good). However, it doesn't ignore sources > that match wildcards in ".elpaignore" (bad). That's because, even > though 'byte-compile-ignore-files' is documented to be a list of > regexps, 'byte-recompile-directory' treats it as a list of strings. I am a bit confused about this point. Why do you think that `byte-recompile-directory' treads `byte-compile-ignore-files' as a list of non-regexp strings? > To reproduce this, install a package via VC, for example via M-x > package-vc-install RET https://github.com/jimporter/urgrep.git > RET. Then notice how "urgrep-tests.el" got compiled, even though it > matches a wildcard in ".elpaignore". > > Patch attached to fix this. Eli, would this be safe enough for 29.2? > 'byte-compile-ignore-files' is a new feature in 29.1, so hopefully no > one else is relying on its current semantics just yet. > > From ec4e198fb9c87653d1e65288969bed1ff548683c Mon Sep 17 00:00:00 2001 > From: Jim Porter > Date: Mon, 31 Jul 2023 23:10:03 -0700 > Subject: [PATCH] Fix handling of ".elpaignore" file when compiling packages > > * lisp/emacs-lisp/bytecomp.el (byte-recompile-directory): Treat > 'byte-compile-ignore-files' as a list of regexps per its docstring. > --- > lisp/emacs-lisp/bytecomp.el | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 5b1d958e6c2..d123e68a088 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -1995,9 +1995,8 @@ byte-recompile-directory > (or (null arg) (eq 0 arg) > (y-or-n-p (concat "Check " source "? "))) > ;; Directory is requested to be ignored > - (not (string-match-p > - (regexp-opt byte-compile-ignore-files) > - source)) > + (not (seq-some (lambda (ex) (string-match-p ex source)) > + byte-compile-ignore-files)) Here also, instead of merging a list of regular expressions into a disjunctive one, you match each individually. Am I missing something, or what does this change? (string-match-p (regexp-opt '("foo" "bar" "baz")) "foo") ;=> 0 (seq-some (lambda (ex) (string-match-p ex "foo")) '("foo" "bar" "baz")) ;=> 0 (string-match-p (regexp-opt '("foo" "bar" "baz")) "quux") ;=> nil (seq-some (lambda (ex) (string-match-p ex "quux")) '("foo" "bar" "baz")) ;=> nil > (setq directories (nconc directories (list source)))) > ;; It is an ordinary file. Decide whether to compile it. > (if (and (string-match emacs-lisp-file-regexp source) > @@ -2007,9 +2006,8 @@ byte-recompile-directory > (not (auto-save-file-name-p source)) > (not (member source (dir-locals--all-files directory))) > ;; File is requested to be ignored > - (not (string-match-p > - (regexp-opt byte-compile-ignore-files) > - source))) > + (not (seq-some (lambda (ex) (string-match-p ex source)) > + byte-compile-ignore-files))) > (progn (cl-incf > (pcase (byte-recompile-file source force arg) > ('no-byte-compile skip-count) From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 64985@debbugs.gnu.org Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169090624711617 (code B ref 64985); Tue, 01 Aug 2023 16:11:02 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 16:10:47 +0000 Received: from localhost ([127.0.0.1]:48212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQrxP-00031I-6j for submit@debbugs.gnu.org; Tue, 01 Aug 2023 12:10:47 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:47337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQrxN-000312-1C for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 12:10:45 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1bbf3da0ea9so25035035ad.2 for <64985@debbugs.gnu.org>; Tue, 01 Aug 2023 09:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690906238; x=1691511038; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=2v2PpH5rBEe5UVJ9qICh3tSelZlRHrka0WAIwr2k5Qs=; b=SvQEqFHQ0HVyYEDwWHU8XAjDZSjSukS/pAM46YLBeNPhjZpi0FwSymAwFh+WDxbmxT PYcY0FkuIlfw6lA/v/+P1RfsPDfaNDkMmWOnTvq0BIsRfPQSxi5CwkS0xxFtIbKbLx9s Fmsr4S+1Amp8L8bL4RURFLk3vnWVqctxw/smSiBDIKHkGVahOvwUOtt3mV2YljIFfEdD m/akC5l4q+0ppMR2N0eBNgsH1sfg/+PPBA8U24h7Ki0Bh12tDhdkjpmc0ht3ZYtnyNT0 rFt6lwvTzQWItFG5yiUMfpBxCjak3RjCrrBQohGdabogK59PtBG7fISWVXCH11grW0I0 Y/6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690906238; x=1691511038; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2v2PpH5rBEe5UVJ9qICh3tSelZlRHrka0WAIwr2k5Qs=; b=WMFdVoJSwG2k4J6SX41K/nz1q9TPTdyCURzAlCYK9kVODWpF64KhCYPe6/lV9wbioS Opl5d76BraIFb2NyDEzCUydpGB5dKG3gHQOv1SsXErgbM0QCHmxGDwwT9x/GeU/kvejQ pe3txcX/r2ILVv56UCLs3oOooWnYoZWhlIoavJVKbqzRXt7w1fWcYcHtCKeP6ZeBv/QY dKNbBzRXv9vRQ+QKT+L2cmErp5Bw42bTNTEj3o3+q6m2mnixip4y+ARiTa1CDApdc1yt FGVfh6cLYYmssDGGM8l2cXUpJSjqrcxByabFoiaPnKnxIAF8IBIcK4J67yIfhcyQC/fa ICtQ== X-Gm-Message-State: ABy/qLbrjBv/6Gex84+gMRWKfBCVAuJBgGEjwDh8zmnNNcRu9AFVDAvU 4kv1wtmVSAhLlPY5ZijDCns= X-Google-Smtp-Source: APBJJlF/F5caxe8wcZJHbAAMbWzub25I11cMgL077gsBxfcyv4cSQAyGqxdyeCYObw2asvKKV6TJLA== X-Received: by 2002:a17:902:834c:b0:1bb:a6de:8e49 with SMTP id z12-20020a170902834c00b001bba6de8e49mr11234476pln.9.1690906238402; Tue, 01 Aug 2023 09:10:38 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m24-20020a170902bb9800b001bbbbda70ccsm10662534pls.158.2023.08.01.09.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 09:10:37 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 09:10:38 -0700 MIME-Version: 1.0 Content-Language: en-US References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <87edknj6nf.fsf@posteo.net> From: Jim Porter In-Reply-To: <87edknj6nf.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/1/2023 5:20 AM, Philip Kaludercic wrote: > Jim Porter writes: > >> When using the various package-vc installation functions, Emacs >> byte-compiles the source (good). However, it doesn't ignore sources >> that match wildcards in ".elpaignore" (bad). That's because, even >> though 'byte-compile-ignore-files' is documented to be a list of >> regexps, 'byte-recompile-directory' treats it as a list of strings. > > I am a bit confused about this point. Why do you think that > `byte-recompile-directory' treads `byte-compile-ignore-files' as a list > of non-regexp strings? The docstring for 'regexp-opt' (which is what 'byte-recompile-directory' uses to combine 'byte-compile-ignore-files') says this: Return a regexp to match a string in the list STRINGS. Each member of STRINGS is treated as a fixed string, not as a regexp. > Here also, instead of merging a list of regular expressions into a > disjunctive one, you match each individually. Am I missing something, > or what does this change? > > (string-match-p (regexp-opt '("foo" "bar" "baz")) "foo") ;=> 0 > (seq-some (lambda (ex) (string-match-p ex "foo")) '("foo" "bar" "baz")) ;=> 0 Consider this case: (string-match-p (regexp-opt '("fo+" "bar")) "foo") ;=> nil (seq-some (lambda (ex) (string-match-p ex "foo")) '("fo+" "bar")) ;=> 0 There might be another way to do this, e.g. so that we could optimize the regexp, but I'm not sure if Emacs has anything to optimize a list of *regexp* alternatives (rather than a list of *string* alternatives). I tested out 'rx' too, but no luck there either. This seemed like the best I could do without more extensive changes, which I wanted to avoid for the 29 branch. From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 64985@debbugs.gnu.org Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169090672812383 (code B ref 64985); Tue, 01 Aug 2023 16:19:02 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 16:18:48 +0000 Received: from localhost ([127.0.0.1]:48228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQs5A-0003Dd-B1 for submit@debbugs.gnu.org; Tue, 01 Aug 2023 12:18:48 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:58470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQs58-0003DP-8E for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 12:18:46 -0400 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-686f090310dso5834563b3a.0 for <64985@debbugs.gnu.org>; Tue, 01 Aug 2023 09:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690906720; x=1691511520; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=x4Yc2CPseIaJuaM07hmHlsevwk5vNlaMrtv/krQcvEM=; b=BC0Kc7p4O4I8vpjvjCFqoT0O52aDgRzTx65hMCyuLC7Nosb9sJli2N6Tfd5pSNt5/V EYRic0UiLMEF+VpxPqqtCAVzbwHGZnlRtuol0RpaI9BM0DjgBAGFn0xwLFT+Jesfq90W zDLFkNITLGBeOmeUlEii5MraJCuJXQHZo4r1fIdkS1GL5JsL0zVGjQR0FldqXjO05WUr pdtPo09RzWKuXLGSzY0sSBEMGcrDWAuMpGxzz2xZgrJLTOho7Tx3JtwX0SM1QADv7GvY hb/dUrrH+AUtljrdpyRyzql5qRXxaq090nVmwhxEf5Eb8mTMA2GPVj0+vk9BUHx0OG/1 wTbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690906720; x=1691511520; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x4Yc2CPseIaJuaM07hmHlsevwk5vNlaMrtv/krQcvEM=; b=MoFAng8kJMj3xn9hJNkeoWuhjj5yzfb+1HMlFdzDNg3VS7zPsaZM+CCEzsfqBN7puH ktZl5E3CnCln2GNzk0k6z+seRX6K6HWDOXN83SPv/hM4gtIgUwoDP6ubTOFI/nf7gL+P n2sKSHl1mBjwMJqh9wT+eWGOJFeHKRt7Qd6E+YySlop6bODeJouGpa2Cm+jy+IoW7fgp sC70vDe6kBtbt6Z+Yj4OXbaRVMiA6AE3jgWYcllHALdUISxLt2Leeal08wwO/ZdoHoqz htLTHDExYK9Bo8hKNlpiTUEZWSCaNBXwA3M/m5kJFMoCFHtHGfpUVV5NWGuzIQKFKdtF /q2Q== X-Gm-Message-State: ABy/qLbH82o1I9XKvqyivpnSPWgf1T/WdSd1s/u56TgmC4BBa5/mvZM6 1ZbxGxbep65U157KYD7Wpr4= X-Google-Smtp-Source: APBJJlE3OiiikT0TX9K/pJn621EOlxH7BuLcUnmNl0WgVEmLYjisiyYCw/4I7yr3y1PfwkN0cTIi+A== X-Received: by 2002:a05:6a00:24d0:b0:668:8705:57cf with SMTP id d16-20020a056a0024d000b00668870557cfmr16366096pfv.25.1690906720354; Tue, 01 Aug 2023 09:18:40 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i13-20020aa7908d000000b00682ed27f99dsm9519631pfa.46.2023.08.01.09.18.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 09:18:39 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 09:18:40 -0700 MIME-Version: 1.0 Content-Language: en-US From: Jim Porter References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <87edknj6nf.fsf@posteo.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/1/2023 9:10 AM, Jim Porter wrote: > There might be another way to do this, e.g. so that we could optimize > the regexp, but I'm not sure if Emacs has anything to optimize a list of > *regexp* alternatives (rather than a list of *string* alternatives). I > tested out 'rx' too, but no luck there either. This seemed like the best > I could do without more extensive changes, which I wanted to avoid for > the 29 branch. Note: 'rx' (well, 'rx-to-string') would work here too, but it didn't optimize the list of regexp alternatives, and I found the code to be harder to read (though I could just be doing it in a clumsy way). From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> In-Reply-To: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 64985@debbugs.gnu.org, Philip Kaludercic Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091096219415 (code B ref 64985); Tue, 01 Aug 2023 17:30:02 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 17:29:22 +0000 Received: from localhost ([127.0.0.1]:48279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQtBR-000535-U0 for submit@debbugs.gnu.org; Tue, 01 Aug 2023 13:29:22 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:60830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQtBP-00052o-K3 for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 13:29:20 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fe28f92d8eso5062873e87.1 for <64985@debbugs.gnu.org>; Tue, 01 Aug 2023 10:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690910953; x=1691515753; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=CT42cQ4OyQ7jorb11unYY9fG6h4QI5/UmtoEtsEnhNQ=; b=TFTUJWeC5KLUSoimMi4xsKngsNkOnvNtpYdwEvxF9Lw0Si3sfusvTQ5shT5KSkyMxT LZdcnCWr0VX4uVGUB+fUPykXbML7aNF2DQAweIitsyZkym+8bKf/8dQ6LU5my99u9rRU UzO3B5AcQknaf0WKAhyQF2iPy4vz5yPj32dqPTuoYRW+LCRiGoNsyr0snAp5A9awwFSm QP64/t03Y5B+l80wQu/1ASEz+ltv+8dMg8xZB7MpNzIs7nhlD3Alb/IlOaHS2HUCCbfc rQZguBPGadU6effrIuDu6MlZ4UDl82Si3VkNvVdh7xUMLe8y0McouU8HQ3rtg1BVxFoR MyLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690910953; x=1691515753; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CT42cQ4OyQ7jorb11unYY9fG6h4QI5/UmtoEtsEnhNQ=; b=RIT/qgsmVOrVLmVvyKz4nZ6EFu0q/JZquSmobpnSF+/K1pvJQtIDbPubM0SRBtxJvx TjLpgYNm2Nfz9KhKtyUtU0L3iiIYUo0nHzRhHC76VCOBUbxsfPDP0b0PBLx52tUDxv3/ KmFko+myABVY1qA2AkO2ly0HXIdwL6kKQJIvVs4ZmQpIZ+q0scvE0XtmszYxzgARIs/d OqwKZufZbwRiw81n7b/I7IL1gDNLCs/FyBR3vv41vOyaxTiKswR05BOkNmL2S2fXavPB 0awb/FWLo+xNtPHGsu4r/RaD0NE4SGbvo851agsvdktHd/vG9m1LvC/wQlYjAqvmpT5b D9Bg== X-Gm-Message-State: ABy/qLZt7m4csFHBsL6wTOeUmTtM3cgqUu+L8CEEUN7ySuiJush+FgN3 xDrv0BxLMUVxVYLU40bg9PQ= X-Google-Smtp-Source: APBJJlHRd14M3HBuHYqldDj5Ya1oPRL+t+N2Eua6CTU+V8rMdMzQt3Y6QJ5cKifzCW/tTK2JTemEAw== X-Received: by 2002:ac2:5a1c:0:b0:4f4:c6ab:f119 with SMTP id q28-20020ac25a1c000000b004f4c6abf119mr2872475lfn.64.1690910952951; Tue, 01 Aug 2023 10:29:12 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm2617275lfn.39.2023.08.01.10.29.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2023 10:29:12 -0700 (PDT) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Message-Id: <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> Date: Tue, 1 Aug 2023 19:29:11 +0200 X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> There might be another way to do this, e.g. so that we could optimize=20= >> the regexp, but I'm not sure if Emacs has anything to optimize a list = of=20 >> *regexp* alternatives (rather than a list of *string* alternatives). = I=20 >> tested out 'rx' too, but no luck there either. This seemed like the = best=20 >> I could do without more extensive changes, which I wanted to avoid = for=20 >> the 29 branch. >>=20 > Note: 'rx' (well, 'rx-to-string') would work here too, but it didn't=20= > optimize the list of regexp alternatives, and I found the code to be=20= > harder to read (though I could just be doing it in a clumsy way). rx doesn't attempt to left-factorise disjunctive patterns unless they = are all literal strings or characters. I have considered a = generalisation, but it would be done on the rx level and so wouldn't = solve your immediate problem here. An alternative would be to match against (mapconcat #'identity byte-compile-ignore-files "\\|") ...) From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 18:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 64985@debbugs.gnu.org, Philip Kaludercic Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091346223666 (code B ref 64985); Tue, 01 Aug 2023 18:12:02 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 18:11:02 +0000 Received: from localhost ([127.0.0.1]:48315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQtpl-00069X-PB for submit@debbugs.gnu.org; Tue, 01 Aug 2023 14:11:02 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:56777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQtpk-00069G-LB for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 14:11:00 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1bbff6b2679so19885895ad.1 for <64985@debbugs.gnu.org>; Tue, 01 Aug 2023 11:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690913455; x=1691518255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=pWc7dhEHjiORILPoGbpFYpcWMiIVpvdbK6UrFoJ30Bw=; b=BtS84io4QwE581ozt5jxWKvj9CUPMd8u+X0THypoIGyAaTrAXP7gSJlxx4Hy6lZz7x 7Ag6f8zQLEo8SZXOHeDBi2eBmrD8LgC3XYYRr7f5YCpaF0mDQNzAS7tehKaIxqdVfpYk HzYNwy1LYB4dPCNS26ajFz34lqAQOE1g41fuHzwzXbtavsBJkFxRpbSllPV55qL/il/u pLiHV5SiOK07xa7O/ssnUeD+Q5Bh/M+9hm2zVDA2Gbs5OqZSh0o+wYLcZeOnu4Wbg8pz 9nyZwTlMA27wAxpZCZ/IYlVEBs1BXy6XatXLE9PjfXm5Rnf5wqy7gEd60rrKQbYmX7Jq XlEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690913455; x=1691518255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pWc7dhEHjiORILPoGbpFYpcWMiIVpvdbK6UrFoJ30Bw=; b=LYw6hQv38DPj4AVgKWcbxqBa2excGg+LeKgMq1eQ4wMBoOqI6QdiYwUzlpvfc/u4kd vN0oihAYFK/6C/fxuIJgGU/K34YjjMWEC2l9VOJMrKQ+pvYTtYbfXaQuhJeIWaauZoq/ sXroS/tMM7NZ4nUX8Icr/sTuvKq/K5BPYd2dHtJL0CSTxjV8cfw/xfTEiT687RENFEcd n3ps9igsDB1+KwZ56eBPkJkGa3IQO73Eej6Y+Jm+TYdzSjx4OqHeg4h0rtxmykvz+Zkd BVNzmmn7ZOVh/I6hTrcXgeRkJcLLxuj7y3uGoG7P6BV+thapl2uP6oDXy9buI91hZGtK iWHw== X-Gm-Message-State: ABy/qLacoCxlRh9gzHh60JLEVPoUSE+ejfkW0zbDHWhLq2UxvybCQAhf 3fCua8IBeC0oc4gN2tP0QgQ= X-Google-Smtp-Source: APBJJlE0UrWjIzz8Bdx7xhbOrUTB5zpMasb0E5OMyTMVQBNmHQgepO9m3RrsLmXCQqv/19DMVSAd5A== X-Received: by 2002:a17:902:e5c1:b0:1bb:8f37:dd0f with SMTP id u1-20020a170902e5c100b001bb8f37dd0fmr13081412plf.45.1690913454571; Tue, 01 Aug 2023 11:10:54 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id iy15-20020a170903130f00b001b801044466sm10820861plb.114.2023.08.01.11.10.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 11:10:53 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 11:10:54 -0700 MIME-Version: 1.0 Content-Language: en-US References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> From: Jim Porter In-Reply-To: <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/1/2023 10:29 AM, Mattias Engdegård wrote: > An alternative would be to match against > > (mapconcat #'identity byte-compile-ignore-files "\\|") ...) Yeah, I thought about that too. I'm not sure if this would be better than using 'seq-some' though; if anyone else has strong opinions on this, I'm happy to change the code to whatever the preferred implementation is. (I'm also not sure the specific implementation matters too much since I doubt this bit is a performance bottleneck.) From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 64985@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091473925685 (code B ref 64985); Tue, 01 Aug 2023 18:33:02 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 18:32:19 +0000 Received: from localhost ([127.0.0.1]:48322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQuAM-0006gC-UE for submit@debbugs.gnu.org; Tue, 01 Aug 2023 14:32:19 -0400 Received: from mout01.posteo.de ([185.67.36.65]:50297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQuAK-0006fw-Bl for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 14:32:17 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 33944240027 for <64985@debbugs.gnu.org>; Tue, 1 Aug 2023 20:32:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690914730; bh=cvB0qrOlFPuFh2LV3B7FwWHmGIyQTNIjdOqvEle29Y0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=QzFuLXx+RvhMpGDhc9C/VhCGkB/IShG1WthBWKQ9xEo2NqwFAlFeIPgjpkYJUlY1J mY5VFH3tl1Iw0wdLDUkARVnBsIQKsPS2bAuKYZJ7A4P76g83CC44aInsXGtF/yjOl3 XNG0peX0emZXYNBMch7WTZldIg03c9MsUejlZuANC3DbptOyaJFVm69zcjFIWJCA1m /wpyztwqlY5wRmG2eStEjvtA9BDnKmrDw5/58R4mtrQWhzt8kKX9UAmZtep/tY/HTu ac3UJhVBT+xaazV5aPKeLhLAKMsEdPyCDYzVVq3YOjqJCCwuIRW9VnczsfEFpYlWbJ XgBvyhim8T6dA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RFkGx49hdz6v1B; Tue, 1 Aug 2023 20:32:09 +0200 (CEST) From: Philip Kaludercic In-Reply-To: (Jim Porter's message of "Tue, 1 Aug 2023 11:10:54 -0700") References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Tue, 01 Aug 2023 18:32:08 +0000 Message-ID: <87a5vak40n.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Jim Porter writes: > On 8/1/2023 10:29 AM, Mattias Engdeg=C3=A5rd wrote: >> An alternative would be to match against >> (mapconcat #'identity byte-compile-ignore-files "\\|") ...) > > Yeah, I thought about that too. I'm not sure if this would be better > than using 'seq-some' though; if anyone else has strong opinions on > this, I'm happy to change the code to whatever the preferred > implementation is. (I'm also not sure the specific implementation > matters too much since I doubt this bit is a performance bottleneck.) The mistake in my previous message was, that I was under the false assumption that regexp-opt did what Mattias mentioned above (I guess the reason is that I faintly remembered that the docstring of regexp-opt mentions (mapconcat 'regexp-quote strings "\\|"), and for some reason I belive the 'regexp-quote was an 'identity). In that case we should certainly apply a patch along the lines of what you suggested, but I would prefer the mapconcat approach, if anything because of the micro-optimisation of avoiding the overhead for the generic seq call and having the create and apply closure over and over again. Not sure if this counts as a strong preference, but it certainly is a preference. From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 64985@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091754330198 (code B ref 64985); Tue, 01 Aug 2023 19:20:02 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 19:19:03 +0000 Received: from localhost ([127.0.0.1]:48327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQutb-0007qz-23 for submit@debbugs.gnu.org; Tue, 01 Aug 2023 15:19:03 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:44115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQutZ-0007qT-5p for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 15:19:01 -0400 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2680f27b52dso3679864a91.0 for <64985@debbugs.gnu.org>; Tue, 01 Aug 2023 12:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690917535; x=1691522335; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=tIRc7c0/9FwikuFFsFq7jGvnuGno7s7bCUzVC50CL68=; b=s5a33ulXFPCqNT4hamXQHDjObNEEw2ycQm4DxCO1qvEUeWu+/3xGSVD21bGv8sxNUn tnXLgWo6AM3UbKihiybjVULUoyKss+k4LIYRHfWMH5NsP1n8XkmQArXQ5wvki7e/Cl/N zvSBhfRE3fPi9c1Fz3XkkgGxIopImthwWvH8YHJ7EclEwoVa7XhMkbapioAVYdJP5O+t PSoKqGuEzA0UxWb5esEZ4hdCUW6faFjBKP6tEcv+qJ38EUGY5P0m++xmQL+Bde94136U xvRLol3QUdFL79fenbQ3g+EwrBV9xINA0Z2KBC68LOdk+Q0eYNl0ua8Rl/fdcq3rt/Ii R+cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690917535; x=1691522335; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tIRc7c0/9FwikuFFsFq7jGvnuGno7s7bCUzVC50CL68=; b=ONmXxreKc8eCXYx6bu8yI0FrO1d73h/M6tbfs43XWeK7Rip050ohX523Xg7qn//4pQ K/qARLHm9g3gVv0a3ht+/k3d6Bv8hKPdm1E4/lf/9iNpGX7ti8iSk6BGur0Apzw4Q/o/ OG8UjgAZ7pE7xck5BzZzVnmefdAcJNYK0kC7Fq74Z1InReBxqsITjy3g7zZ3iMwk45mY EiyLKoQHxXH/NZ6PXB1oNRLpt7aeR1wJ9llDxdzxJzl8a02hco7TWTLxt+cPIOeQt9j3 H5Tjfy2BuKmKRV5BhpVw9oPvMFX6TNyEmCJBQWOJvs6gI8p8h6NGYkFC9Ihdb6J34C2j K1Ng== X-Gm-Message-State: ABy/qLa7EL/zQv+JvZ04zyWlooCtYJ8aUZqICH23WZufIm/xx2F5ZiYv /dWnSGKKNBpQii9WHYjy4U0= X-Google-Smtp-Source: APBJJlEkmAZx54qvdXoR4Yb64VwyfPDR0tXHVnPAu6xBfJ27E9rZFmvOlTV4qkzp3Va9wIUFXIbzwQ== X-Received: by 2002:a17:90a:cb13:b0:268:c48b:705f with SMTP id z19-20020a17090acb1300b00268c48b705fmr5675253pjt.16.1690917535251; Tue, 01 Aug 2023 12:18:55 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id jx3-20020a17090b46c300b00263dfe9b972sm9512249pjb.0.2023.08.01.12.18.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 12:18:54 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------oqit2r0Rf2VMfdg07Efj9qxJ" Message-ID: <9ec021b5-40ca-6858-b2d3-d2bb975d3602@gmail.com> Date: Tue, 1 Aug 2023 12:18:50 -0700 MIME-Version: 1.0 Content-Language: en-US References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> <87a5vak40n.fsf@posteo.net> From: Jim Porter In-Reply-To: <87a5vak40n.fsf@posteo.net> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------oqit2r0Rf2VMfdg07Efj9qxJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/1/2023 11:32 AM, Philip Kaludercic wrote: > In that case we should certainly apply a patch along the lines of what > you suggested, but I would prefer the mapconcat approach, if anything > because of the micro-optimisation of avoiding the overhead for the > generic seq call and having the create and apply closure over and over > again. Not sure if this counts as a strong preference, but it certainly > is a preference. How about this? For extra micro-optimization, I put the 'mapconcat' call outside of the loop. Now we won't concat the same list of strings for every file/dir that we look at. --------------oqit2r0Rf2VMfdg07Efj9qxJ Content-Type: text/plain; charset=UTF-8; name="0001-Fix-handling-of-.elpaignore-file-when-compiling-pack.patch" Content-Disposition: attachment; filename*0="0001-Fix-handling-of-.elpaignore-file-when-compiling-pack.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiNTMwZGUwZjYzOTNkYmI1MTZlYzBlNTYwMWNhOWMyNmRiYmNlNzEwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMzEgSnVsIDIwMjMgMjM6MTA6MDMgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggaGFuZGxpbmcgb2YgIi5lbHBhaWdub3JlIiBmaWxlIHdoZW4gY29tcGlsaW5n IHBhY2thZ2VzCgoqIGxpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCAoYnl0ZS1yZWNvbXBp bGUtZGlyZWN0b3J5KTogVHJlYXQKJ2J5dGUtY29tcGlsZS1pZ25vcmUtZmlsZXMnIGFzIGEg bGlzdCBvZiByZWdleHBzIHBlciBpdHMgZG9jc3RyaW5nCihidWcjNjQ5ODUpLgotLS0KIGxp c3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCB8IDEwICsrKystLS0tLS0KIDEgZmlsZSBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9lbWFjcy1saXNwL2J5dGVjb21wLmVsIGIvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLmVs CmluZGV4IDViMWQ5NThlNmMyLi5mMDY1NjYyODIzNiAxMDA2NDQKLS0tIGEvbGlzcC9lbWFj cy1saXNwL2J5dGVjb21wLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbApA QCAtMTk3NSw2ICsxOTc1LDggQEAgYnl0ZS1yZWNvbXBpbGUtZGlyZWN0b3J5CiAgICAgICAo ZW1hY3MtbGlzcC1jb21waWxhdGlvbi1tb2RlKSkKICAgICAobGV0ICgoZGlyZWN0b3JpZXMg KGxpc3QgZGVmYXVsdC1kaXJlY3RvcnkpKQogCSAgKGRlZmF1bHQtZGlyZWN0b3J5IGRlZmF1 bHQtZGlyZWN0b3J5KQorICAgICAgICAgIChpZ25vcmUtZmlsZXMtcmVnZXhwCisgICAgICAg ICAgIChtYXBjb25jYXQgIydpZGVudGl0eSBieXRlLWNvbXBpbGUtaWdub3JlLWZpbGVzICJc XHwiKSkKIAkgIChza2lwLWNvdW50IDApCiAJICAoZmFpbC1jb3VudCAwKQogCSAgKGZpbGUt Y291bnQgMCkKQEAgLTE5OTUsOSArMTk5Nyw3IEBAIGJ5dGUtcmVjb21waWxlLWRpcmVjdG9y eQogCQkgICAgICAob3IgKG51bGwgYXJnKSAoZXEgMCBhcmcpCiAJCQkgICh5LW9yLW4tcCAo Y29uY2F0ICJDaGVjayAiIHNvdXJjZSAiPyAiKSkpCiAgICAgICAgICAgICAgICAgICAgICAg OzsgRGlyZWN0b3J5IGlzIHJlcXVlc3RlZCB0byBiZSBpZ25vcmVkCi0gICAgICAgICAgICAg ICAgICAgICAgKG5vdCAoc3RyaW5nLW1hdGNoLXAKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAocmVnZXhwLW9wdCBieXRlLWNvbXBpbGUtaWdub3JlLWZpbGVzKQotICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHNvdXJjZSkpCisgICAgICAgICAgICAgICAgICAgICAgKG5v dCAoc3RyaW5nLW1hdGNoLXAgaWdub3JlLWZpbGVzLXJlZ2V4cCBzb3VyY2UpKQogICAgICAg ICAgICAgICAgICAgICAgIChzZXRxIGRpcmVjdG9yaWVzIChuY29uYyBkaXJlY3RvcmllcyAo bGlzdCBzb3VyY2UpKSkpCiAgICAgICAgICAgICAgICA7OyBJdCBpcyBhbiBvcmRpbmFyeSBm aWxlLiAgRGVjaWRlIHdoZXRoZXIgdG8gY29tcGlsZSBpdC4KICAgICAgICAgICAgICAgIChp ZiAoYW5kIChzdHJpbmctbWF0Y2ggZW1hY3MtbGlzcC1maWxlLXJlZ2V4cCBzb3VyY2UpCkBA IC0yMDA3LDkgKzIwMDcsNyBAQCBieXRlLXJlY29tcGlsZS1kaXJlY3RvcnkKICAgICAgICAg ICAgICAgICAgICAgICAgIChub3QgKGF1dG8tc2F2ZS1maWxlLW5hbWUtcCBzb3VyY2UpKQog ICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAobWVtYmVyIHNvdXJjZSAoZGlyLWxvY2Fs cy0tYWxsLWZpbGVzIGRpcmVjdG9yeSkpKQogICAgICAgICAgICAgICAgICAgICAgICAgOzsg RmlsZSBpcyByZXF1ZXN0ZWQgdG8gYmUgaWdub3JlZAotICAgICAgICAgICAgICAgICAgICAg ICAgKG5vdCAoc3RyaW5nLW1hdGNoLXAKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChyZWdleHAtb3B0IGJ5dGUtY29tcGlsZS1pZ25vcmUtZmlsZXMpCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzb3VyY2UpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChu b3QgKHN0cmluZy1tYXRjaC1wIGlnbm9yZS1maWxlcy1yZWdleHAgc291cmNlKSkpCiAgICAg ICAgICAgICAgICAgICAgKHByb2duIChjbC1pbmNmCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAocGNhc2UgKGJ5dGUtcmVjb21waWxlLWZpbGUgc291cmNlIGZvcmNlIGFyZykKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKCduby1ieXRlLWNvbXBpbGUgc2tpcC1jb3Vu dCkKLS0gCjIuMjUuMQoK --------------oqit2r0Rf2VMfdg07Efj9qxJ-- From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 64985@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091771230470 (code B ref 64985); Tue, 01 Aug 2023 19:22:02 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 19:21:52 +0000 Received: from localhost ([127.0.0.1]:48332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQuwJ-0007vO-NO for submit@debbugs.gnu.org; Tue, 01 Aug 2023 15:21:52 -0400 Received: from mout02.posteo.de ([185.67.36.66]:51069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQuwH-0007vA-La for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 15:21:50 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A1570240103 for <64985@debbugs.gnu.org>; Tue, 1 Aug 2023 21:21:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690917703; bh=XwermXkROiziCzJzr43KijREkzIBqrIymFR8QZI82nw=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=EHpshXqZWic1srDIcb0ZuLO/CCyl3VLdyzuGC7QwozqB4v41gsarZDNxJOMzROkjG eK/pGU7QWBdhGxUf6owdzJeHeUJbTaCjZxLRzLTYzKEmRqQDW97Z7opPa3LkdfQWFv ck9li23mSVsO8pLaHIfoDRBL5XOl1QDMzh26zHfhmclzz0Z1Vbf5Lo2q6o4PrP8h/b jIeqzS2Egfds5ddUrF8bk/ac98jV7qIE5VlyMbaxSQleEZehEfGwX5tert50c/nQlG Mg2ANlEDA76q92cmR4RxyH5wWDozHyiYuPgkpEqSHoM+hOnaCn7mJnutJzBe9ofz4A xDeMvUxALoepg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RFlN66kRNz6v89; Tue, 1 Aug 2023 21:21:42 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <9ec021b5-40ca-6858-b2d3-d2bb975d3602@gmail.com> (Jim Porter's message of "Tue, 1 Aug 2023 12:18:50 -0700") References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> <87a5vak40n.fsf@posteo.net> <9ec021b5-40ca-6858-b2d3-d2bb975d3602@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Tue, 01 Aug 2023 19:21:42 +0000 Message-ID: <873512k1q1.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Jim Porter writes: > On 8/1/2023 11:32 AM, Philip Kaludercic wrote: >> In that case we should certainly apply a patch along the lines of what >> you suggested, but I would prefer the mapconcat approach, if anything >> because of the micro-optimisation of avoiding the overhead for the >> generic seq call and having the create and apply closure over and over >> again. Not sure if this counts as a strong preference, but it certainly >> is a preference. > > How about this? For extra micro-optimization, I put the 'mapconcat' > call outside of the loop. Now we won't concat the same list of strings > for every file/dir that we look at. I like this a lot more, thanks. > From b530de0f6393dbb516ec0e5601ca9c26dbbce710 Mon Sep 17 00:00:00 2001 > From: Jim Porter > Date: Mon, 31 Jul 2023 23:10:03 -0700 > Subject: [PATCH] Fix handling of ".elpaignore" file when compiling packages > > * lisp/emacs-lisp/bytecomp.el (byte-recompile-directory): Treat > 'byte-compile-ignore-files' as a list of regexps per its docstring > (bug#64985). > --- > lisp/emacs-lisp/bytecomp.el | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 5b1d958e6c2..f0656628236 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -1975,6 +1975,8 @@ byte-recompile-directory > (emacs-lisp-compilation-mode)) > (let ((directories (list default-directory)) > (default-directory default-directory) > + (ignore-files-regexp > + (mapconcat #'identity byte-compile-ignore-files "\\|")) > (skip-count 0) > (fail-count 0) > (file-count 0) > @@ -1995,9 +1997,7 @@ byte-recompile-directory > (or (null arg) (eq 0 arg) > (y-or-n-p (concat "Check " source "? "))) > ;; Directory is requested to be ignored > - (not (string-match-p > - (regexp-opt byte-compile-ignore-files) > - source)) > + (not (string-match-p ignore-files-regexp source)) > (setq directories (nconc directories (list source)))) > ;; It is an ordinary file. Decide whether to compile it. > (if (and (string-match emacs-lisp-file-regexp source) > @@ -2007,9 +2007,7 @@ byte-recompile-directory > (not (auto-save-file-name-p source)) > (not (member source (dir-locals--all-files directory))) > ;; File is requested to be ignored > - (not (string-match-p > - (regexp-opt byte-compile-ignore-files) > - source))) > + (not (string-match-p ignore-files-regexp source))) > (progn (cl-incf > (pcase (byte-recompile-file source force arg) > ('no-byte-compile skip-count) From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 19:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Philip Kaludercic , Stefan Monnier Cc: 64985@debbugs.gnu.org Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091778630615 (code B ref 64985); Tue, 01 Aug 2023 19:24:01 +0000 Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 19:23:06 +0000 Received: from localhost ([127.0.0.1]:48336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQuxW-0007xj-7K for submit@debbugs.gnu.org; Tue, 01 Aug 2023 15:23:06 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:46471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQuxU-0007x1-1W for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 15:23:04 -0400 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-56433b1b12dso1926737a12.1 for <64985@debbugs.gnu.org>; Tue, 01 Aug 2023 12:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690917778; x=1691522578; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=bRDR8Xu7ZeuSUH8EmZNT/Su/VO+NrksqezbZVqRPuOw=; b=gnKPcHx/jsPMmMKP+udTwpQsanKNI56Ea3u4GCgb8poovQcjRqetrADNEpPuTz1JL8 AM5ABv4SYJsabf60Jvmm99S3osO6pZnvqd4G+mOcUXWGEADwETFWyrmBlMjJvIv18CX1 jbrLjQUEkfoYYU4N6vWRZW80f/g6QtFRrGGysxodgKRWCcZhpfozsWUjVonXyDgINJRm 81P822N6869UkbQkBpXmv/3stzIQSjWphWWeS0UAWxAOoBGGIqNBzgWcQsk6fBBBttSc Txpw73DvkuOVA6st5Q6+2c5jSbZ9te0N6mY1afgYv1tinYvyW9eFMK/N3kTucI0/eoco BGRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690917778; x=1691522578; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bRDR8Xu7ZeuSUH8EmZNT/Su/VO+NrksqezbZVqRPuOw=; b=dX9VGtx1oJbsvKzDt3RTRMWqJSp5Ut2OxNA/VpuuxssPF8wnesLjymLk451hnrT7g1 1S9frBsDeieuLxF7ORKo+/FiH8QYBqO5mvyAGh16z0bbl2YurHlA/p31OeYBZNLWnCpC yK89kKiVIDbMdS/QYO+ZdsCqvBi0G11m4KSumxWvM+QbA1b3Bq+tXHpUACXDuUenrrlL zYvzD16clEPvdLawfJdxlRvEmskWdAsKWczyTTaxQ6MJ0uTs2JvFvKxVUPqEbBkkSFGm 5gihLqMr9xZ80X8njtnuBs0d+PVhj9Rvzx4CtBTj8XMevWt/APrHNOKgQL7aIrC4O428 2Nbw== X-Gm-Message-State: ABy/qLb0PKQXO5ZXpigWNhB7iBElxZr0x2/oK92YtF7cUF+OL81Anarp B/2Jk7ZYockFxoHvWWBHG2s= X-Google-Smtp-Source: APBJJlGapXbxDvdKqBh5cGsTyWNlqu0G825Qiu424HtKsWSOv9WuNreNl240vFKR6muGns9u9E45UQ== X-Received: by 2002:a17:90a:86c7:b0:268:2b5c:14c with SMTP id y7-20020a17090a86c700b002682b5c014cmr11478695pjv.13.1690917778102; Tue, 01 Aug 2023 12:22:58 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x34-20020a17090a6c2500b00264044cca0fsm2743936pjj.1.2023.08.01.12.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 12:22:57 -0700 (PDT) Message-ID: Date: Tue, 1 Aug 2023 12:22:56 -0700 MIME-Version: 1.0 Content-Language: en-US References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <83sf930zzc.fsf@gnu.org> From: Jim Porter In-Reply-To: <83sf930zzc.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/1/2023 4:21 AM, Eli Zaretskii wrote: > Btw, do we have somewhere the documentation of all those features, > including the .elpaignore file and what it can include? I don't see > this documented anywhere, so it's a small wonder people make such > mistakes (if they are mistakes). I'll look into this. I was already looking for a good place to put the documentation I had discussed on emacs-devel about how to choose a good name for an ELPA package, so it would probably make sense for documentation about .elpaignore to live alongside that. From unknown Tue Jun 17 21:56:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Porter Subject: bug#64985: closed (Re: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards) Message-ID: References: <6e947a84-7a73-5890-8672-fe8ef7286c4f@gmail.com> <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> X-Gnu-PR-Message: they-closed 64985 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 64985@debbugs.gnu.org Date: Wed, 02 Aug 2023 18:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1690999742-28231-1" This is a multi-part message in MIME format... ------------=_1690999742-28231-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't c= orrectly handle .elpaignore wildcards which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64985@debbugs.gnu.org. --=20 64985: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64985 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1690999742-28231-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64985-done) by debbugs.gnu.org; 2 Aug 2023 18:08:25 +0000 Received: from localhost ([127.0.0.1]:50126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRGGn-0007KP-Gt for submit@debbugs.gnu.org; Wed, 02 Aug 2023 14:08:25 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:44265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRGGl-0007KA-Dg for 64985-done@debbugs.gnu.org; Wed, 02 Aug 2023 14:08:23 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-686b91c2744so63614b3a.0 for <64985-done@debbugs.gnu.org>; Wed, 02 Aug 2023 11:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690999697; x=1691604497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=JjCuaJdXk5WU0+ob2tkGwVkzV57fz6ToGcA/b/mgfOg=; b=RbChN2ucPPrzPCRvfSmMed5Rq0b7MjBMwKArUm1kNgKYynRUQKDnLwelubpdalL+My KDLwWaBVtEPlw334vO1XqAHpm3YcviPLn8k/UZjx6LyYlXLKXymhYYpvDrwhcyQXuoqD 6dLESfEXkwl569q9orMHJH+BL4guxNdT/BDkydEZcTZqCuinVHZf6k2QgqIeWr5fe5a2 eKUkTseLh1mJbjUfkodZl0YJrqFWS8v9WcmUK0bw1ktm5r70JVLiT83l8es1EWUMqtuB Lj8wCdpaIqYtRevZ2l8rxId4lU4auoGYEWhMLe5ipLQysyQCWlgyOPE8DDWPx/LhgK3j e3Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690999697; x=1691604497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JjCuaJdXk5WU0+ob2tkGwVkzV57fz6ToGcA/b/mgfOg=; b=gFgDc/Rrjrp+9fVoWTAfbV2rvXA7cf3bXesqUzlQDRrSGAYpBSuTIxsCFAIM/FT2Zy gA67SYGRtsqE8Fqa+NcDTIrQu/LMbBOhN0t/xSatpOGlOk3M+k0m26y3EKi5Iqg/T1dt tiVA+UlyYhHjTGKqr/3+WDuxL7mYqbpBSHKTdmAyO7+C/ZWY+w0C4K9q52hlg72IBhKM A4lL+BTEdZymqp//cTKXW7rAFuVpXc79iIPQko976fRggZGhDdeG2UHNMSIzXIzENwTL 3E9UNzjxEAxmvdQIYuaiOVioIoqKkK4GH0JVxm+42ikPxbXOpG6NbWXlE74LPUYvk0pn BscA== X-Gm-Message-State: ABy/qLb4tNixGfaAAelNJ6aIzBRURmTMxiFJlAfnaWT0XacPaHKIuFWg Qmqx5pSiRlgTuZsW6333QsU= X-Google-Smtp-Source: APBJJlGuyj42F1YaGGoZ6VvmRIdtje+fL39HpCYdzI1axzyuqpmbTAbkf5+eptFgwDlFgNIW0oPnXg== X-Received: by 2002:a05:6a20:7d99:b0:13f:4e70:ad48 with SMTP id v25-20020a056a207d9900b0013f4e70ad48mr328954pzj.52.1690999696956; Wed, 02 Aug 2023 11:08:16 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id l24-20020a639858000000b0056438ae5e29sm7171747pgo.43.2023.08.02.11.08.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 11:08:16 -0700 (PDT) Message-ID: <6e947a84-7a73-5890-8672-fe8ef7286c4f@gmail.com> Date: Wed, 2 Aug 2023 11:08:17 -0700 MIME-Version: 1.0 Subject: Re: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Content-Language: en-US To: Philip Kaludercic References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> <87a5vak40n.fsf@posteo.net> <9ec021b5-40ca-6858-b2d3-d2bb975d3602@gmail.com> <873512k1q1.fsf@posteo.net> From: Jim Porter In-Reply-To: <873512k1q1.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64985-done Cc: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , 64985-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/1/2023 12:21 PM, Philip Kaludercic wrote: > Jim Porter writes: > >> How about this? For extra micro-optimization, I put the 'mapconcat' >> call outside of the loop. Now we won't concat the same list of strings >> for every file/dir that we look at. > > I like this a lot more, thanks. Thanks. Now merged to the release branch as da5e05a50e8. Marking this bug closed. ------------=_1690999742-28231-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Aug 2023 06:20:34 +0000 Received: from localhost ([127.0.0.1]:47013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQikE-00056J-Cz for submit@debbugs.gnu.org; Tue, 01 Aug 2023 02:20:34 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQikD-000566-BQ for submit@debbugs.gnu.org; Tue, 01 Aug 2023 02:20:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQik8-0008BW-1E for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 02:20:28 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQik6-000435-5z for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 02:20:27 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-686bc261111so3771160b3a.3 for ; Mon, 31 Jul 2023 23:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690870824; x=1691475624; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=oJc13hxy21DqKxvcuUZkjkJd+BudhGB/InGSFtXhU6Q=; b=CohrBo8b4KSWIRtSTvCEoKQqMGvfKPJnWGj5UioPoMvydGUKIKhJZJDVKkjo3luBq6 O+aEbr9jQfw8STItnB+dQplyrO1SB7Gd8qXGkN/KkHU3zRonrv8KqFbQwdlLBhHG4K3t BYOQnOkegFf5V4bkLFWd9ilmCr6bUwnpaUJJ5YGSldGnrRQKpJGccvTelAu7gk9cOIwU Zpm0pCMQ27zYDrdVJHwF9luVMOBBP+IuL3ToVTbR6TrX3OvKplC56N0LnTOSV+x5itpr njvzObqW6YgJlxfWpBLc5gt4eRZFDh2fuYXwgMk0hvrmqCIVwPL705U/EeAQ84rWkQiC kSkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690870824; x=1691475624; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oJc13hxy21DqKxvcuUZkjkJd+BudhGB/InGSFtXhU6Q=; b=dV2TmVoWpvsTS0EwJlZMBo7mnPo+pjMONmO0sLiYR8lZEQxzNPYsFAJKQmh65acSCs gH/gkwKYCLHSckQGukDXM58it0aDmluooEUgdXTflyaujs/rWAFPEbUc99/h78OK1rZG 1WLvOlm0kBdzDW3GquH7OhaEr19ygu5EZd6jOXVTzs2glgzPyDjVrl4xbWKWAp7Q7cqp uoIOqKZwMHxiwXamcfo/1pCeZ85Vbw+hGgQYJXYw95MlvPecFj0GLlhu37wMzr83S/Db G0hS4q+qrR11JJWu3IiyTWXSsYsG1jhmBKGbew7vM/E3JNTkN9o72vNXmIrYInCTs+Ai ysUA== X-Gm-Message-State: ABy/qLbJO0KcUdOmepBX2slDUgwuRkw5Km+8bWkGw+5kcwcIaFPG6/Ul gPbZRsbu2F3KGxj0H0JT73UqXBwImcM= X-Google-Smtp-Source: APBJJlGh6mMbJ+ht2dhI5D2f1RXF5W1IUdKDR8I4ZvhRPSQcE2UC+Cm9aC0DIUHgAN39jCf+FZHiwA== X-Received: by 2002:a05:6a21:3b4a:b0:137:9622:17b7 with SMTP id zy10-20020a056a213b4a00b00137962217b7mr11666784pzb.25.1690870824271; Mon, 31 Jul 2023 23:20:24 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m14-20020a638c0e000000b0055fedbf1938sm9142827pgd.31.2023.07.31.23.20.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 23:20:23 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------0YBeEpaFCClTbTacSBedp7LF" Message-ID: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> Date: Mon, 31 Jul 2023 23:20:21 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------0YBeEpaFCClTbTacSBedp7LF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit When using the various package-vc installation functions, Emacs byte-compiles the source (good). However, it doesn't ignore sources that match wildcards in ".elpaignore" (bad). That's because, even though 'byte-compile-ignore-files' is documented to be a list of regexps, 'byte-recompile-directory' treats it as a list of strings. To reproduce this, install a package via VC, for example via M-x package-vc-install RET https://github.com/jimporter/urgrep.git RET. Then notice how "urgrep-tests.el" got compiled, even though it matches a wildcard in ".elpaignore". Patch attached to fix this. Eli, would this be safe enough for 29.2? 'byte-compile-ignore-files' is a new feature in 29.1, so hopefully no one else is relying on its current semantics just yet. --------------0YBeEpaFCClTbTacSBedp7LF Content-Type: text/plain; charset=UTF-8; name="0001-Fix-handling-of-.elpaignore-file-when-compiling-pack.patch" Content-Disposition: attachment; filename*0="0001-Fix-handling-of-.elpaignore-file-when-compiling-pack.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYzRlMTk4ZmI5Yzg3NjUzZDFlNjUyODg5NjliZWQxZmY1NDg2ODNjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMzEgSnVsIDIwMjMgMjM6MTA6MDMgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggaGFuZGxpbmcgb2YgIi5lbHBhaWdub3JlIiBmaWxlIHdoZW4gY29tcGlsaW5n IHBhY2thZ2VzCgoqIGxpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCAoYnl0ZS1yZWNvbXBp bGUtZGlyZWN0b3J5KTogVHJlYXQKJ2J5dGUtY29tcGlsZS1pZ25vcmUtZmlsZXMnIGFzIGEg bGlzdCBvZiByZWdleHBzIHBlciBpdHMgZG9jc3RyaW5nLgotLS0KIGxpc3AvZW1hY3MtbGlz cC9ieXRlY29tcC5lbCB8IDEwICsrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2Vy dGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNw L2J5dGVjb21wLmVsIGIvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLmVsCmluZGV4IDViMWQ5 NThlNmMyLi5kMTIzZTY4YTA4OCAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL2J5dGVj b21wLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbApAQCAtMTk5NSw5ICsx OTk1LDggQEAgYnl0ZS1yZWNvbXBpbGUtZGlyZWN0b3J5CiAJCSAgICAgIChvciAobnVsbCBh cmcpIChlcSAwIGFyZykKIAkJCSAgKHktb3Itbi1wIChjb25jYXQgIkNoZWNrICIgc291cmNl ICI/ICIpKSkKICAgICAgICAgICAgICAgICAgICAgICA7OyBEaXJlY3RvcnkgaXMgcmVxdWVz dGVkIHRvIGJlIGlnbm9yZWQKLSAgICAgICAgICAgICAgICAgICAgICAobm90IChzdHJpbmct bWF0Y2gtcAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZWdleHAtb3B0IGJ5dGUt Y29tcGlsZS1pZ25vcmUtZmlsZXMpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgc291 cmNlKSkKKyAgICAgICAgICAgICAgICAgICAgICAobm90IChzZXEtc29tZSAobGFtYmRhIChl eCkgKHN0cmluZy1tYXRjaC1wIGV4IHNvdXJjZSkpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYnl0ZS1jb21waWxlLWlnbm9yZS1maWxlcykpCiAgICAgICAgICAg ICAgICAgICAgICAgKHNldHEgZGlyZWN0b3JpZXMgKG5jb25jIGRpcmVjdG9yaWVzIChsaXN0 IHNvdXJjZSkpKSkKICAgICAgICAgICAgICAgIDs7IEl0IGlzIGFuIG9yZGluYXJ5IGZpbGUu ICBEZWNpZGUgd2hldGhlciB0byBjb21waWxlIGl0LgogICAgICAgICAgICAgICAgKGlmIChh bmQgKHN0cmluZy1tYXRjaCBlbWFjcy1saXNwLWZpbGUtcmVnZXhwIHNvdXJjZSkKQEAgLTIw MDcsOSArMjAwNiw4IEBAIGJ5dGUtcmVjb21waWxlLWRpcmVjdG9yeQogICAgICAgICAgICAg ICAgICAgICAgICAgKG5vdCAoYXV0by1zYXZlLWZpbGUtbmFtZS1wIHNvdXJjZSkpCiAgICAg ICAgICAgICAgICAgICAgICAgICAobm90IChtZW1iZXIgc291cmNlIChkaXItbG9jYWxzLS1h bGwtZmlsZXMgZGlyZWN0b3J5KSkpCiAgICAgICAgICAgICAgICAgICAgICAgICA7OyBGaWxl IGlzIHJlcXVlc3RlZCB0byBiZSBpZ25vcmVkCi0gICAgICAgICAgICAgICAgICAgICAgICAo bm90IChzdHJpbmctbWF0Y2gtcAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJl Z2V4cC1vcHQgYnl0ZS1jb21waWxlLWlnbm9yZS1maWxlcykKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHNvdXJjZSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAo c2VxLXNvbWUgKGxhbWJkYSAoZXgpIChzdHJpbmctbWF0Y2gtcCBleCBzb3VyY2UpKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnl0ZS1jb21waWxlLWlnbm9y ZS1maWxlcykpKQogICAgICAgICAgICAgICAgICAgIChwcm9nbiAoY2wtaW5jZgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHBjYXNlIChieXRlLXJlY29tcGlsZS1maWxlIHNvdXJj ZSBmb3JjZSBhcmcpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgnbm8tYnl0ZS1j b21waWxlIHNraXAtY291bnQpCi0tIAoyLjI1LjEKCg== --------------0YBeEpaFCClTbTacSBedp7LF-- ------------=_1690999742-28231-1-- From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 30.0.50; package-recompile-all and package-recompile do not recompile anything, seems related to the patch associated with bug #64985 References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> In-Reply-To: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> Resent-From: Vincenzo Pupillo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 64985@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169117787825464 (code B ref -1); Fri, 04 Aug 2023 19:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Aug 2023 19:37:58 +0000 Received: from localhost ([127.0.0.1]:54911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS0cX-0006cd-9u for submit@debbugs.gnu.org; Fri, 04 Aug 2023 15:37:58 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS0cS-0006cF-4H for submit@debbugs.gnu.org; Fri, 04 Aug 2023 15:37:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qS0cJ-0003KX-R5 for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 15:37:44 -0400 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qS0cG-0005I6-3C for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 15:37:43 -0400 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2b9b5ee9c5aso39670571fa.1 for ; Fri, 04 Aug 2023 12:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691177851; x=1691782651; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=vh4QIfJfaD34NOKKJ6HmoqZHpu4lfz13fZT8PQudo2I=; b=BYCmBdoRQGakSUvpBH5Bfaz5sDFMlkimf5PPTIXAnWA0OI/E38FtMgjmB/te2D/xav hT/dMPJeEvTUIC/otTJYhhPQMQSAKd3qRTaqCXmEGVrJIpBz8HkbRnw9Du2WEr2ifI0P dUUPM29yQAW8TfkuYkUMm4+rEO1yNFXuIbJ4YlDlgYrTBsh/I1Lsl1O059GmSvpsUucR +Jqn6vw2cdXVb1cLc1H8qjvpsNVYEZpfL9GHiYfJ7tB/2vOB6wYU2orcMjdwiw2Z/ZxK vDvZ6zKw+qKkb8f9eP797C+K/wuBfUo43Y9jvvfIn6202MsxjaAYvJnW5N9dcpZpjXSt i4qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691177851; x=1691782651; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vh4QIfJfaD34NOKKJ6HmoqZHpu4lfz13fZT8PQudo2I=; b=RbfWywggVq4DgHxd2coADvkxH8rehL6wainvIhXZAPfk5jP1OhIoMICPGTmSCLUTNB ydNR2+IW/3hwEXIVXOKq5ot6dkpi7rbBNjCS0hznpLEG4nnAllCY5W3b2emIzgiPSYDW DGFNwdprbpqC7NM1GUhhmYexrhdA2yFcxG8C7lvJFMVbettY50fvLEiVQjU7JPKEL6/G k0U9oJKrefQ7dlC+JHcfwtGZzeplwL1Vv391shP/NSmR0WxbZ464eTz5rP99TB6sPKOt B++nWO5Gl1bAHJHfa4iUm9XbFZ96RQqFwDVcsY7Js1SdLqSQqd0nuGvwT9Oi0xIC4LFD Fvvw== X-Gm-Message-State: AOJu0YwdPFzgnY7fNKomECP/1QNHaJ177Y8urrkf1bJWvH2jmas2jGZ7 K3sw1P+/Pa6HqHlR7qjavJ3rkE/Dhqs= X-Google-Smtp-Source: AGHT+IHK0e5Fe7Kz0ZzUfnVWmZ7kcgcaGGgaQiblqp3kCQ5H1ZcrAU8yXUutSdig7q6W1fQZ5XACDQ== X-Received: by 2002:a2e:2e19:0:b0:2b9:e53f:e1fd with SMTP id u25-20020a2e2e19000000b002b9e53fe1fdmr2269338lju.34.1691177851169; Fri, 04 Aug 2023 12:37:31 -0700 (PDT) Received: from fedora.localnet (93-40-70-209.ip37.fastwebnet.it. [93.40.70.209]) by smtp.gmail.com with ESMTPSA id g4-20020a170906520400b0099bd7b26639sm1719477ejm.6.2023.08.04.12.37.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 12:37:30 -0700 (PDT) From: Vincenzo Pupillo Date: Fri, 04 Aug 2023 21:37:25 +0200 Message-ID: <2359232.ElGaqSPkdT@fedora> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=v.pupillo@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, today, after a git pull from master and rebuilding emacs (I removed all .elc files, make clean && make bootstrap as usual), I tried to recompile all installed packages, but without success. Emacs says: Checking /home/vincenzo/.emacs.d/elpa/zig-mode-20230722.2023... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/yasnippet-20200604.246... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/yaml-20230714.154... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/xterm-color-20230321.3... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/xcscope-20230626.2109... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/xclip-1.11... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/with-editor-20230711.1217... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/which-key-20230712.2151... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/web-completion-data-20160318.848... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/w3m-20230801.18... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/vterm-20230417.424... Done (Total of 0 files compiled) Checking /home/vincenzo/.emacs.d/elpa/vertico-1.4... It seems to be a problem related to the patch attached to the bug #64985 My byte-compile-ignore-files is nil as a result, If I've made no mistake, (mapconcat #'identity byte-compile-ignore-files "\\|") is an empty string. Could this be the problem? Thanks. Vincenzo In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-08-04 built on fedora Repository revision: 60e5f212182ca2f41f89a4315075e38433bc8ac0 Repository branch: master System Description: Fedora Linux 38 (KDE Plasma) Configured using: 'configure --with-native-compilation=aot --with-tree-sitter --with-cairo --with-x-toolkit=gtk3 --without-pop --with-xwidgets --without-imagemagick --prefix=/opt/emacs_pgtk --with-file-notification=inotify --enable-link-time-optimization --with-native-compilation --with-xinput2 --with-pgtk 'CFLAGS=-DMAIL_USE_LOCKF -O2 -funroll-loops -fno-strict-aliasing -march=native -mtune=native -D_FORTIFY_SOURCE=2 -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fstack-clash-protection -fcf-protection'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: it_IT.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: global-git-gutter-mode: t editorconfig-mode: t xclip-mode: t which-key-mode: t global-flycheck-mode: t flycheck-mode: t projectile-mode: t server-mode: t yas-minor-mode: t company-quickhelp-mode: t company-quickhelp-local-mode: t global-company-mode: t company-mode: t persp-mode: t vertico-mode: t override-global-mode: t electric-pair-mode: t which-function-mode: t save-place-mode: t winner-mode: t minibuffer-electric-default-mode: t global-hl-line-mode: t savehist-mode: t delete-selection-mode: t recentf-mode: t xterm-mouse-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t Load-path shadows: /home/vincenzo/.emacs.d/elpa/transient-20230723.1411/transient hides /opt/ emacs_pgtk/share/emacs/30.0.50/lisp/transient Features: (shadow sort mail-extr emacsbug message yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils debug backtrace cl-print vc-git diff-mode vc-dispatcher citre citre-global vertico-directory ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util git-gutter editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch shortdoc help-fns radix-tree cus-start cus-load mvn vterm face-remap term disp-table ehelp vterm-module term/xterm xterm expand-region text-mode-expansions cc-mode-expansions er-basic-expansions expand-region-core expand-region-custom dired-launch xclip which-key consult-imenu consult-flycheck flycheck find-func dash jka-compr let-alist projectile-speedbar sr-speedbar speedbar ezimage dframe projectile skeleton find-dired citre-lang-fileref dired-x dired dired-loaddefs lisp-mnt grep ibuf-ext ibuffer ibuffer-loaddefs add-log compile server yasnippet derived init custom-skeleton custom-rust custom-dart custom-java custom-go custom-php custom-c cuda-mode cc-langs cl citre-lang-c citre-tags citre-ctags citre-readtags citre-readtags-tables citre-backend-interface citre-ui-peek color citre-ui-jump citre-common-tag citre-common-util cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs custom-sql custom-clojure custom-web custom-ruby custom-markup citre-config company-quickhelp pos-tip company-dabbrev-code company-dabbrev company-files company-capf company consult-xref xref project consult bookmark text-property-search pp perspective ibuf-macs comp comp-cstr warnings icons advice ido vertico compat edmacro kmacro json-ts-mode cmake-ts-mode yaml-ts-mode treesit standard-dark-theme standard-themes cl-extra use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core ffap thingatpt elec-pair which-func imenu saveplace tramp-sh tramp rx trampver tramp-integration files-x tramp-message help-mode tramp-compat xdg shell pcomplete comint ansi-osc parse-time iso8601 time-date format-spec ansi-color tramp-loaddefs winner ring minibuf-eldef hl-line savehist delsel recentf tree-widget wid-edit xt-mouse custom-function custom-variable fonts cargo-autoloads citre-autoloads clj-refactor-autoloads cider-autoloads clojure-mode-autoloads cmake-project-autoloads company-glsl-autoloads company-quickhelp-autoloads company-web-autoloads company-autoloads consult-dir-autoloads consult-flycheck-autoloads consult-lsp-autoloads consult-autoloads cuda-mode-autoloads dired-launch-autoloads dired-rsync-autoloads docker-autoloads aio-autoloads editorconfig-autoloads expand-region-autoloads flutter-autoloads flycheck-autoloads git-gutter-autoloads glsl-mode-autoloads go-mode-autoloads google-translate-autoloads gotest-autoloads hover-autoloads iedit-autoloads inflections-autoloads lsp-dart-autoloads dart-mode-autoloads lsp-java-autoloads dap-mode-autoloads lsp-docker-autoloads bui-autoloads lsp-treemacs-autoloads lsp-ui-autoloads lsp-mode-autoloads lua-mode-autoloads magit-autoloads pcase git-commit-autoloads magit-section-autoloads meson-mode-autoloads multiple-cursors-autoloads mvn-autoloads nexus-autoloads paredit-autoloads parseedn-autoloads parseclj-autoloads perspective-autoloads php-mode-autoloads pkg-info-autoloads epl-autoloads plantuml-mode-autoloads popup-autoloads pos-tip-autoloads projectile-speedbar-autoloads projectile-autoloads queue-autoloads request-autoloads restclient-autoloads rustic-autoloads markdown-mode-autoloads f-autoloads rust-mode-autoloads rvm-autoloads sesman-autoloads spinner-autoloads sr-speedbar-autoloads standard-themes-autoloads tablist-autoloads transient-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads ht-autoloads hydra-autoloads lv-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads s-autoloads dash-autoloads vertico-autoloads vterm-autoloads w3m-load w3m-autoloads web-completion-data-autoloads which-key-autoloads with-editor-autoloads info compat-autoloads xclip-autoloads xcscope-autoloads xterm-color-autoloads yaml-autoloads zig-mode-autoloads reformatter-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 674043 157766) (symbols 48 33121 1) (strings 32 157317 5061) (string-bytes 1 6516168) (vectors 16 45685) (vector-slots 8 853703 46616) (floats 8 319 390) (intervals 56 1552 635) (buffers 984 19)) From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 30.0.50; package-recompile-all and package-recompile do not recompile anything, seems related to the patch associated with bug #64985 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Vincenzo Pupillo , 64985@debbugs.gnu.org Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169117956628520 (code B ref 64985); Fri, 04 Aug 2023 20:07:01 +0000 Received: (at 64985) by debbugs.gnu.org; 4 Aug 2023 20:06:06 +0000 Received: from localhost ([127.0.0.1]:54953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS13l-0007Pw-M1 for submit@debbugs.gnu.org; Fri, 04 Aug 2023 16:06:05 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:52557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS13j-0007PP-GV for 64985@debbugs.gnu.org; Fri, 04 Aug 2023 16:06:04 -0400 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-55b0e7efb1cso1402896a12.1 for <64985@debbugs.gnu.org>; Fri, 04 Aug 2023 13:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691179557; x=1691784357; h=in-reply-to:from:references:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=tPKoDLMI3WPIciVJwLhRde4jFfvlyYCMCU15Xj4H8+c=; b=kVJSGZP5FLTdhWB8eZkwcO+/eKvyftwedHKF/goQ7HOdrRdatOgb9ZXPFFsojspAUT 6ariuCFJRHbxexZcY8A/B3fp2W9JOoHUd3JggYEghf3aIk4ODVPZzcyyWTQCkmZzedw7 USBef2XY7hY7hsIxSUnNatLvBU6uNgpok/Yk7RcFnTlooPW1JYK9aWz3B5wXgzW89iF0 gbr/PPaWXrocyo0m/a1Jarqs1QF2wzg1PKmC8RDBnRLsQCfYZ1jjFoAodBCsR5TQsH95 LG2SnqZRtMWQ0m048afmzudlwzPfqhuIpGPFmp7Q4HYfH/ftEZa4JaKvMLlkDYMhcVVi kB8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691179557; x=1691784357; h=in-reply-to:from:references:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tPKoDLMI3WPIciVJwLhRde4jFfvlyYCMCU15Xj4H8+c=; b=TPQ7CtAz6Ol98b6pdVn1ly1zKoZXpBKnjrICO1g0h3abvkkNlYJlLCLtCbo4JklG2M 1GjSCbuzm9+luPsE1uaoZINpRG7U90rHeNeXkA2WebWVYVlG5AUPdBwIZqq8oDj5ZwKn fKs4c1ovW76tNpdO+m36Q4RG6oWmW9sSHy+K88EXxBqucwiTkWU2BIbb8ZlYPSQ+LHNA FcnJAhdIZDAI5tcw4ze8E4HT6asJCjUofZHVB/HjVhDbG+HKH5UfrZkpvKh8ert/xAH8 RD6J/TuNvLiuaZwUtDjaLRv6Ck8b/xApvGFTmfefOpDlUVMqhRSaRkcUEtNZg5JbOC8H GuYg== X-Gm-Message-State: AOJu0YyZCxYUnRbV/eDtDZfUS9o8pg4f3IBA4SgePkvgwVbSRzxHJNL8 /L77UxVBlVtoGok1k/2tD/Q= X-Google-Smtp-Source: AGHT+IGrgXVc7/1vU3dsjzx4pCu93TqvDwiyFPY+yNpKp1VAV+VCtU3Ds2cxzzSOK9QUgufhv9moPg== X-Received: by 2002:a17:90a:ec0b:b0:268:10a3:ceaa with SMTP id l11-20020a17090aec0b00b0026810a3ceaamr2301056pjy.21.1691179557335; Fri, 04 Aug 2023 13:05:57 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id w2-20020a17090a380200b00263f40cf83esm4826198pjb.47.2023.08.04.13.05.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Aug 2023 13:05:56 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------ldBqaFsjPJgaq01H0J8HS8Qy" Message-ID: <3af9fde7-4cee-d38f-c626-f9c29d472049@gmail.com> Date: Fri, 4 Aug 2023 13:05:56 -0700 MIME-Version: 1.0 Content-Language: en-US References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <2359232.ElGaqSPkdT@fedora> From: Jim Porter In-Reply-To: <2359232.ElGaqSPkdT@fedora> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------ldBqaFsjPJgaq01H0J8HS8Qy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/4/2023 12:37 PM, Vincenzo Pupillo wrote: > It seems to be a problem related to the patch attached to the bug #64985 > My byte-compile-ignore-files is nil as a result, If I've made no mistake, > (mapconcat #'identity byte-compile-ignore-files "\\|") is an empty string. > Could this be the problem? Oops. Does this patch fix things? --------------ldBqaFsjPJgaq01H0J8HS8Qy Content-Type: text/plain; charset=UTF-8; name="0001-Fix-handling-of-byte-compile-ignore-files-when-nil.patch" Content-Disposition: attachment; filename*0="0001-Fix-handling-of-byte-compile-ignore-files-when-nil.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSAxY2ExNDkyYTE1ZWI5N2U3YWI3OTI5ZmQyMTY2ZjFiZjUzZThkYmJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgNCBBdWcgMjAyMyAxMzowMTozNSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBoYW5kbGluZyBvZiAnYnl0ZS1jb21waWxlLWlnbm9yZS1maWxlcycgd2hlbiBu aWwKCkJlZm9yZSB0aGlzIGZpeCwgd2hlbiAnYnl0ZS1jb21waWxlLWlnbm9yZS1maWxlcycg d2FzIG5pbCwKJ2J5dGUtcmVjb21waWxlLWRpcmVjdG9yeScgd291bGQgaWdub3JlIGV2ZXJ5 IGZpbGUgKGJ1ZyM2NDk4NSkuCgoqIGxpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCAoYnl0 ZS1yZWNvbXBpbGUtZGlyZWN0b3J5KTogSGFuZGxlIGNhc2UKd2hlbiAnYnl0ZS1jb21waWxl LWlnbm9yZS1maWxlcycgaXMgbmlsLgotLS0KIGxpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5l bCB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCBiL2xpc3Av ZW1hY3MtbGlzcC9ieXRlY29tcC5lbAppbmRleCA2NWNjYjYwNzI2Zi4uZDA5M2Q5NWE3NzUg MTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbAorKysgYi9saXNwL2Vt YWNzLWxpc3AvYnl0ZWNvbXAuZWwKQEAgLTE5MjMsNyArMTkyMyw5IEBAIGJ5dGUtcmVjb21w aWxlLWRpcmVjdG9yeQogICAgIChsZXQgKChkaXJlY3RvcmllcyAobGlzdCBkZWZhdWx0LWRp cmVjdG9yeSkpCiAJICAoZGVmYXVsdC1kaXJlY3RvcnkgZGVmYXVsdC1kaXJlY3RvcnkpCiAg ICAgICAgICAgKGlnbm9yZS1maWxlcy1yZWdleHAKLSAgICAgICAgICAgKG1hcGNvbmNhdCAj J2lkZW50aXR5IGJ5dGUtY29tcGlsZS1pZ25vcmUtZmlsZXMgIlxcfCIpKQorICAgICAgICAg ICAoaWYgYnl0ZS1jb21waWxlLWlnbm9yZS1maWxlcworICAgICAgICAgICAgICAgKG1hcGNv bmNhdCAjJ2lkZW50aXR5IGJ5dGUtY29tcGlsZS1pZ25vcmUtZmlsZXMgIlxcfCIpCisgICAg ICAgICAgICAgcmVnZXhwLXVubWF0Y2hhYmxlKSkKIAkgIChza2lwLWNvdW50IDApCiAJICAo ZmFpbC1jb3VudCAwKQogCSAgKGZpbGUtY291bnQgMCkKLS0gCjIuMjUuMQoK --------------ldBqaFsjPJgaq01H0J8HS8Qy-- From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 30.0.50; package-recompile-all and package-recompile do not recompile anything, seems related to the patch associated with bug #64985 References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> In-Reply-To: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 17:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 64985@debbugs.gnu.org, Vincenzo Pupillo Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169125554627116 (code B ref 64985); Sat, 05 Aug 2023 17:13:01 +0000 Received: (at 64985) by debbugs.gnu.org; 5 Aug 2023 17:12:26 +0000 Received: from localhost ([127.0.0.1]:58051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSKpG-00073I-6u for submit@debbugs.gnu.org; Sat, 05 Aug 2023 13:12:26 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:59392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSKpE-000734-U0 for 64985@debbugs.gnu.org; Sat, 05 Aug 2023 13:12:25 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4fe655796faso195872e87.2 for <64985@debbugs.gnu.org>; Sat, 05 Aug 2023 10:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691255539; x=1691860339; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=pyVKYeZwcja8qsKYovVbAhj9ifDVjdTkyJJuJNhhZl4=; b=mUhvm2SWRNmJJuDaaGMqgcd9oAVXZsPfb7WXKdSycsZS/9t/WX9+apaqJUqEw4nuwW mK1jOZhKVlv3/IzqyRO+vJCmXwQagxWq5sBgDWGo2w4lShmi0npg/xr57kfwJuMG5/v1 CFF3XRygA3rxeXTaubMKea7yMYTYfgm4zWAGn5bow50Q/U9ckUgv03cQJSxUIfg77qwH GiuByBwDK8p0MALBPwRan2m+JBASZTkqaKstcEuSwxYYHJoaWWlk4qPde6iEoLqNrjSF fPtktjxL6af11Dz0mNAWdBL+R/5T07FhuWxiHNNhD1NUvgCWEiqzIDD0JAwFgzUpP+Aq uLMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691255539; x=1691860339; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pyVKYeZwcja8qsKYovVbAhj9ifDVjdTkyJJuJNhhZl4=; b=LhcxB3iFTFlxOwvdSKlc40bgTdyOclL3iA98g/wUP0tnwfNCt9gtqqRFv2Oq8wXzFw +2gzQBISbLmGCLmmLlTm75DEj60I91t+NBhCwxgk1TFVq8pMAR1k8SdSBEg1sF4VKQoz 5i2c3NB2UpvRW7OwaqTJPhNMuJiGriD3Zm6lXQRigS1FiUGEyACsuiaTVxLerf/5DiBr DVrOo3+jSrwR85bbcCxewm0ERPzjG747ZmtLUZWLMTdp1iBwJt60Xyqce7iIKocLXCFi qLDxd1fNSQaBCejHfl+zmsleTqW2kNOhMe86AhMuBCbRDmQR9RGt++EjbYahmzNYO2H5 ihTA== X-Gm-Message-State: AOJu0YwBfXEmR0vMu4sA8y6QdZp3WRyIlEKVLkzg+bp8iBr3V5wcQFXM zX2yiA2oyo3IqaniOj+DHvs= X-Google-Smtp-Source: AGHT+IFK9JKD+D82JVAxVybS7uZtQ4j4KvbVNlLXEY+psrWbDXKYYp9HCIDM0rz4WxWfY+Yu9qWugg== X-Received: by 2002:a05:6512:36cd:b0:4f9:571d:c50e with SMTP id e13-20020a05651236cd00b004f9571dc50emr3141909lfs.36.1691255538587; Sat, 05 Aug 2023 10:12:18 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id i19-20020ac25233000000b004fb8c31c8desm806163lfl.208.2023.08.05.10.12.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Aug 2023 10:12:17 -0700 (PDT) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Message-Id: <84B60072-B340-40CE-BC49-BB781A4EF256@gmail.com> Date: Sat, 5 Aug 2023 19:12:16 +0200 X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Oops. Does this patch fix things? It's obviously the right thing to do (and make package-tests work = again). Please apply! From unknown Tue Jun 17 21:56:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64985: 30.0.50; package-recompile-all and package-recompile do not recompile anything, seems related to the patch associated with bug #64985 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 64985@debbugs.gnu.org, Vincenzo Pupillo Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169125580927579 (code B ref 64985); Sat, 05 Aug 2023 17:17:01 +0000 Received: (at 64985) by debbugs.gnu.org; 5 Aug 2023 17:16:49 +0000 Received: from localhost ([127.0.0.1]:58056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSKtU-0007Al-SP for submit@debbugs.gnu.org; Sat, 05 Aug 2023 13:16:49 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:47549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSKtR-0007AU-7j for 64985@debbugs.gnu.org; Sat, 05 Aug 2023 13:16:47 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-686b9964ae2so2206080b3a.3 for <64985@debbugs.gnu.org>; Sat, 05 Aug 2023 10:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691255799; x=1691860599; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=rQvf/Qi/gdk9YKSgcmwyVFi2gR2P7OQoZwzDe3nqgcw=; b=ouPwRxO0QqOfnrwcArUvruDBwVyzCIOE+yAo6Et277QIN3FwOeJc2sLYaPjhdNESLF xk0JxbwkFxKDzeLoCFbIOQtSDZVwowjxD+AV4ytEGgYwvGohVuRjqltr0TzifD24/fty zEbxG7NugvHF0/fkxQRinu2hNq68hvtqemLBTimjk/d4W3PdtFLf9v+ULlNIeJr1fa5e r3MYPrJZdfRQy7MMQ0LpPycJdn9myLUgJFa89UEtUQPhSo5r44n5iEiTRVJm0jMhNApp DY/Gpi20GhxOHmt1XhdFkS8t5K+zrltXnj3rJOxQZpKtA1vKHTRkPoYAOSbEPXC9f/mR aqUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691255799; x=1691860599; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rQvf/Qi/gdk9YKSgcmwyVFi2gR2P7OQoZwzDe3nqgcw=; b=C8KCSuXvJK3rMJqkWLZt8OReNMUg/y8SccYug6Y+F9BQw/SPhzmKZuukBES+vAbyp0 GstjdZGaccbzRmVzbW6fCOsj6CoOHRiOSrWFvzIAMzfMMcBgle8MkkIw2cVMhgqyHKZb dZoNLFDHl1eGkPTQ9PjrrSLyNKmtH1UFgtTMqrypFfe28GBybvELh96YRj0VNIYts30t 6yrK8Uvigm6qtosX31RoDX6JLxRZGJ5ldQ/e7LgaQzVvrfXuIRn7SWZRwXee070J/TF4 CJbBUdOOrCYgH513AWFHKoEe7HJcbv+dUOmyJGOHUCL0ZMyvGkxusMwxKrHE1KGwewac O+pw== X-Gm-Message-State: AOJu0YyInZA4wyTV7dqMQA5mckZdMtupDTchkcx+3pMnb228T5MzBmxa 4u6lx3mH0ZU39QVsGUyQUVM= X-Google-Smtp-Source: AGHT+IH9y5ltuuMSjHEXepYRS/gl7UM157Z+QZC7WVj+VZfWi3OZjKbPqVx15sRLnu5EoVWh5enM0w== X-Received: by 2002:a05:6a00:18a9:b0:682:2e99:9de0 with SMTP id x41-20020a056a0018a900b006822e999de0mr4723266pfh.23.1691255799246; Sat, 05 Aug 2023 10:16:39 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id q201-20020a632ad2000000b005572d796b9esm2662149pgq.88.2023.08.05.10.16.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Aug 2023 10:16:38 -0700 (PDT) Message-ID: Date: Sat, 5 Aug 2023 10:16:40 -0700 MIME-Version: 1.0 Content-Language: en-US References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <84B60072-B340-40CE-BC49-BB781A4EF256@gmail.com> From: Jim Porter In-Reply-To: <84B60072-B340-40CE-BC49-BB781A4EF256@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/5/2023 10:12 AM, Mattias Engdegård wrote: >> Oops. Does this patch fix things? > > It's obviously the right thing to do (and make package-tests work again). Please apply! Merged to the release branch as 1e8322bb26e.